honeybee-openstudio 2.28.1 → 2.28.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f46d6897c585ff7082971de6ff24b62e1d4213697bb9e3fb08a9b4eefd069a6d
-  data.tar.gz: 4c231dc4b6622e5d9871eddb54e6b6e32ebb5302183372845ea690552f0407f3
+  metadata.gz: 1c3f02cf48f4c9d6c3b519513a9602452d044c24287ba8b3ad9d9317e2cb869b
+  data.tar.gz: 5a08ac81d335c8ca9862dbf84a2e918480b594cf4e2e2cc495ef78d26b3e6256
 SHA512:
-  metadata.gz: 8a9192fca6bf36375576eb5fd7efb3f104e4ed34b2607e8d80c36ce60f272cdd7c62b1badb4a43f1c0daa0e813b63e5dffc407e25032172c045d7523b5f05e7d
-  data.tar.gz: e2533183332b489d8ba275feddf184c56f7cdca3a5bb561ce9ae7ad6af3177b9983b57872a1623c316a1d4b3ddea060dec1ab2714429edbe1a450928c5a5bb01
+  metadata.gz: 8b94674ad176a8846d1a2b10bfc11f3da312ff7e9adb186eac9c93a4bbc66d87d76bc1b41e730d49d9f93cd1d409e6f38b1256e9a5fb5dd4bdb08e077bb4b482
+  data.tar.gz: 30daf7224ae75f43219a0e9566146a045d5d86f074079ee29157455373804967b639a820f328777e71b69982a0392bbc4f97c0a24fdef55d2bff0c8a04ef5a46

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.28.1'
+  spec.version       = '2.28.2'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/to_openstudio/geometry/aperture.rb

@@ -48,14 +48,13 @@ module Honeybee
       @hash[:geometry][:boundary].each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
       # triangulate subsurface if neccesary
       triangulated = false
       final_vertices_list = []
       matching_os_subsurfaces = []
       matching_os_subsurface_indices = []
-      if reordered_vertices.size > 4
+      if os_vertices.size > 4
 
         # if this apeture has a matched apeture, see if the other one has already been created
         # the matched apeture should have been converted to multiple subsurfaces
@@ -75,9 +74,9 @@ module Honeybee
         if final_vertices_list.empty?
 
           # transform to face coordinates
-          t = OpenStudio::Transformation::alignFace(reordered_vertices)
+          t = OpenStudio::Transformation::alignFace(os_vertices)
           tInv = t.inverse
-          face_vertices = OpenStudio::reverse(tInv*reordered_vertices)
+          face_vertices = OpenStudio::reverse(tInv*os_vertices)
 
           # no holes in the subsurface
           holes = OpenStudio::Point3dVectorVector.new
@@ -85,7 +84,7 @@ module Honeybee
           # triangulate surface
           triangles = OpenStudio::computeTriangulation(face_vertices, holes)
           if triangles.empty?
-            raise "Failed to triangulate aperture #{@hash[:identifier]} with #{reordered_vertices.size} vertices"
+            raise "Failed to triangulate aperture #{@hash[:identifier]} with #{os_vertices.size} vertices"
           end
 
           # create new list of surfaces
@@ -98,13 +97,13 @@ module Honeybee
         end
 
       else
-        # reordered_vertices are good as is
-        final_vertices_list << reordered_vertices
+        # os_vertices are good as is
+        final_vertices_list << os_vertices
       end
 
       result = []
-      final_vertices_list.each_with_index do |reordered_vertices, index|
-        os_subsurface = OpenStudio::Model::SubSurface.new(reordered_vertices, openstudio_model)
+      final_vertices_list.each_with_index do |os_vertices, index|
+        os_subsurface = OpenStudio::Model::SubSurface.new(os_vertices, openstudio_model)
 
         if !matching_os_subsurfaces.empty?
           os_subsurface.setName(@hash[:identifier] + "..#{matching_os_subsurface_indices[index]}")
@@ -174,9 +173,8 @@ module Honeybee
       hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
-      os_shading_surface = OpenStudio::Model::ShadingSurface.new(reordered_vertices, openstudio_model)
+      os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
       os_shading_surface.setName(@hash[:identifier])
       unless @hash[:display_name].nil?
         os_shading_surface.setDisplayName(@hash[:display_name])

data/lib/to_openstudio/geometry/door.rb

@@ -48,14 +48,13 @@ module Honeybee
       @hash[:geometry][:boundary].each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
       # triangulate subsurface if neccesary
       triangulated = false
       final_vertices_list = []
       matching_os_subsurfaces = []
       matching_os_subsurface_indices = []
-      if reordered_vertices.size > 4
+      if os_vertices.size > 4
 
         # if this door has a matched door, see if the other one has already been created
         # the matched door should have been converted to multiple subsurfaces
@@ -75,9 +74,9 @@ module Honeybee
         if final_vertices_list.empty?
 
           # transform to face coordinates
-          t = OpenStudio::Transformation::alignFace(reordered_vertices)
+          t = OpenStudio::Transformation::alignFace(os_vertices)
           tInv = t.inverse
-          face_vertices = OpenStudio::reverse(tInv*reordered_vertices)
+          face_vertices = OpenStudio::reverse(tInv*os_vertices)
 
           # no holes in the subsurface
           holes = OpenStudio::Point3dVectorVector.new
@@ -85,7 +84,7 @@ module Honeybee
           # triangulate surface
           triangles = OpenStudio::computeTriangulation(face_vertices, holes)
           if triangles.empty?
-            raise "Failed to triangulate door #{@hash[:identifier]} with #{reordered_vertices.size} vertices"
+            raise "Failed to triangulate door #{@hash[:identifier]} with #{os_vertices.size} vertices"
           end
 
           # create new list of surfaces
@@ -98,13 +97,13 @@ module Honeybee
         end
 
       else
-        # reordered_vertices are good as is
-        final_vertices_list << reordered_vertices
+        # os_vertices are good as is
+        final_vertices_list << os_vertices
       end
 
       result = []
-      final_vertices_list.each_with_index do |reordered_vertices, index|
-        os_subsurface = OpenStudio::Model::SubSurface.new(reordered_vertices, openstudio_model)
+      final_vertices_list.each_with_index do |os_vertices, index|
+        os_subsurface = OpenStudio::Model::SubSurface.new(os_vertices, openstudio_model)
 
         if !matching_os_subsurfaces.empty?
           os_subsurface.setName(@hash[:identifier] + "..#{matching_os_subsurface_indices[index]}")
@@ -168,9 +167,8 @@ module Honeybee
     hb_verts.each do |vertex|
       os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
     end
-    reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
-    os_shading_surface = OpenStudio::Model::ShadingSurface.new(reordered_vertices, openstudio_model)
+    os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
     os_shading_surface.setName(@hash[:identifier])
     unless @hash[:display_name].nil?
       os_shading_surface.setDisplayName(@hash[:display_name])

data/lib/to_openstudio/geometry/face.rb

@@ -55,10 +55,9 @@ module Honeybee
       hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
       # create the openstudio surface and assign the type
-      os_surface = OpenStudio::Model::Surface.new(reordered_vertices, openstudio_model)
+      os_surface = OpenStudio::Model::Surface.new(os_vertices, openstudio_model)
       os_surface.setName(@hash[:identifier])
       unless @hash[:display_name].nil?
         os_surface.setDisplayName(@hash[:display_name])
@@ -198,9 +197,8 @@ module Honeybee
       hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
-      os_shading_surface = OpenStudio::Model::ShadingSurface.new(reordered_vertices, openstudio_model)
+      os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
       os_shading_surface.setName(@hash[:identifier])
       unless @hash[:display_name].nil?
         os_shading_surface.setDisplayName(@hash[:display_name])

data/lib/to_openstudio/geometry/shade.rb

@@ -55,9 +55,8 @@ module Honeybee
       hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
-      reordered_vertices = OpenStudio.reorderULC(os_vertices)
 
-      os_shading_surface = OpenStudio::Model::ShadingSurface.new(reordered_vertices, openstudio_model)
+      os_shading_surface = OpenStudio::Model::ShadingSurface.new(os_vertices, openstudio_model)
       os_shading_surface.setName(@hash[:identifier])
       unless @hash[:display_name].nil?
         os_shading_surface.setDisplayName(@hash[:display_name])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.28.1
+  version: 2.28.2
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-12-06 00:00:00.000000000 Z
+date: 2021-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler