honeybee-openstudio 2.27.2 → 2.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff7d0e37c330a44d6397e17757c1908eab92d37e5f04a82362e9391276e13c00
-  data.tar.gz: 8d3c5348477b29a53bd9d0e1175f110a05e1ef2b213e0a692618308c00f4dfa2
+  metadata.gz: 68d5909ca4defd67e4437a988537724db7f6b1ae5691342278eb0c13c47cc033
+  data.tar.gz: ada6cbf89e0813172a16b4ffb1ac7fa78a26c6018e4b5a439586d886816a55e4
 SHA512:
-  metadata.gz: 9344fb8b49dbf2c45faba9451840968208115ca401ead34d338dc27c9b391ff56c8f2bb4eaab0bcf688620bc99427dc2dabf79d468abece155d5d459c04eb330
-  data.tar.gz: 8af9d9bc6f29fea997ee68c357a9bdb6684b54cd45769cc5aa7fb214aa7658f91362704f34f52b9599a8d9b146796a04d5eb5bd959e06927da10659211912151
+  metadata.gz: 5e0eee873af2b06907cfed7ca2124d27ab9396f0d43eb8b1cf7895910d4645bd26b3dd84357f6954bfa85502fa4b61332fd7d2e2171d33a5a3797ede14e3ef3e
+  data.tar.gz: 1a784987d9db719a4cb703f2e47041f2612003fa3b1595a5c6bf017a2f895d9edbf494462cfd0141c9783f929a3c3450fd691f7457882427642acef706a9f528

data/.github/workflows/ci.yaml

@@ -15,8 +15,8 @@ jobs:
       run: |
         echo $(pwd)
         echo $(ls)
-        docker pull nrel/openstudio:3.2.0
-        docker run --name test --rm -d -t -v $(pwd):/work -w /work nrel/openstudio:3.2.0
+        docker pull nrel/openstudio:3.3.0
+        docker run --name test --rm -d -t -v $(pwd):/work -w /work nrel/openstudio:3.3.0
         docker exec -t test pwd
         docker exec -t test ls
         docker exec -t test bundle update

data/Gemfile

@@ -7,7 +7,7 @@ gemspec
 if File.exist?('../OpenStudio-extension-gem')  # local development copy
   gem 'openstudio-extension', path: '../OpenStudio-extension-gem'
 else  # get it from rubygems.org
-  gem 'openstudio-extension', '0.4.3'
+  gem 'openstudio-extension', '0.5.1'
 end
 
 # coveralls gem is used to generate coverage reports through CI

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.27.2'
+  spec.version       = '2.28.0'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 
@@ -33,6 +33,6 @@ Gem::Specification.new do |spec|
   end
 
   spec.add_dependency 'json_pure'
-  spec.add_dependency 'openstudio-extension', '0.4.3'
-  spec.add_dependency 'openstudio-standards', '~> 0.2.14'
+  spec.add_dependency 'openstudio-extension', '0.5.1'
+  spec.add_dependency 'openstudio-standards', '~> 0.2.15'
 end

data/lib/measures/from_honeybee_model_to_gbxml/measure.rb

@@ -91,13 +91,6 @@ class FromHoneybeeModelToGbxml < OpenStudio::Measure::ModelMeasure
     os_model = honeybee_model.to_openstudio_model(model)
     STDOUT.flush
 
-    # make sure the zone name is different from the space name to comply with gbXML
-    zones = os_model.getThermalZones()
-    zones.each do |zone|
-      zone_name = zone.name.to_s + '_Zone'
-      zone.setName(zone_name)
-    end
-
     # convert the OpenStudio model into a gbXML Model
     output_file_path = runner.getStringArgumentValue('output_file_path', user_arguments)
     if output_file_path && !output_file_path.empty?

data/lib/to_openstudio/geometry/room.rb

@@ -39,7 +39,7 @@ module Honeybee
     attr_reader :unique_space_type
 
     def find_existing_openstudio_object(openstudio_model)
-      model_space = openstudio_model.getSpaceByName(@hash[:identifier])
+      model_space = openstudio_model.getSpaceByName(@hash[:identifier] + '_Space')
       return model_space.get unless model_space.empty?
       nil
     end
@@ -75,7 +75,7 @@ module Honeybee
     def to_openstudio(openstudio_model)
       # create the space and thermal zone
       os_space = OpenStudio::Model::Space.new(openstudio_model)
-      os_space.setName(@hash[:identifier])
+      os_space.setName(@hash[:identifier] + '_Space')
       unless @hash[:display_name].nil?
         os_space.setDisplayName(@hash[:display_name])
       end

data/lib/to_openstudio/load/service_hot_water.rb

@@ -234,7 +234,7 @@ module Honeybee
       # create water use equipment + connection and set identifier
       os_shw_def = OpenStudio::Model::WaterUseEquipmentDefinition.new(openstudio_model)
       os_shw = OpenStudio::Model::WaterUseEquipment.new(os_shw_def)
-      unique_id = @hash[:identifier] + '..' + os_space.nameString
+      unique_id = @hash[:identifier] + '..' + os_space.nameString[0...-6]
       os_shw_def.setName(unique_id)
       os_shw.setName(unique_id)
 

data/lib/to_openstudio/simulation/parameter_model.rb

@@ -145,13 +145,24 @@ module Honeybee
           os_sizing_par.setCoolingSizingFactor(@hash[:sizing_parameter][:cooling_factor])
         end
         # set any design days
+        db_temps = []
         if @hash[:sizing_parameter][:design_days]
           @hash[:sizing_parameter][:design_days].each do |des_day|
             des_day_object = DesignDay.new(des_day)
             os_des_day = des_day_object.to_openstudio(@openstudio_model)
+            db_temps << des_day[:dry_bulb_condition][:dry_bulb_max]
           end
         end
       end
+      # use the average of design day temperatures to set the water mains temperature
+      os_water_mains = @openstudio_model.getSiteWaterMainsTemperature 
+      os_water_mains.setCalculationMethod('Correlation')
+      if db_temps.length > 0
+        os_water_mains.setAnnualAverageOutdoorAirTemperature((db_temps.max + db_temps.min) / 2)
+      else  # just use some dummy values so that the simulation does not fail
+        os_water_mains.setAnnualAverageOutdoorAirTemperature(12)
+      end
+      os_water_mains.setMaximumDifferenceInMonthlyAverageOutdoorAirTemperatures(4)
 
       # set Outputs for the simulation
       if @hash[:output]
@@ -238,9 +249,6 @@ module Honeybee
         os_site.setTerrain(@hash[:terrain_type])
       end
 
-      # ensure water mains temperatures are written
-      os_water_mains = @openstudio_model.getSiteWaterMainsTemperature 
-      os_water_mains.setCalculationMethod('CorrelationFromWeatherFile')
     end
 
   end #SimulationParameter

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.27.2
+  version: 2.28.0
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-11-25 00:00:00.000000000 Z
+date: 2021-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -117,28 +117,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.4.3
+        version: 0.5.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.4.3
+        version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: openstudio-standards
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.14
+        version: 0.2.15
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.14
+        version: 0.2.15
 description: Library and measures for translating between Honeybee JSON schema and
   OpenStudio Model schema (OSM).
 email: