honeybee-openstudio 2.23.4 → 2.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b883c23eb45c35c5ff82b420a7eba79e2cf2f4c228603531c8f049bf19ca4478
-  data.tar.gz: f2776a7b81b4cb648ecc5171fd50f79face62d79574c0651801a5bad0fd388d9
+  metadata.gz: aaaa7ddfb52102f325f31d2090e14c7174c3a98ba156859b989b30391a4abbdb
+  data.tar.gz: 5f6fb58c9f9f926fab088fb0c300cbe4527039a984d2bc5d816d72c27f64d7f7
 SHA512:
-  metadata.gz: 005e5223dd3db47c4a86760d54ed366ed6d2e2a23c31eddb00bab5398744e95de129cac8068708f976393763228953c9ab1e9f2d01949229ca1ed980b98edb67
-  data.tar.gz: 050271b5e95a661bcc489303f9362040a283e891410a1cb4cd71eb3af5f793a69122cbb147cf5fada554240a0a64c88f37a0b53a06188d350406ee319d3488ae
+  metadata.gz: 47d6f83ad9135c92c77e5924c9d1872c2b2573a2d056f9940bec7f96b7aba8e74c6bcd0aca8cd83766a79c4c8398df88bbf54ae2a29edb8a080cc6d57a6f13ef
+  data.tar.gz: dc582df2f41e9ffe26b67a0c92b0d256dbab7215697573655d4eb50edd6a498ef9f084fd66016f8dfff3882555afacdcb6b558db7d7ed4fabc795145d3df89af

data/.github/workflows/ci.yaml

@@ -33,7 +33,7 @@ jobs:
       - name: set up node  # we need node for for semantic release
         uses: actions/setup-node@v2.1.2
         with:
-          node-version: 14.2.0
+          node-version: 14.17.0
       - name: install semantic-release
         run:
           npm install @semantic-release/exec

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.23.4'
+  spec.version       = '2.24.0'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/files/honeybee_adapter.rb

@@ -34,7 +34,7 @@ require 'openstudio/workflow/adapters/output_adapter'
 # Local file based workflow
 class HoneybeeAdapter < OpenStudio::Workflow::OutputAdapters
   def initialize(options = {})
-    puts "viiiiiiiiiiiiizzzzzzzzz!"
+
     STDOUT.flush
     super
   end

data/lib/from_openstudio/geometry/aperture.rb

@@ -72,7 +72,7 @@ module Honeybee
       unless sub_surface.isConstructionDefaulted
         construction = sub_surface.construction
         if !construction.empty?
-          constr_id = construction.get.nameString
+          constr_id = clean_identifier(construction.get.nameString)
           unless $window_constructions[constr_id].nil?
             hash[:construction] = constr_id
           end

data/lib/from_openstudio/geometry/door.rb

@@ -72,7 +72,7 @@ module Honeybee
       unless sub_surface.isConstructionDefaulted
         construction = sub_surface.construction
         if !construction.empty?
-          constr_id = construction.get.nameString
+          constr_id = clean_identifier(construction.get.nameString)
           if hash[:is_glass] && !$window_constructions[constr_id].nil?
             hash[:construction] = constr_id
           elsif !hash[:is_glass] && !$opaque_constructions[constr_id].nil?

data/lib/from_openstudio/geometry/face.rb

@@ -74,7 +74,7 @@ module Honeybee
       unless surface.isConstructionDefaulted
         construction = surface.construction
         if !construction.empty?
-          constr_id = construction.get.nameString
+          constr_id = clean_identifier(construction.get.nameString)
           unless $opaque_constructions[constr_id].nil?
             hash[:construction] = constr_id
           end

data/lib/from_openstudio/geometry/room.rb

@@ -112,7 +112,7 @@ module Honeybee
     def self.story_from_space(space)
       story = space.buildingStory
       if !story.empty?
-        return story.get.nameString
+        return clean_identifier(story.get.nameString)
       end
       nil
     end

data/lib/from_openstudio/geometry/shade.rb

@@ -62,7 +62,7 @@ module Honeybee
       unless shading_surface.isConstructionDefaulted
         construction = shading_surface.construction
         if !construction.empty?
-          const_name = construction.get.nameString
+          const_name = clean_identifier(construction.get.nameString)
           hash[:construction] = const_name
           unless $shade_constructions.has_key?(const_name)
             const_obj = construction.get
@@ -74,7 +74,12 @@ module Honeybee
 
       transmittance_schedule = shading_surface.transmittanceSchedule
       if !transmittance_schedule.empty?
-        hash[:transmittance_schedule] = transmittance_schedule.get.nameString
+        trans_sch_name = clean_identifier(transmittance_schedule.get.nameString)
+        # Check whether schedules other than schedule ruleset or schedule fixed interval are
+        # being assigned
+        unless $schedules[trans_sch_name].nil?
+          hash[:transmittance_schedule] = trans_sch_name
+        end
       end
 
       hash

data/lib/from_openstudio/model.rb

@@ -48,6 +48,7 @@ require 'from_openstudio/construction/shade'
 require 'from_openstudio/construction_set'
 require 'from_openstudio/schedule/type_limit'
 require 'from_openstudio/schedule/ruleset'
+require 'from_openstudio/schedule/fixed_interval'
 
 require 'openstudio'
 
@@ -64,7 +65,8 @@ module Honeybee
       hash[:tolerance] = 0.01
       hash[:angle_tolerance] = 1.0
 
-      # Hashes for all constructions in the model
+      # Hashes for all shcedules and constructions in the model
+      $schedules = {}
       $opaque_constructions = {}
       $window_constructions = {}
       $shade_constructions = {}
@@ -133,6 +135,7 @@ module Honeybee
       hash[:construction_sets] = constructionsets_from_model(openstudio_model)
       hash[:schedule_type_limits] = schedtypelimits_from_model(openstudio_model)
       hash[:schedules] = scheduleruleset_from_model(openstudio_model)
+      hash[:schedules] = schedulefixedinterval_from_model(openstudio_model)
 
       hash
     end
@@ -282,7 +285,22 @@ module Honeybee
     def self.scheduleruleset_from_model(openstudio_model)
       result = []
       openstudio_model.getScheduleRulesets.each do |sch_ruleset|
-        result << ScheduleRulesetAbridged.from_schedule_ruleset(sch_ruleset)
+        sched_hash = ScheduleRulesetAbridged.from_schedule_ruleset(sch_ruleset)
+        $schedules[sched_hash[:identifier]] = sched_hash
+        result << sched_hash
+      end
+      result
+    end
+
+    # Create HB Schedule Fixed Interval from OpenStudio Schedule Fixed Interval
+    def self.schedulefixedinterval_from_model(openstudio_model)
+      result = []
+      # check if it is a leap year 
+      is_leap_year = openstudio_model.getYearDescription.isLeapYear
+      openstudio_model.getScheduleFixedIntervals.each do |sch_fix_int|
+        sched_fixed_hash = ScheduleFixedIntervalAbridged.from_schedule_fixedinterval(sch_fix_int, is_leap_year)
+        $schedules[sched_fixed_hash[:identifier]] = sched_fixed_hash
+        result << sched_fixed_hash
       end
       result
     end

data/lib/from_openstudio/schedule/fixed_interval.rb

@@ -0,0 +1,71 @@
+# *******************************************************************************
+# Honeybee OpenStudio Gem, Copyright (c) 2020, Alliance for Sustainable
+# Energy, LLC, Ladybug Tools LLC and other contributors. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# (1) Redistributions of source code must retain the above copyright notice,
+# this list of conditions and the following disclaimer.
+#
+# (2) Redistributions in binary form must reproduce the above copyright notice,
+# this list of conditions and the following disclaimer in the documentation
+# and/or other materials provided with the distribution.
+#
+# (3) Neither the name of the copyright holder nor the names of any contributors
+# may be used to endorse or promote products derived from this software without
+# specific prior written permission from the respective party.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER(S) AND ANY CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER(S), ANY CONTRIBUTORS, THE
+# UNITED STATES GOVERNMENT, OR THE UNITED STATES DEPARTMENT OF ENERGY, NOR ANY OF
+# THEIR EMPLOYEES, BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
+# OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+# STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+# OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# *******************************************************************************
+
+require 'honeybee/schedule/fixed_interval'
+require 'from_openstudio/model_object'
+
+module Honeybee
+    class ScheduleFixedIntervalAbridged < ModelObject
+
+        def self.from_schedule_fixedinterval(schedule_fixedinterval, is_leap_year)
+            # create an empty hash
+            hash = {}
+            hash[:type] = 'ScheduleFixedIntervalAbridged'
+            hash[:identifier] = clean_name(schedule_fixedinterval.nameString)
+            start_month = schedule_fixedinterval.startMonth
+            start_day = schedule_fixedinterval.startDay
+            if is_leap_year
+                # if it is a leap year then add  1 as third value
+                hash[:start_date] = [start_month, start_day, 1]
+            else
+                hash[:start_date] = [start_month, start_day]
+            end
+            hash[:interpolate] = schedule_fixedinterval.interpolatetoTimestep
+            # assigning schedule type limit if it exists
+            unless schedule_fixedinterval.scheduleTypeLimits.empty?
+                typ_lim = schedule_fixedinterval.scheduleTypeLimits.get
+                hash[:schedule_type_limit] = clean_name(typ_lim.nameString)
+            end
+            interval_length = schedule_fixedinterval.intervalLength
+            hash[:timestep] = 60 / interval_length.to_i
+            # get values from schedule fixed interval
+            values = schedule_fixedinterval.timeSeries.values
+            value_array = []
+            for i in 0..(values.size - 1)
+                value_array << values[i]
+            end
+            hash[:values] = value_array
+
+            hash
+        end
+    
+    end
+end

data/lib/from_openstudio/simulation/design_day.rb

@@ -37,7 +37,7 @@ module Honeybee
     def self.from_design_day(design_day)
       hash = {}
       hash[:type] = 'DesignDay'
-      hash[:name] = design_day.nameString
+      hash[:name] = clean_identifier(design_day.nameString)
       hash[:day_type] = day_type_from_design_day(design_day)
       hash[:dry_bulb_condition] = dry_bulb_condition_from_design_day(design_day)
       hash[:humidity_condition] = humidity_condition_from_design_day(design_day)

data/lib/measures/from_honeybee_simulation_parameter/measure.xml

@@ -83,4 +83,3 @@
     </file>
   </files>
 </measure>
-<error>cannot load such file -- honeybee/simulation/parameter</error>

data/lib/to_openstudio/geometry/face.rb

@@ -43,9 +43,16 @@ module Honeybee
     end
 
     def to_openstudio(openstudio_model)
+      # get the vertices from the face
+      if @hash[:geometry][:vertices].nil?
+        hb_verts = @hash[:geometry][:boundary]
+      else
+        hb_verts = @hash[:geometry][:vertices]
+      end
+
       # reorder the vertices to ensure they start from the upper-left corner
       os_vertices = OpenStudio::Point3dVector.new
-      @hash[:geometry][:boundary].each do |vertex|
+      hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
       reordered_vertices = OpenStudio.reorderULC(os_vertices)

data/lib/to_openstudio/geometry/shade.rb

@@ -43,9 +43,16 @@ module Honeybee
     end
 
     def to_openstudio(openstudio_model)
+      # get the vertices from the face
+      if @hash[:geometry][:vertices].nil?
+        hb_verts = @hash[:geometry][:boundary]
+      else
+        hb_verts = @hash[:geometry][:vertices]
+      end
+
       # create the openstudio shading surface
       os_vertices = OpenStudio::Point3dVector.new
-      @hash[:geometry][:boundary].each do |vertex|
+      hb_verts.each do |vertex|
         os_vertices << OpenStudio::Point3d.new(vertex[0], vertex[1], vertex[2])
       end
       reordered_vertices = OpenStudio.reorderULC(os_vertices)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.23.4
+  version: 2.24.0
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-09-17 00:00:00.000000000 Z
+date: 2021-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -187,6 +187,7 @@ files:
 - lib/from_openstudio/material/window_simpleglazsys.rb
 - lib/from_openstudio/model.rb
 - lib/from_openstudio/model_object.rb
+- lib/from_openstudio/schedule/fixed_interval.rb
 - lib/from_openstudio/schedule/ruleset.rb
 - lib/from_openstudio/schedule/type_limit.rb
 - lib/from_openstudio/simulation/design_day.rb