honeybee-openstudio 2.23.1 → 2.23.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f5b611d0b78befb14bd1968ad3bc09479295c7367265049523c28ef3b3e3feeb
-  data.tar.gz: 6630478417dcc8d8680339b3d673b857ac6e0593152310213a3dc9c6eb227914
+  metadata.gz: 5ced01eda1ef2637e0f07892dc5498c63c7e7e424965ef9d458e0ce16daba7c2
+  data.tar.gz: b98a359da6cfbef7010b3b77b0a3513937015c571c0c27602d3c7e4c4de35ed3
 SHA512:
-  metadata.gz: 549cb01585b8b2983b5d5014703325bf87a83db1cc600c4f4ed557a501d998cc5e2632970a7d58d0c75d7a34234a11befbe2eb27c49c085303d25708040c794a
-  data.tar.gz: 16c6ed67bb2a2a8a5e83fe63641dee6db8df13a855103149565a4d476e0746c02a7837d12307f45ad67fe77854d2c572fcd39323434be5338395e27bb98f36a5
+  metadata.gz: bbc8d2fde85273d8bed150e222671fee710f2c450591cf1dbf3b1f26e40c5b11ae1006f6ae865f2ae6250076a34518f120da7593e27f278d75aded811cae5957
+  data.tar.gz: 78cd389a850c7b326a6e461126e969bec2c8f14a673c8aa4058216a5c67156f070e41d72360aa68f198e36590c83c011357a6f7bf6fc632528ba3713d3307afb

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.23.1'
+  spec.version       = '2.23.5'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 

data/lib/files/honeybee_adapter.rb

@@ -34,7 +34,7 @@ require 'openstudio/workflow/adapters/output_adapter'
 # Local file based workflow
 class HoneybeeAdapter < OpenStudio::Workflow::OutputAdapters
   def initialize(options = {})
-    puts "viiiiiiiiiiiiizzzzzzzzz!"
+
     STDOUT.flush
     super
   end

data/lib/from_openstudio/schedule/type_limit.rb

@@ -65,6 +65,8 @@ module Honeybee
         unit_type = 'ConvectionCoefficient'
       elsif unit_type == 'Activitylevel'
         unit_type = 'ActivityLevel'
+      elsif unit_type == 'Controlmode'
+        unit_type = 'Control'
       end
       hash[:unit_type] = unit_type
 

data/lib/honeybee/model_object.rb

@@ -36,13 +36,6 @@ module Honeybee
 
     attr_reader :errors, :warnings
 
-    @@encoding_options = {
-      :invalid           => :replace,  # Replace invalid byte sequences
-      :undef             => :replace,  # Replace anything not defined in ASCII
-      :replace           => '',        # Use a blank for those replacements
-      :universal_newline => true       # Always break lines with \n
-    }
-
     def method_missing(sym, *args)
       name = sym.to_s
       aname = name.sub('=', '')
@@ -107,12 +100,12 @@ module Honeybee
 
     # remove illegal characters in identifier
     def self.clean_name(str)
-      ascii = str.encode(Encoding.find('ASCII'), @@encoding_options)
+      ascii = str.encode(Encoding.find('ASCII'))
     end
 
     # remove illegal characters in identifier
     def self.clean_identifier(str)
-      encode_str = str.encode(Encoding.find('ASCII'), @@encoding_options)
+      encode_str = str.encode(Encoding.find('ASCII'))
       encode_str.gsub(/[^.A-Za-z0-9_-]/, '_').gsub(' ', '_')
     end
 

data/lib/measures/from_honeybee_simulation_parameter/measure.xml

@@ -83,4 +83,3 @@
     </file>
   </files>
 </measure>
-<error>cannot load such file -- honeybee/simulation/parameter</error>

data/lib/to_openstudio/construction/dynamic.rb

@@ -88,7 +88,7 @@ module Honeybee
 
       # set up the EMS sensor for the schedule value
       state_sch = openstudio_model.getScheduleByName(@hash[:schedule])
-      @sch_sensor_name = replace_ems_special_characters(@hash[:identifier]) + '_Sensor' + @@sensor_count.to_s
+      @sch_sensor_name = replace_ems_special_characters(@hash[:identifier]) + 'Sensor' + @@sensor_count.to_s
       @@sensor_count = @@sensor_count + 1
       unless state_sch.empty?  # schedule not specified
         sch_var = OpenStudio::Model::OutputVariable.new('Schedule Value', openstudio_model)
@@ -107,18 +107,15 @@ module Honeybee
       @sub_faces.each do |dyn_window|
         window_act = OpenStudio::Model::EnergyManagementSystemActuator.new(
           dyn_window, 'Surface', 'Construction State')
-        dyn_window_name = dyn_window.name
-        unless dyn_window_name.empty?
-          act_name = replace_ems_special_characters(dyn_window_name.get) + '_Actuator' + @@actuator_count.to_s
-          @@actuator_count = @@actuator_count + 1
-          window_act.setName(act_name)
-          actuator_names << act_name
-        end
+        act_name = replace_ems_special_characters(dyn_window.nameString) + 'Actuator' + @@actuator_count.to_s
+        @@actuator_count = @@actuator_count + 1
+        window_act.setName(act_name)
+        actuator_names << act_name
       end
 
       # create the EMS Program to accout for each state according to the control logic
       ems_program = OpenStudio::Model::EnergyManagementSystemProgram.new(openstudio_model)
-      prog_name = replace_ems_special_characters(@hash[:identifier]) + '_StateChange' + @@program_count.to_s
+      prog_name = replace_ems_special_characters(@hash[:identifier]) + 'StateChange' + @@program_count.to_s
       @@program_count = @@program_count + 1
       ems_program.setName(prog_name)
 
@@ -143,12 +140,9 @@ module Honeybee
         # create the construction index variable
         constr_i = OpenStudio::Model::EnergyManagementSystemConstructionIndexVariable.new(
           openstudio_model, construction)
-        constr_name = construction.name
-        unless constr_name.empty?
-          constr_i_name = replace_ems_special_characters(constr_name.get) + '_State' + @@state_count.to_s
-          @@state_count = @@state_count + 1
-          constr_i.setName(constr_i_name)
-        end
+        constr_i_name = replace_ems_special_characters(construction.nameString) + 'State' + @@state_count.to_s
+        @@state_count = @@state_count + 1
+        constr_i.setName(constr_i_name)
 
         # loop through the actuators and set the appropriate window state
         actuator_names.each do |act_name|

data/lib/to_openstudio/construction/windowshade.rb

@@ -86,13 +86,13 @@ module Honeybee
       shd_mat_name = openstudio_model.getMaterialByName(@hash[:shade_material])
       unless shd_mat_name.empty?
         @shade_material = shd_mat_name.get
-        obj_type = @shade_material.iddObject.name
+        obj_type = @shade_material.iddObject.name.to_s
       end
       unless @shade_material.nil?
-        if obj_type == 'OS:WindowMaterial:StandardGlazing'
+        if obj_type == 'OS:WindowMaterial:StandardGlazing' || obj_type == 'OS:WindowMaterial:Glazing'
           if @shade_location == 'Interior'
               os_materials[-1] = @shade_material
-          elsif @shade_location == 'Exterior' | os_materials.length < 2
+          elsif @shade_location == 'Exterior' || os_materials.length < 2
               os_materials[0] = @shade_material
           else  # middle glass pane
               os_materials[-3] = @shade_material
@@ -150,9 +150,9 @@ module Honeybee
 
       # figure out the shading type
       unless @shade_material.nil?
-        obj_type = @shade_material.iddObject.name
+        obj_type = @shade_material.iddObject.name.to_s
       end
-      if obj_type == 'OS:WindowMaterial:StandardGlazing'
+      if obj_type == 'OS:WindowMaterial:StandardGlazing' || obj_type == 'OS:WindowMaterial:Glazing'
         shd_type = 'SwitchableGlazing'
       elsif obj_type == 'OS:WindowMaterial:Blind'
         if @shade_location == 'Between'

data/lib/to_openstudio/ventcool/control.rb

@@ -85,7 +85,7 @@ module Honeybee
         in_var.setKeyValue(os_zone_name)
       end
       in_air_temp = OpenStudio::Model::EnergyManagementSystemSensor.new(openstudio_model, in_var)
-      in_sensor_name = replace_ems_special_characters(os_zone_name) + '_Sensor' + @@sensor_count.to_s
+      in_sensor_name = replace_ems_special_characters(os_zone_name) + 'Sensor' + @@sensor_count.to_s
       @@sensor_count = @@sensor_count + 1
       in_air_temp.setName(in_sensor_name)
 
@@ -97,7 +97,7 @@ module Honeybee
           sch_var.setReportingFrequency('Timestep')
           sch_var.setKeyValue(@hash[:schedule])
           sch_sens = OpenStudio::Model::EnergyManagementSystemSensor.new(openstudio_model, sch_var)
-          sch_sensor_name = replace_ems_special_characters(os_zone_name) + '_Sensor' + @@sensor_count.to_s
+          sch_sensor_name = replace_ems_special_characters(os_zone_name) + 'Sensor' + @@sensor_count.to_s
           @@sensor_count = @@sensor_count + 1
           sch_sens.setName(sch_sensor_name)
         end
@@ -108,14 +108,11 @@ module Honeybee
       vent_opening_surfaces.each do |vent_srf|
         window_act = OpenStudio::Model::EnergyManagementSystemActuator.new(
             vent_srf, 'AirFlow Network Window/Door Opening', 'Venting Opening Factor')
-        vent_srf_name = vent_srf.name
-        unless vent_srf_name.empty?
-          act_name = replace_ems_special_characters(vent_srf_name.get) + \
-            '_OpenFactor' + @@actuator_count.to_s
-            @@actuator_count = @@actuator_count + 1
-          window_act.setName(act_name)
-          actuator_names << act_name
-        end
+        act_name = replace_ems_special_characters(vent_srf.nameString) + \
+          'OpenFactor' + @@actuator_count.to_s
+          @@actuator_count = @@actuator_count + 1
+        window_act.setName(act_name)
+        actuator_names << act_name
       end
 
       # create the first line of the EMS Program to open each window according to the control logic
@@ -158,7 +155,7 @@ module Honeybee
 
       # initialize the program and add the complete logic
       ems_program = OpenStudio::Model::EnergyManagementSystemProgram.new(openstudio_model)
-      prog_name = replace_ems_special_characters(os_zone_name) + '_WindowOpening' + @@program_count.to_s
+      prog_name = replace_ems_special_characters(os_zone_name) + 'WindowOpening' + @@program_count.to_s
       @@program_count = @@program_count + 1
       ems_program.setName(prog_name)
       ems_program.addLine(complete_logic)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.23.1
+  version: 2.23.5
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-09-15 00:00:00.000000000 Z
+date: 2021-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler