honeybee-openstudio 2.22.2 → 2.22.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5392435198119a686f3699148121914e8bd91ce5664c5b6499b9c992718655ae
-  data.tar.gz: 41671a1887d378797a955d26d48211476754dcf31f178fa13ba8689a62e50826
+  metadata.gz: b23a8787eb73cfedcfb87593efb1089039ddf316fef2c45ef5911251a2a7b7fe
+  data.tar.gz: '019c3ea7029d7372de457911e7fbb08f690f83fc27e5605249e273b9bb677701'
 SHA512:
-  metadata.gz: 486f13b92b50320910c4612c91fa6baf1050f618e844253a3462652d969878cbb99dd67c31569eda343467dc29d10d969d88f626c49d814e4fcc96805ab60780
-  data.tar.gz: e7baa65945989b5c72169530e40529a7ed2a598980ca3176c51c3fed079f75467353d408e605ae5b47e9a9566147b7ce1006346e9e8d4f3740c03f9cef9a7fff
+  metadata.gz: 3ebc33a0448cfc47bf86dc954d7186798d35482975b5a3fd66efcfe7003e7c1e06b43334621935e5eda599e433c68b3e64d7b9414bc80280af8b56ad503b55b4
+  data.tar.gz: 9923b7fec07cc6729d8a7f882802022629073671e2e2d9c53e5afb244ddbb9e87a8fd3a93e32a748742ba1cc079b32dc1e5d4a36b598d68b36deefc6574bf7ac

data/Gemfile

@@ -7,7 +7,7 @@ gemspec
 if File.exist?('../OpenStudio-extension-gem')  # local development copy
   gem 'openstudio-extension', path: '../OpenStudio-extension-gem'
 else  # get it from rubygems.org
-  gem 'openstudio-extension', '0.4.2'
+  gem 'openstudio-extension', '0.4.3'
 end
 
 # coveralls gem is used to generate coverage reports through CI

data/honeybee-openstudio.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'honeybee-openstudio'
-  spec.version       = '2.22.2'
+  spec.version       = '2.22.3'
   spec.authors       = ['Tanushree Charan', 'Dan Macumber', 'Chris Mackey', 'Mostapha Sadeghipour Roudsari']
   spec.email         = ['tanushree.charan@nrel.gov', 'chris@ladybug.tools']
 
@@ -29,10 +29,10 @@ Gem::Specification.new do |spec|
     spec.add_development_dependency "json-schema",    "~> 2.8.1"
     spec.add_development_dependency "rake",           "~> 13.0"
     spec.add_development_dependency "rspec",          "~> 3.9"
-    spec.add_development_dependency "rubocop",        "~> 0.54.0"
+    spec.add_development_dependency "rubocop",        "~> 1.15.0"
   end
 
   spec.add_dependency 'json_pure'
-  spec.add_dependency 'openstudio-extension', '0.4.2'
-  spec.add_dependency 'openstudio-standards', '~> 0.2.13'
+  spec.add_dependency 'openstudio-extension', '0.4.3'
+  spec.add_dependency 'openstudio-standards', '~> 0.2.14'
 end

data/lib/to_openstudio/geometry/face.rb

@@ -77,7 +77,7 @@ module Honeybee
 
           # assign the flow exponent if it's specified
           if vent_crack[:flow_exponent]
-            os_crack.	setAirMassFlowExponent(vent_crack[:flow_exponent])
+            os_crack.setAirMassFlowExponent(vent_crack[:flow_exponent])
           end
 
           # if it's a Surface boundary condition ensure the neighbor is not written as a duplicate

data/lib/to_openstudio/geometry/room.rb

@@ -349,8 +349,10 @@ module Honeybee
             if sub_f.adjacentSubSurface.empty?  # not an interior window that's already in the AFN
               vent_open = VentilationOpening.new(opening)
               open_fac = vent_open.to_openstudio_afn(openstudio_model, sub_f)
-              operable_subfs << sub_f
-              opening_factors << open_fac
+              unless open_fac.nil?  # nil is used for horizontal exterior skylights
+                operable_subfs << sub_f
+                opening_factors << open_fac
+              end
             end
           end
         end

data/lib/to_openstudio/ventcool/opening.rb

@@ -128,43 +128,69 @@ module Honeybee
     end
 
     def to_openstudio_afn(openstudio_model, parent)
-      # process the flow_coefficient_closed and set it to a very small number if it's 0
+      # get the tilt and BC of the parent so that we can use the correct AFN object
+      srf_tilt = parent.tilt.to_f * (180 / Math::PI)
+      srf_bc = parent.outsideBoundaryCondition.to_s
+
+      # process the flow_coefficient_closed and flow exponent
       if @hash[:flow_coefficient_closed] and @hash[:flow_coefficient_closed] != 0
         flow_coefficient = @hash[:flow_coefficient_closed]
       else
         flow_coefficient = 1.0e-09  # set it to a very small number
       end
-
-      # create the simple opening object for the Aperture or Door using default values
       flow_exponent = defaults[:flow_exponent_closed][:default].to_f
-      two_way_thresh = defaults[:two_way_threshold][:default].to_f
-      discharge_coeff = defaults[:discharge_coefficient][:default].to_f
-      os_opening = OpenStudio::Model::AirflowNetworkSimpleOpening.new(
-        openstudio_model, flow_coefficient, flow_exponent, two_way_thresh, discharge_coeff)
-
-      # assign the flow exponent when the opening is closed
-      if @hash[:flow_exponent_closed]
-        os_opening.setAirMassFlowExponentWhenOpeningisClosed(@hash[:flow_exponent_closed])
-      end
-      # assign the minimum difference for two-way flow
-      if @hash[:two_way_threshold]
-        os_opening.setMinimumDensityDifferenceforTwoWayFlow(@hash[:two_way_threshold])
-      end
-      # assign the discharge coefficient
-      if @hash[:discharge_coefficient]
-        os_opening.setDischargeCoefficient(@hash[:discharge_coefficient])
-      end
-
-      # create the AirflowNetworkSurface
-      os_afn_srf = parent.getAirflowNetworkSurface(os_opening)
 
-      # assign the opening area
+      # process the opening area
       if @hash[:fraction_area_operable]
         open_fac = @hash[:fraction_area_operable]
       else
         open_fac = defaults[:fraction_area_operable][:default]
       end
-      os_afn_srf.setWindowDoorOpeningFactorOrCrackFactor(open_fac)
+
+      # create an opening obj
+      if srf_tilt < 10 || srf_tilt > 170
+        if srf_bc == 'Outdoors'
+          # create a crack object to represent an exterior in-operable horizontal skylight
+          open_fac = nil
+          os_opening = OpenStudio::Model::AirflowNetworkCrack.new(
+            openstudio_model, flow_coefficient, flow_exponent, $afn_reference_crack)
+        else
+          # create a HorizontalOpening object to represent the interior horizontal window
+          discharge_coeff = defaults[:discharge_coefficient][:default].to_f
+          if srf_tilt < 10
+            slope_ang = 90 - srf_tilt
+          else
+            slope_ang = 90 - (180 - srf_tilt)
+          end
+          os_opening = OpenStudio::Model::AirflowNetworkHorizontalOpening .new(
+            openstudio_model, flow_coefficient, flow_exponent, slope_ang, discharge_coeff)
+        end
+      else
+        # create the simple opening object for the Aperture or Door using default values
+        two_way_thresh = defaults[:two_way_threshold][:default].to_f
+        discharge_coeff = defaults[:discharge_coefficient][:default].to_f
+        os_opening = OpenStudio::Model::AirflowNetworkSimpleOpening.new(
+          openstudio_model, flow_coefficient, flow_exponent, two_way_thresh, discharge_coeff)
+
+        # assign the flow exponent when the opening is closed
+        if @hash[:flow_exponent_closed]
+          os_opening.setAirMassFlowExponentWhenOpeningisClosed(@hash[:flow_exponent_closed])
+        end
+        # assign the minimum difference for two-way flow
+        if @hash[:two_way_threshold]
+          os_opening.setMinimumDensityDifferenceforTwoWayFlow(@hash[:two_way_threshold])
+        end
+        # assign the discharge coefficient
+        if @hash[:discharge_coefficient]
+          os_opening.setDischargeCoefficient(@hash[:discharge_coefficient])
+        end
+      end
+
+      # create the AirflowNetworkSurface and assign the opening factor
+      os_afn_srf = parent.getAirflowNetworkSurface(os_opening)
+      unless open_fac.nil?
+        os_afn_srf.setWindowDoorOpeningFactorOrCrackFactor(open_fac)
+      end
 
       open_fac
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: honeybee-openstudio
 version: !ruby/object:Gem::Version
-  version: 2.22.2
+  version: 2.22.3
 platform: ruby
 authors:
 - Tanushree Charan
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-08-20 00:00:00.000000000 Z
+date: 2021-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -89,14 +89,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.54.0
+        version: 1.15.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.54.0
+        version: 1.15.0
 - !ruby/object:Gem::Dependency
   name: json_pure
   requirement: !ruby/object:Gem::Requirement
@@ -117,28 +117,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.4.2
+        version: 0.4.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.4.2
+        version: 0.4.3
 - !ruby/object:Gem::Dependency
   name: openstudio-standards
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.13
+        version: 0.2.14
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.13
+        version: 0.2.14
 description: Library and measures for translating between Honeybee JSON schema and
   OpenStudio Model schema (OSM).
 email: