honeybadger 5.13.0 → 5.13.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 02da7e28bdfb138d80a3e8e3e591d45383406fac1676ed04f0df139125e56247
-  data.tar.gz: 2c08c2e0e4e42ea9b7532c09f28f8d1c60a4944dab1e0d1ebc277becb58f8947
+  metadata.gz: de851e791df98653d1e5af860eba6f9dec3cc39666cff9e6e8bfc04dcfd81e5d
+  data.tar.gz: 618b8fd621606d0e8db648807e308a67b9c0212a0dea0e66c4bd54cf9e671cf6
 SHA512:
-  metadata.gz: cd07b8f3bfe423336690f00dc80addfb4fbda2db27bbcca0739204888b1565455ea09cbb6d5e643162f00c247ce09ff867e3eab0d71d7f59ca8d39bfc26164cd
-  data.tar.gz: 93e0ad66065c9be2c216e69a0d631effe6ba795ff90f328bf05a24bd2d45b60369e1cf3df4b0fc15478c7a73ec497a8661265bdb3daf52b39668117a7b123c9b
+  metadata.gz: a5b1db0b353ff7000b6b32c7664e69003a9bb69a75282392f639df5b8b352c65b7f4bd3a4736fbfd96a44d3d0070dc9c1ef348d98878cb93f22f7cb73b856a5a
+  data.tar.gz: 8aea0c27bd056a5cfc41114ee0a160e00c30aa8752fcec84b215706a23b6329a6f1648106176f9ca8f484e7518716c4348e9aaf1989ee70dcbfe9de415f32e1e

data/CHANGELOG.md

@@ -1,6 +1,22 @@
 # Change Log
 
 
+## [5.13.2](https://github.com/honeybadger-io/honeybadger-ruby/compare/v5.13.1...v5.13.2) (2024-07-03)
+
+
+### Bug Fixes
+
+* buffer more and warn less ([#575](https://github.com/honeybadger-io/honeybadger-ruby/issues/575)) ([8e99e17](https://github.com/honeybadger-io/honeybadger-ruby/commit/8e99e17af65e8d0002e5e8204d5ded1cea891e86))
+
+## [5.13.1](https://github.com/honeybadger-io/honeybadger-ruby/compare/v5.13.0...v5.13.1) (2024-07-01)
+
+
+### Bug Fixes
+
+* do not check for rails console ([#574](https://github.com/honeybadger-io/honeybadger-ruby/issues/574)) ([ba74af8](https://github.com/honeybadger-io/honeybadger-ruby/commit/ba74af8b55393ea0a96962085ea48c4376380be3))
+* ignore content-less SQL statements ([#572](https://github.com/honeybadger-io/honeybadger-ruby/issues/572)) ([e7ecd36](https://github.com/honeybadger-io/honeybadger-ruby/commit/e7ecd36969922496e276a246406fe7d792de00e3))
+* sanitize SQL when reporting SQL queries ([#571](https://github.com/honeybadger-io/honeybadger-ruby/issues/571)) ([40d4a79](https://github.com/honeybadger-io/honeybadger-ruby/commit/40d4a79a5c1f758fe49779e63697d56599537235))
+
 ## [5.13.0](https://github.com/honeybadger-io/honeybadger-ruby/compare/v5.12.0...v5.13.0) (2024-06-18)
 
 

data/lib/honeybadger/config/defaults.rb

@@ -93,7 +93,7 @@ module Honeybadger
       },
       :'events.max_queue_size' => {
         description: 'Maximum number of event for the event worker queue.',
-        default: 10000,
+        default: 100000,
         type: Integer
       },
       :'events.batch_size' => {

data/lib/honeybadger/config.rb

@@ -277,7 +277,6 @@ module Honeybadger
     end
 
     def insights_enabled?
-      return false if defined?(::Rails.application) && ::Rails.const_defined?("Console")
       !!self[:'insights.enabled']
     end
 

data/lib/honeybadger/events_worker.rb

@@ -39,13 +39,14 @@ module Honeybadger
       @pid = Process.pid
       @send_queue = []
       @last_sent = nil
+      @dropped_events = 0
     end
 
     def push(msg)
       return false unless start
 
       if queue.size >= config.events_max_queue_size
-        warn { sprintf('Unable to send event; reached max queue size of %s.', queue.size) }
+        @dropped_events += 1
         return false
       end
 
@@ -207,7 +208,12 @@ module Honeybadger
       send_now(mutex.synchronize { send_queue })
       mutex.synchronize do
         @last_sent = Time.now
+        debug { sprintf('Sending %s events', send_queue.length) }
         send_queue.clear
+        if @dropped_events > 0
+          warn { sprintf('Dropped %s messages due to exceeding max queue size of %s', @dropped_events, config.events_max_queue_size) }
+        end
+        @dropped_events = 0
       end
     end
 

data/lib/honeybadger/notification_subscriber.rb

@@ -1,4 +1,5 @@
 require 'honeybadger/instrumentation_helper'
+require 'honeybadger/util/sql'
 
 module Honeybadger
   class NotificationSubscriber
@@ -9,7 +10,7 @@ module Honeybadger
     def finish(name, id, payload)
       @finish_time = ::Process.clock_gettime(::Process::CLOCK_MONOTONIC)
 
-      return unless process?(name)
+      return unless process?(name, payload)
 
       payload = {
         instrumenter_id: id,
@@ -23,7 +24,7 @@ module Honeybadger
       Honeybadger.event(name, payload)
     end
 
-    def process?(event)
+    def process?(event, payload)
       true
     end
 
@@ -58,10 +59,16 @@ module Honeybadger
   class ActiveRecordSubscriber < NotificationSubscriber
     def format_payload(payload)
       {
-        query: payload[:sql].to_s.gsub(/\s+/, ' ').strip,
+        query: Util::SQL.obfuscate(payload[:sql], payload[:connection].adapter_name),
         async: payload[:async]
       }
     end
+
+    def process?(event, payload)
+      return false if payload[:name] == "SCHEMA"
+      return false if payload[:sql]&.match?(/^(begin|commit)( transaction)?$/i)
+      true
+    end
   end
 
   class ActiveJobSubscriber < NotificationSubscriber

data/lib/honeybadger/plugins/rails.rb

@@ -71,16 +71,18 @@ module Honeybadger
       end
 
       Plugin.register :rails do
-        requirement { config.load_plugin_insights?(:rails_metrics) && defined?(::Rails.application) && ::Rails.application }
+        requirement { defined?(::Rails.application) && ::Rails.application }
 
         execution do
-          ::ActiveSupport::Notifications.subscribe(/(process_action|send_file|redirect_to|halted_callback|unpermitted_parameters)\.action_controller/, Honeybadger::ActionControllerSubscriber.new)
-          ::ActiveSupport::Notifications.subscribe(/(write_fragment|read_fragment|expire_fragment|exist_fragment\?)\.action_controller/, Honeybadger::ActionControllerCacheSubscriber.new)
-          ::ActiveSupport::Notifications.subscribe(/cache_(read|read_multi|generate|fetch_hit|write|write_multi|increment|decrement|delete|delete_multi|cleanup|prune|exist\?)\.active_support/, Honeybadger::ActiveSupportCacheSubscriber.new)
-          ::ActiveSupport::Notifications.subscribe(/^render_(template|partial|collection)\.action_view/, Honeybadger::ActionViewSubscriber.new)
-          ::ActiveSupport::Notifications.subscribe("sql.active_record", Honeybadger::ActiveRecordSubscriber.new)
-          ::ActiveSupport::Notifications.subscribe("process.action_mailer", Honeybadger::ActionMailerSubscriber.new)
-          ::ActiveSupport::Notifications.subscribe(/(service_upload|service_download)\.active_storage/, Honeybadger::ActiveStorageSubscriber.new)
+          if config.load_plugin_insights?(:rails)
+            ::ActiveSupport::Notifications.subscribe(/(process_action|send_file|redirect_to|halted_callback|unpermitted_parameters)\.action_controller/, Honeybadger::ActionControllerSubscriber.new)
+            ::ActiveSupport::Notifications.subscribe(/(write_fragment|read_fragment|expire_fragment|exist_fragment\?)\.action_controller/, Honeybadger::ActionControllerCacheSubscriber.new)
+            ::ActiveSupport::Notifications.subscribe(/cache_(read|read_multi|generate|fetch_hit|write|write_multi|increment|decrement|delete|delete_multi|cleanup|prune|exist\?)\.active_support/, Honeybadger::ActiveSupportCacheSubscriber.new)
+            ::ActiveSupport::Notifications.subscribe(/^render_(template|partial|collection)\.action_view/, Honeybadger::ActionViewSubscriber.new)
+            ::ActiveSupport::Notifications.subscribe("sql.active_record", Honeybadger::ActiveRecordSubscriber.new)
+            ::ActiveSupport::Notifications.subscribe("process.action_mailer", Honeybadger::ActionMailerSubscriber.new)
+            ::ActiveSupport::Notifications.subscribe(/(service_upload|service_download)\.active_storage/, Honeybadger::ActiveStorageSubscriber.new)
+          end
         end
       end
     end

data/lib/honeybadger/util/sql.rb

@@ -1,32 +1,29 @@
 module Honeybadger
   module Util
     class SQL
-      EscapedQuotes = /(\\"|\\')/.freeze
-      SQuotedData = /'(?:[^']|'')*'/.freeze
-      DQuotedData = /"(?:[^"]|"")*"/.freeze
-      NumericData = /\b\d+\b/.freeze
-      Newline = /\n/.freeze
-      Replacement = "?".freeze
-      EmptyReplacement = "".freeze
-      DoubleQuoters = /(postgres|sqlite|postgis)/.freeze
+      ESCAPE_QUOTES = /(\\"|\\')/
+      SQUOTE_DATA = /'(?:[^']|'')*'/
+      DQUOTE_DATA = /"(?:[^"]|"")*"/
+      NUMBER_DATA = /\b\d+\b/
+      DOUBLE_QUOTERS = /(postgres|sqlite|postgis)/i
 
       def self.obfuscate(sql, adapter)
-        force_utf_8(sql.dup).tap do |s|
-          s.gsub!(EscapedQuotes, EmptyReplacement)
-          s.gsub!(SQuotedData, Replacement)
-          s.gsub!(DQuotedData, Replacement) if adapter =~ DoubleQuoters
-          s.gsub!(NumericData, Replacement)
-          s.gsub!(Newline, EmptyReplacement)
-          s.squeeze!(' ')
+        force_utf_8(sql.to_s.dup).tap do |s|
+          s.gsub!(/\s+/, " ")
+          s.gsub!(ESCAPE_QUOTES, "".freeze)
+          s.gsub!(SQUOTE_DATA, "'?'".freeze)
+          s.gsub!(DQUOTE_DATA, '"?"'.freeze) unless adapter.to_s.match?(DOUBLE_QUOTERS)
+          s.gsub!(NUMBER_DATA, "?".freeze)
+          s.strip!
         end
       end
 
       def self.force_utf_8(string)
         string.encode(
-          Encoding.find('UTF-8'),
-          invalid: :replace, 
-          undef: :replace, 
-          replace: ''
+          Encoding.find("UTF-8"),
+          invalid: :replace,
+          undef: :replace,
+          replace: ""
         )
       end
     end

data/lib/honeybadger/version.rb

@@ -1,4 +1,4 @@
 module Honeybadger
   # The current String Honeybadger version.
-  VERSION = '5.13.0'.freeze
+  VERSION = '5.13.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: honeybadger
 version: !ruby/object:Gem::Version
-  version: 5.13.0
+  version: 5.13.2
 platform: ruby
 authors:
 - Honeybadger Industries LLC
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-06-18 00:00:00.000000000 Z
+date: 2024-07-03 00:00:00.000000000 Z
 dependencies: []
 description: Make managing application errors a more pleasant experience.
 email: