honeybadger 4.7.0 → 4.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c106736f2bbc8d50ef833e9672693b6261cfb7c5852273caad63d2bd77c4e6c6
-  data.tar.gz: 1a23b8213a91d8f2cd0c58e33815bc78dec8c6cb0b361c6ae246b542667d1ab3
+  metadata.gz: 2c76ef937ae77d449421f97e342bd86f77176a705fb6b7a75e4928e0a48fc71b
+  data.tar.gz: db036be307a2f741187951a46f30845451e5e01d49d266250837dcb6869b084c
 SHA512:
-  metadata.gz: b5fa74f25ec9d2acb5dcfb9743900015973c30f83082a8d67016e70afd767021c75dea3afb4179af365b35ebacd359f866fe72bec3ab59b1b9698a986cb1b8c8
-  data.tar.gz: d748ce7cbc8f5de4241d30bca391a1bcfb80e336720e1f8d7430af034b265898e4b76491cfabe36525b65ddcb7aa7956664b3648d0adf9642c9d5f4b14d9bf12
+  metadata.gz: e57d7371fa97c9e9f356824ac5ee15454106cbf332d772c0fc74f01a5d8d5aaac7b78f7f09eacc2d4e902c432f24ca30146ed36e697048ee9a9e31902472942d
+  data.tar.gz: 6f14009e5ea56d72bdba4a95a3bcfe23fd29e6bc8870b701e3f6a0869e4aa750bc56485ac149f512484881bdd477af7c8dd41668b104323d54be840c31f13800

data/CHANGELOG.md

@@ -5,6 +5,14 @@ adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [4.7.1] - 2020-08-11
+### Fixed
+- ActiveRecord SQL Breadcrumb event pulls adapter from supplied connection,
+  allowing for multiple databases.
+- Fix Rails deprecation of `ActionDispatch::ParamsParser::ParseError`
+- Deal with invalid UTF-8 byte sequences during SQL obfuscation
+- Fix Ruby 2.7 deprecation notice in sql.rb
+
 ## [4.7.0] - 2020-06-02
 ### Fixed
 - Alias `Notice#controller=` as `Notice#component=`

data/lib/honeybadger/agent.rb

@@ -70,6 +70,8 @@ module Honeybadger
       if local_context
         @context ||= ContextManager.new
         @breadcrumbs = Breadcrumbs::Collector.new(config)
+      else
+        @breadcrumbs = nil
       end
 
       init_worker

data/lib/honeybadger/breadcrumbs/active_support.rb

@@ -15,10 +15,11 @@ module Honeybadger
               ["Active Record", name].compact.join(" - ")
             end,
             category: "query",
-            select_keys: [:sql, :name, :connection_id, :cached],
+            select_keys: [:sql, :name, :connection, :connection_id, :cached],
             transform: lambda do |data|
               if data[:sql]
-                adapter = active_record_connection_db_config[:adapter]
+                connection = data.delete(:connection) || ::ActiveRecord::Base.connection
+                adapter = connection.adapter_name.downcase
                 data[:sql] = Util::SQL.obfuscate(data[:sql], adapter)
               end
               data
@@ -102,16 +103,6 @@ module Honeybadger
           }
         }
       end
-
-      private_class_method def self.active_record_connection_db_config
-        if ::ActiveRecord::Base.respond_to?(:connection_db_config)
-          # >= Rails 6.1
-          ::ActiveRecord::Base.connection_db_config.configuration_hash
-        else
-          # < Rails 6.1
-          ::ActiveRecord::Base.connection_config
-        end
-      end
     end
   end
 end

data/lib/honeybadger/cli/helpers.rb

@@ -15,7 +15,7 @@ To fix this issue, please try the following:
 
   - Make sure the gem is configured properly.
   - Retry executing this command a few times.
-  - Make sure you can connect to #{host} (`ping #{host}`).
+  - Make sure you can connect to #{host} (`curl https://#{host}/v1/notices`).
   - Email support@honeybadger.io for help. Include as much debug info as you
     can for a faster resolution!
 

data/lib/honeybadger/cli/main.rb

@@ -196,7 +196,7 @@ WELCOME
 # What can I do?
 
   - Retry the command.
-  - Make sure you can connect to api.honeybadger.io (`ping api.honeybadger.io`).
+  - Make sure you can connect to api.honeybadger.io (`curl https://api.honeybadger.io/v1/notices`).
   - If you continue to see this message, email us at support@honeybadger.io
     (don't forget to attach this output!)
 

data/lib/honeybadger/cli/test.rb

@@ -175,7 +175,7 @@ To fix this issue, please try the following:
 
   - Make sure the gem is configured properly.
   - Retry executing this command a few times.
-  - Make sure you can connect to #{host} (`ping #{host}`).
+  - Make sure you can connect to #{host} (`curl https://#{host}/v1/notices`).
   - Email support@honeybadger.io for help. Include as much debug info as you
     can for a faster resolution!
 

data/lib/honeybadger/config/defaults.rb

@@ -13,7 +13,12 @@ module Honeybadger
                       'ActionController::UnknownFormat',
                       'ActionController::InvalidAuthenticityToken',
                       'ActionController::InvalidCrossOriginRequest',
+                      # ActionDispatch::ParamsParser::ParseError was removed in Rails 6.0
+                      # and may be removed here once support for Rails 5.2 is dropped.
+                      # https://github.com/rails/rails/commit/e16c765ac6dcff068ff2e5554d69ff345c003de1
+                      # https://github.com/honeybadger-io/honeybadger-ruby/pull/358
                       'ActionDispatch::ParamsParser::ParseError',
+                      'ActionDispatch::Http::Parameters::ParseError',
                       'ActionController::BadRequest',
                       'ActionController::ParameterMissing',
                       'ActiveRecord::RecordNotFound',

data/lib/honeybadger/util/sql.rb

@@ -11,7 +11,7 @@ module Honeybadger
       DoubleQuoters = /(postgres|sqlite|postgis)/.freeze
 
       def self.obfuscate(sql, adapter)
-        sql.dup.tap do |s|
+        force_utf_8(sql.dup).tap do |s|
           s.gsub!(EscapedQuotes, EmptyReplacement)
           s.gsub!(SQuotedData, Replacement)
           s.gsub!(DQuotedData, Replacement) if adapter =~ DoubleQuoters
@@ -20,6 +20,15 @@ module Honeybadger
           s.squeeze!(' ')
         end
       end
+
+      def self.force_utf_8(string)
+        string.encode(
+          Encoding.find('UTF-8'),
+          invalid: :replace, 
+          undef: :replace, 
+          replace: ''
+        )
+      end
     end
   end
 end

data/lib/honeybadger/version.rb

@@ -1,4 +1,4 @@
 module Honeybadger
   # The current String Honeybadger version.
-  VERSION = '4.7.0'.freeze
+  VERSION = '4.7.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: honeybadger
 version: !ruby/object:Gem::Version
-  version: 4.7.0
+  version: 4.7.1
 platform: ruby
 authors:
 - Honeybadger Industries LLC
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-06-02 00:00:00.000000000 Z
+date: 2020-08-11 00:00:00.000000000 Z
 dependencies: []
 description: Make managing application errors a more pleasant experience.
 email:
@@ -135,7 +135,7 @@ homepage: https://github.com/honeybadger-io/honeybadger-ruby
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--markup=tomdoc"
 - "--main=README.md"
@@ -154,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Error reports you can be happy about.
 test_files: []