honeybadger 4.2.0 → 4.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a6d163c5a87db64d1c5e591757d69dfd7be38854e01150c3ec4a86f041ea020
-  data.tar.gz: b3b56e28bd3f5885d5db6adf4d23d7f7ce7bdce8497ce62f68b3b267921a0eee
+  metadata.gz: 05e9c7de2bd4014e179121924ea1a5fd6458b7c222b79bf8fe3f83b8003514d3
+  data.tar.gz: 9f4d71019d4c70edd7c4855fe614c65d5e1b0828e947c5e5139c6391c8996906
 SHA512:
-  metadata.gz: f4eeb6527e4de32f97020b8b19af675e17500138aafde1ee1a9541ebf9b6b09fa7f62987f63d3908c03646ff4dd2303d10460d930c2b3075a4df2054e7003371
-  data.tar.gz: 0ad30ae7ddf8a44d592cac241e5faa8b4c55589b2cba15d414e3c6d06df59f745fd2034d0cfa45334f0a81466d2b2904c65df368751af2ee87d6217ac2a5e60d
+  metadata.gz: 0dbafa05b24ddb36f788cf470a381261186dd3ec815f095394156405154f9e6ed75986b1caced46d5b82f8a9ef59b0228b277319237d320c054f4529ebb47dfa
+  data.tar.gz: a194e1bd2c80039f5a58050b059dcd62762cd5a9392292fc3b532eace76d6c577a1d220d0ea33a4377e8d71a593dfd303ee71edaa2bc8b33fe611e63635cebad

data/CHANGELOG.md

@@ -5,14 +5,21 @@ adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+## [4.2.1] - 2019-02-01
+### Fixed
+- Fix #301 - before_notify hooks are overridden on subsequent
+  `Honeybadger.configure` calls.
+- Revert "Get the right controller / action name in Rails, when using an
+  exception app for custom error pages."
+
 ## [4.2.0] - 2019-01-31
 ### Changed
-- Issue a Notification from a Sidekiq job when either the `sidekiq.attempt_threshold` is reached OR if the job defined retry threshold is reached, whichever comes first.
+- Issue a Notification from a Sidekiq job when either the `sidekiq.attempt_threshold` is reached OR if the job defined retry threshold is reached, whichever comes first. -@mstruve
 - Updated supported Ruby/Rails versions (MRI >= 2.3.0, JRuby >= 9.2, Rails >= 4.2)
   https://docs.honeybadger.io/ruby/gem-reference/supported-versions.html
 
 ### Added
-- Get the right controller / action name in Rails, when using an exception app for custom error pages.
+- Get the right controller / action name in Rails, when using an exception app for custom error pages. -@fernandes
 
 ## [4.1.0] - 2018-10-16
 ### Added

data/lib/honeybadger/config/ruby.rb

@@ -82,13 +82,15 @@ module Honeybadger
       end
 
       def before_notify(action = nil, &block)
-        (hash[:before_notify] ||= []).tap do |before_notify_hooks|
-          if action && validate_before_action(action)
-            before_notify_hooks << action
-          elsif block_given? && validate_before_action(block)
-            before_notify_hooks << block
-          end
+        hooks = Array(get(:before_notify)).dup
+
+        if action && validate_before_action(action)
+          hooks << action
+        elsif block_given? && validate_before_action(block)
+          hooks << block
         end
+
+        hash[:before_notify] = hooks
       end
 
       def backtrace_filter

data/lib/honeybadger/config.rb

@@ -72,9 +72,9 @@ module Honeybadger
     end
 
     def configure
-      ruby_config = Ruby.new(self)
-      yield(ruby_config)
-      self.ruby = ruby.merge(ruby_config).freeze
+      new_ruby = Ruby.new(self)
+      yield(new_ruby)
+      self.ruby = ruby.merge(new_ruby).freeze
       @logger = @backend = nil
       self
     end

data/lib/honeybadger/plugins/rails.rb

@@ -33,21 +33,6 @@ module Honeybadger
         requirement { defined?(::Rails.application) && ::Rails.application }
 
         execution do
-          if ::Rails.application.config.exceptions_app.is_a?(::ActionDispatch::Routing::RouteSet)
-            Honeybadger.configure do |config|
-              config.before_notify do |notice|
-                begin
-                  route_resolver = ::Rails.application.routes.recognize_path(notice.url)
-                  notice.component = route_resolver[:controller]
-                  notice.action = route_resolver[:action]
-                rescue ::ActionController::RoutingError
-                  # if rails can't find the route (like assets)
-                  # we just ignore and keep the old component / action
-                end
-              end
-            end
-          end
-
           require 'rack/request'
           if defined?(::ActionDispatch::DebugExceptions)
             # Rails 3.2.x+

data/lib/honeybadger/version.rb

@@ -1,4 +1,4 @@
 module Honeybadger
   # The current String Honeybadger version.
-  VERSION = '4.2.0'.freeze
+  VERSION = '4.2.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: honeybadger
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.2.1
 platform: ruby
 authors:
 - Honeybadger Industries LLC
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-31 00:00:00.000000000 Z
+date: 2019-02-02 00:00:00.000000000 Z
 dependencies: []
 description: Make managing application errors a more pleasant experience.
 email: