honeybadger 2.3.1 → 2.3.2.beta.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b8fd7ece78bb49eb737c7e1b63fcade6ec62681e
-  data.tar.gz: d7403db13cc08a42b163935683efc7b2142c05c2
+  metadata.gz: 38da9f662383d281ad7a322daa0487915c2510aa
+  data.tar.gz: 11addbaca8a3be842d3d87a0525ef858a9676684
 SHA512:
-  metadata.gz: 1b983bdca80d05e73242350255360c01cc67c69d4237e78707b920234bfa4e37d778b4c8de9e7610e85f9bef0c05179681182f65b8d0725aff9ba1374ee1c6f0
-  data.tar.gz: 31b7be6e92207d526d78c6e4d72afb7b3c128eb1827adf33e0d75b8518763bac3ffc729017f08897aa8b67726a34b6837f5dcb950d501d403d49b066697eb836
+  metadata.gz: 54e65efde630cf3282af4218edde463f3b92059874551a0c852e48120657ae86bf9e4e9abc35f39387709c7d32e11766313c6f224d674967fda5beb59c5c30e4
+  data.tar.gz: 4993751cfb80e7c42a402275e8f233b05f72dbb5850c69b675dd10e0824ab2b42f0d5075ab00fbd743ad668a5d376e72246f618217cace90a4cce10cb6917238

data/CHANGELOG.md

@@ -5,6 +5,12 @@ adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased][unreleased]
 
+## [2.3.2.beta.1] - 2015-12-07
+## Fixed
+- Be stricter when sanitizing recursive objects (allow only `Hash`, `Array`,
+  `Set`).  This fixes a bug where some gems (such as the dropbox gem)
+  monkeypatch `#to_hash` on `Array`.
+
 ## [2.3.1] - 2015-11-20
 ## Fixed
 - Handle invalid utf8 in ActiveRecord SQL queries.

data/README.md

@@ -39,7 +39,7 @@ Integrating with other libraries/frameworks is simple! [See the documentation](h
 | Resque        | any           | yes        |
 | Delayed Job   | any           | yes        |
 
-You can integrate honeybadger into any Ruby script by using manual exception notification, which is detailed below. 
+You can integrate honeybadger into any Ruby script via the `Honeybadger.notify` method. 
 
 ## Getting Started
 
@@ -329,7 +329,7 @@ end
 
 ### `Honeybadger.exception_filter()`: Programmatically ignore exceptions
 
-This method lets you add a callback that will be run every time an exception is about to be reported to Honeybadger. If your callback returns a falsey value, the exception won't be reported. [View full method documentation](http://www.rubydoc.info/gems/honeybadger/Honeybadger%3Aexception_filter)
+This method lets you add a callback that will be run every time an exception is about to be reported to Honeybadger. If your callback returns a truthy value, the exception won't be reported. [View full method documentation](http://www.rubydoc.info/gems/honeybadger/Honeybadger%3Aexception_filter)
 
 #### Use this method if:
 

data/lib/honeybadger/notice.rb

@@ -174,7 +174,7 @@ module Honeybadger
           token: id,
           class: s(error_class),
           message: s(error_message),
-          backtrace: s(backtrace),
+          backtrace: s(backtrace.to_a),
           source: s(source),
           fingerprint: s(fingerprint),
           tags: s(tags),
@@ -447,7 +447,7 @@ module Honeybadger
         c << {
           class: e.class.name,
           message: e.message,
-          backtrace: parse_backtrace(e.backtrace || caller)
+          backtrace: parse_backtrace(e.backtrace || caller).to_a
         }
         i += 1
       end

data/lib/honeybadger/util/sanitizer.rb

@@ -3,8 +3,6 @@ require 'set'
 module Honeybadger
   module Util
     class Sanitizer
-      OBJECT_WHITELIST = [Hash, Array, String, Integer, Float, TrueClass, FalseClass, NilClass]
-
       FILTERED_REPLACEMENT = '[FILTERED]'.freeze
 
       TRUNCATION_REPLACEMENT = '[TRUNCATED]'.freeze
@@ -26,15 +24,14 @@ module Honeybadger
       end
 
       def sanitize(data, depth = 0, stack = nil)
-        if recursive?(data)
+        if data.kind_of?(Hash) || data.kind_of?(Array) || data.kind_of?(Set)
           return '[possible infinite recursion halted]' if stack && stack.include?(data.object_id)
           stack = stack ? stack.dup : Set.new
           stack << data.object_id
         end
 
-        if data.kind_of?(String)
-          self.class.sanitize_string(data)
-        elsif data.respond_to?(:to_hash)
+        case data
+        when Hash
           return '[max depth reached]' if depth >= max_depth
           hash = data.to_hash
           new_hash = {}
@@ -47,14 +44,16 @@ module Honeybadger
             end
           end
           new_hash
-        elsif data.respond_to?(:to_ary)
+        when Array, Set
           return '[max depth reached]' if depth >= max_depth
-          data.to_ary.map do |value|
+          data.to_a.map do |value|
             sanitize(value, depth+1, stack)
           end.compact
-        elsif OBJECT_WHITELIST.any? {|c| data.kind_of?(c) }
+        when Numeric, TrueClass, FalseClass, NilClass
           data
-        else
+        when String
+          self.class.sanitize_string(data.to_s)
+        else # all other objects:
           self.class.sanitize_string(data.to_s)
         end
       end
@@ -119,10 +118,6 @@ module Honeybadger
 
       attr_reader :max_depth, :filters
 
-      def recursive?(data)
-        data.respond_to?(:to_hash) || data.respond_to?(:to_ary)
-      end
-
       def filter_key?(key)
         return false unless filters
 

data/lib/honeybadger/version.rb

@@ -1,4 +1,4 @@
 module Honeybadger
   # Public: The current String Honeybadger version.
-  VERSION = '2.3.1'.freeze
+  VERSION = '2.3.2.beta.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: honeybadger
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.2.beta.1
 platform: ruby
 authors:
 - Honeybadger Industries LLC
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-20 00:00:00.000000000 Z
+date: 2015-12-07 00:00:00.000000000 Z
 dependencies: []
 description: Make managing application errors a more pleasant experience.
 email:
@@ -134,9 +134,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5