honeybadger 1.9.5 → 1.10.0.beta1

data/spec/honeybadger/user_feedback_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+require 'sham_rack'
+
+describe Honeybadger::UserFeedback do
+  let(:main_app) do
+    lambda do |env|
+      env['honeybadger.error_id'] = honeybadger_id if defined?(honeybadger_id)
+      [200, {}, ["<!-- HONEYBADGER FEEDBACK -->"]]
+    end
+  end
+  let(:informer_app) { Honeybadger::UserFeedback.new(main_app) }
+  let(:response) { Net::HTTP.get_response(URI.parse("http://example.com/")) }
+
+  before do
+    ShamRack.mount(informer_app, "example.com")
+  end
+
+  context "feedback feature is disabled by ping" do
+    it 'does not modify the output' do
+      expect(response.body).to eq '<!-- HONEYBADGER FEEDBACK -->'
+    end
+  end
+
+  context "feedback feature is enabled by ping" do
+    before do
+      Honeybadger.configuration.features['feedback'] = true
+    end
+
+    context "there is a honeybadger id" do
+      let(:honeybadger_id) { 1 }
+
+      it 'modifies output' do
+        rendered_length = informer_app.render_form(1).size
+        expect(response.body).to match(/honeybadger_feedback_token/)
+        expect(response["Content-Length"].to_i).to eq rendered_length
+      end
+
+      context "feedback feature is disabled by customer" do
+        before do
+          Honeybadger.configuration.feedback = false
+        end
+
+        it 'does not modify the output' do
+          expect(response.body).to eq '<!-- HONEYBADGER FEEDBACK -->'
+        end
+      end
+    end
+
+    context "there is no honeybadger id" do
+      it 'does not modify the output' do
+        expect(response.body).to eq '<!-- HONEYBADGER FEEDBACK -->'
+      end
+    end
+  end
+end

data/spec/honeybadger/user_informer_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+require 'sham_rack'
+
+describe Honeybadger::UserInformer do
+  it 'modifies output if there is a honeybadger id' do
+    main_app = lambda do |env|
+      env['honeybadger.error_id'] = 1
+      [200, {}, ["<!-- HONEYBADGER ERROR -->"]]
+    end
+    informer_app = Honeybadger::UserInformer.new(main_app)
+
+    ShamRack.mount(informer_app, "example.com")
+
+    response = Net::HTTP.get_response(URI.parse("http://example.com/"))
+    expect(response.body).to eq 'Honeybadger Error 1'
+    expect(response["Content-Length"].to_i).to eq 19
+  end
+
+  it 'does not modify output if there is no honeybadger id' do
+    main_app = lambda do |env|
+      [200, {}, ["<!-- HONEYBADGER ERROR -->"]]
+    end
+    informer_app = Honeybadger::UserInformer.new(main_app)
+
+    ShamRack.mount(informer_app, "example.com")
+
+    response = Net::HTTP.get_response(URI.parse("http://example.com/"))
+    expect(response.body).to eq '<!-- HONEYBADGER ERROR -->'
+  end
+end

data/spec/support/helpers.rb

@@ -24,12 +24,15 @@ module Helpers
   end
 
   def stub_http(options = {})
-    response = options[:response] || Faraday::Response.new(:status => 200)
+    response = options[:response] || Net::HTTPSuccess.new('1.2', '200', 'OK')
     response.stub(:body => options[:body] || '{"id":"1234"}')
-
-    http = Faraday.new
-    http.stub(:post).and_return(response)
-    Faraday.stub(:new => http)
+    http = double(:post          => response,
+                :read_timeout= => nil,
+                :open_timeout= => nil,
+                :ca_file=      => nil,
+                :verify_mode=  => nil,
+                :use_ssl=      => nil)
+    Net::HTTP.stub(:new).and_return(http)
     http
   end
 
@@ -43,7 +46,7 @@ module Helpers
   def build_notice_data(exception = nil)
     exception ||= build_exception
     {
-      :api_key       => 'abc123',
+      :api_key       => nil,
       :error_class   => exception.class.name,
       :error_message => "#{exception.class.name}: #{exception.message}",
       :backtrace     => exception.backtrace,

metadata

@@ -1,46 +1,36 @@
 --- !ruby/object:Gem::Specification
 name: honeybadger
 version: !ruby/object:Gem::Version
-  version: 1.9.5
+  version: 1.10.0.beta1
+  prerelease: 7
 platform: ruby
 authors:
 - Joshua Wood
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-06 00:00:00.000000000 Z
+date: 2013-12-04 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: faraday
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.7'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -48,6 +38,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -55,6 +46,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -62,6 +54,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -69,6 +62,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: sham_rack
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -76,6 +70,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -83,6 +78,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: capistrano
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -90,6 +86,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -97,6 +94,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -104,6 +102,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -111,113 +110,129 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sinatra
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fuubar
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: growl
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Make managing application errors a more pleasant experience.
@@ -295,6 +310,9 @@ files:
 - lib/honeybadger/shared_tasks.rb
 - lib/honeybadger/stats.rb
 - lib/honeybadger/tasks.rb
+- lib/honeybadger/templates/feedback_form.html.erb
+- lib/honeybadger/user_feedback.rb
+- lib/honeybadger/user_informer.rb
 - lib/honeybadger_tasks.rb
 - lib/rails/generators/honeybadger/honeybadger_generator.rb
 - rails/init.rb
@@ -312,6 +330,8 @@ files:
 - spec/honeybadger/rails/action_controller_spec.rb
 - spec/honeybadger/rails_spec.rb
 - spec/honeybadger/sender_spec.rb
+- spec/honeybadger/user_feedback_spec.rb
+- spec/honeybadger/user_informer_spec.rb
 - spec/honeybadger_tasks_spec.rb
 - spec/spec_helper.rb
 - spec/support/array_including.rb
@@ -321,7 +341,6 @@ files:
 - spec/support/helpers.rb
 homepage: http://www.honeybadger.io
 licenses: []
-metadata: {}
 post_install_message: 
 rdoc_options:
 - --charset=UTF-8
@@ -329,18 +348,23 @@ rdoc_options:
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -735420527713291381
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.5
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 2
 summary: Error reports you can be happy about.

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: dd5d724bc0336e08b1ecc6f49f1e1508f21c7174
-  data.tar.gz: 57a61bc6a3d43587c00f106ac290bac232f6c5d9
-SHA512:
-  metadata.gz: 55735a6b7bbf0fc130005599f33568adc7a158a3b35ff2a04599b63ce7dd25b37bc55e56594e07f28cd2882e53ea816e34dc417823c58fe4f04497a48a81d1f2
-  data.tar.gz: d68d1302ba96a55d3363880d14115d6fdac5b435add9417063672b044ef7860995fc5d8514d60e47c30f900e5e340fac602635e80be18bcb108c63c70d988d40