honeybadger 1.8.1 → 1.9.0.beta1

data/test/unit/rack_test.rb

@@ -1,88 +0,0 @@
-require 'test_helper'
-
-class RackTest < Test::Unit::TestCase
-  should "call the upstream app with the environment" do
-    environment = { 'key' => 'value' }
-    app = lambda { |env| ['response', {}, env] }
-    stack = Honeybadger::Rack.new(app)
-
-    response = stack.call(environment)
-
-    assert_equal ['response', {}, environment], response
-  end
-
-  should "deliver an exception raised while calling an upstream app" do
-    Honeybadger.stubs(:notify_or_ignore)
-
-    exception = build_exception
-    environment = { 'key' => 'value' }
-    app = lambda do |env|
-      raise exception
-    end
-
-    begin
-      stack = Honeybadger::Rack.new(app)
-      stack.call(environment)
-    rescue Exception => raised
-      assert_equal exception, raised
-    else
-      flunk "Didn't raise an exception"
-    end
-
-    assert_received(Honeybadger, :notify_or_ignore) do |expect|
-      expect.with(exception, :rack_env => environment)
-    end
-  end
-
-  should "deliver an exception in rack.exception" do
-    Honeybadger.stubs(:notify_or_ignore)
-    exception = build_exception
-    environment = { 'key' => 'value' }
-
-    response = [200, {}, ['okay']]
-    app = lambda do |env|
-      env['rack.exception'] = exception
-      response
-    end
-    stack = Honeybadger::Rack.new(app)
-
-    actual_response = stack.call(environment)
-
-    assert_equal response, actual_response
-    assert_received(Honeybadger, :notify_or_ignore) do |expect|
-      expect.with(exception, :rack_env => environment)
-    end
-  end
-
-  should "deliver an exception in sinatra.error" do
-    Honeybadger.stubs(:notify_or_ignore)
-    exception = build_exception
-    environment = { 'key' => 'value' }
-
-    response = [200, {}, ['okay']]
-    app = lambda do |env|
-      env['sinatra.error'] = exception
-      response
-    end
-    stack = Honeybadger::Rack.new(app)
-
-    actual_response = stack.call(environment)
-
-    assert_equal response, actual_response
-    assert_received(Honeybadger, :notify_or_ignore) do |expect|
-      expect.with(exception, :rack_env => environment)
-    end
-  end
-
-  should "clear context after app is called" do
-    Honeybadger.context( :foo => :bar )
-    assert_equal({ :foo => :bar }, Thread.current[:honeybadger_context])
-
-    app = lambda { |env| ['response', {}, env] }
-    stack = Honeybadger::Rack.new(app)
-
-    response = stack.call({})
-
-    assert_equal nil, Thread.current[:honeybadger_context]
-  end
-end

data/test/unit/sender_test.rb

@@ -1,290 +0,0 @@
-require 'test_helper'
-
-class SenderTest < Test::Unit::TestCase
-  def setup
-    reset_config
-  end
-
-  def build_sender(opts = {})
-    Honeybadger.configure do |conf|
-      opts.each {|opt, value| conf.send(:"#{opt}=", value) }
-    end
-  end
-
-  def send_exception(args = {})
-    notice = args.delete(:notice) || build_notice_data
-    sender = args.delete(:sender) || build_sender(args)
-    sender.send_to_honeybadger(notice)
-  end
-
-  def stub_http(options = {})
-    response = options[:response] || Net::HTTPSuccess.new('1.2', '200', 'OK')
-    response.stubs(:body => options[:body] || '{"id":"1234"}')
-    http = stub(:post          => response,
-                :read_timeout= => nil,
-                :open_timeout= => nil,
-                :ca_file=      => nil,
-                :verify_mode=  => nil,
-                :use_ssl=      => nil)
-    Net::HTTP.stubs(:new => http)
-    http
-  end
-
-  should "post to Honeybadger when using an HTTP proxy" do
-    response = stub(:body => 'body')
-    http     = stub(:post          => response,
-                    :read_timeout= => nil,
-                    :open_timeout= => nil,
-                    :use_ssl=      => nil,
-                    :ca_file=      => nil,
-                    :verify_mode=  => nil)
-    proxy    = stub(:new => http)
-    Net::HTTP.stubs(:Proxy => proxy)
-
-    url = "http://api.honeybadger.io:80#{Honeybadger::Sender::NOTICES_URI}"
-    uri = URI.parse(url)
-
-    proxy_host = 'some.host'
-    proxy_port = 88
-    proxy_user = 'login'
-    proxy_pass = 'passwd'
-
-    send_exception(:proxy_host => proxy_host,
-                   :proxy_port => proxy_port,
-                   :proxy_user => proxy_user,
-                   :proxy_pass => proxy_pass)
-    assert_received(http, :post) do |expect| 
-      expect.with(uri.path, anything, Honeybadger::HEADERS.merge({ 'X-API-Key' => 'abc123'}))
-    end
-    assert_received(Net::HTTP, :Proxy) do |expect|
-      expect.with(proxy_host, proxy_port, proxy_user, proxy_pass)
-    end
-  end
-
-  should "return the created group's id on successful posting" do
-    http = stub_http(:body => '{"id":"3799307"}')
-    assert_equal "3799307", send_exception(:secure => false)
-  end
-
-  should "return nil on failed posting" do
-    http = stub_http(:response => Net::HTTPServerError.new('1.2', '500', 'Internal Error'))
-    assert_equal nil, send_exception(:secure => false)
-  end
-
-  should "log missing API key and return nil" do
-    sender = build_sender({ :api_key => nil })
-    sender.expects(:log).with(:error, includes('API key'))
-    assert_equal nil, send_exception(:sender => sender, :secure => false)
-  end
-
-  should "should log success" do
-    http = stub_http
-    sender = build_sender
-    sender.expects(:log).with(:debug, includes('Success'), kind_of(Net::HTTPSuccess), kind_of(String))
-    send_exception(:sender => sender, :secure => false)
-  end
-
-  should "should log failure" do
-    http = stub_http(:response => Net::HTTPServerError.new('1.2', '500', 'Internal Error'))
-    sender = build_sender
-    sender.expects(:log).with(:error, includes('Failure'), kind_of(Net::HTTPServerError), kind_of(String))
-    send_exception(:sender => sender, :secure => false)
-  end
-
-  context "when encountering exceptions: " do
-    context "HTTP connection setup problems" do
-      should "not be rescued" do
-        proxy = stub()
-        proxy.stubs(:new).raises(NoMemoryError)
-        Net::HTTP.stubs(:Proxy => proxy)
-
-        assert_raise NoMemoryError do
-          build_sender.send(:setup_http_connection)
-        end
-      end
-
-      should "be logged" do
-        proxy = stub()
-        proxy.stubs(:new).raises(RuntimeError)
-        Net::HTTP.stubs(:Proxy => proxy)
-
-        sender = build_sender
-        sender.expects(:log).with(:error, includes('Failure initializing the HTTP connection'))
-
-        assert_raise RuntimeError do
-          sender.send(:setup_http_connection)
-        end
-
-      end
-    end
-
-    context "unexpected exception sending problems" do
-      should "be logged" do
-        sender  = build_sender
-        sender.stubs(:setup_http_connection).raises(RuntimeError.new)
-
-        sender.expects(:log).with(:error, includes('Error'))
-        sender.send_to_honeybadger("stuff")
-      end
-
-      should "return nil no matter what" do
-        sender  = build_sender
-        sender.stubs(:setup_http_connection).raises(LocalJumpError)
-
-        assert_nothing_thrown do
-          assert_nil sender.send_to_honeybadger("stuff")
-        end
-      end
-    end
-
-    should "return nil on failed posting" do
-      http = stub_http
-      http.stubs(:post).raises(Errno::ECONNREFUSED)
-      assert_equal nil, send_exception(:secure => false)
-    end
-
-    should "not fail when posting and a timeout exception occurs" do
-      http = stub_http
-      http.stubs(:post).raises(TimeoutError)
-      assert_nothing_thrown do
-        send_exception(:secure => false)
-      end
-    end
-
-    should "not fail when posting and a connection refused exception occurs" do
-      http = stub_http
-      http.stubs(:post).raises(Errno::ECONNREFUSED)
-      assert_nothing_thrown do
-        send_exception(:secure => false)
-      end
-    end
-
-    should "not fail when posting any http exception occurs" do
-      http = stub_http
-      Honeybadger::Sender::HTTP_ERRORS.each do |error|
-        http.stubs(:post).raises(error)
-        assert_nothing_thrown do
-          send_exception(:secure => false)
-        end
-      end
-    end
-  end
-
-  context "SSL" do
-    should "post to the right url for non-ssl" do
-      http = stub_http
-      url = "http://api.honeybadger.io:80#{Honeybadger::Sender::NOTICES_URI}"
-      uri = URI.parse(url)
-      send_exception(:secure => false)
-      assert_received(http, :post) {|expect| expect.with(uri.path, anything, Honeybadger::HEADERS.merge({ 'X-API-Key' => 'abc123'})) }
-    end
-
-    should "post to the right path for ssl" do
-      http = stub_http
-      send_exception(:secure => true)
-      assert_received(http, :post) {|expect| expect.with(Honeybadger::Sender::NOTICES_URI, anything, Honeybadger::HEADERS.merge({ 'X-API-Key' => 'abc123'})) }
-    end
-
-    should "verify the SSL peer when the use_ssl option is set to true" do
-      url = "https://api.honeybadger.io#{Honeybadger::Sender::NOTICES_URI}"
-      uri = URI.parse(url)
-
-      real_http = Net::HTTP.new(uri.host, uri.port)
-      real_http.stubs(:post => nil)
-      proxy = stub(:new => real_http)
-      Net::HTTP.stubs(:Proxy => proxy)
-      File.stubs(:exist?).with(OpenSSL::X509::DEFAULT_CERT_FILE).returns(false)
-
-      send_exception(:secure => true)
-      assert(real_http.use_ssl?)
-      assert_equal(OpenSSL::SSL::VERIFY_PEER,        real_http.verify_mode)
-      assert_equal(Honeybadger.configuration.local_cert_path, real_http.ca_file)
-    end
-
-    should "use the default DEFAULT_CERT_FILE if asked to" do
-      File.expects(:exist?).with(OpenSSL::X509::DEFAULT_CERT_FILE).returns(true)
-
-      Honeybadger.configure do |config|
-        config.secure = true
-        config.use_system_ssl_cert_chain = true
-      end
-
-      sender = Honeybadger::Sender.new(Honeybadger.configuration)
-
-      assert(sender.use_system_ssl_cert_chain?)
-
-      http    = sender.send(:setup_http_connection)
-      assert_not_equal http.ca_file, Honeybadger.configuration.local_cert_path
-    end
-
-    should "verify the connection when the use_ssl option is set (VERIFY_PEER)" do
-      sender  = build_sender(:secure => true)
-      http    = sender.send(:setup_http_connection)
-      assert_equal(OpenSSL::SSL::VERIFY_PEER, http.verify_mode)
-    end
-
-    should "use the default cert (OpenSSL::X509::DEFAULT_CERT_FILE) only if explicitly told to" do
-      sender  = build_sender(:secure => true)
-      http    = sender.send(:setup_http_connection)
-
-      assert_equal(Honeybadger.configuration.local_cert_path, http.ca_file)
-
-      File.stubs(:exist?).with(OpenSSL::X509::DEFAULT_CERT_FILE).returns(true)
-      sender  = build_sender(:secure => true, :use_system_ssl_cert_chain => true)
-      http    = sender.send(:setup_http_connection)
-
-      assert_not_equal(Honeybadger.configuration.local_cert_path, http.ca_file)
-      assert_equal(OpenSSL::X509::DEFAULT_CERT_FILE, http.ca_file)
-    end
-
-    should "connect to the right port for ssl" do
-      stub_http
-      send_exception(:secure => true)
-      assert_received(Net::HTTP, :new) {|expect| expect.with("api.honeybadger.io", 443) }
-    end
-
-    should "connect to the right port for non-ssl" do
-      stub_http
-      send_exception(:secure => false)
-      assert_received(Net::HTTP, :new) {|expect| expect.with("api.honeybadger.io", 80) }
-    end
-
-    should "use ssl if secure" do
-      stub_http
-      send_exception(:secure => true, :host => 'example.org')
-      assert_received(Net::HTTP, :new) {|expect| expect.with('example.org', 443) }
-    end
-
-    should "not use ssl if not secure" do
-      stub_http
-      send_exception(:secure => false, :host => 'example.org')
-      assert_received(Net::HTTP, :new) {|expect| expect.with('example.org', 80) }
-    end
-  end
-
-  context "network timeouts" do
-    should "default the open timeout to 2 seconds" do
-      http = stub_http
-      send_exception
-      assert_received(http, :open_timeout=) {|expect| expect.with(2) }
-    end
-
-    should "default the read timeout to 5 seconds" do
-      http = stub_http
-      send_exception
-      assert_received(http, :read_timeout=) {|expect| expect.with(5) }
-    end
-
-    should "allow override of the open timeout" do
-      http = stub_http
-      send_exception(:http_open_timeout => 4)
-      assert_received(http, :open_timeout=) {|expect| expect.with(4) }
-    end
-
-    should "allow override of the read timeout" do
-      http = stub_http
-      send_exception(:http_read_timeout => 10)
-      assert_received(http, :read_timeout=) {|expect| expect.with(10) }
-    end
-  end
-end