honey_format 0.21.0 → 0.21.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46fdc7932e9287a30e106b06d264e1816ca0b0270c175a279b52e5173eb79780
-  data.tar.gz: 67e680e4771404bd64d8c07267982296f49fcf123d154d8739b8d3776fa05b53
+  metadata.gz: dd0d06f453986109809c196cef032b5f60233e165a8d5e029162b26b6cc801b2
+  data.tar.gz: 8f5a15f42e9f2587bc80b7e88d5c929d74a04ef69bd6be272513ba8fc544a22a
 SHA512:
-  metadata.gz: a0fec7274008e64d2848d1f7f6c4b277651993d1355948bb948b68a91034f57689e05b8443874141bc8edb1183ade8dbfe2d387ef28bd9a0e67db2172df61a3d
-  data.tar.gz: a64d69090268ae7c8d4abcef2ff3f33d1be3aba971719f63aa50183f0c1c953e798a192945af9f283669b661fe560d4cdb0fa205857b6165a1ad501b0a494402
+  metadata.gz: 563e6ba6a8ede49e13d15957c12c247b6e26c981afe25b150d6ae8c6c3dab58929c100341dcc0181790a03eabffca5ddd3ac127cf97fcdb4ac76ef04b01c9839
+  data.tar.gz: 93a08cb9b2683961e80f8f2bb79f763f05fb1401e112458a6188bf86530233e93f9d397b0ee415e4ce9c8b95ff644485e50dc6b52a2c8381aa4379b0bce0e65a

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # HEAD
 
+## v0.21.1
+
+* Closes [issue #58](https://github.com/buren/honey_format/issues/58). [PR #62](https://github.com/buren/honey_format/pull/62)
+
 ## v0.21.0
 
 * Add `Rows#[]` method

data/README.md

@@ -91,7 +91,7 @@ __Type converters__
 
 > Type converters are great if you want to convert column values, like numbers and dates.
 
-There are a few default type converters
+There are a bunch of [default type converters](https://github.com/buren/honey_format/blob/master/lib/honey_format/converters/converters.rb)
 ```ruby
 csv_string = "Id,Username\n1,buren"
 type_map = { id: :integer }
@@ -139,7 +139,7 @@ Default converter names
 HoneyFormat.config.default_converters.keys
 ```
 
-See [`Configuration#default_converters`](https://github.com/buren/honey_format/blob/master/lib/honey_format/configuration.rb#L99) for a complete list of the default ones.
+See [`Converters::DEFAULT`](https://github.com/buren/honey_format/blob/master/lib/honey_format/converters.rb) for a complete list of the default converter names.
 
 __Row builder__
 

data/honey_format.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'benchmark-ips'
   spec.add_development_dependency 'bundler', '> 1.10', '< 3'
   spec.add_development_dependency 'byebug'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '~> 12.3'
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'simplecov'
 end

data/lib/honey_format/configuration.rb

@@ -97,34 +97,7 @@ module HoneyFormat
     # Default converter registry
     # @return [Hash] hash with default converters
     def default_converters
-      @default_converters ||= {
-        # strict variants
-        decimal!: StrictConvertDecimal,
-        integer!: StrictConvertInteger,
-        date!: StrictConvertDate,
-        datetime!: StrictConvertDatetime,
-        symbol!: StrictConvertSymbol,
-        downcase!: StrictConvertDowncase,
-        upcase!: StrictConvertUpcase,
-        boolean!: StrictConvertBoolean,
-        # safe variants
-        decimal: ConvertDecimal,
-        decimal_or_zero: ConvertDecimalOrZero,
-        integer: ConvertInteger,
-        integer_or_zero: ConvertIntegerOrZero,
-        date: ConvertDate,
-        datetime: ConvertDatetime,
-        symbol: ConvertSymbol,
-        downcase: ConvertDowncase,
-        upcase: ConvertUpcase,
-        boolean: ConvertBoolean,
-        md5: ConvertMD5,
-        hex: ConvertHex,
-        nil: ConvertNil,
-        blank: ConvertBlank,
-        header_column: ConvertHeaderColumn,
-        method_name: ConvertHeaderColumn,
-      }.freeze
+      @default_converters ||= Converters::DEFAULT
     end
   end
 end

data/lib/honey_format/converters/convert_boolean.rb

@@ -4,9 +4,9 @@ require 'set'
 
 module HoneyFormat
   # String values considered truthy
-  TRUTHY = Set.new(%w[t T 1 y Y true TRUE]).freeze
+  TRUTHY = Set.new(%w[t T 1 y Y true TRUE] + [true]).freeze
   # String values considered falsy
-  FALSY = Set.new(%w[f F 0 n N false FALSE]).freeze
+  FALSY = Set.new(%w[f F 0 n N false FALSE] + [false]).freeze
 
   # Tries to convert value boolean to, returns nil if it can't convert
   ConvertBoolean = proc do |v|

data/lib/honey_format/converters/convert_date_and_time.rb

@@ -23,8 +23,8 @@ module HoneyFormat
   end
 
   # Convert to date or raise error
-  StrictConvertDate = proc { |v| Date.parse(v) }
+  StrictConvertDate = proc { |v| v.is_a?(Date) ? v : Date.parse(v) }
 
   # Convert to datetime or raise error
-  StrictConvertDatetime = proc { |v| Time.parse(v) }
+  StrictConvertDatetime = proc { |v| v.is_a?(Time) ? v : Time.parse(v) }
 end

data/lib/honey_format/converters/converters.rb

@@ -9,4 +9,35 @@ require 'honey_format/converters/convert_string'
 module HoneyFormat
   # Convert to nil
   ConvertNil = proc {}
+
+  module Converters
+    DEFAULT = {
+      # strict variants
+      decimal!: StrictConvertDecimal,
+      integer!: StrictConvertInteger,
+      date!: StrictConvertDate,
+      datetime!: StrictConvertDatetime,
+      symbol!: StrictConvertSymbol,
+      downcase!: StrictConvertDowncase,
+      upcase!: StrictConvertUpcase,
+      boolean!: StrictConvertBoolean,
+      # safe variants
+      decimal: ConvertDecimal,
+      decimal_or_zero: ConvertDecimalOrZero,
+      integer: ConvertInteger,
+      integer_or_zero: ConvertIntegerOrZero,
+      date: ConvertDate,
+      datetime: ConvertDatetime,
+      symbol: ConvertSymbol,
+      downcase: ConvertDowncase,
+      upcase: ConvertUpcase,
+      boolean: ConvertBoolean,
+      md5: ConvertMD5,
+      hex: ConvertHex,
+      nil: ConvertNil,
+      blank: ConvertBlank,
+      header_column: ConvertHeaderColumn,
+      method_name: ConvertHeaderColumn,
+    }.freeze
+  end
 end

data/lib/honey_format/version.rb

@@ -5,6 +5,6 @@ module HoneyFormat
   VERSION = [
     MAJOR_VERSION = 0,
     MINOR_VERSION = 21,
-    PATCH_VERSION = 0,
+    PATCH_VERSION = 1,
   ].join('.')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: honey_format
 version: !ruby/object:Gem::Version
-  version: 0.21.0
+  version: 0.21.1
 platform: ruby
 authors:
 - Jacob Burenstam
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-17 00:00:00.000000000 Z
+date: 2020-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -64,14 +64,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement