honey_format 0.19.0 → 0.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf04ea671d5bdbe82a40c6c755e0f975a4326e3f803cc380cbfb513bcb7587d1
-  data.tar.gz: 14893ca65e6ecb420fac9e4a4783d2ab2267d2b63b492a70c297ca51e66bf711
+  metadata.gz: 7c0136727f1cf1e473ac8a517105158a9c927c5988f525b1640ffced32c5a2fd
+  data.tar.gz: d26d86cd08edbc33f2f9b8399ef2f7c5aade4b35ca4ea7617dc6a21415b72c9a
 SHA512:
-  metadata.gz: c9a89819d1d40b99af14bbc1c0b5df765d5c91ab7c1146f39f8b6dd04796d718251280b6b31b3dc61e14ba413f46d9edb9e7e8a1aa1c308531d20cfdb0c5bb9b
-  data.tar.gz: b23f67d3df21ca3a01d03c7054502aa0a60d2819717f770db3a30edccdf597b9a9943b7107515e1e454156625c5d1aa3efcd918772b0dcbc5b9b85298ed71fe8
+  metadata.gz: 6ec8850e11d3ae4039b748738641bacd19ea3ffe9f437e2d93eb407e9d7e7cb2dcc669116f04f2a175855fbc121bad62228dc6dbd022163d033a52e89af6e8e7
+  data.tar.gz: 9ec609fe969d26348c1be54458a79ea24a199085381e82c3bc79d58b5054bb02300759946f520c7b29eb0273e56db290375c791ee4fb2c5fecf10da65954e54b

data/.travis.yml

@@ -9,11 +9,11 @@ matrix:
   include:
   - rvm: 2.3.0
     install:
-      - gem install bundler --no-ri --no-rdoc
+      - gem install bundler --no-document
       - bundle install
   - rvm: 2.5.1
     install:
-      - gem install bundler --no-ri --no-rdoc
+      - gem install bundler --no-document
       - bundle install
   - rvm: 2.6.0-preview3
     install:
@@ -21,7 +21,7 @@ matrix:
   - name: TruffleRuby
     rvm: system
     install:
-      - export TRUFFLERUBY_VERSION=1.0.0-rc3
+      - export TRUFFLERUBY_VERSION=1.0.0-rc10
       - curl -L https://github.com/oracle/truffleruby/releases/download/vm-$TRUFFLERUBY_VERSION/truffleruby-$TRUFFLERUBY_VERSION-linux-amd64.tar.gz | tar xz
       - export PATH="$PWD/truffleruby-$TRUFFLERUBY_VERSION-linux-amd64/bin:$PATH"
       - gem install bundler -v 1.16.6 --no-ri --no-rdoc

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # HEAD
 
+## v0.20.0
+
+* Support additional header variant, pass hash with `String => Symbol` and/or `String => #call` (callable object). Unmapped keys are converted using the default header converter.
+    ```ruby
+    converter = {
+      'First name' => :first_name,
+      'Last name' => -> { :surname }
+    }
+    csv = HoneyFormat::CSV.new(csv_string, header_converter: converter)
+    ```
+* Add `encoding` option to `CSV`
+
 ## v0.19.0
 
 * Add `method_name` as alias for `header_column` converter

data/README.md

@@ -27,8 +27,8 @@ Id,Username,Email
 2,jacob,jacob@example.com
 CSV
 csv = HoneyFormat::CSV.new(csv_string, type_map: { id: :integer })
-csv.columns     # => [:id, :username]
-csv.rows        # => [#<Row id=1, username="buren">]
+csv.columns     # => [:id, :username, :email]
+csv.rows        # => [#<Row id=1, username="buren", email="buren@example.com">, #<Row id=2, username="jacob", email="jacob@example.com">]
 user = csv.rows.first
 user.id         # => 1
 user.username   # => "buren"
@@ -248,21 +248,36 @@ csv.columns # => [:ID, :USERNAME]
 
 Pass your own header converter
 ```ruby
-map = { 'First^Name' => :first_name }
-converter = ->(column) { map.fetch(column, column.downcase) }
+# unmapped keys use the default header converter,
+# mix simple key => value mapping with key => proc
+converter = {
+  'First^Name' => :first_name,
+  'Username' => -> { :handle }
+}
 
-csv_string = "ID,First^Name\n1,Jacob"
+csv_string = "ID,Username,First^Name\n1,buren,Jacob"
 user = HoneyFormat::CSV.new(csv_string, header_converter: converter).rows.first
 user.first_name # => "Jacob"
+user.handle     # => "buren"
 user.id         # => "1"
+
+# you can also pass a proc or any callable object
+converter = Class.new do
+  define_singleton_method(:call) { |value, index| "#{value}#{index}" }
+end
+# or
+converter = ->(value, index) { "#{value}#{index}"  }
+user = HoneyFormat::CSV.new(csv_string, header_converter: converter)
 ```
 
-Missing header values
+Missing header values are automatically set and deduplicated
 ```ruby
-csv_string = "first,,third\nval0,val1,val2"
+csv_string = "first,,third,third\nval0,val1,val2,val3"
 csv = HoneyFormat::CSV.new(csv_string)
 user = csv.rows.first
 user.column1 # => "val1"
+user.third   # => "val2"
+user.third1  # => "val3"
 ```
 
 Duplicated header values
@@ -302,7 +317,7 @@ user['first^name'] # => "Jacob"
 
 __Errors__
 
-> When you need that some extra safety.
+> When you need to be extra safe.
 
 If you want to there are some errors you can rescue
 ```ruby

data/honey_format.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.3.0'
 
   spec.add_development_dependency 'benchmark-ips'
-  spec.add_development_dependency 'bundler', '~> 1.10'
+  spec.add_development_dependency 'bundler', '> 1.10', '< 3'
   spec.add_development_dependency 'byebug'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec'

data/lib/honey_format/csv.rb

@@ -19,6 +19,7 @@ module HoneyFormat
     # @param header_deduplicator [#call] deduplicates header columns.
     # @param row_builder [#call] will be called for each parsed row.
     # @param type_map [Hash] map of column_name => type conversion to perform.
+    # @param encoding [String] CSV encoding (for example "BOM|UTF-16LE:UTF-8").
     # @param skip_lines [Regexp, String]
     #   Regexp for determining wheter a line is a comment. See CSV skip_lines option.
     # @raise [HeaderError] super class of errors raised when there is a CSV header error.
@@ -46,6 +47,8 @@ module HoneyFormat
     # @example Skip lines all lines starting with '#'
     #   csv = HoneyFormat::CSV.new("name,id\n# some comment\njacob,1", skip_lines: '#')
     #   csv.rows.length # => 1
+    # @example CSV encoding
+    #   csv = HoneyFormat::CSV.new(csv_string, encoding: "BOM|UTF-16LE:UTF-8")
     # @see Matrix#new
     def initialize(
       csv,
@@ -56,6 +59,7 @@ module HoneyFormat
       header_converter: HoneyFormat.header_converter,
       header_deduplicator: HoneyFormat.config.header_deduplicator,
       row_builder: nil,
+      encoding: nil,
       type_map: {},
       skip_lines: HoneyFormat.config.skip_lines
     )
@@ -65,7 +69,8 @@ module HoneyFormat
         row_sep: row_delimiter,
         quote_char: quote_character,
         skip_blanks: true,
-        skip_lines: skip_lines
+        skip_lines: skip_lines,
+        encoding: encoding
       )
       super(
         csv,

data/lib/honey_format/matrix/header.rb

@@ -10,10 +10,11 @@ module HoneyFormat
     # Instantiate a Header
     # @return [Header] a new instance of Header.
     # @param [Array<String>] header array of strings.
-    # @param converter [#call, Symbol]
+    # @param converter [#call, Symbol, Hash]
     #   header converter that implements a #call method
     #   that takes one column (string) argument OR symbol for a registered
-    #   converter registry.
+    #   converter registry OR a hash mapped to a symbol or something that responds
+    #   to #call.
     # @param deduplicator [#call, Symbol]
     #   header deduplicator that implements a #call method
     #   that takes columns Array<String> argument OR symbol for a registered
@@ -93,7 +94,7 @@ module HoneyFormat
     private
 
     # Set the header converter
-    # @param [Symbol, #call] symbol to known converter or object that responds to #call
+    # @param [Hash, Symbol, #call] symbol to known converter, object that responds to #call or Hash
     # @return [nil]
     def converter=(object)
       if object.is_a?(Symbol)
@@ -101,6 +102,11 @@ module HoneyFormat
         return
       end
 
+      if object.is_a?(Hash)
+        @converter = hash_converter(object)
+        return
+      end
+
       @converter = object
     end
 
@@ -134,21 +140,17 @@ module HoneyFormat
     # @param [Integer] index the CSV header column index
     # @return [Symbol] the converted column
     def convert_column(column, index)
-      value = if converter_arity == 1
-                @converter.call(column)
-              else
-                @converter.call(column, index)
-              end
-      value.to_sym
+      call_column_builder(@converter, column, index)&.to_sym
     end
 
-    # Returns the converter#call method arity
-    # @return [Integer] the converter#call method arity
-    def converter_arity
+    # Returns the callable object method arity
+    # @param [#arity, #call] callable thing that responds to #call and maybe #arity
+    # @return [Integer] the method arity
+    def callable_arity(callable)
       # procs and lambdas respond to #arity
-      return @converter.arity if @converter.respond_to?(:arity)
+      return callable.arity if callable.respond_to?(:arity)
 
-      @converter.method(:call).arity
+      callable.method(:call).arity
     end
 
     # Raises an error if header column is missing/empty
@@ -164,5 +166,29 @@ module HoneyFormat
       ]
       raise(Errors::MissingHeaderColumnError, parts.join(' '))
     end
+
+    def hash_converter(hash)
+      lambda { |value, index|
+        # support strings and symbol keys interchangeably
+        column = hash.fetch(value) do
+          key = value.respond_to?(:to_sym) ? value.to_sym : value
+          # if column is unmapped use the default header converter
+          hash.fetch(key) { HoneyFormat.header_converter.call(value, index) }
+        end
+
+        # The hash can contain mixed values, Symbol and procs
+        if column.respond_to?(:call)
+          column = call_column_builder(column, value, index)
+        end
+
+        column&.to_sym
+      }
+    end
+
+    def call_column_builder(callable, value, index)
+      return callable.call if callable_arity(callable).zero?
+      return callable.call(value) if callable_arity(callable) == 1
+      callable.call(value, index)
+    end
   end
 end

data/lib/honey_format/matrix/row.rb

@@ -4,7 +4,7 @@ module HoneyFormat
   # Default row builder
   class Row < Struct
     # Create a row
-    # @return [Struct] returns an instantiated Struct representing a row
+    # @return [Row] returns an instantiated Row
     # @example
     #   row_klass = Row.new(:id, :username)
     #   row = row_klass.call('1', 'buren')

data/lib/honey_format/version.rb

@@ -4,7 +4,7 @@ module HoneyFormat
   # Gem version
   VERSION = [
     MAJOR_VERSION = 0,
-    MINOR_VERSION = 19,
+    MINOR_VERSION = 20,
     PATCH_VERSION = 0,
   ].join('.')
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: honey_format
 version: !ruby/object:Gem::Version
-  version: 0.19.0
+  version: 0.20.0
 platform: ruby
 authors:
 - Jacob Burenstam
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-08 00:00:00.000000000 Z
+date: 2019-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -28,16 +28,22 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '1.10'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '1.10'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -162,8 +168,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Makes working with CSVs as smooth as honey.