holidays 4.6.0 → 4.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 399d042a1ccc98734480467097210ca85c4bca9c
-  data.tar.gz: 7e7975f71f2df4d9bf5dacef3ac1e6b14b35ec39
+  metadata.gz: 871b08553ee038ed6f91d776fd6f88aca3794f2e
+  data.tar.gz: e72de1dec225bd96944fc8bf9999215de0b6a17d
 SHA512:
-  metadata.gz: c10f368bebfc2121146d2e89828ff8ee85d93a2135ec2841f4848be47f098e9c5ddc9c6ba9549b1aacc111a34f6b63b721580c7d8a7e76763488e28c1a2ed79e
-  data.tar.gz: a85d60db955877940d618b61975e6f0d53d3c0e70e01a242196e9fbdfbe743325dacf32cee5f984c0dbadb721ba185f8a518c4bf72c864d63b4c18500b7cf98a
+  metadata.gz: 87c05e189fcea4445530190bcdbd32126bbb1af3b4dc7e52de3e71c289ccb5ac014cb1dd1e8d14022634a1a02ac5ba3d32acde7a7df8f5ec700a9217d5f87b9e
+  data.tar.gz: 325bb3ec66f2b48c774564aba19bc41c9b3b46ee143cb8f0d5789b30778fa0b34dc04f6af4b97d0c87514a8e1b4ab4426250bb52897637e8f347ec3aa339b4e4

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Ruby Holidays Gem CHANGELOG
 
+## 4.7.0
+
+* Fix issue-225 (`LocalJumpError` for certain `jp` definition combinations) (https://github.com/ttwo32)
+* Add Korean Lunar holidays (https://github.com/jonathanpike)
+
 ## 4.6.0
 
 * Add holidays for 'Luxembourg' (https://github.com/dunyakirkali)

data/CONTRIBUTING.md

@@ -14,8 +14,8 @@ Here are the steps to take once you have a good idea on what you want to change:
 
 * Fork the repository
 * Edit desired definition YAML file(s) located under `definitions/`. If you are adding a new region be sure to update `definitions/index.yaml` as well
-* Run `bundle exec rake generate` to generate updated final definitions (they will be located under `lib/generated_definitions/` and `test/defs/`)
-* Run `bundle exec rake test` to ensure your changes did not introduce errors
+* Run `make generate` to generate updated final definitions (they will be located under `lib/generated_definitions/` and `test/defs/`)
+* Run `make test` to ensure your changes did not introduce errors
 * Open a PR with *all* of these changes. You *MUST* include the generated definition files and tests in your PR. There is no automatic process to generate definitions at this time
 
 Including documentation with your updates is very much appreciated. A simple Wikipedia entry or government link in the comments alongside your changes would be perfect.
@@ -36,6 +36,6 @@ Don't worry about versioning, we'll handle it on our end.
 
 We have included a few handy tasks to help you troubleshoot and test:
 
-* `rake test` - runs the entire suite
-* `rake test_region <region>` - runs the tests for just that region. Make sure to run `rake generate` after updating your YAML before running this!
-* `rake console` - launches an IRB session with the 'holidays' gem loaded for quick testing
+* `make test` - runs the entire suite
+* `REGION=<region> make test_region` - runs the tests for just that region. Make sure to run `make generate` after updating your YAML before running this!
+* `make console` - launches an IRB session with the 'holidays' gem loaded for quick testing

data/Makefile

@@ -0,0 +1,29 @@
+default: test
+
+setup:
+	bundle install
+
+test:
+	bundle exec rake test
+
+generate:
+	bundle exec rake generate
+
+console:
+	bundle exec rake console
+
+test_region:
+	bundle exec rake test_region $(REGION)
+
+build:
+	bundle exec gem build holidays.gemspec
+
+push:
+	bundle exec gem push holidays.gemspec
+
+clean:
+	rm -rf holidays-*.gem
+	rm -rf reports
+	rm -rf coverage
+
+.PHONY: setup test generate

data/README.md

@@ -107,7 +107,7 @@ Multiple files can also be passed:
 
     Holidays.load_custom('/home/user/holidays/custom_holidays1.yaml', '/home/user/holidays/custom_holidays2.yaml')
 
-### Extending Ruby's Date class
+### Extending Ruby's Date and Time classes
 
 To extend the 'Date' class:
 
@@ -136,11 +136,23 @@ Or lookup Canada Day in different regions:
     d.holiday?(:fr) # France
     => false
 
+Or return the new date based on the options:
+
+    d = Date.civil(2008,7,1)
+    d.change(:year => 2016, :month => 1, :day => 1)
+    => #<Date: 2016-01-01 ((2457389j,0s,0n),+0s,2299161j)>
+
 Or you can calculate the day of the month:
 
     Date.calculate_mday(2015, 4, :first, 2)
     => 7
 
+Or find end of month for given date (requires 'Time' extensions as well):
+
+    d = Date.civil(2016,8,1)
+    d.end_of_month
+    => #<Date: 2016-08-31 ((2457632j,0s,0n),+0s,2299161j)>
+
 ### Caching Holiday Lookups
 
 If you are checking holidays regularly you can cache your results for improved performance. Run this before looking up a holiday (eg. in an initializer):

data/Rakefile

@@ -60,8 +60,8 @@ namespace :generate do
       puts "Building #{region} definition module:"
       files = files.collect { |f| "#{DEFINITION_PATH}/#{f}" }.uniq
 
-      regions, rules_by_month, custom_methods, tests = Holidays::DefinitionFactory.file_parser.parse_definition_files(files)
-      module_src, test_src = Holidays::DefinitionFactory.source_generator.generate_definition_source(region, files, regions, rules_by_month, custom_methods, tests)
+      regions, rules_by_month, custom_methods, tests = Holidays::Factory::Definition.file_parser.parse_definition_files(files)
+      module_src, test_src = Holidays::Factory::Definition.source_generator.generate_definition_source(region, files, regions, rules_by_month, custom_methods, tests)
 
       File.open("lib/#{Holidays::DEFINITIONS_PATH}/#{region.downcase.to_s}.rb","w") do |file|
         file.puts module_src

data/definitions/au.yaml

@@ -169,8 +169,11 @@ methods:
   afl_grand_final:
     arguments: year
     source: |
-      if year == 2015
+      case year
+      when 2015
         Date.civil(2015, 10, 2)
+      when 2016
+        Date.civil(2017, 9, 30)
       end
   qld_queens_bday_october:
     # http://www.justice.qld.gov.au/fair-and-safe-work/industrial-relations/public-holidays/dates
@@ -179,7 +182,7 @@ methods:
     arguments: year
     source: |
       if year >= 2016
-        DateCalculatorFactory.day_of_month_calculator.call(year, 10, 1, 1)
+        Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 10, 1, 1)
       elsif year == 2012
         1
       else
@@ -191,7 +194,7 @@ methods:
     arguments: year
     source: |
       if year <= 2015
-        DateCalculatorFactory.day_of_month_calculator.call(year, 6, 2, 1)
+        Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 6, 2, 1)
       end
   qld_labour_day_may:
     # http://www.justice.qld.gov.au/fair-and-safe-work/industrial-relations/public-holidays/dates
@@ -199,7 +202,7 @@ methods:
     arguments: year
     source: |
       if year < 2013 || year >= 2016
-        DateCalculatorFactory.day_of_month_calculator.call(year, 5, 1, 1)
+        Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 5, 1, 1)
       end
   qld_labour_day_october:
     # http://www.justice.qld.gov.au/fair-and-safe-work/industrial-relations/public-holidays/dates
@@ -207,7 +210,7 @@ methods:
     arguments: year
     source: |
       if year >= 2013 && year < 2016
-        DateCalculatorFactory.day_of_month_calculator.call(year, 10, 1, 1)
+        Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 10, 1, 1)
       end
   g20_day_2014_only:
     # http://www.justice.qld.gov.au/fair-and-safe-work/industrial-relations/public-holidays/dates
@@ -220,7 +223,7 @@ methods:
     # The Thursday before the fourth Saturday in October.
     arguments: year
     source: |
-      fourth_sat_in_oct = Date.civil(year, 10, Holidays::DateCalculatorFactory.day_of_month_calculator.call(year, 10, 4, :saturday))
+      fourth_sat_in_oct = Date.civil(year, 10, Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 10, 4, :saturday))
       fourth_sat_in_oct - 2 # the thursday before
   march_pub_hol_sa:
     # http://www.safework.sa.gov.au/show_page.jsp?id=2483#.VQ9Mfmb8-8E
@@ -230,7 +233,7 @@ methods:
       if year < 2006
         nil
       else
-        Date.civil(year, 3, Holidays::DateCalculatorFactory.day_of_month_calculator.call(year, 3, :second, :monday))
+        Date.civil(year, 3, Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 3, :second, :monday))
       end
   may_pub_hol_sa:
     # http://www.safework.sa.gov.au/show_page.jsp?id=2483#.VQ9Mfmb8-8E
@@ -240,7 +243,7 @@ methods:
       if year >= 2006
         nil
       else
-        Date.civil(year, 5, Holidays::DateCalculatorFactory.day_of_month_calculator.call(year, 5, :third, :monday))
+        Date.civil(year, 5, Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 5, :third, :monday))
       end
 
 tests: |
@@ -312,7 +315,7 @@ tests: |
     assert_equal 'Melbourne Cup Day', Holidays.on(Date.civil(2015,11,3), :au_vic_melbourne)[0][:name]
 
     assert_equal 'Friday before the AFL Grand Final', Date.civil(2015,10,2).holidays(:au_vic)[0][:name]
-    assert_nil Date.civil(2016,10,2).holidays(:au_vic)[0]
+    assert_equal 'Friday before the AFL Grand Final', Date.civil(2016,9, 30).holidays(:au_vic)[0][:name]
 
     assert_equal "May Public Holiday", Date.civil(2005, 5, 16).holidays(:au_sa)[0][:name]
     assert_equal [], Date.civil(2014, 5, 19).holidays(:au_sa)

data/definitions/ca.yaml

@@ -141,7 +141,7 @@ months:
     wday: 1
   11:
   - name: Remembrance Day
-    regions: [ca]
+    regions: [ ca_ab, ca_sk, ca_bc, ca_pe, ca_nf, ca_nt, ca_nu, ca_nb, ca_yk]
     mday: 11
   12:
   - name: Christmas Day
@@ -171,7 +171,6 @@ tests: |
      Date.civil(2008,7,1) => 'Canada Day',
      Date.civil(2008,9,1) => 'Labour Day',
      Date.civil(2008,10,13) => 'Thanksgiving',
-     Date.civil(2008,11,11) => 'Remembrance Day',
      Date.civil(2008,12,25) => 'Christmas Day',
      Date.civil(2008,12,26) => 'Boxing Day'}.each do |date, name|
       assert_equal name, (Holidays.on(date, :ca, :informal)[0] || {})[:name]
@@ -300,3 +299,19 @@ tests: |
         assert_equal name, Holidays.on(date, region)[0][:name]
       end
     end
+
+    # Remembrance Day in all Canadian provinces
+    # except (Nova Scotia, Manitoba, Ontario, and Quebec)
+    [
+      :ca_ab,
+      :ca_sk,
+      :ca_bc,
+      :ca_pe,
+      :ca_nf,
+      :ca_nt,
+      :ca_nu,
+      :ca_nb,
+      :ca_yk
+    ].each do |province|
+      assert_equal "Remembrance Day", Holidays.on(Date.civil(2016,11,11), province)[0][:name]
+    end

data/definitions/ch.yaml

@@ -159,7 +159,7 @@ methods:
         date += 1
       end
 
-      if date.eql?(Holidays::DateCalculatorFactory::Easter::Gregorian.easter_calculator.calculate_easter_for(year)-3)
+      if date.eql?(Holidays::Factory::DateCalculator::Easter::Gregorian.easter_calculator.calculate_easter_for(year)-3)
         date += 7
       end
       date

data/definitions/index.yaml

@@ -28,12 +28,14 @@ defs:
   IE: ['ie.yaml']
   IS: ['is.yaml']
   IT: ['it.yaml']
+  KR: ['kr.yaml']
   LI: ['li.yaml']
   LT: ['lt.yaml']
   MA: ['ma.yaml']
   MX: ['mx.yaml', 'north_america_informal.yaml']
   NERC: ['nerc.yaml']
   NL: ['nl.yaml']
+  LU: ['lu.yaml']
   "NO": ['no.yaml']
   NYSE: ['nyse.yaml']
   NZ: ['nz.yaml']
@@ -56,3 +58,4 @@ defs:
   SK: ['sk.yaml']
   SI: ['si.yaml']
   SG: ['sg.yaml']
+  MY: ['my.yaml']

data/definitions/is.yaml

@@ -117,7 +117,7 @@ methods:
       date = Date.civil(year,4,18)
       if date.wday < 4
         date += (4 - date.wday)
-      else date
+      else
         date += (11 - date.wday)
       end
       date

data/definitions/jp.yaml

@@ -119,6 +119,8 @@ months:
     function: jp_respect_for_aged_holiday_substitute(year)
   - name: 国民の休日
     regions: [jp]
+    year_ranges:
+      - after: 2003
     function: jp_citizens_holiday(year)
   - name: 秋分の日
     regions: [jp]
@@ -162,7 +164,7 @@ methods:
   jp_health_sports_day_substitute:
     arguments: year
     source: |
-      Holidays::DefinitionFactory.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, 10, Holidays::DateCalculatorFactory.day_of_month_calculator.call(year, 10, 2, 1))
+      Holidays::Factory::Definition.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, 10, Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 10, 2, 1))
   jp_vernal_equinox_day:
     arguments: year
     source: |
@@ -185,12 +187,12 @@ methods:
   jp_vernal_equinox_day_substitute:
     arguments: year
     source: |
-      date = Holidays::DefinitionFactory.custom_methods_repository.find("jp_vernal_equinox_day(year)").call(year)
-      Holidays::DefinitionFactory.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, date.month, date.mday)
+      date = Holidays::Factory::Definition.custom_methods_repository.find("jp_vernal_equinox_day(year)").call(year)
+      Holidays::Factory::Definition.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, date.month, date.mday)
   jp_marine_day_substitute:
     arguments: year
     source: |
-      Holidays::DefinitionFactory.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, 7, Holidays::DateCalculatorFactory.day_of_month_calculator.call(year, 7, 3, 1))
+      Holidays::Factory::Definition.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, 7, Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 7, 3, 1))
   jp_national_culture_day:
     arguments: year
     source: |
@@ -213,13 +215,12 @@ methods:
   jp_national_culture_day_substitute:
     arguments: year
     source: |
-      date = Holidays::DefinitionFactory.custom_methods_repository.find("jp_national_culture_day(year)").call(year)
-      Holidays::DefinitionFactory.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, date.month, date.mday)
+      date = Holidays::Factory::Definition.custom_methods_repository.find("jp_national_culture_day(year)").call(year)
+      Holidays::Factory::Definition.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, date.month, date.mday)
   jp_citizens_holiday:
     arguments: year
     source: |
-      year < 2003 and return nil
-      ncd = Holidays::DefinitionFactory.custom_methods_repository.find("jp_national_culture_day(year)").call(year)
+      ncd = Holidays::Factory::Definition.custom_methods_repository.find("jp_national_culture_day(year)").call(year)
       if ncd.wday == 3
         ncd - 1
       else
@@ -228,29 +229,28 @@ methods:
   jp_mountain_holiday:
     arguments: year
     source: |
-      return nil if year < 2016
       Date.civil(year, 8, 11)
   jp_mountain_holiday_substitute:
     arguments: year
     source: |
-      date = Holidays::DefinitionFactory.custom_methods_repository.find("jp_mountain_holiday(year)").call(year)
-      Holidays::DefinitionFactory.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, date.month, date.mday)
+      date = Holidays::Factory::Definition.custom_methods_repository.find("jp_mountain_holiday(year)").call(year)
+      Holidays::Factory::Definition.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, date.month, date.mday)
   jp_respect_for_aged_holiday_substitute:
     arguments: year
     source: |
-      Holidays::DefinitionFactory.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, 9, Holidays::DateCalculatorFactory.day_of_month_calculator.call(year, 9, 3, 1))
+      Holidays::Factory::Definition.custom_methods_repository.find("jp_substitute_holiday(year, month, day)").call(year, 9, Holidays::Factory::DateCalculator.day_of_month_calculator.call(year, 9, 3, 1))
   jp_substitute_holiday:
     arguments: year, month, day
     source: |
       date = Date.civil(year, month, day)
-      date.wday == 0 ? (Holidays::DefinitionFactory.custom_methods_repository.find("jp_next_weekday(date)").call(date+1)) : nil
+      date.wday == 0 ? (Holidays::Factory::Definition.custom_methods_repository.find("jp_next_weekday(date)").call(date+1)) : nil
   jp_next_weekday:
     arguments: date
     source: |
       is_holiday = Holidays::JP.holidays_by_month[date.month].any? do |holiday|
         holiday[:mday] == date.day
       end
-      date.wday == 0 || is_holiday ? (Holidays::DefinitionFactory.custom_methods_repository.find("jp_next_weekday(date)").call(date+1)) : date
+      date.wday == 0 || is_holiday ? (Holidays::Factory::Definition.custom_methods_repository.find("jp_next_weekday(date)").call(date+1)) : date
 
 tests: |
   {Date.civil(2008,1,1) => '元日',
@@ -314,3 +314,8 @@ tests: |
 
   # before 2016, there is no mountain holiday.
   assert_nil Holidays.on(Date.civil(2015,8,11), :jp)[0]
+
+  # before 2003, there is no citizens holiday.
+  # [note] citizens holiday requires that jp_national_culture_day is wednesday.
+  #        Before 2003, the closest past year that mathches above condition is 1998.
+  assert_nil Holidays.on(Date.civil(1998,9,22), :jp)[0]

data/definitions/kr.yaml

@@ -0,0 +1,282 @@
+# Republic of Korea holiday definitions for the Ruby Holiday gem.
+# Provided by Jonathan Pike
+#
+# Updated: 2016-09-23.
+# Sources:
+# - https://en.wikipedia.org/wiki/List_of_public_holidays_in_South_Korea
+# - http://www.hko.gov.hk/gts/time/conversion.htm (for Lunar Calendar Conversions)
+
+---
+months:
+  0: 
+  - name: Korean New Year
+    regions: [kr]
+    function: kr_new_years(year)
+  - name: Buddah's Birthday
+    regions: [kr]
+    function: kr_buddahs_birthday(year)
+  - name: Korean Thanksgiving 
+    regions: [kr]
+    function: kr_thanksgiving(year)
+  1: 
+  - name: New Year's Day
+    regions: [kr]
+    mday: 1
+  3:
+  - name: Independence Movement Day
+    regions: [kr]
+    mday: 1
+  5:
+  - name: Children's Day
+    regions: [kr]
+    mday: 5
+  6:
+  - name: Memorial Day 
+    regions: [kr]
+    mday: 6
+  7:
+  - name: Constitution Day 
+    regions: [kr]
+    mday: 17
+    type: informal
+  8: 
+  - name: Liberation Day
+    regions: [kr]
+    mday: 15
+  10:
+  - name: National Foundation Day 
+    regions: [kr]
+    mday: 3
+  - name: Hangul Day 
+    regions: [kr]
+    mday: 9
+  12:
+  - name: Christmas Day
+    regions: [kr]
+    mday: 25
+
+methods: 
+  kr_new_years: 
+    arguments: year
+    source: |
+      month_day = case year
+        when 1941
+          [1, 17]
+        when 1966
+          [1, 21]
+        when 1909, 1947, 2004, 2023, 2042
+          [1, 22]
+        when 1917, 1928, 1974, 1993, 2012, 2031, 2015
+          [1, 23]
+        when 1925, 1936, 1955, 2001, 2039
+          [1, 24]
+        when 1906, 1944, 1963, 1982, 2020
+          [1, 25]
+        when 1914, 1933, 2009, 2028, 2047
+          [1, 26]
+        when 1952, 1971, 1990
+          [1, 27]
+        when 1922, 1960, 1979, 1998, 2017, 2036
+          [1, 28]
+        when 1903, 1949, 1987, 2006, 2025
+          [1, 29]
+        when 1911, 1930, 1968, 2044
+          [1, 30]
+        when 1938, 1957, 1976, 1995, 2014, 2033
+          [1, 31]
+        when 1919, 1948, 2003, 2022, 2041
+          [2, 1]
+        when 1908, 1927, 1946, 1965, 1984, 2049
+          [2, 2]
+        when 1916, 1954, 1973, 2011, 2030
+          [2, 3]
+        when 1905, 1935, 1992, 2038
+          [2, 4]
+        when 1924, 1943, 1962, 1981, 1989, 2000, 2019
+          [2, 5]
+        when 1913, 1932, 1951, 1970, 2027, 2046
+          [2, 6]
+        when 1978, 1997, 2008
+          [2, 7]
+        when 1902, 1921, 1940, 1959, 2016, 2035
+          [2, 8]
+        when 1967, 1986, 2005
+          [2, 9]
+        when 1910, 1929, 1994, 2013, 2024, 2043
+          [2, 10]
+        when 1918, 1937, 1975, 2032
+          [2, 11]
+        when 1956, 2002, 2021, 2040
+          [2, 12]
+        when 1907, 1926, 1945, 1964, 1983, 2029
+          [2, 13]
+        when 1915, 1934, 1953, 2010, 2048
+          [2, 14]
+        when 1942, 1961, 1972, 1991, 2037
+          [2, 15]
+        when 1904, 1923, 1980, 1999, 2018
+          [2, 16]
+        when 1931, 1950, 1969, 1988, 2026, 2045
+          [2, 17]
+        when 1912, 1958, 1977, 2007
+          [2, 18]
+        when 1901, 1939, 1996, 2015, 2034
+          [2, 19]
+        when 1920, 1985
+          [2, 20]
+      end 
+      Date.civil(year, month_day[0], month_day[1])
+  
+  kr_buddahs_birthday:
+    arguments: year
+    source: | 
+      month_day = case year
+        when 2039
+          [4, 30]
+        when 1952, 1963, 1982
+          [5, 1]
+        when 1914, 1933, 1971, 1990, 2009, 2028, 2047
+          [5, 2]
+        when 1941, 1960, 1979, 1998, 2017, 2036
+          [5, 3]
+        when 1901, 1903, 1922, 1968
+          [5, 4]
+        when 1949, 1987, 2006, 2012, 2025, 2044
+          [5, 5]
+        when 1911, 1930, 1976, 2014, 2033
+          [5, 6]
+        when 1908, 1919, 1957, 1995, 2041
+          [5, 7]
+        when 1927, 1946, 1965, 1984, 2003, 2022
+          [5, 8]
+        when 1916, 2030, 2049
+          [5, 9]
+        when 1935, 1954, 1973, 1992, 2011
+          [5, 10]
+        when 1905, 1924, 1943, 1962, 1981, 2000, 2038
+          [5, 11]
+        when 1970, 1989, 2008, 2019
+          [5, 12]
+        when 1913, 1932, 1951, 2027
+          [5, 13]
+        when 1938, 1940, 1978, 1997, 2016
+          [5, 14]
+        when 1902, 1921, 1959, 2005, 2024, 2035
+          [5, 15]
+        when 1910, 1929, 1948, 1967, 1986, 2032, 2043
+          [5, 16]
+        when 1918, 1937, 1956, 2013
+          [5, 17]
+        when 1975, 1994, 2040
+          [5, 18]
+        when 1907, 1926, 1945, 1964, 2002, 2021
+          [5, 19]
+        when 1934, 1953, 1972, 1983, 2029, 2046, 2048
+          [5, 20]
+        when 1915, 1980, 1991, 2010 
+          [5, 21]
+        when 1904, 1942, 1961, 1999, 2018, 2037
+          [5, 22]
+        when 1923, 1969, 1988
+          [5, 23]
+        when 1912, 1931, 1950, 1996, 2007, 2026, 2045
+          [5, 24]
+        when 1920, 1977, 2015, 2034
+          [5, 25]
+        when 1909, 1928, 1939, 1947, 1958, 2004, 2023, 2042
+          [5, 26]
+        when 1966, 1985
+          [5, 27]
+        when 1917, 1936, 1993, 2031, 2050
+          [5, 28]
+        when 1925, 1944, 1955, 1974
+          [5, 29]
+        when 1906, 2001, 2020
+          [5, 30]
+      end 
+      Date.civil(year, month_day[0], month_day[1])
+
+  kr_thanksgiving:
+    arguments: year
+    source: | 
+      month_day = case year
+        when 1905, 1924, 1973
+          [9, 8]
+        when 1913, 1970, 1989, 2000, 2008, 2019, 2038
+          [9, 10]
+        when 1902, 1932, 1938, 1981, 2027
+          [9, 11]
+        when 1929, 1940, 1951, 1978, 2016, 2035
+          [9, 12]
+        when 1921, 1948, 1959, 1997, 2024
+          [9, 13]
+        when 1910, 1975, 2005
+          [9, 14]
+        when 1918, 1937, 1945, 1967, 1986, 2032, 2043
+          [9, 15]
+        when 1907, 1964, 1994, 2013, 2040
+          [9, 16]
+        when 1926, 1956, 1962, 1972, 2046, 2048
+          [9, 17]
+        when 1934, 1953, 2002, 2021
+          [9, 18]
+        when 1904, 1915, 1980, 2010, 2029
+          [9, 19]
+        when 1923, 1969, 1983, 1991, 1999
+          [9, 20]
+        when 1942, 1961, 1988, 2037
+          [9, 21]
+        when 1912, 1977 ,1996, 2007, 2015, 2018, 2026
+          [9, 22]
+        when 1931, 1939, 1950
+          [9, 23]
+        when 1909, 1920, 1947, 1958, 2034, 2045
+          [9, 24]
+        when 1917, 1928, 1936, 1966, 1985, 2050
+          [9, 25]
+        when 2001, 2004, 2023, 2042
+          [9, 26]
+        when 1906, 1925, 1944, 1955, 1974, 1993, 2031 
+          [9, 27]
+        when 1914, 1963, 1971, 2009
+          [9, 28]
+        when 1933, 1952, 1982, 2020
+          [9, 29]
+        when 1941, 1979, 1990, 2017, 2028, 2036, 2047
+          [9, 30]
+        when 1901, 1960, 1968, 1987, 2006
+          [10, 1]
+        when 1903, 1922, 1949, 1998
+          [10, 2]
+        when 1911, 1976, 2014, 2033, 2044
+          [10, 3]
+        when 1927, 1930, 2012, 2025, 2041
+          [10, 4]
+        when 1908, 1919, 1935, 1946, 1957, 1995, 2039
+          [10, 5]
+        when 1916, 1965, 2003, 2022, 2030, 2049
+          [10, 6]
+        when 1984
+          [10, 7]
+        when 1943, 1954, 1992
+          [10, 8]
+        when 2011
+          [10, 9]
+      end 
+      Date.civil(year, month_day[0], month_day[1])
+
+tests: | 
+  {Date.civil(2016,2,8) => "Korean New Year",
+   Date.civil(2016,5,14) => "Buddah\'s Birthday",
+   Date.civil(2016,9,12) => "Korean Thanksgiving",
+   Date.civil(2016,1,1) => "New Year\'s Day", 
+   Date.civil(2016,3,1) => "Independence Movement Day",
+   Date.civil(2016,5,5) => "Children\'s Day",
+   Date.civil(2016,6,6) => "Memorial Day",
+   Date.civil(2016,7,17) => "Constitution Day",
+   Date.civil(2016,8,15) => "Liberation Day",
+   Date.civil(2016,10,3) => "National Foundation Day",
+   Date.civil(2016,10,9) => "Hangul Day",
+   Date.civil(2016,12,25) => "Christmas Day"}.each do |date, name|
+    assert_equal name, (Holidays.on(date, :kr, :informal)[0] || {})[:name]
+  end