holidays 4.6.0 → 4.7.0

data/test/holidays/{option → finder}/context/test_parse_options.rb

@@ -1,6 +1,6 @@
 require File.expand_path(File.dirname(__FILE__)) + '/../../../test_helper'
 
-require 'holidays/option/context/parse_options'
+require 'holidays/finder/context/parse_options'
 
 #TODO This set of tests need love. Since the class itself requires actual
 #     definition files we have real defs in here, meaning that these tests
@@ -17,9 +17,9 @@ class ParseOptionsTests < Test::Unit::TestCase
 
     # As mentioned above, this set of tests is NOT isolated. We need
     # the real merger code here.
-    @definition_merger = Holidays::DefinitionFactory.merger
+    @definition_merger = Holidays::Factory::Definition.merger
 
-    @subject = Holidays::Option::Context::ParseOptions.new(
+    @subject = Holidays::Finder::Context::ParseOptions.new(
       @regions_repo,
       @region_validator,
       @definition_merger,
@@ -28,30 +28,30 @@ class ParseOptionsTests < Test::Unit::TestCase
 
   def test_returns_observed_true_if_options_contains_observed_flag
     @regions_repo.expects(:exists?).returns(false)
-    regions, observed, informal = @subject.call([:ca, :observed])
+    observed = @subject.call([:ca, :observed])[1]
     assert_equal(true, observed)
   end
 
   def test_returns_observed_false_if_options_contains_observed_flag
     @regions_repo.expects(:exists?).returns(false)
-    regions, observed, informal = @subject.call([:ca])
+    observed = @subject.call([:ca])[1]
     assert_equal(false, observed)
   end
 
   def test_returns_informal_true_if_options_contains_informal_flag
     @regions_repo.expects(:exists?).returns(false)
-    regions, observed, informal = @subject.call([:ca, :informal])
+    informal = @subject.call([:ca, :informal])[2]
     assert_equal(true, informal)
   end
 
   def test_returns_informal_false_if_options_contains_informal_flag
     @regions_repo.expects(:exists?).returns(false)
-    regions, observed, informal = @subject.call([:ca])
+    informal = @subject.call([:ca])[2]
     assert_equal(false, informal)
   end
 
   def test_returns_any_if_no_regions_are_provided
-    regions, observed, informal = @subject.call(:informal)
+    regions = @subject.call(:informal)[0]
     assert_equal([:any], regions)
   end
 
@@ -60,7 +60,7 @@ class ParseOptionsTests < Test::Unit::TestCase
     @regions_repo.expects(:exists?).with(:ch_zh).returns(true)
     @regions_repo.expects(:search).with('ch_').returns([:ch_zh])
 
-    regions, observed, informal = @subject.call([:ch_])
+    regions = @subject.call([:ch_])[0]
     assert_equal(false, regions.include?(:ch_))
   end
 

data/test/holidays/finder/context/test_search.rb

@@ -0,0 +1,203 @@
+require File.expand_path(File.dirname(__FILE__)) + '/../../../test_helper'
+
+require 'holidays/finder/context/search'
+
+class FinderSearchTests < Test::Unit::TestCase
+  def setup
+    @holidays_by_month_repo = mock()
+    @custom_method_processor = mock()
+    @day_of_month_calculator = mock()
+
+    @in_region_rule = mock()
+    @year_range_rule = mock()
+    @rules = {:in_region => @in_region_rule, :year_range => @year_range_rule}
+
+    @custom_method_repo = mock()
+    @proc_cache_repo = mock()
+
+    @subject = Holidays::Finder::Context::Search.new(
+      @holidays_by_month_repo,
+      @custom_method_processor,
+      @day_of_month_calculator,
+      @rules,
+    )
+
+    @start_date = Date.civil(2015, 1, 1)
+    @end_date = Date.civil(2015, 1, 1)
+    @dates_driver = {2015 => [1]}
+    @regions = [:us]
+    @options = []
+
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:mday => 1, :name => "Test", :regions=>@regions])
+    @in_region_rule.expects(:call).at_most_once.returns(true)
+    @year_range_rule.expects(:call).at_most_once.returns(false)
+  end
+
+  def test_raises_error_if_dates_driver_is_empty
+    @dates_driver = {}
+    assert_raises ArgumentError do
+      @subject.call(@dates_driver, @regions, @options)
+    end
+  end
+
+  def test_raises_error_if_dates_driver_contains_bad_month
+    @dates_driver = {2015 => [100]}
+    assert_raises ArgumentError do
+      @subject.call(@dates_driver, @regions, @options)
+    end
+  end
+
+  def test_raises_error_if_dates_driver_contains_bad_month_mixed_with_valid_months
+    @dates_driver = {2015 => [1, 12], 2020 => [1, 200]}
+    assert_raises ArgumentError do
+      @subject.call(@dates_driver, @regions, @options)
+    end
+  end
+
+  def test_returns_nothing_if_holidays_repo_returns_nil
+    @holidays_by_month_repo.expects(:find_by_month).with(1).returns(nil)
+    assert_equal([], @subject.call(@dates_driver, @regions, @options))
+  end
+
+  def test_returns_nothing_if_holidays_repo_returns_empty_array
+    @holidays_by_month_repo.expects(:find_by_month).with(1).returns([])
+    assert_equal([], @subject.call(@dates_driver, @regions, @options))
+  end
+
+  def test_returns_nothing_if_holidays_not_in_region
+    @holidays_by_month_repo.expects(:find_by_month).returns([:regions=>[:other_region]])
+    @in_region_rule.expects(:call).with(@regions, [:other_region]).returns(false)
+    assert_equal([], @subject.call(@dates_driver, @regions, @options))
+  end
+
+  def test_returns_nothing_if_only_informal_holidays_are_returned_and_no_informal_flag_set
+    @holidays_by_month_repo.expects(:find_by_month).returns([:type => :informal, :regions=>@regions])
+    assert_equal([], @subject.call(@dates_driver, @regions, @options))
+  end
+
+  def test_year_rule_set_but_not_in_required_years_returns_nothing
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:mday => 1, :name => "Test", :regions=>@regions, :year_ranges => [:after => 2000]])
+    assert_equal([], @subject.call(@dates_driver, @regions, @options))
+  end
+
+  def test_function_present_returns_date
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:mday => 1, :name => "Test", :regions=> @regions, :function => "func-id", :function_arguments => [:year], :function_modifier => 1])
+
+    returned_date = Date.civil(2015, 3, 10)
+    @custom_method_processor.expects(:call).with(
+      2015,
+      1,
+      1,
+      "func-id",
+      [:year],
+      1,
+    ).returns(returned_date)
+
+    assert_equal(
+      [{
+        :date => Date.civil(2015, 3, 10),
+        :name => "Test",
+        :regions => [:us],
+      }],
+       @subject.call(@dates_driver, @regions, @options)
+    )
+  end
+
+  #FIXME This is a test that reflects how the current system works
+  #      but this is NOT valid. See https://github.com/holidays/holidays/issues/204
+  def test_function_returns_nil_date_should_not_be_returned
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:mday => 1, :name => "Test", :regions=> @regions, :function => "func-id", :function_arguments => [:year], :function_modifier => 1])
+
+    @custom_method_processor.expects(:call).with(
+      2015,
+      1,
+      1,
+      "func-id",
+      [:year],
+      1,
+    ).returns(nil)
+
+    assert_equal([], @subject.call(@dates_driver, @regions, @options))
+  end
+
+  def test_function_not_present_mday_set
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:mday => 15, :name => "Test", :regions=> @regions])
+
+    assert_equal(
+      [{
+        :date => Date.civil(2015, 1, 15),
+        :name => "Test",
+        :regions => [:us],
+      }],
+       @subject.call(@dates_driver, @regions, @options)
+    )
+  end
+
+  def test_function_not_present_mday_not_set
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:name => "Test", :week => 1, :wday => 1, :regions=> @regions])
+
+    @day_of_month_calculator.expects(:call).with(2015, 1, 1, 1).returns(20)
+
+    assert_equal(
+      [{
+        :date => Date.civil(2015, 1, 20),
+        :name => "Test",
+        :regions => [:us],
+      }],
+      @subject.call(@dates_driver, @regions, @options)
+    )
+  end
+
+  def test_returns_holiday_if_informal_and_informal_flag_set
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:mday => 13, :name => "Test", :type => :informal, :regions=>@regions])
+
+    assert_equal(
+      [{
+        :date => Date.civil(2015, 1, 13),
+        :name => "Test",
+        :regions => [:us],
+      }],
+      @subject.call(@dates_driver, @regions, [:informal])
+    )
+  end
+
+  def test_does_not_return_holiday_if_informal_and_informal_flag_not_set
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:mday => 13, :name => "Test", :type => :informal, :regions=>@regions])
+
+    assert_equal([], @subject.call(@dates_driver, @regions, @options))
+  end
+
+  def test_returns_observed_result_if_observed_set_and_observed_function_present
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:mday => 8, :name => "Test", :type => :observed, :observed => "SOME_OBSERVED_FUNC_ID", :regions=>@regions])
+
+    @custom_method_processor.expects(:call).with(
+      2015,
+      1,
+      8,
+      "SOME_OBSERVED_FUNC_ID",
+      [:date],
+    ).returns(Date.civil(2015, 10, 1))
+
+    assert_equal(
+      [{
+        :date => Date.civil(2015, 10, 1),
+        :name => "Test",
+        :regions => [:us],
+      }],
+      @subject.call(@dates_driver, @regions, [:observed])
+    )
+  end
+
+  def test_returns_unobserved_date_if_observed_method_not_set_but_flag_is_present
+    @holidays_by_month_repo.expects(:find_by_month).at_most_once.returns([:mday => 14, :name => "Test", :type => :observed, :observed => "SOME_OBSERVED_FUNC_ID", :regions=>@regions])
+
+    assert_equal(
+      [{
+        :date => Date.civil(2015, 1, 14),
+        :name => "Test",
+        :regions => [:us],
+      }],
+      @subject.call(@dates_driver, @regions, @options)
+    )
+  end
+end

data/test/holidays/finder/context/test_year_holiday.rb

@@ -0,0 +1,202 @@
+require File.expand_path(File.dirname(__FILE__)) + '/../../../test_helper'
+
+require 'holidays/finder/context/year_holiday'
+
+class YearHolidayTests < Test::Unit::TestCase
+  def setup
+    @regions = [:us]
+    @observed = false
+    @informal = false
+
+    @definition_search = mock()
+    @dates_driver_builder = mock()
+    @options_parser = mock()
+
+    @subject = Holidays::Finder::Context::YearHoliday.new(
+      @definition_search,
+      @dates_driver_builder,
+      @options_parser,
+    )
+
+    @from_date= Date.civil(2015, 1, 1)
+    @dates_driver = {2015 => [0, 1, 2], 2014 => [0, 12]}
+    @options = [@regions, @observed, @informal]
+
+    @definition_search.expects(:call).at_most_once.with(
+      @dates_driver,
+      @regions,
+      [],
+    ).returns([{
+      :date => Date.civil(2015, 1, 1),
+      :name => "Test",
+      :regions => [:us],
+    }])
+
+    @dates_driver_builder.expects(:call).at_most_once.with(
+      @from_date, @from_date >> 12,
+    ).returns(
+      @dates_driver,
+    )
+
+    @options_parser.expects(:call).at_most_once.with(@options).returns(@options)
+  end
+
+  def test_returns_error_if_from_date_is_missing
+    assert_raise ArgumentError do
+      @subject.call(nil, @options)
+    end
+  end
+
+  def test_returns_error_if_from_date_is_not_a_date
+    assert_raise ArgumentError do
+      @subject.call("2015-1-1", @options)
+    end
+  end
+
+  def test_returns_single_holiday
+    assert_equal(
+      [
+        {
+          :date => Date.civil(2015, 1, 1),
+          :name => "Test",
+          :regions => [:us],
+        }
+      ],
+      @subject.call(@from_date, @options)
+    )
+  end
+
+  def test_returns_multiple_holidays_in_a_year
+    @definition_search.expects(:call).at_most_once.with(
+      @dates_driver,
+      @regions,
+      [],
+    ).returns([
+      {
+        :date => Date.civil(2015, 1, 1),
+        :name => "Test",
+        :regions => [:us],
+      },
+      {
+        :date => Date.civil(2015, 2, 1),
+        :name => "Test",
+        :regions => [:us],
+      },
+      {
+        :date => Date.civil(2015, 12, 1),
+        :name => "Test",
+        :regions => [:us],
+      },
+      ]
+    )
+
+    assert_equal(
+      [
+        {
+          :date => Date.civil(2015, 1, 1),
+          :name => "Test",
+          :regions => [:us],
+        },
+        {
+          :date => Date.civil(2015, 2, 1),
+          :name => "Test",
+          :regions => [:us],
+        },
+        {
+          :date => Date.civil(2015, 12, 1),
+          :name => "Test",
+          :regions => [:us],
+        }
+      ],
+      @subject.call(@from_date, @options)
+    )
+  end
+
+  def test_returns_multiple_holidays_filters_dates_outside_of_year
+    @definition_search.expects(:call).at_most_once.with(
+      @dates_driver,
+      @regions,
+      [],
+    ).returns([
+      {
+        :date => Date.civil(2015, 1, 1),
+        :name => "Test",
+        :regions => [:us],
+      },
+      {
+        :date => Date.civil(2015, 2, 1),
+        :name => "Test",
+        :regions => [:us],
+      },
+      {
+        :date => Date.civil(2016, 12, 1),
+        :name => "Test",
+        :regions => [:us],
+      },
+      ]
+    )
+
+    assert_equal(
+      [
+        {
+          :date => Date.civil(2015, 1, 1),
+          :name => "Test",
+          :regions => [:us],
+        },
+        {
+          :date => Date.civil(2015, 2, 1),
+          :name => "Test",
+          :regions => [:us],
+        },
+      ],
+      @subject.call(@from_date, @options)
+    )
+  end
+
+  def test_returns_sorted_multiple_holidays
+    @definition_search.expects(:call).at_most_once.with(
+      @dates_driver,
+      @regions,
+      [],
+    ).returns(
+      [
+        {
+          :date => Date.civil(2015, 1, 1),
+          :name => "Test",
+          :regions => [:us],
+        },
+        {
+          :date => Date.civil(2015, 12, 1),
+          :name => "Test",
+          :regions => [:us],
+        },
+        {
+          :date => Date.civil(2015, 2, 1),
+          :name => "Test",
+          :regions => [:us],
+        },
+      ]
+    )
+
+    assert_equal(
+      [
+        {
+          :date => Date.civil(2015, 1, 1),
+          :name => "Test",
+          :regions => [:us],
+        },
+        {
+          :date => Date.civil(2015, 2, 1),
+          :name => "Test",
+          :regions => [:us],
+        },
+        {
+          :date => Date.civil(2015, 12, 1),
+          :name => "Test",
+          :regions => [:us],
+        }
+      ],
+      @subject.call(@from_date, @options)
+    )
+  end
+end