hoe 3.13.0 → 3.13.1

data/lib/hoe/racc.rb

@@ -42,7 +42,7 @@ module Hoe::Racc
     # -l = no-line-convert (they don't ever line up anyhow)
     self.racc_flags ||= "-v -l"
     self.oedipus_options ||= {
-                              :do_parse => false
+                              :do_parse => false,
                              }
   end
 
@@ -50,7 +50,7 @@ module Hoe::Racc
   # Activate the racc dependencies
 
   def activate_racc_deps
-    dependency 'racc', '~> 1.4.6', :development
+    dependency "racc", "~> 1.4.6", :development
   end
 
   ##
@@ -75,7 +75,7 @@ module Hoe::Racc
     end
 
     # HACK: taken from oedipus_lex's .rake file to bypass isolate bootstrap
-    rule ".rex.rb" => proc {|path| path.sub(/\.rb$/, "") } do |t|
+    rule ".rex.rb" => proc { |path| path.sub(/\.rb$/, "") } do |t|
       require "oedipus_lex"
       warn "Generating #{t.name} from #{t.source} from #{OedipusLex::VERSION}"
       oedipus = OedipusLex.new oedipus_options

data/lib/hoe/rake.rb

@@ -51,7 +51,7 @@ module Rake
     tasks.flatten.each do |name|
       case name
       when Regexp then
-        all_tasks.delete_if { |k,_| k =~ name }
+        all_tasks.delete_if { |k, _| k =~ name }
       else
         all_tasks.delete(name)
       end

data/lib/hoe/rcov.rb

@@ -18,32 +18,31 @@ module Hoe::RCov
   # Define tasks for plugin.
 
   def define_rcov_tasks
-    begin # take a whack at defining rcov tasks
-      task :isolate # ensure it exists
+    task :isolate # ensure it exists
 
-      task :rcov => :isolate do
-        sh(*make_rcov_cmd)
-      end
+    task :rcov => :isolate do
+      sh(*make_rcov_cmd)
+    end
 
-      task :clobber_rcov do
-        rm_rf "coverage"
-      end
+    task :clobber_rcov do
+      rm_rf "coverage"
+    end
 
-      task :clobber => :clobber_rcov
+    task :clobber => :clobber_rcov
 
-      # this is for my emacs rcov overlay stuff on emacswiki.
-      task :rcov_overlay do
-        path = ENV["FILE"]
-        rcov, eol = Marshal.load(File.read("coverage.info")).last[path], 1
-        puts rcov[:lines].zip(rcov[:coverage]).map { |line, coverage|
-          bol, eol = eol, eol + line.length
-          [bol, eol, "#ffcccc"] unless coverage
-        }.compact.inspect
-      end
-    rescue LoadError
-      # skip
-      task :clobber_rcov # in case rcov didn't load
+    # this is for my emacs rcov overlay stuff on emacswiki.
+    task :rcov_overlay do
+      path = ENV["FILE"]
+      rcov, eol = Marshal.load(File.read("coverage.info")).last[path], 1
+      puts rcov[:lines].zip(rcov[:coverage]).map { |line, coverage|
+        bol, eol = eol, eol + line.length
+        [bol, eol, "#ffcccc"] unless coverage
+      }.compact.inspect
     end
+  rescue LoadError
+    # skip
+    task :clobber_rcov # in case rcov didn't load
+    # TODO: didn't load? this must be terribly historical
   end
 
   def make_rcov_cmd # :nodoc:

data/lib/hoe/signing.rb

@@ -45,7 +45,7 @@ module Hoe::Signing
   def define_signing_tasks
     set_up_signing
 
-    desc 'Generate a key for signing your gems.'
+    desc "Generate a key for signing your gems."
     task :generate_key do
       generate_key_task
     end
@@ -55,12 +55,12 @@ module Hoe::Signing
     signing_key = nil
     cert_chain = []
 
-    with_config do |config, path|
-      break unless config['signing_key_file'] and config['signing_cert_file']
-      key_file = File.expand_path config['signing_key_file'].to_s
+    with_config do |config, _path|
+      break unless config["signing_key_file"] and config["signing_cert_file"]
+      key_file = File.expand_path config["signing_key_file"].to_s
       signing_key = key_file if File.exist? key_file
 
-      cert_file = File.expand_path config['signing_cert_file'].to_s
+      cert_file = File.expand_path config["signing_cert_file"].to_s
       cert_chain << cert_file if File.exist? cert_file
     end
 
@@ -74,15 +74,15 @@ module Hoe::Signing
     email = Array(spec.email)
     abort "No email in your gemspec" if email.nil? or email.empty?
 
-    key_file = with_config { |config, _| config['signing_key_file'] }
-    cert_file = with_config { |config, _| config['signing_cert_file'] }
+    key_file = with_config { |config, _| config["signing_key_file"] }
+    cert_file = with_config { |config, _| config["signing_cert_file"] }
 
     if key_file.nil? or cert_file.nil? then
-      ENV['SHOW_EDITOR'] ||= 'no'
-      Rake::Task['config_hoe'].invoke
+      ENV["SHOW_EDITOR"] ||= "no"
+      Rake::Task["config_hoe"].invoke
 
-      key_file = with_config { |config, _| config['signing_key_file'] }
-      cert_file = with_config { |config, _| config['signing_cert_file'] }
+      key_file = with_config { |config, _| config["signing_key_file"] }
+      cert_file = with_config { |config, _| config["signing_cert_file"] }
     end
 
     key_file = File.expand_path key_file

data/lib/hoe/test.rb

@@ -30,7 +30,7 @@ module Hoe::Test
   # this is an unfortunate naming collision. I don't use the CPU (N)
   # specifier so it is shifting to "C" inside of Hoe.
   ENV.delete "N" if ENV["N"]
-  ENV["N"] = ENV['C'] if ENV['C']
+  ENV["N"] = ENV["C"] if ENV["C"]
 
   ##
   # Optional: Array of incompatible versions for multiruby filtering.
@@ -65,7 +65,7 @@ module Hoe::Test
     self.multiruby_skip ||= []
     self.testlib        ||= :minitest
     self.test_prelude   ||= nil
-    self.rspec_dirs     ||= %w(spec lib)
+    self.rspec_dirs     ||= %w[spec lib]
     self.rspec_options  ||= []
   end
 
@@ -78,31 +78,31 @@ module Hoe::Test
     task :test
 
     if File.directory? "test" then
-      desc 'Run the test suite. Use FILTER or TESTOPTS to add flags/args.'
+      desc "Run the test suite. Use FILTER or TESTOPTS to add flags/args."
       task :test do
         ruby make_test_cmd
       end
 
-      desc 'Print out the test command. Good for profiling and other tools.'
+      desc "Print out the test command. Good for profiling and other tools."
       task :test_cmd do
         puts make_test_cmd
       end
 
-      desc 'Run the test suite using multiruby.'
+      desc "Run the test suite using multiruby."
       task :multi do
         ENV["EXCLUDED_VERSIONS"] = multiruby_skip.join(":")
         system "multiruby -S rake"
       end
 
-      desc 'Show which test files fail when run alone.'
+      desc "Show which test files fail when run alone."
       task :test_deps do
         tests = Dir[*self.test_globs].uniq
 
-        paths = ['bin', 'lib', 'test'].join(File::PATH_SEPARATOR)
-        null_dev = Hoe::WINDOZE ? '> NUL 2>&1' : '> /dev/null 2>&1'
+        paths = %w[bin lib test].join(File::PATH_SEPARATOR)
+        null_dev = Hoe::WINDOZE ? "> NUL 2>&1" : "> /dev/null 2>&1"
 
         tests.each do |test|
-          if not system "ruby -I#{paths} #{test} #{null_dev}" then
+          unless system "ruby -I#{paths} #{test} #{null_dev}" then
             puts "Dependency Issues: #{test}"
           end
         end
@@ -128,7 +128,7 @@ module Hoe::Test
       end
     end
 
-    desc 'Run the default task(s).'
+    desc "Run the default task(s)."
     task :default => default_tasks
 
     unless default_tasks.empty? then
@@ -154,10 +154,10 @@ module Hoe::Test
       file "#{pkg}.gem" => turd
     end
 
-    desc 'Run ZenTest against the package.'
+    desc "Run ZenTest against the package."
     task :audit do
-      libs = %w(lib test ext).join(File::PATH_SEPARATOR)
-      sh "zentest -I=#{libs} #{spec.files.grep(/^(lib|test)/).join(' ')}"
+      libs = %w[lib test ext].join(File::PATH_SEPARATOR)
+      sh "zentest -I=#{libs} #{spec.files.grep(/^(lib|test)/).join(" ")}"
     end
   end
 
@@ -165,7 +165,7 @@ module Hoe::Test
   # Generate the test command-line.
 
   def make_test_cmd
-    unless SUPPORTED_TEST_FRAMEWORKS.has_key?(testlib)
+    unless SUPPORTED_TEST_FRAMEWORKS.key?(testlib)
       raise "unsupported test framework #{testlib}"
     end
 
@@ -175,7 +175,7 @@ module Hoe::Test
     tests << framework if framework
     tests << test_globs.sort.map { |g| Dir.glob(g) }
     tests.flatten!
-    tests.map! {|f| %(require "#{f}")}
+    tests.map! { |f| %(require "#{f}") }
 
     tests.insert 1, test_prelude if test_prelude
 
@@ -186,7 +186,7 @@ module Hoe::Test
   # Attempt to load RSpec 2, returning true if successful
 
   def try_loading_rspec2
-    require 'rspec/core/rake_task'
+    require "rspec/core/rake_task"
 
     desc "Run all specifications"
     RSpec::Core::RakeTask.new(:spec) do |t|
@@ -205,7 +205,7 @@ module Hoe::Test
   # Attempt to load RSpec 1, returning true if successful
 
   def try_loading_rspec1
-    require 'spec/rake/spectask'
+    require "spec/rake/spectask"
 
     desc "Run all specifications"
     Spec::Rake::SpecTask.new(:spec) do |t|

data/test/test_hoe.rb

@@ -1,6 +1,6 @@
-require 'minitest/autorun'
-require 'hoe'
-require 'tempfile'
+require "minitest/autorun"
+require "hoe"
+require "tempfile"
 
 class Hoe
   def self.files= x
@@ -57,24 +57,24 @@ class TestHoe < Minitest::Test
   end
 
   def test_activate_plugins
-    initializers = hoe.methods.grep(/^initialize/).map { |s| s.to_s }
+    initializers = hoe.methods.grep(/^initialize/).map(&:to_s)
 
-    assert_includes initializers, 'initialize_package'
-    assert_includes initializers, 'initialize_publish'
-    assert_includes initializers, 'initialize_test'
+    assert_includes initializers, "initialize_package"
+    assert_includes initializers, "initialize_publish"
+    assert_includes initializers, "initialize_test"
   end
 
   def test_activate_plugins_hoerc
-    home = ENV['HOME']
+    home = ENV["HOME"]
     load_path = $LOAD_PATH.dup
     Hoe.files = nil
 
     Dir.mktmpdir do |path|
-      ENV['HOME'] = path
+      ENV["HOME"] = path
       $LOAD_PATH << path
 
-      Dir.mkdir File.join(path, 'hoe')
-      open File.join(path, 'hoe', 'hoerc.rb'), 'w' do |io|
+      Dir.mkdir File.join(path, "hoe")
+      open File.join(path, "hoe", "hoerc.rb"), "w" do |io|
         io.write <<-EOM
           module Hoe::Hoerc
             def initialize_hoerc; end
@@ -83,11 +83,11 @@ class TestHoe < Minitest::Test
         EOM
       end
 
-      write_hoerc path, 'plugins' => %w[hoerc]
+      write_hoerc path, "plugins" => %w[hoerc]
 
-      methods = hoe.methods.grep(/^initialize/).map { |s| s.to_s }
+      methods = hoe.methods.grep(/^initialize/).map(&:to_s)
 
-      assert_includes methods, 'initialize_hoerc'
+      assert_includes methods, "initialize_hoerc"
       assert_includes Hoe.plugins, :hoerc
     end
   ensure
@@ -95,21 +95,21 @@ class TestHoe < Minitest::Test
   end
 
   def test_have_gem_eh
-    assert hoe.have_gem? 'rake'
-    refute hoe.have_gem? 'nonexistent'
+    assert hoe.have_gem? "rake"
+    refute hoe.have_gem? "nonexistent"
   end
 
   def test_initialize_plugins_hoerc
-    home = ENV['HOME']
+    home = ENV["HOME"]
     load_path = $LOAD_PATH.dup
     Hoe.files = nil
 
     Dir.mktmpdir do |path|
-      ENV['HOME'] = path
+      ENV["HOME"] = path
       $LOAD_PATH << path
 
-      Dir.mkdir File.join(path, 'hoe')
-      open File.join(path, 'hoe', 'hoerc.rb'), 'w' do |io|
+      Dir.mkdir File.join(path, "hoe")
+      open File.join(path, "hoe", "hoerc.rb"), "w" do |io|
         io.write <<-EOM
           module Hoe::Hoerc
             def initialize_hoerc; @hoerc_plugin_initialized = true; end
@@ -118,10 +118,10 @@ class TestHoe < Minitest::Test
         EOM
       end
 
-      write_hoerc path, 'plugins' => %w[hoerc]
+      write_hoerc path, "plugins" => %w[hoerc]
 
       methods = hoe.instance_variables.map(&:to_s)
-      assert_includes(methods, '@hoerc_plugin_initialized',
+      assert_includes(methods, "@hoerc_plugin_initialized",
                       "Hoerc plugin wasn't initialized")
       assert_includes Hoe.plugins, :hoerc
     end
@@ -130,7 +130,7 @@ class TestHoe < Minitest::Test
   end
 
   def write_hoerc path, data
-    open File.join(path, '.hoerc'), 'w' do |io|
+    open File.join(path, ".hoerc"), "w" do |io|
       io.write YAML.dump data
     end
   end
@@ -140,23 +140,23 @@ class TestHoe < Minitest::Test
     Hoe.plugins.delete :hoerc
     Hoe.send :remove_const, :Hoerc
     $LOAD_PATH.replace load_path
-    ENV['HOME'] = home
+    ENV["HOME"] = home
   end
 
   def test_initialize_intuit
     Dir.mktmpdir do |path|
       Dir.chdir path do
-        open 'Manifest.txt', 'w' do |io| # sorted
-          io.puts 'FAQ.rdoc'
-          io.puts 'History.rdoc'
-          io.puts 'README.rdoc'
+        open "Manifest.txt", "w" do |io| # sorted
+          io.puts "FAQ.rdoc"
+          io.puts "History.rdoc"
+          io.puts "README.rdoc"
         end
 
-        open 'README.rdoc',  'w' do |io| io.puts '= blah' end
-        open 'History.rdoc', 'w' do |io| io.puts '=== 1.0' end
+        open "README.rdoc",  "w" do |io| io.puts "= blah" end
+        open "History.rdoc", "w" do |io| io.puts "=== 1.0" end
 
-        assert_equal 'History.rdoc', hoe.history_file
-        assert_equal 'README.rdoc', hoe.readme_file
+        assert_equal "History.rdoc", hoe.history_file
+        assert_equal "README.rdoc", hoe.readme_file
         assert_equal %w[FAQ.rdoc History.rdoc README.rdoc],
                      hoe.spec.extra_rdoc_files
       end
@@ -166,28 +166,28 @@ class TestHoe < Minitest::Test
   def test_initialize_intuit_ambiguous
     Dir.mktmpdir do |path|
       Dir.chdir path do
-        open 'Manifest.txt', 'w' do |io|
-          io.puts 'History.rdoc' # sorted
-          io.puts 'README.ja.rdoc'
-          io.puts 'README.rdoc'
+        open "Manifest.txt", "w" do |io|
+          io.puts "History.rdoc" # sorted
+          io.puts "README.ja.rdoc"
+          io.puts "README.rdoc"
         end
 
-        open 'README.rdoc',    'w' do |io| io.puts '= blah' end
-        open 'README.ja.rdoc', 'w' do |io| io.puts '= blah' end
-        open 'History.rdoc',   'w' do |io| io.puts '=== 1.0' end
+        open "README.rdoc",    "w" do |io| io.puts "= blah" end
+        open "README.ja.rdoc", "w" do |io| io.puts "= blah" end
+        open "History.rdoc",   "w" do |io| io.puts "=== 1.0" end
 
-        assert_equal 'README.ja.rdoc', hoe(:skip_files).readme_file
+        assert_equal "README.ja.rdoc", hoe(:skip_files).readme_file
       end
     end
   end
 
   def test_file_read_utf
-    Tempfile.open 'BOM' do |io|
+    Tempfile.open "BOM" do |io|
       io.write "\xEF\xBB\xBFBOM"
       io.rewind
 
       content = File.read_utf io.path
-      assert_equal 'BOM', content
+      assert_equal "BOM", content
 
       if content.respond_to? :encoding then
         assert_equal Encoding::UTF_8, content.encoding
@@ -231,7 +231,7 @@ class TestHoe < Minitest::Test
     t = Gem::Specification::TODAY
 
     hoe = self.hoe do
-      self.version = '1.2.3'
+      self.version = "1.2.3"
     end
 
     files = File.read("Manifest.txt").split(/\n/) + [".gemtest"]
@@ -251,28 +251,27 @@ class TestHoe < Minitest::Test
 
     text_files = files.grep(/(txt|rdoc)$/).reject { |f| f =~ /template/ }
 
-    assert_equal 'blah', spec.name
-    assert_equal '1.2.3', spec.version.to_s
-    assert_equal '>= 0', spec.required_rubygems_version.to_s
+    assert_equal "blah", spec.name
+    assert_equal "1.2.3", spec.version.to_s
+    assert_equal ">= 0", spec.required_rubygems_version.to_s
 
-    assert_equal ['author'], spec.authors
+    assert_equal ["author"], spec.authors
     assert_equal t, spec.date
     assert_match(/Hoe.*Rakefiles/, spec.description)
-    assert_equal ['email'], spec.email
-    assert_equal ['sow'], spec.executables
+    assert_equal ["email"], spec.email
+    assert_equal ["sow"], spec.executables
     assert_equal text_files, spec.extra_rdoc_files
     assert_equal files.sort, spec.files.sort
     assert_equal urls["home"], spec.homepage
-    assert_equal ['--main', 'README.rdoc'], spec.rdoc_options
-    assert_equal ['lib'], spec.require_paths
+    assert_equal ["--main", "README.rdoc"], spec.rdoc_options
+    assert_equal ["lib"], spec.require_paths
     assert_equal Gem::RubyGemsVersion, spec.rubygems_version
     assert_match(/^Hoe.*Rakefiles$/, spec.summary)
-    assert_equal files.grep(/^test/).sort, spec.test_files.sort
 
-    deps = spec.dependencies.sort_by { |dep| dep.name }
+    deps = spec.dependencies.sort_by(&:name)
 
     expected = [
-      ["hoe",  :development, "~> #{Hoe::VERSION.sub(/\.\d+$/, '')}"],
+      ["hoe",  :development, "~> #{Hoe::VERSION.sub(/\.\d+$/, "")}"],
       ["rdoc", :development, "~> 4.0"],
     ]
 
@@ -293,28 +292,28 @@ class TestHoe < Minitest::Test
   def test_license
     spec = self.hoe.spec
 
-    assert_equal %w(MIT), spec.licenses
+    assert_equal %w[MIT], spec.licenses
   end
 
   def test_multiple_calls_to_license
     hoe = self.hoe :skip_license do
-      license 'MIT'
-      license 'GPL-2'
+      license "MIT"
+      license "GPL-2"
     end
 
     spec = hoe.spec
 
-    assert_equal %w(MIT GPL-2), spec.licenses
+    assert_equal %w[MIT GPL-2], spec.licenses
   end
 
   def test_setting_licenses
     hoe = self.hoe :skip_license do
-      self.licenses = ['MIT', 'GPL-2']
+      self.licenses = ["MIT", "GPL-2"]
     end
 
     spec = hoe.spec
 
-    assert_equal %w(MIT GPL-2), spec.licenses
+    assert_equal %w[MIT GPL-2], spec.licenses
   end
 
   def test_plugins
@@ -328,7 +327,7 @@ class TestHoe < Minitest::Test
   end
 
   def test_read_manifest
-    expected = File.read_utf('Manifest.txt').split
+    expected = File.read_utf("Manifest.txt").split
 
     assert_equal expected, hoe.read_manifest
   end
@@ -336,12 +335,12 @@ class TestHoe < Minitest::Test
   def test_rename
     # project, file_name, klass, test_klass = Hoe.normalize_names 'project_name'
 
-    assert_equal %w(    word      word     Word    TestWord),           Hoe.normalize_names('word')
-    assert_equal %w(    word      word     Word    TestWord),           Hoe.normalize_names('Word')
-    assert_equal %w(two_words two_words TwoWords   TestTwoWords),       Hoe.normalize_names('TwoWords')
-    assert_equal %w(two_words two_words TwoWords   TestTwoWords),       Hoe.normalize_names('twoWords')
-    assert_equal %w(two-words two/words Two::Words TestTwo::TestWords), Hoe.normalize_names('two-words')
-    assert_equal %w(two_words two_words TwoWords   TestTwoWords),       Hoe.normalize_names('two_words')
+    assert_equal %w[word      word     Word    TestWord],           Hoe.normalize_names("word")
+    assert_equal %w[word      word     Word    TestWord],           Hoe.normalize_names("Word")
+    assert_equal %w[two_words two_words TwoWords   TestTwoWords],       Hoe.normalize_names("TwoWords")
+    assert_equal %w[two_words two_words TwoWords   TestTwoWords],       Hoe.normalize_names("twoWords")
+    assert_equal %w[two-words two/words Two::Words TestTwo::TestWords], Hoe.normalize_names("two-words")
+    assert_equal %w[two_words two_words TwoWords   TestTwoWords],       Hoe.normalize_names("two_words")
   end
 
   def test_nosudo
@@ -351,40 +350,40 @@ class TestHoe < Minitest::Test
       end
     end
 
-    assert_match(/^(sudo )?(j|maglev-)?gem.*/, hoe.install_gem('foo'))
-    ENV['NOSUDO'] = '1'
-    assert_match(/^(j|maglev-)?gem.*/, hoe.install_gem('foo'))
+    assert_match(/^(sudo )?(j|maglev-)?gem.*/, hoe.install_gem("foo"))
+    ENV["NOSUDO"] = "1"
+    assert_match(/^(j|maglev-)?gem.*/, hoe.install_gem("foo"))
   ensure
     ENV.delete "NOSUDO"
   end
 
   def test_with_config_default
-    home = ENV['HOME']
+    home = ENV["HOME"]
     Hoe.files = nil
 
     Dir.mktmpdir do |path|
-      ENV['HOME'] = path
+      ENV["HOME"] = path
 
-      hoeconfig = hoe.with_config {|config, _| config }
+      hoeconfig = hoe.with_config { |config, _| config }
 
       assert_equal Hoe::DEFAULT_CONFIG, hoeconfig
     end
   ensure
-    ENV['HOME'] = home
+    ENV["HOME"] = home
   end
 
   def test_with_config_overrides
     overrides = {
-      'exclude' => Regexp.union( Hoe::DEFAULT_CONFIG["exclude"], /\.hg/ ),
-      'plugins' => ['tweedledee', 'tweedledum']
+      "exclude" => Regexp.union( Hoe::DEFAULT_CONFIG["exclude"], /\.hg/ ),
+      "plugins" => %w[tweedledee tweedledum],
     }
-    overrides_rcfile = File.join(Dir.pwd, '.hoerc')
+    overrides_rcfile = File.join(Dir.pwd, ".hoerc")
 
-    home = ENV['HOME']
+    home = ENV["HOME"]
     Hoe.files = nil
 
     Dir.mktmpdir do |path|
-      ENV['HOME'] = path
+      ENV["HOME"] = path
 
       write_hoerc path, Hoe::DEFAULT_CONFIG
 
@@ -392,12 +391,12 @@ class TestHoe < Minitest::Test
         io.write YAML.dump( overrides )
       end
 
-      hoeconfig = hoe.with_config {|config, _| config }
+      hoeconfig = hoe.with_config { |config, _| config }
 
       assert_equal Hoe::DEFAULT_CONFIG.merge(overrides), hoeconfig
     end
   ensure
     File.delete overrides_rcfile if File.exist?( overrides_rcfile )
-    ENV['HOME'] = home
+    ENV["HOME"] = home
   end
 end