hoe-manns 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c520f15246cb2a93b38e8a9cae434cec43eaff5f
-  data.tar.gz: 312fc60064cbd210126c05b6fe5f0f2fff4ec71a
+  metadata.gz: 24e8a05d3e2815eaf89233b8dba6e0f879f54faf
+  data.tar.gz: 208d0551004f9beffdd33f069566a14f6cdd328e
 SHA512:
-  metadata.gz: 1db2f2ad834709b8c5ce3b65236f2694aa1f6bfef31e40ed705bcd9706d03d0b99134af09eeaac2156f6d92282f51fdd5414fadd2263c1fe4db535823050aa9a
-  data.tar.gz: 05a696ee280c7a365fc776670af4e626d61e45d4f1ae9182bd7f18dc6638415753546a8e35807483b7854b20dd7d409fbba7035fdc4c2d03aee2a9aa2dc65134
+  metadata.gz: 67a366ceb2601c6fdbf6c9c11a75290df7d673089f93bc23eda832147129a8d37238d676f6b0e64c78feb4768243985e4c9fe14b1b7bf8e68683267df1c686f3
+  data.tar.gz: 5c1e4d929026f4b93ce4e45f33d967bf33a13b7e5a3dca8e78a0daf5c580676997ca8aa6e02b903df260b2ba395c20bbd9ce5ffc3f205f585cbbd0d259941c95

data/Gemfile.lock

@@ -34,9 +34,9 @@ GEM
       bundler-audit (~> 0.5)
       parseconfig (~> 1.0)
       rainbow (~> 2.2)
-    hoe-reek (1.1.8)
-      bundler (~> 1.13)
-      reek (~> 4.5)
+    hoe-reek (1.2.0)
+      bundler (~> 1.15)
+      reek (~> 4.7)
     hoe-rubocop (1.0.8)
       bundler (~> 1.14)
       rubocop (~> 0.47)
@@ -53,7 +53,7 @@ GEM
     powerpack (0.1.1)
     rainbow (2.2.2)
       rake
-    rake (12.1.0)
+    rake (12.2.1)
     rdoc (5.1.0)
     reek (4.7.2)
       codeclimate-engine-rb (~> 0.4.0)

data/History.rdoc

@@ -1,3 +1,14 @@
+=== 2.1.0 / 2017-10-25
+
+* 5 minor enhancements
+
+    * HM-9: Split module into two seperate modules
+    * HM-10: Remove run_after_release
+    * HM-11: Remove system('git add recipes/recipe.rb') if File.exist?('recipes/recipe.rb')
+    * HM-13: Add more tests
+    * Added task 'rake bundler:gemfile install'
+    * Changed publican to daps docbook managing
+
 === 2.0.0 / 2017-10-19
 
 * 5 major enhancements

data/Manifest.txt

@@ -6,5 +6,6 @@ Manifest.txt
 README.rdoc
 Rakefile
 lib/hoe/manns.rb
+lib/hoe/manns-methods.rb
 spec/manns_spec.rb
 spec/spec_helper.rb

data/README.rdoc

@@ -74,7 +74,6 @@ Read the documentation at: https://saigkill.github.io/hoe-manns/about/
 
 * rake
 * hoe
-* parseconfig
 * bundler-audit
 
 == INSTALL:

data/Rakefile

@@ -1,14 +1,6 @@
 # -*- ruby -*-
 # Release:
-# * bump version
-# * do stuff
-# * update documentation
-# * enable :git
-# * rake run_before_release
-# * disable :git
-# * Checkin
-# * rake release
-# * rake run_after_release
+# See README.rdoc.release
 
 require 'rubygems'
 require 'hoe'
@@ -29,7 +21,7 @@ Hoe.plugin :version
 # rubocop:disable Metrics/LineLength
 Hoe.spec 'hoe-manns' do
   developer('Sascha Manns', 'Sascha.Manns@mailbox.org')
-  license 'GPL-3' # this should match the license in the README
+  license 'GPL-3.0' # this should match the license in the README
   require_ruby_version '>= 2.2.0'
 
   dependency 'rainbow', '~> 2.2'

data/lib/hoe/manns-methods.rb

@@ -0,0 +1,70 @@
+# Copyright (C) 2013-2017 Sascha Manns <Sascha.Manns@mailbox.org>
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Dependencies
+require 'rainbow/ext/string'
+
+# Module Hoe
+# rubocop:disable Metrics/ClassAndModuleChildren
+module Hoe::MannsMethods
+  # Installs a bundle
+  def self.bundle_install
+    puts 'Installing Bundle'.color(:yellow)
+    system('bundle install')
+    puts 'Installed Bundle'.color(:green)
+  end
+
+  # Update Gemfile.lock
+  def self.update_gemfile_lock_method
+    puts 'Updating Gemfile.lock'.color(:yellow)
+    system('bundle update')
+    puts 'Updated Gemfile.lock'.color(:green)
+  end
+
+  # Remove prerelease gemspec
+  def self.remove_pre_gemspec_method
+    puts 'Removing pre version of gemspec'.color(:yellow)
+    File.delete(*Dir.glob('*.gemspec'))
+    puts 'Removed'.color(:green)
+  end
+
+  # Copying stuff to master
+  def self.copy_master
+    copy_master_co_master
+    puts 'Set a Git Tag'.color(:yellow)
+    system('rake git:tag')
+    puts 'Checking out develop again'.color(:yellow)
+    system('git checkout develop')
+    puts 'Done'.color(:green)
+  end
+
+  # Check out master
+  def self.copy_master_co_master
+    puts 'Checking out master'.color(:yellow)
+    system('git checkout master')
+    puts 'Merging master with develop'.color(:yellow)
+    system('git merge develop')
+    puts 'Pushing master to origin'.color(:yellow)
+    system('git push')
+  end
+
+  # Cleanup the pkg
+  def self.clean_pkg_method
+    puts 'Cleaning pkg'.color(:yellow)
+    FileUtils.rm_rf('pkg') if Dir.exist?('pkg')
+    FileUtils.rm_rf('recipes/pkg') if Dir.exist?('recipes/pkg')
+    puts 'Cleanup succeed'.color(:green)
+  end
+end

data/lib/hoe/manns.rb

@@ -15,16 +15,19 @@
 
 # Dependencies
 require 'hoe'
+require_relative 'manns-methods.rb'
 
-# Main module for hoe-manns
+# Main module Hoe
+# TODO: Currently i don't know how to fix this.
+# Nested usage triggers error "hoe not a module"
+# rubocop:disable Metrics/ClassAndModuleChildren
 module Hoe::Manns
   # Version constant for HOE::Manns
-  VERSION = '2.0.0'.freeze
+  VERSION = '2.1.0'.freeze
 
   attr_accessor :remove_pre_gemspec
   attr_accessor :copy_master
   attr_accessor :run_before_release
-  attr_accessor :run_after_release
   attr_accessor :clean_pkg
   attr_accessor :bundle_audit
 
@@ -36,45 +39,49 @@ module Hoe::Manns
   end
 
   # Definitions of the Rake task
+  # TODO: Check if this smells can be pacified in future
+  # rubocop:disable Metrics/AbcSize
+  # rubocop:disable Metrics/MethodLength
+  # This method smells of :reek:TooManyStatements
   def define_manns_tasks
-    # Rake Task for updating Gemfile.lock
+    # Install a Bundle
+    desc 'Install a Bundle'
+    task 'bundler:gemfile_install' do
+      Hoe::MannsMethods.bundle_install
+    end
+
+    # Task for updating Gemfile.lock
     desc 'Update Gemfile.lock'
     task 'bundler:gemfile_lock' do
-      Hoe::Manns.update_gemfile_lock_method
+      Hoe::MannsMethods.update_gemfile_lock_method
     end
 
-    # Rake Task for removing Prerelease Gemspecs
+    # Task for removing Prerelease Gemspecs
     desc 'Remove Pre-Gemspec'
     task 'gem:spec_remove' do
-      Hoe::Manns.remove_pre_gemspec_method
+      Hoe::MannsMethods.remove_pre_gemspec_method
     end
 
-    # Rake Task for git tag
+    # Task for git tag
     desc 'Copy master'
     task :copy_master do
-      Hoe::Manns.copy_master
+      Hoe::MannsMethods.copy_master
     end
 
-    # Rake Task for running needed Rake Tasks before running rake release
+    # Task for running needed Rake Tasks before running rake release
     desc 'Run all tasks before rake release'
-    task run_before_release: %w[git:manifest bundler:gemfile
-                                bundler:gemfile_lock gem:spec_remove bundle_audit:run copy_master] do
+    task run_before_release:
+             %w[git:manifest bundler:gemfile bundler:gemfile_lock gem:spec_remove bundle_audit:run copy_master] do
       puts 'Ready to run rake release VERSION=x.y.z'.color(:green)
     end
 
-    # Rake Task for running needed Rake Tasks after running rake release
-    desc 'Run all tasks after rake release'
-    task run_after_release: %w[send_email clean_pkg] do
-      puts 'Release finished'.color :green
-    end
-
-    # Rake Task for cleaning up the pkg
+    # Task for cleaning up the pkg
     desc 'Clean pkg'
     task :clean_pkg do
-      Hoe::Manns.clean_pkg_method
+      Hoe::MannsMethods.clean_pkg_method
     end
 
-    # Method for bundle audit
+    # Tasks for bundle audit
     namespace :bundle_audit do
       desc 'Update bundle-audit database'
       task :update do
@@ -96,43 +103,4 @@ module Hoe::Manns
       Rake::Task['bundle_audit:run'].invoke
     end
   end
-
-  require 'rainbow/ext/string'
-  # Method for updating Gemfile.lock
-  def self.update_gemfile_lock_method
-    puts 'Updating Gemfile.lock'.color(:yellow)
-    system('bundle update')
-    puts 'Updated Gemfile.lock'.color(:green)
-  end
-
-  # Method for removing prerelease gemspec
-  def self.remove_pre_gemspec_method
-    puts 'Removing pre version of gemspec'.color(:yellow)
-    File.delete(*Dir.glob('*.gemspec'))
-    puts 'Removed'.color(:green)
-  end
-
-  # Method for copying to master
-  def self.copy_master
-    puts 'Checking out master'.color(:yellow)
-    system('git checkout master')
-    puts 'Merging master with develop'.color(:yellow)
-    system('git merge develop')
-    puts 'Pushing master to origin'.color(:yellow)
-    system('git add recipes/recipe.rb') if File.exist?('recipes/recipe.rb')
-    system('git push')
-    puts 'Set a Git Tag'.color(:yellow)
-    system('rake git:tag')
-    puts 'Checking out develop again'.color(:yellow)
-    system('git checkout develop')
-    puts 'Done'.color(:green)
-  end
-
-  # Method for cleanup the pkg
-  def self.clean_pkg_method
-    puts 'Cleaning pkg'.color(:yellow)
-    FileUtils.rm_rf('pkg') if Dir.exist?('pkg')
-    FileUtils.rm_rf('recipes/pkg') if Dir.exist?('recipes/pkg')
-    puts 'Cleanup succeed'.color(:green)
-  end
 end

data/spec/manns_spec.rb

@@ -1,13 +1,23 @@
 require 'rspec'
 require File.join(File.dirname(__FILE__), '..', 'lib/hoe/manns')
+require File.join(File.dirname(__FILE__), '..', 'lib/hoe/manns-methods')
 require File.join(File.dirname(__FILE__), '..', 'spec/spec_helper')
 require 'fileutils'
 
+# TODO: Try to split this block into smaller once
+# rubocop:disable Metrics/BlockLength
 describe 'Hoe::Manns' do
+  describe 'bundle_install' do
+    it 'installs a bundle' do
+      success = Hoe::MannsMethods.bundle_install
+      expect(success)
+    end
+  end
+
   describe 'update_gemfile_lock_method' do
     it 'creates a new Gemfile.lock' do
       FileUtils.rm(File.join(File.dirname(__FILE__), '..', 'Gemfile.lock'))
-      Hoe::Manns.update_gemfile_lock_method
+      Hoe::MannsMethods.update_gemfile_lock_method
       avail = File.exist?(File.join(File.dirname(__FILE__), '..',
                                     'Gemfile.lock'))
       expect(avail)
@@ -17,7 +27,7 @@ describe 'Hoe::Manns' do
   describe 'remove_pre_gemspec' do
     it 'removes the old gemspec' do
       FileUtils.touch('hoe-manns.gemspec')
-      Hoe::Manns.remove_pre_gemspec_method
+      Hoe::MannsMethods.remove_pre_gemspec_method
       gemspec = Dir.glob('*.gemspec').empty?
       expect(gemspec)
     end
@@ -25,7 +35,7 @@ describe 'Hoe::Manns' do
 
   describe 'clean_pkg' do
     it 'cleans the pkg' do
-      Hoe::Manns.clean_pkg_method
+      Hoe::MannsMethods.clean_pkg_method
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,15 +1,4 @@
 require 'coveralls'
-require 'simplecov'
 require 'fileutils'
 require 'rake'
 Coveralls.wear!
-
-SimpleCov.formatter = Coveralls::SimpleCov::Formatter
-SimpleCov.start do
-  add_filter '.yardoc'
-  add_filter 'config'
-  add_filter 'doc'
-  add_filter 'manual'
-  add_filter 'pkg'
-  add_filter 'vendor'
-end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hoe-manns
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Sascha Manns
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-19 00:00:00.000000000 Z
+date: 2017-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -290,12 +290,13 @@ files:
 - README.rdoc
 - Rakefile
 - STATUS.rdoc
+- lib/hoe/manns-methods.rb
 - lib/hoe/manns.rb
 - spec/manns_spec.rb
 - spec/spec_helper.rb
 homepage: https://launchpad.net/hoe-manns
 licenses:
-- GPL-3
+- GPL-3.0
 metadata: {}
 post_install_message: 'Please file bugreports on: https://bugs.launchpad.net/hoe-manns'
 rdoc_options: