hockeyhelper 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 361f2c3a9a76cf49107f730ecef7116e49f013df
-  data.tar.gz: 0421c010c61dad94c49a94dc2c292d0c1fb6319a
+  metadata.gz: 212599997dfc02a934cd61af78a1a0281870879a
+  data.tar.gz: fb1888ebfb274ceb17ec9f1640bc7c15ff746a2a
 SHA512:
-  metadata.gz: ed29a07b77a17dbf91d6766a570d2115802250a4ae0093bd120f9c1637aad53b57ec0b2fdb786fff8bf60a443adba1ab0f2e0635f984619cb6cae00437530288
-  data.tar.gz: e170b47aed77cac749c202b8b0f1aa095c39a1171e11f49b48c871b8d33c271bd38bdeedeff98cc947ed5a4b90547d812dcbb5c63232978be2fc9bbaf1bc8725
+  metadata.gz: 741a038849604a3f5880625086cbdb92e29ba859cbdd6e15071892cbb05ebb87f6714cd1432d00749a66060e7cb6ad79775f343e4a31a792942145e018630629
+  data.tar.gz: dc029688584ed5047d4d8e7a933200d4f4f08e70affcd28b7cd9341456033c757bf69eafd4eeae9a689edb111aa04d1e3e84f67f22ec5c19389cee074ee5051f

data/hockey.gemspec

@@ -23,5 +23,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "yard"
+  spec.add_development_dependency "flay"
   spec.add_dependency "faraday"
 end

data/lib/hockeyhelper/app.rb

@@ -1,6 +1,10 @@
+require_relative 'paging_array'
+
 module Hockey
 
   # App on HockeyApp
+  #
+  # @see http://support.hockeyapp.net/kb/api/api-apps HokceyApp Apps API Reference
   class App
 
     attr_reader :title
@@ -15,10 +19,15 @@ module Hockey
 
     attr :net
 
+    # Construct a new instance of {App}
+    #
+    # @param hashobj [Hash] an instance of app receiving from HockeyApp
+    # @param networking [Hockey::Networking] an instance of Hockey::Networking object
     def self.create_from(hashobj, networking)
       self.new hashobj, networking
     end
 
+    # Construct a new instance of {App}
     def initialize(hashobj, networking)
       @title = hashobj['title']
       @bundle_identifier = hashobj['bundle_identifier']
@@ -30,8 +39,8 @@ module Hockey
       @platform = hashobj['platform']
       @original_hash = hashobj
       @net = networking
-      @users = nil
-      @versions = nil
+      @cached_users = nil
+      @cached_versions = nil
     end
 
     def inspect
@@ -40,23 +49,24 @@ module Hockey
     alias_method :to_s, :inspect
 
     # List all users of an app on HockeyApp.
-    # return an Array of User objects.
-    def users
-      return @users if @users
-
-      obj = @net.get_object "/api/2/apps/#{@public_identifier}/app_users"
-
-      @users = []
-      obj['app_users'].each do |hashobj|
-        @users << User.create_from(hashobj, @net)
+    #
+    # @return [Array<User>] fetched {User} objects from HockeyApp.
+    def users(page: 1)
+      @cached_users ||= []
+
+      if @cached_users.empty?
+        obj = @net.get_object "/api/2/apps/#{@public_identifier}/app_users"
+        obj['app_users'].each do |hashobj|
+          @cached_users << User.create_from(hashobj, @net)
+        end
       end
 
-      @users
+      PagingArray.paginate with: @cached_users, page: page
     end
 
     # Invite a user to an app.
     # return a User object.
-    def invite_user(email:email)
+    def invite_user(email: '')
       obj = @net.post_object "/api/2/apps/#{@public_identifier}/app_users", {:email=>email, :role=>1}
 
       user = User.create_from(obj, @net)
@@ -65,7 +75,7 @@ module Hockey
     end
 
     # Remove a user from an app on HockeyApp.
-    def remove_user(email:nil)
+    def remove_user(email: nil)
       users()
       user = @users.find {|u| u.email == email }
 
@@ -76,17 +86,17 @@ module Hockey
 
     # List all versions of an app. The endpoint returns all versions for developer and members, but only released versions for testers.
     # return an Array of Version objects.
-    def versions
-      return @versions if @versions
-
-      obj = @net.get_object "/api/2/apps/#{@public_identifier}/app_versions"
-
-      @versions = []
-      obj['app_versions'].each do |hashobj|
-        @versions << Version.create_from(hashobj, @net)
+    def versions(page: 1)
+      @cached_versions ||= []
+
+      if @cached_versions.empty?
+        obj = @net.get_object "/api/2/apps/#{@public_identifier}/app_versions"
+        obj['app_versions'].each do |hashobj|
+          @cached_versions << Version.create_from(hashobj, @net)
+        end
       end
 
-      @versions
+      PagingArray.paginate with: @cached_versions, page: page
     end
 
     # List all crash groups for an app.
@@ -96,7 +106,7 @@ module Hockey
     #   :date, :class, :number_of_crashes, :last_crash_at
     # +order+ parameter:
     #   :asc, :desc
-    def crash_reasons(page: 1, per: 25, symbolicated: true, sort: :date, order: :asc)
+    def crash_reasons(page: 1, symbolicated: true, sort: :date, order: :asc)
       obj = @net.get_object "/api/2/apps/#{@public_identifier}/crash_reasons"
 
       cr = []

data/lib/hockeyhelper/client.rb

@@ -27,11 +27,7 @@ module Hockey
         end
       end
 
-      apps = PagingArray.new
-      apps.replace(@cached_apps[(page - 1) * apps.per_page, apps.per_page])
-      apps.update_page_with(page, @cached_apps.size)
-
-      apps
+      PagingArray.paginate with: @cached_apps, page: page
     end
 
     # List all teams for an account.

data/lib/hockeyhelper/paging_array.rb

@@ -1,11 +1,22 @@
 module Hockey
 
+  class PageRangeError < RangeError; end
+
   class PagingArray < Array
     attr_reader :current_page
     attr_reader :per_page         # = 25
     attr_reader :total_entries
     attr_reader :total_pages
 
+    def self.paginate(with: [], page: 1)
+      obj = self.new
+      obj.replace(with[(page - 1) * obj.per_page, obj.per_page])
+      obj.update_page_with(page, with.size)
+      obj
+    rescue
+      raise PageRangeError, 'your specified page is out of range in array'
+    end
+
     def initialize
       super
       @per_page = 25

data/lib/hockeyhelper/version.rb

@@ -1,6 +1,6 @@
 module Hockey
 
-  VERSION = "0.0.3"
+  VERSION = '0.0.4'
 
   # Version on HockeyApp
   class Version

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hockeyhelper
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Hiroki Yagita
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-04 00:00:00.000000000 Z
+date: 2015-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: flay
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement