RubyGems - hobo - Versions diffs - 0.7.3 → 0.7.4 - Mend

hobo 0.7.3 → 0.7.4

Files changed (46) hide show

data/bin/hobo CHANGED

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
-HOBO_VERSION = "0.7.3"
+HOBO_VERSION = "0.7.4"
 require 'fileutils'
 Signal.trap("INT") { puts; exit }

data/hobo_files/plugin/CHANGES.txt CHANGED

@@ -1,3 +1,305 @@
+== Hobo 0.7.4 ===
+Switching to a new style for the changelog. Now that we're using git
+the commit logs are a lot better, so this file is just going to
+contain edited highlights of the commit log.
+    Rapid: making <view> make more use of the to_html API from
+    HoboFields
+    Reworked REXML extensions. Now compatible with REXML 3.7.1.1
+    through 3.7.1.3
+    ModelController -- fix to chosing whether or not to paginate
+    Various IE Javascript fixes
+    Rapid, <select-many>: Additional params, and IE fix
+    Moving the part-contexts javascripts from the very end of the
+    output, to the end of <body>
+      The script tag must now be output by the <page>, instead of
+      being appended automatically by DRYML. This is done in
+      <simple-layout/>
+    Rapid -- removing <view for='percentage'>
+    DRYML -- improved error reporting
+    Hobo::Model: fix -- we were breaking inheritence of validations
+    Model generators -- adding some helpful comments
+    Rapid: Fix to permission check for adding to primary collection on
+    <show-page>
+    Rapid: removing empty message from <index-page>
+    Rapid: Fix to enum-string editor
+    Rapid: Fix to auto-label in <count>
+    User model generator -- change create permission to allow admin to
+    create another admin
+    New lowpro version
+    New automatic css class 'with-owner' on default <card/>
+    Hobo::ModelController -- fix to automatic inclusion of reorder
+    action for models that act as list
+    Improvements to default <card>
+    Rapid javascript: try to automatically bring back the
+    empty-message on removing the last item from a collection
+    Scopes: fix to apply_scopes
+    Fix to <name-for-collection>
+    Rapid tags: Support for the empty-message on a collection
+    re-appearing automatically if all the items are removed by the
+    user
+    DRYML: scoped variables -- assigning to a variable now modifies
+    it's value in a parent scope if it's present in one
+    <delete-button> fix -- was incorrectly guessing 'in-place' during
+    ajax update
+    New tag <name-for-collection>
+    Fix to <view for='text'/>
+    Improvements to <table-plus>
+      Ability to sort by name of 'this' when 'this' is one of the
+      fields
+      Keep table headings in when the table is empty
+      Don't include page nav if the collection doesn't support it
+    Improvements to rapid pages
+      Allowing has_many associations in forms
+      Allowing the primary collection on a show page to be provided by
+      an instance variable (so that filtering/searching/pagination are
+      supported)
+      Tidy of <show-page>
+      <index-page> -- improved wording
+      Fixes to <index-page>
+    <account-nav> make 'logged in as bob' a link to current_user
+    Factored out default <collection> into <base-collection>, and
+    fixes to <collection-preview>
+    <base-card> -- add 'edit' link
+    <base-card> change 'title' param to 'heading' and make it easier
+    to provide your own
+    <creation-details> use a div rather than a span
+    Fix to <select-many>
+    Fix to <select-menu>
+    Fix to <input for='datetime'>
+    Rapid forms: switching to <select-one> and <select-many> naming
+    <form> -- don't include auth token on GET forms
+    Rapid: <belongs-to-menu-editor> -- don't show 'View' link if the
+    thing is not linkable
+    Rapid: adding sort attribute to <belongs-to-menu-editor>
+    Rapid: default 'no-filter' option for filter-menu
+    Rapid: Fix to extraneous whitespace in <you>
+    Rapid: better guess of label on <count>
+    Rapid: Use association name rather than class name in css classes
+    on <a> tags (when available)
+    Rapid: Fix to use of <else> with <a>
+    Removed 'all' method from ScopedProxy - delegates to the model
+    class instead
+    Fix to origin_attribute on scoped associations
+    Fix to with_abc automatic scopes
+    New automatic scopes 'include' and 'search', and improvements to
+    order_by scope
+    Scopes: fix to parameterised scopes on associations
+    Scopes: new apply_scopes method for models and has_many
+    associations
+        Pass a hash of scope-name => scope-arguments (single valur or
+        array), the result will be scoped accordingly, but only if the
+        first argument to the scope is not blank. It's designed to be
+        used from controllers: if a param (e.g. a search or filter) is
+        not included in the request, the scope is not applied
+    Hobo::ModelController -- fix to permission denied response for
+    ajax actions
+    Hobo::ModelController -- Fix to flash message after update
+    Hobo::ModelController -- fix to redirection after submitting a
+    form
+    Hobo::ModelController -- cleaning up sorting and filtering
+    Hobo::ModelController -- make reorder one of the automatic
+    :write_only actions if the model has the position_column method
+    <with-fields> better error reporting
+    Hobo::ModelController -- adding automatic reorder action
+      Works with acts_as_list and scriptaculous drag and drop
+      re-ordering
+    Hobo::Model adding :managed => true option to has_many
+      Only valid with the :through option. Records of the joining
+      model will be created and destroyed as required when this record
+      is saved, in order to honour the contents of the association at
+      save time.
+    Hobo::Model -- adding .user_update
+    Hobo::Model -- fix to user_find
+    Hobo::HoboHelper -- #map_this (used by repeat) will set this_key
+    when iterating over a hash
+    DRYML: made this_field_reflection do a better job of figuring out
+    the current reflection
+    DRYML: adding this_key -- gives you the current key when
+    <repeat>ing on a hash
+    DRYML: Error message for invalid attributes on parameter tags,
+    e.g. <foo: if-'...'>
+    Hobo module - fix to permission checks on unexpected objects
+    Hobo module -- always return false for can_create? on has_many
+    associations that are not 'simple'
+      (i.e. they have conditions)
+    DRYML: Fix for replacing an overridden tag parameter
+    Rapid pages: new submit label on show page (add to collection)
+    Rapid pages: Add param to <show-page>
+    Rapid pages: by default, append app-name to every title, override
+    with full-title attribute (<base-page>)
+    Rapid pages: <show-page> -- update primary collection count when
+    an item is deleted
+    Rapid pages: fix on <show-page>
+    Rapid pages: make edit link on show-page check if the edit action
+    is linkable
+    Rapid forms: adding inputs (just textareas) for textile and
+    markdown
+    front_controller generator -- use <collection-preview> in
+    index.dryml
+    Rapid generics: adding support for <collection with='&MyModel'/>
+    Rapid tags: switching to <main-nav> tag, called from simple-layout
+    hobo_model_resource generator -- removing creating of (rails
+    style) resource route
+    Improvements to rapid pages
+      Allowing has_many associations in forms
+      Allowing the primary collection on a show page to be provided by
+      an instance variable (so that filtering/searching/pagination are
+      supported)
+    Rapid: Fix to use of <else> with <a>
+    Removed 'all' method from ScopedProxy - delegates to the model
+    class instead
+    Fix to origin_attribute on scoped associations
+    Rapid tags: disabled <belongs-to-view>, new <view
+    for='ActiveRecord::Base'> is used now
+    Hobo::Model -- fix to reverse_refelction
+    Rapid tags: Adding <head:> and <foot:> params to <ul>
+    Rapid tags: Adding params to <select-many>
+    Rapid tags: adding support for <ul empty> (force the <ul> to
+    appear even if empty)
+    Fix: automatic scopes not_ and "association name" were not being
+    created
+    Rapid forms: Renaming <name-array-input> to <select-many> (and
+    improvements)
+    Hobo::Model -- adding assigment by arrays of names to has_many
+    associations
+    Hobo::Model -- adding Model.manage_join_records
+    Routing: fix -- don't try to load assemble.rb if
+    ApplicationController not defined
+    Rapid pages: Fix to body class on <new-page>
+    Rapid pages: fix to show page
+    Rapid pages -- fixing pluralisation of <index-page> title
+    Adding support for 'this' psuedo-field to <with-fields> and
+    <with-fields-names>
+      In particular, this makes it possible to include the object
+      itself in a table plus column
+    Adding a general <view> for ActiveRecord objects (just <a/>)
+    Allowing lookup of polymorphic tags to include ActiveRecord::Base
+    or Object as a catch-all
+    Rapid generics: make collection preview hide the show-all link if
+    there are none
+    <page-nav> now uses will_paginate's helper to provide much better
+    page navigation than before.
 === Release 0.7.3 ===
 hobo command -- options are now:

data/hobo_files/plugin/generators/hobo_front_controller/templates/index.dryml CHANGED

@@ -15,15 +15,8 @@
   <content-body:>
     <ul with="&front_models">
       <li:>
-        <header><h2><a/></h2></header>
-        <section>
-          <p if="&this.count == 0">There are no <type-name plural/></p>
-          <else>
-            <card repeat="&select_viewable(this.recent.all)"/>
-            <p><a>More</a> (<count/>)</p>
-          </else>
-          <p if="&can_create? && linkable?(:new)">Create a <a to="&this" action="new"/>.</p>
-        </section>
+        <collection-preview/>
+        <p if="&can_create? && linkable?(:new)">Create a <a to="&this" action="new"/>.</p>
       </li:>
     </ul>
   </content-body>

data/hobo_files/plugin/generators/hobo_model/templates/model.rb CHANGED

@@ -1,6 +1,6 @@
 class <%= class_name %> < ActiveRecord::Base
-  hobo_model
+  hobo_model # Don't put anything above this
   fields do
 <% for attribute in attributes -%>

data/hobo_files/plugin/generators/hobo_model_resource/hobo_model_resource_generator.rb CHANGED

@@ -50,8 +50,6 @@ class HoboModelResourceGenerator < Rails::Generator::NamedBase
       m.template('functional_test.rb', File.join('test/functional', controller_class_path, "#{controller_file_name}_controller_test.rb"))
       m.template('helper.rb',          File.join('app/helpers',     controller_class_path, "#{controller_file_name}_helper.rb"))
-      m.route_resources controller_file_name
     end
   end

data/hobo_files/plugin/generators/hobo_rapid/templates/hobo-rapid.js CHANGED

@@ -49,8 +49,7 @@ var Hobo = {
             updates.each(function(id_or_el) {
                 var el = $(id_or_el)
                 if (el) { // ignore update of parts that do not exist
-                    var partDomId
-                    partDomId = el.id
+                    var partDomId = el.id
                     if (!hoboParts[partDomId]) { throw "Update of dom-id that is not a part: " + partDomId }
                     params.push("render["+i+"][part_context]=" + encodeURIComponent(hoboParts[partDomId]))
                     params.push("render["+i+"][id]=" + partDomId)
@@ -113,6 +112,7 @@ var Hobo = {
             if (options.onComplete)
                 options.onComplete.apply(this, arguments)
             if (form && options.refocusForm) Form.focusFirstElement(form)
+            Event.addBehavior.reload()
         }
         if (options.method && options.method.toLowerCase() == "put") {
             delete options.method
@@ -185,30 +185,30 @@ var Hobo = {
         var updateParams = Hobo.ajaxUpdateParams(updates, [{id: id,
                                                             result: 'new_field_value',
                                                             func: "Hobo.onFieldEditComplete"}])
-        opts = {okButton: false,
-                cancelLink: false,
-                submitOnBlur: true,
-                evalScripts: true,
-                htmlResponse: false,
-                ajaxOptions: { method: "put" },
-                onEnterHover: null,
-                onLeaveHover: null,
-                callback: function(form, val) {
-                    old = val
-                    return (Hobo.fieldSetParam(el, val) + "&" + updateParams)
-                },
-                onFailure: function(resp) {
-                    alert(resp.responseText); el.innerHTML = old
-                },
-                onEnterEditMode: function() {
-                    var blank_message = el.getAttribute("hobo-blank-message")
-                    if (el.innerHTML.gsub("&nbsp;", " ") == blank_message) {
-                        el.innerHTML = ""
-                    } else {
-                        Hobo.ipeOldValues[el.id] = el.innerHTML
+        var opts = {okButton: false,
+                    cancelLink: false,
+                    submitOnBlur: true,
+                    evalScripts: true,
+                    htmlResponse: false,
+                    ajaxOptions: { method: "put" },
+                    onEnterHover: null,
+                    onLeaveHover: null,
+                    callback: function(form, val) {
+                        old = val
+                        return (Hobo.fieldSetParam(el, val) + "&" + updateParams)
+                    },
+                    onFailure: function(resp) {
+                        alert(resp.responseText); el.innerHTML = old
+                    },
+                    onEnterEditMode: function() {
+                        var blank_message = el.getAttribute("hobo-blank-message")
+                        if (el.innerHTML.gsub("&nbsp;", " ") == blank_message) {
+                            el.innerHTML = ""
+                        } else {
+                            Hobo.ipeOldValues[el.id] = el.innerHTML
+                        }
                     }
-                }
-               }
+                   }
         Object.extend(opts, options)
         return new Ajax.InPlaceEditor(el, Hobo.putUrl(el), opts)
     },
@@ -220,14 +220,14 @@ var Hobo = {
         }
         select(".in-place-textfield-bhv").each(function (el) {
-            ipe = Hobo._makeInPlaceEditor(el)
+            var ipe = Hobo._makeInPlaceEditor(el)
             ipe.getText = function() {
                 return this.element.innerHTML.gsub(/<br\s*\/?>/, "\n").unescapeHTML()
             }
         })
         select(".in-place-textarea-bhv").each(function (el) {
-            ipe = Hobo._makeInPlaceEditor(el, {rows: 2})
+            var ipe = Hobo._makeInPlaceEditor(el, {rows: 2})
             ipe.getText = function() {
                 return this.element.innerHTML.gsub(/<br\s*\/?>/, "\n").unescapeHTML()
             }
@@ -259,12 +259,12 @@ var Hobo = {
         select("select.number-editor-bhv").each(function(el) {
             el.onchange = function() {
-                Hobo.ajaxSetFieldForElement(el, el.value)
+                Hobo.ajaxSetFieldForElement(el, $F(el))
             }
         })
         select(".autocomplete-bhv").each(function (el) {
-            options = {paramName: "query", minChars: 3, method: 'get' }
+            var options = {paramName: "query", minChars: 3, method: 'get' }
             if (el.hasClassName("autosubmit")) {
                 options.afterUpdateElement = function(el, item) { el.form.onsubmit(); }
             }
@@ -325,34 +325,50 @@ var Hobo = {
         return res
     },
     fadeObjectElement: function(el) {
-        new Effect.Fade(Hobo.objectElementFor(el),
-                        { duration: 0.5,
-                          afterFinish: function (ef) { ef.element.remove() } });
+        var fadeEl = Hobo.objectElementFor(el)
+        new Effect.Fade(fadeEl, { duration: 0.5, afterFinish: function (ef) {
+            ef.element.remove()
+        } });
+        Hobo.showEmptyMessageAfterLastRemove(fadeEl)
     },
     removeButton: function(el, url, updates, options) {
         if (options.fade == null) { options.fade = true; }
         if (options.confirm == null) { options.fade = "Are you sure?"; }
         if (options.confirm == false || confirm(options.confirm)) {
-            objEl = Hobo.objectElementFor(el)
+            var objEl = Hobo.objectElementFor(el)
             Hobo.showSpinner('Removing');
             function complete() {
                 if (options.fade) { Hobo.fadeObjectElement(el) }
                 Hobo.hideSpinner()
             }
             if (updates && updates.length > 0) {
-                new Hobo.ajaxRequest(url, "Removing", updates, { method:'delete',
-                                                                 onComplete: complete});
+                new Hobo.ajaxRequest(url, updates, { method:'delete', message: "Removing...", onComplete: complete});
             } else {
-                new Ajax.Request(url, {asynchronous:true, evalScripts:true, method:'delete',
-                                       onComplete: complete});
+                var ajaxOptions = {asynchronous:true, evalScripts:true, method:'delete', onComplete: complete}
+                if (typeof(formAuthToken) != "undefined") {
+                    ajaxOptions.parameters = formAuthToken.name + "=" + formAuthToken.value
+                }
+                new Ajax.Request(url, ajaxOptions);
             }
         }
     },
+    showEmptyMessageAfterLastRemove: function(el) {
+        var empty
+        var container = el.parentNode
+        if (container.getElementsByTagName(el.nodeName).length == 1 &&
+            (empty = container.next('.empty-collection-message'))) {
+            new Effect.Appear(empty, {delay:0.3})
+        }
+    },
     parseFieldId: function(el) {
         id = el.getAttribute("hobo-model-id")
         if (!id) return
@@ -360,6 +376,7 @@ var Hobo = {
         if (m) return { name: m[1], id: m[2], field: m[3] }
     },
     appendRow: function(el, rowSrc) {
         // IE friendly method to add a <tr> (from html source) to a table
         // el should be an element that contains *only* a table
@@ -368,6 +385,7 @@ var Hobo = {
         Hobo.applyEvents(el)
     },
     objectElementFor: function(el) {
         var m
         while(el.getAttribute) {
@@ -492,7 +510,7 @@ Element.Methods.$$ = function(e, css) {
 // --- has_many_through_input --- //
-HasManyThroughInput = Behavior.create({
+SelectManyInput = Behavior.create({
     initialize : function() {
         // onchange doesn't bubble in IE6 so...
@@ -500,15 +518,16 @@ HasManyThroughInput = Behavior.create({
     },
     addOne : function() {
-        var select = this.element.down('select')
+        var select = this.element.down('select')
         var selected = select.options[select.selectedIndex]
-        if (selected.style.display != "none" & selected.value != "") {
-            var newItem = DOM.Builder.fromHTML(this.element.down('.item-proto').innerHTML.strip())
+        if (selected.style.display != "none" & selected.text != "") {
+            var newItem = $(DOM.Builder.fromHTML(this.element.down('.item-proto').innerHTML.strip()))
             this.element.down('.items').appendChild(newItem);
             newItem.down('span').innerHTML = selected.innerHTML
-            newItem.down('input[type=hidden]').value = selected.innerHTML
+            this.itemAdded(newItem, selected)
             selected.style.display = 'none'
             select.value = ""
+            Event.addBehavior.reload()
         }
     },
@@ -525,12 +544,23 @@ HasManyThroughInput = Behavior.create({
         var label = el.down('span').innerHTML
         var option = $A(this.element.getElementsByTagName('option')).find(function(o) { return o.innerHTML == label })
         option.style.display = 'block'
+    },
+    itemAdded: function(item, option) {
+        this.hiddenField(item).value = option.innerHTML
+    },
+    hiddenField: function(item) {
+        return item.down('input[type=hidden]')
+        //return item.getElementsByClassName("hidden-field")[0]
     }
 })
 Event.addBehavior({
-    'div.has-many-through.input' : HasManyThroughInput(),
+    'div.select-many.input' : SelectManyInput(),
     '.association-count:click' : function(e) {
 	new Effect.ScrollTo('primary-collection', {duration: 1.0, offset: -20, transition: Effect.Transitions.sinoidal});
 	Event.stop(e);
@@ -538,11 +568,11 @@ Event.addBehavior({
     'form.filter-menu select:change': function(event) {
         var paramName = this.up('form').down('input[type=hidden]').value.gsub("-", "_")
         var params = {}
-        remove = [ 'page' ]
-	if (this.value == '') {
+        var remove = [ 'page' ]
+	if ($F(this) == '') {
             remove.push(paramName)
         } else {
-            params[paramName] = this.value
+            params[paramName] = $F(this)
 	}
 	location.href = Hobo.addUrlParams(params, {remove: remove})
     }