hobbit-contrib 0.0.1 → 0.1.0

data/spec/error_handling_and_filter_spec.rb

@@ -0,0 +1,140 @@
+require 'minitest_helper'
+
+describe 'combine Hobbit::ErrorHandling and Hobbit::Filter' do
+  include Hobbit::Contrib::Mock
+  include Rack::Test::Methods
+
+  describe 'when the exception ocurrs in a route' do
+    let(:app) do
+      mock_app do
+        include Hobbit::Filter
+        include Hobbit::ErrorHandling
+
+        error Exception do |exc|
+          exc.message
+        end
+
+        before do
+          env['hobbit.before'] = 'this is before'
+        end
+
+        after do
+          env['hobbit.after'] = 'this is after'
+        end
+
+        get '/' do
+          raise Exception, 'Sorry'
+        end
+      end
+    end
+
+    it 'must call the before filter' do
+      get '/'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'Sorry'
+      last_request.env.must_include 'hobbit.before'
+      last_request.env.wont_include 'hobbit.after'
+    end
+  end
+
+  describe 'when the exception ocurrs in a before filter' do
+    let(:app) do
+      mock_app do
+        include Hobbit::Filter
+        include Hobbit::ErrorHandling
+
+        error Exception do |exc|
+          exc.message
+        end
+
+        before do
+          raise Exception, 'Sorry'
+        end
+
+        after do
+          env['hobbit.after'] = 'this is after'
+        end
+
+        get '/' do
+          'this wont be the body'
+        end
+      end
+    end
+
+    it 'must call the before filter' do
+      get '/'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'Sorry'
+      last_request.env.wont_include 'hobbit.after'
+    end
+  end
+
+  describe 'when the exception ocurrs in an after filter' do
+    let(:app) do
+      mock_app do
+        include Hobbit::Filter
+        include Hobbit::ErrorHandling
+
+        error Exception do |exc|
+          exc.message
+        end
+
+        before do
+          env['hobbit.before'] = 'this is before'
+        end
+
+        after do
+          raise Exception, 'Sorry'
+        end
+
+        get '/' do
+          'this wont be the body'
+        end
+      end
+    end
+
+    it 'must call the before filter' do
+      get '/'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'Sorry'
+      last_request.env.must_include 'hobbit.before'
+    end
+  end
+
+  describe 'the order of the modules inclusion matters' do
+    describe 'when ErrorHandling is included before Filter' do
+      let(:app) do
+        mock_app do
+          include Hobbit::ErrorHandling
+          include Hobbit::Filter
+
+          error Exception do |exc|
+            exc.message
+          end
+
+          before do
+            env['hobbit.before'] = 'this is before'
+          end
+
+          after do
+            env['hobbit.after'] = 'this is after'
+          end
+
+          get '/' do
+            raise Exception, 'Sorry'
+          end
+        end
+      end
+
+      it 'wont work as expected' do
+        get '/'
+        last_response.must_be :ok?
+        last_response.body.must_equal 'Sorry'
+        last_request.env.must_include 'hobbit.before'
+        # this is contrary to a previous test, which is not the desired workflow
+        # or is it?
+        last_request.env.must_include 'hobbit.after'
+      end
+    end
+  end
+end

data/spec/error_handling_spec.rb

@@ -0,0 +1,94 @@
+require 'minitest_helper'
+
+describe Hobbit::ErrorHandling do
+  include Hobbit::Contrib::Mock
+  include Rack::Test::Methods
+
+  class NotFoundException < StandardError ; end
+
+  let(:app) do
+    mock_app do
+      include Hobbit::ErrorHandling
+
+      error Exception do |exception|
+        exception.message
+      end
+
+      error NotFoundException do
+        'Not Found'
+      end
+
+      get '/' do
+        'hello'
+      end
+
+      get '/raises' do
+        'not this'
+        raise Exception, 'Exception'
+      end
+
+      get '/other_raises' do
+        response.write 'not this'
+        raise NotFoundException
+      end
+    end
+  end
+
+  describe '::error' do
+    specify do
+      p = Proc.new { 'error' }
+      app = mock_app do
+        include Hobbit::ErrorHandling
+        error Exception, &p
+      end
+
+      app.to_app.class.errors.must_include Exception
+      app.to_app.class.errors[Exception].call.must_equal p.call
+    end
+  end
+
+  describe '::errors' do
+    it 'must return a Hash' do
+      app.to_app.class.errors.must_be_kind_of Hash
+    end
+  end
+
+  describe 'when does not raises an exception' do
+    it 'must work as expected' do
+      get '/'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'hello'
+    end
+  end
+
+  describe 'when raises an exception' do
+    it 'must call the block set in error' do
+      get '/raises'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'Exception'
+    end
+
+    it 'must allow to define more than one exception' do
+      get '/other_raises'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'Not Found'
+    end
+
+    it 'must set the returned value of the error block as the body' do
+      get '/other_raises'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'Not Found'
+      last_response.body.wont_equal 'not this'
+    end
+
+    it 'must override a previous block if a new one is passed' do
+      app.to_app.class.error Exception do
+        'other handler!'
+      end
+
+      get '/raises'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'other handler!'
+    end
+  end
+end

data/spec/filter_spec.rb

@@ -0,0 +1,101 @@
+require 'minitest_helper'
+
+describe Hobbit::Filter do
+  include Hobbit::Contrib::Mock
+  include Rack::Test::Methods
+
+  let(:app) do
+    mock_app do
+      include Hobbit::Filter
+
+      before do
+        env['hobbit.before'] = 'this is before'
+      end
+
+      get '/' do
+        'GET /'
+      end
+
+      after do
+        env['hobbit.after'] = 'this is after'
+      end
+    end
+  end
+
+  %w(after before).each do |kind|
+    str = <<EOS
+  describe '::#{kind}' do
+    specify do
+      p = Proc.new { 'do something' }
+      app = mock_app do
+        include Hobbit::Filter
+        #{kind}('', &p)
+      end
+
+      app.to_app.class.filters[:#{kind}].size.must_equal 1
+      app.to_app.class.filters[:#{kind}].first[:block].call.must_equal p.call
+    end
+  end
+
+  describe 'when a filter matches' do
+    it "must call the filters' block" do
+      get '/'
+      last_response.must_be :ok?
+      last_request.env.must_include 'hobbit.#{kind}'
+      last_request.env['hobbit.#{kind}'].must_equal 'this is #{kind}'
+    end
+  end
+EOS
+    class_eval str
+  end
+
+  describe '::filters' do
+    it 'must return a Hash' do
+      app.to_app.class.filters.must_be_kind_of Hash
+    end
+  end
+
+  it 'must call before and after filters' do
+    get '/'
+    last_response.must_be :ok?
+    last_request.env.must_include 'hobbit.before'
+    last_request.env['hobbit.before'].must_equal 'this is before'
+    last_request.env.must_include 'hobbit.after'
+    last_request.env['hobbit.after'].must_equal 'this is after'
+  end
+
+  describe 'when multiple filters are declared' do
+    let(:app) do
+      mock_app do
+        include Hobbit::Filter
+
+        before do
+          env['hobbit.before'] = 'this will match'
+        end
+
+        before '/' do
+          env['hobbit.before'] = 'this wont match'
+        end
+
+        after do
+          env['hobbit.after'] = 'this will match'
+        end
+
+        after '/' do
+          env['hobbit.after'] = 'this wont match'
+        end
+
+        get('/') { 'GET /' }
+      end
+    end
+
+    it 'must call the first that matches' do
+      get '/'
+      last_response.must_be :ok?
+      last_request.env.must_include 'hobbit.before'
+      last_request.env['hobbit.before'].must_equal 'this will match'
+      last_request.env.must_include 'hobbit.after'
+      last_request.env['hobbit.after'].must_equal 'this will match'
+    end
+  end
+end

data/spec/fixtures/render/views/hello.erb

@@ -0,0 +1,5 @@
+<!DOCTYPE html>
+<html>
+  <head><title>Hello <%= name %>!</title></head>
+  <body>Hello <%= name %>!</body>
+</html>

data/spec/fixtures/render/views/index.erb

@@ -0,0 +1,5 @@
+<!DOCTYPE html>
+<html>
+  <head><title>Hello World!</title></head>
+  <body>Hello World!</body>
+</html>

data/spec/minitest_helper.rb

@@ -3,6 +3,9 @@ ENV['RACK_ENV'] ||= 'test'
 require 'bundler'
 Bundler.require :default, ENV['RACK_ENV'].to_sym
 
+require 'coveralls'
+Coveralls.wear!
+
 require 'minitest/autorun'
 require 'rack'
 require 'rack/test'
@@ -10,5 +13,13 @@ require 'rack/test'
 require 'hobbit'
 require 'hobbit/contrib'
 
-# hobbit test apps
-require 'fixtures/test_enhanced_render_app/test_enhanced_render_app'
+module Hobbit
+  module Contrib
+    module Mock
+      def mock_app(&block)
+        app = Class.new Hobbit::Base, &block
+        app.new
+      end
+    end
+  end
+end

data/spec/render_spec.rb

@@ -0,0 +1,33 @@
+require 'minitest_helper'
+
+describe Hobbit::Render do
+  include Hobbit::Contrib::Mock
+  include Rack::Test::Methods
+
+  def app
+    mock_app do
+      include Hobbit::Render
+
+      def name
+        'Hobbit'
+      end
+
+      get('/') { render File.expand_path('../fixtures/render/views/index.erb', __FILE__) }
+      get('/using-context') { render File.expand_path('../fixtures/render/views/hello.erb', __FILE__) }
+    end
+  end
+
+  describe '#render' do
+    it 'must render a template' do
+      get '/'
+      last_response.must_be :ok?
+      last_response.body.must_match /Hello World!/
+    end
+
+    it 'must use the app as context' do
+      get '/using-context'
+      last_response.must_be :ok?
+      last_response.body.must_match /Hello Hobbit!/
+    end
+  end
+end

data/spec/session_spec.rb

@@ -0,0 +1,33 @@
+require 'minitest_helper'
+
+describe Hobbit::Session do
+  include Hobbit::Contrib::Mock
+  include Rack::Test::Methods
+
+  def app
+    mock_app do
+      include Hobbit::Session
+      use Rack::Session::Cookie, secret: SecureRandom.hex(64)
+
+      get '/' do
+        session[:name] = 'hobbit'
+      end
+
+      get '/name' do
+        session[:name]
+      end
+    end
+  end
+
+  describe '#session' do
+    it 'must return a session object' do
+      get '/'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'hobbit'
+
+      get '/name'
+      last_response.must_be :ok?
+      last_response.body.must_equal 'hobbit'
+    end
+  end
+end

metadata

@@ -1,23 +1,37 @@
 --- !ruby/object:Gem::Specification
 name: hobbit-contrib
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Patricio Mac Adden
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-17 00:00:00.000000000 Z
+date: 2013-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: hobbit
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+- !ruby/object:Gem::Dependency
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -25,19 +39,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: hobbit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +94,48 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: tilt
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: hobbit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: tilt
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Contributed Hobbit extensions
 email:
 - patriciomacadden@gmail.com
@@ -94,16 +150,29 @@ files:
 - README.md
 - Rakefile
 - hobbit-contrib.gemspec
+- lib/hobbit/asset_tag.rb
 - lib/hobbit/contrib.rb
 - lib/hobbit/contrib/version.rb
 - lib/hobbit/enhanced_render.rb
+- lib/hobbit/environment.rb
+- lib/hobbit/error_handling.rb
+- lib/hobbit/filter.rb
+- lib/hobbit/render.rb
+- lib/hobbit/session.rb
+- spec/asset_tag_spec.rb
 - spec/enhanced_render_spec.rb
-- spec/fixtures/test_enhanced_render_app.rb
-- spec/fixtures/test_enhanced_render_app/test_enhanced_render_app.rb
-- spec/fixtures/test_enhanced_render_app/views/_partial.erb
-- spec/fixtures/test_enhanced_render_app/views/index.erb
-- spec/fixtures/test_enhanced_render_app/views/layouts/layout.erb
+- spec/environment_spec.rb
+- spec/error_handling_and_filter_spec.rb
+- spec/error_handling_spec.rb
+- spec/filter_spec.rb
+- spec/fixtures/enhanced_render/views/_partial.erb
+- spec/fixtures/enhanced_render/views/index.erb
+- spec/fixtures/enhanced_render/views/layouts/layout.erb
+- spec/fixtures/render/views/hello.erb
+- spec/fixtures/render/views/index.erb
 - spec/minitest_helper.rb
+- spec/render_spec.rb
+- spec/session_spec.rb
 homepage: ''
 licenses:
 - MIT
@@ -129,10 +198,17 @@ signing_key:
 specification_version: 4
 summary: Contributed Hobbit extensions
 test_files:
+- spec/asset_tag_spec.rb
 - spec/enhanced_render_spec.rb
-- spec/fixtures/test_enhanced_render_app.rb
-- spec/fixtures/test_enhanced_render_app/test_enhanced_render_app.rb
-- spec/fixtures/test_enhanced_render_app/views/_partial.erb
-- spec/fixtures/test_enhanced_render_app/views/index.erb
-- spec/fixtures/test_enhanced_render_app/views/layouts/layout.erb
+- spec/environment_spec.rb
+- spec/error_handling_and_filter_spec.rb
+- spec/error_handling_spec.rb
+- spec/filter_spec.rb
+- spec/fixtures/enhanced_render/views/_partial.erb
+- spec/fixtures/enhanced_render/views/index.erb
+- spec/fixtures/enhanced_render/views/layouts/layout.erb
+- spec/fixtures/render/views/hello.erb
+- spec/fixtures/render/views/index.erb
 - spec/minitest_helper.rb
+- spec/render_spec.rb
+- spec/session_spec.rb

data/spec/fixtures/test_enhanced_render_app/test_enhanced_render_app.rb

@@ -1,25 +0,0 @@
-class TestEnhancedRenderApp < Hobbit::Base
-  include Hobbit::EnhancedRender
-
-  # we do this because it the layout path is relative to file being run
-  def layout_path(template)
-    File.expand_path("../#{super}", __FILE__)
-  end
-
-  # we do this because it the view path is relative to file being run
-  def view_path(template)
-    File.expand_path("../#{super}", __FILE__)
-  end
-
-  get '/' do
-    render 'index', {}, layout: 'layout'
-  end
-
-  get '/without-layout' do
-    render 'index'
-  end
-
-  get '/partial' do
-    partial 'partial'
-  end
-end

data/spec/fixtures/test_enhanced_render_app.rb

@@ -1,25 +0,0 @@
-class TestEnhancedRenderApp < Hobbit::Base
-  include Hobbit::EnhancedRender
-
-  # we do this because it the layout path is relative to file being run
-  def layout_path(template)
-    File.expand_path("../#{super}", __FILE__)
-  end
-
-  # we do this because it the view path is relative to file being run
-  def view_path(template)
-    File.expand_path("../#{super}", __FILE__)
-  end
-
-  get '/' do
-    render 'index', {}, layout: 'layout'
-  end
-
-  get '/without-layout' do
-    render 'index'
-  end
-
-  get '/partial' do
-    partial 'partial'
-  end
-end