hoardable 0.18.2 → 0.19.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa8fcbadc193fbfcbdb4efa5f1030c2ff5a6be1da19b672136ca0ce5a4bfd846
-  data.tar.gz: 57b7f6fcbe331e181be56a4e8d284bed7ba322c9cb42280917a684e99ae53c0f
+  metadata.gz: affe4a55357ac085a712046c50d2742c7f1887947dee2a7e4d221cf5c7fd7086
+  data.tar.gz: 7b2112637801d32e5f18a93d3aa54077e631d25fd9ef6a85639770910d87024b
 SHA512:
-  metadata.gz: f4adc32f25af165fc80a53b0982b392dc4878ff3b6afcf1f9f892d75acac859c3b8bf1d9a292e9578da25926b349e380e92dd2d06e8bcb683239e0a7b4ddb95e
-  data.tar.gz: a076911d80e94a764992716188f35dfe5893662e908d40d7f2b7c48305d3188554a494f5c0fd6d598161a16b52abd53a392cf85e29d927535624d25de3ae3b2a
+  metadata.gz: dfdf425df919edd8abce1942108881469c3c29b4e3e0ac9641ab56c221a6c0496f73ae7b6c657aa3edf33ae31b265e15d245e1e4d6e41fedbcbc7983af0657f9
+  data.tar.gz: 04b2495a301dd95bdd8d7f4af56ea6cf6dac682d7da59e59dee6d40ed031451410344a34f9580551047985009fc17e5ce1ac0e6d83c0a6f531ec071e932788d7

data/CHANGELOG.md

@@ -1,3 +1,27 @@
+## 0.19.2
+
+- Consult `inheritance_column` when constructing default scope
+
+## 0.19.1
+
+- Thread-safety support added for `with_hoardable_config`.
+
+## 0.19.0
+
+- Ensure that stateful Hoardable class methods `with`, `travel_to` and `at` are thread-safe.
+
+## 0.18.2
+
+- Fix for using `update_all` with Hoardable records.
+
+## 0.18.1
+
+- Support for STI models.
+
+## 0.18.0
+
+- Improved compatibilty with using `ActiveRecord` relationship caching when not using `Hoardable.at`.
+
 ## 0.17.0
 
 - Much improved performance of setting `hoardable_id` for versions.

data/Gemfile

@@ -2,7 +2,12 @@
 
 source "https://rubygems.org"
 
+gem "bigdecimal"
 gem "debug"
+gem "drb"
+gem "logger"
+gem "mutex_m"
+gem "ostruct"
 if (rails_version = ENV["RAILS_VERSION"])
   gem "rails", "~> #{rails_version}"
 else

data/lib/hoardable/arel_visitors.rb

@@ -46,7 +46,7 @@ module Hoardable
         hoardable_maybe_add_only(left, collector)
       else
         return unless left.instance_variable_get("@klass").in?(Hoardable::REGISTRY)
-        return if Hoardable.instance_variable_get("@at")
+        return if Thread.current[:hoardable_at]
 
         collector << "ONLY "
       end

data/lib/hoardable/database_client.rb

@@ -28,9 +28,7 @@ module Hoardable
     end
 
     def find_or_initialize_hoardable_event_uuid
-      Thread.current[:hoardable_event_uuid] ||= (
-        ActiveRecord::Base.connection.query("SELECT gen_random_uuid();")[0][0]
-      )
+      Thread.current[:hoardable_event_uuid] ||= SecureRandom.uuid
     end
 
     def initialize_version_attributes(operation)
@@ -56,7 +54,7 @@ module Hoardable
     end
 
     def has_one_at_timestamp
-      Hoardable.instance_variable_get("@at") || source_record.updated_at
+      Thread.current[:hoardable_at] || source_record.updated_at
     rescue NameError
       raise(UpdatedAtColumnMissingError, source_record.class.table_name)
     end
@@ -93,7 +91,7 @@ module Hoardable
     end
 
     def initialize_temporal_range
-      upper_bound = Hoardable.instance_variable_get("@travel_to") || Time.now.utc
+      upper_bound = Thread.current[:hoardable_travel_to] || Time.now.utc
       lower_bound = (previous_temporal_tsrange_end || hoardable_source_epoch)
 
       if upper_bound < lower_bound

data/lib/hoardable/engine.rb

@@ -6,7 +6,7 @@ module Hoardable
 
   # Symbols for use with setting contextual data, when creating versions. See
   # {file:README.md#tracking-contextual-data README} for more.
-  DATA_KEYS = %i[meta whodunit event_uuid].freeze
+  DATA_KEYS = %i[meta whodunit].freeze
 
   # Symbols for use with setting {Hoardable} configuration. See {file:README.md#configuration
   # README} for more.
@@ -44,13 +44,13 @@ module Hoardable
 
   class << self
     CONFIG_KEYS.each do |key|
-      define_method(key) { @config[key] }
+      define_method(key) { hoardable_config[key] }
 
       define_method("#{key}=") { |value| @config[key] = value }
     end
 
     DATA_KEYS.each do |key|
-      define_method(key) { @context[key] }
+      define_method(key) { hoardable_context[key] }
 
       define_method("#{key}=") { |value| @context[key] = value }
     end
@@ -60,14 +60,23 @@ module Hoardable
     #
     # @param hash [Hash] config and contextual data to set within a block
     def with(hash)
-      current_config = @config
-      current_context = @context
-      @config = current_config.merge(hash.slice(*CONFIG_KEYS))
-      @context = current_context.merge(hash.slice(*DATA_KEYS))
+      thread = Thread.current
+      current_thread_config = thread[:hoardable_config]
+      current_thread_context = thread[:hoardable_context]
+      thread[:hoardable_config] = hoardable_config.merge(hash.slice(*CONFIG_KEYS))
+      thread[:hoardable_context] = hoardable_context.merge(hash.slice(*DATA_KEYS))
       yield
     ensure
-      @config = current_config
-      @context = current_context
+      thread[:hoardable_config] = current_thread_config
+      thread[:hoardable_context] = current_thread_context
+    end
+
+    private def hoardable_config
+      @config.merge(Thread.current[:hoardable_config] ||= {})
+    end
+
+    private def hoardable_context
+      @context.merge(Thread.current[:hoardable_context] ||= {})
     end
 
     # Allows performing a query for record states at a certain time. Returned {SourceModel}
@@ -75,20 +84,22 @@ module Hoardable
     #
     # @param datetime [DateTime, Time] the datetime or time to temporally query records at
     def at(datetime)
-      @at = datetime
+      thread = Thread.current
+      thread[:hoardable_at] = datetime
       yield
     ensure
-      @at = nil
+      thread[:hoardable_at] = nil
     end
 
     # Allows calling code to set the upper bound for the temporal range for recorded audits.
     #
     # @param datetime [DateTime] the datetime to temporally record versions at
     def travel_to(datetime)
-      @travel_to = datetime
+      thread = Thread.current
+      thread[:hoardable_travel_to] = datetime
       yield
     ensure
-      @travel_to = nil
+      thread[:hoardable_travel_to] = nil
     end
 
     # @!visibility private

data/lib/hoardable/has_many.rb

@@ -13,8 +13,8 @@ module Hoardable
       end
 
       private def hoardable_scope
-        if Hoardable.instance_variable_get("@at") &&
-             (hoardable_id = @association.owner.hoardable_id)
+        if Thread.current[:hoardable_at]
+          (hoardable_id = @association.owner.hoardable_id)
           @association.scope.rewhere(@association.reflection.foreign_key => hoardable_id)
         else
           @association.scope
@@ -36,7 +36,7 @@ module Hoardable
         # {HasManyExtension} scope is always used when using {Hoardable.at}.
         class_eval <<-RUBY, __FILE__, __LINE__ + 1
           def #{args.first}
-            if Hoardable.instance_variable_get("@at")
+            if Thread.current[:hoardable_at]
               super.extending
             else
               super

data/lib/hoardable/model.rb

@@ -9,9 +9,6 @@ module Hoardable
     extend ActiveSupport::Concern
 
     class_methods do
-      # @!visibility private
-      attr_reader :_hoardable_config
-
       # If called with a hash, this will set the model-level +Hoardable+ configuration variables. If
       # called without an argument it will return the computed +Hoardable+ configuration considering
       # both model-level and global values.
@@ -23,10 +20,7 @@ module Hoardable
         if hash
           @_hoardable_config = hash.slice(*CONFIG_KEYS)
         else
-          @_hoardable_config ||= {}
-          CONFIG_KEYS.to_h do |key|
-            [key, @_hoardable_config.key?(key) ? @_hoardable_config[key] : Hoardable.send(key)]
-          end
+          CONFIG_KEYS.to_h { |key| [key, _hoardable_config.fetch(key) { Hoardable.send(key) }] }
         end
       end
 
@@ -36,11 +30,20 @@ module Hoardable
       # @param hash [Hash] The +Hoardable+ configuration for the model. Keys must be present in
       #   {CONFIG_KEYS}
       def with_hoardable_config(hash)
-        current_config = @_hoardable_config
-        @_hoardable_config = hash.slice(*CONFIG_KEYS)
+        thread = Thread.current
+        current_thread_config = thread[hoardable_current_config_key]
+        thread[hoardable_current_config_key] = _hoardable_config.merge(hash.slice(*CONFIG_KEYS))
         yield
       ensure
-        @_hoardable_config = current_config
+        thread[hoardable_current_config_key] = current_thread_config
+      end
+
+      private def _hoardable_config
+        (@_hoardable_config ||= {}).merge(Thread.current[hoardable_current_config_key] ||= {})
+      end
+
+      private def hoardable_current_config_key
+        "hoardable_#{name}_config".to_sym
       end
     end
 

data/lib/hoardable/scopes.rb

@@ -14,15 +14,15 @@ module Hoardable
       default_scope do
         scope =
           (
-            if (hoardable_at = Hoardable.instance_variable_get("@at"))
+            if (hoardable_at = Thread.current[:hoardable_at])
               at(hoardable_at)
             else
               exclude_versions
             end
           )
-        next scope unless klass == version_class && "type".in?(column_names)
+        next scope unless klass == version_class && superclass.inheritance_column.in?(column_names)
 
-        scope.where(type: superclass.sti_name)
+        scope.where(superclass.inheritance_column => superclass.sti_name)
       end
 
       # @!scope class

data/lib/hoardable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hoardable
-  VERSION = "0.18.2"
+  VERSION = "0.19.2"
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: hoardable
 version: !ruby/object:Gem::Version
-  version: 0.18.2
+  version: 0.19.2
 platform: ruby
 authors:
 - justin talbott
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-01-19 00:00:00.000000000 Z
+date: 2025-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -162,7 +161,6 @@ metadata:
   homepage_uri: https://github.com/waymondo/hoardable
   source_code_uri: https://github.com/waymondo/hoardable
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -177,8 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: An ActiveRecord extension for versioning and soft-deletion of records in
   Postgres