hoardable 0.18.1 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36d1113a71b72492244fadc8172ef4a08f28bdff546b7344bb385ce38e82ecbd
-  data.tar.gz: a4cee0c629c4c1d59f6c0b632c0499fc5e094e099c7e0dc4bf3e0d79271f6eb8
+  metadata.gz: 12ee4c5fbbd0b35bda5c9b7427015a1d60ca9cc919ac992caca386d4c3664163
+  data.tar.gz: 0020d7f28b85fb70efc3a1b80695f1e9c69f60c954b6aeccb71cedadccb97e0c
 SHA512:
-  metadata.gz: 3cb288b7dbd5938056d3fd5fae396ad6d7caca20a98902ebb228a75d4c05d5e689807ea90f4e6f96dc5e1ac20bbb028fa12717676da3f60163ca4a362bf33db1
-  data.tar.gz: 44bba102025a18563d29d76430d27f06299316d69b37e08fa3b216453dfe6c4890f82e6f065843c127cf26fb0da39f7ce76194d2e31dc2bd0021d9973e6c9748
+  metadata.gz: 2fe01feb0e5260d8072f4a45640517a5041a83c566db15b45cc32d141fa8883cf84a1bec16b8ec043a6b914b28e0e824d1e2820454756501941831613efe95a7
+  data.tar.gz: ceef85ede42a50189fb41de31fe0d4ab6882c2139d825569cd674fdf9611f89fd96721156cad5dee347359f67ecba68d8e9a794c2c6513710a39c2e599975668

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+## 0.19.0
+
+- Ensure that stateful Hoardable class methods `with`, `travel_to` and `at` are thread-safe.
+
+## 0.18.2
+
+- Fix for using `update_all` with Hoardable records.
+
+## 0.18.1
+
+- Support for STI models.
+
+## 0.18.0
+
+- Improved compatibilty with using `ActiveRecord` relationship caching when not using `Hoardable.at`.
+
 ## 0.17.0
 
 - Much improved performance of setting `hoardable_id` for versions.

data/lib/hoardable/arel_crud.rb

@@ -0,0 +1,17 @@
+module Hoardable
+  # Monkey-patches an internal Arel method to ensure that bulk UPDATE's always operate
+  # directly on the root table by injecting the ONLY keyword.
+  module ArelCrud
+    def compile_update(*args)
+      um = super(*args)
+
+      if source.left.instance_variable_get(:@klass).in?(Hoardable::REGISTRY)
+        return um.table(Arel.sql("ONLY #{source.left.name}"))
+      end
+
+      um
+    end
+  end
+end
+
+Arel::SelectManager.prepend Hoardable::ArelCrud

data/lib/hoardable/arel_visitors.rb

@@ -46,7 +46,7 @@ module Hoardable
         hoardable_maybe_add_only(left, collector)
       else
         return unless left.instance_variable_get("@klass").in?(Hoardable::REGISTRY)
-        return if Hoardable.instance_variable_get("@at")
+        return if Thread.current[:hoardable_at]
 
         collector << "ONLY "
       end

data/lib/hoardable/database_client.rb

@@ -56,7 +56,7 @@ module Hoardable
     end
 
     def has_one_at_timestamp
-      Hoardable.instance_variable_get("@at") || source_record.updated_at
+      Thread.current[:hoardable_at] || source_record.updated_at
     rescue NameError
       raise(UpdatedAtColumnMissingError, source_record.class.table_name)
     end
@@ -93,7 +93,7 @@ module Hoardable
     end
 
     def initialize_temporal_range
-      upper_bound = Hoardable.instance_variable_get("@travel_to") || Time.now.utc
+      upper_bound = Thread.current[:hoardable_travel_to] || Time.now.utc
       lower_bound = (previous_temporal_tsrange_end || hoardable_source_epoch)
 
       if upper_bound < lower_bound

data/lib/hoardable/engine.rb

@@ -44,13 +44,19 @@ module Hoardable
 
   class << self
     CONFIG_KEYS.each do |key|
-      define_method(key) { @config[key] }
+      define_method(key) do
+        local_config = Thread.current[:hoardable_config] || @config
+        local_config[key]
+      end
 
       define_method("#{key}=") { |value| @config[key] = value }
     end
 
     DATA_KEYS.each do |key|
-      define_method(key) { @context[key] }
+      define_method(key) do
+        local_context = Thread.current[:hoardable_context] || @context
+        local_context[key]
+      end
 
       define_method("#{key}=") { |value| @context[key] = value }
     end
@@ -60,14 +66,13 @@ module Hoardable
     #
     # @param hash [Hash] config and contextual data to set within a block
     def with(hash)
-      current_config = @config
-      current_context = @context
-      @config = current_config.merge(hash.slice(*CONFIG_KEYS))
-      @context = current_context.merge(hash.slice(*DATA_KEYS))
+      thread = Thread.current
+      thread[:hoardable_config] = @config.merge(hash.slice(*CONFIG_KEYS))
+      thread[:hoardable_context] = @context.merge(hash.slice(*DATA_KEYS))
       yield
     ensure
-      @config = current_config
-      @context = current_context
+      thread[:hoardable_config] = nil
+      thread[:hoardable_context] = nil
     end
 
     # Allows performing a query for record states at a certain time. Returned {SourceModel}
@@ -75,20 +80,22 @@ module Hoardable
     #
     # @param datetime [DateTime, Time] the datetime or time to temporally query records at
     def at(datetime)
-      @at = datetime
+      thread = Thread.current
+      thread[:hoardable_at] = datetime
       yield
     ensure
-      @at = nil
+      thread[:hoardable_at] = nil
     end
 
     # Allows calling code to set the upper bound for the temporal range for recorded audits.
     #
     # @param datetime [DateTime] the datetime to temporally record versions at
     def travel_to(datetime)
-      @travel_to = datetime
+      thread = Thread.current
+      thread[:hoardable_travel_to] = datetime
       yield
     ensure
-      @travel_to = nil
+      thread[:hoardable_travel_to] = nil
     end
 
     # @!visibility private

data/lib/hoardable/has_many.rb

@@ -13,8 +13,8 @@ module Hoardable
       end
 
       private def hoardable_scope
-        if Hoardable.instance_variable_get("@at") &&
-             (hoardable_id = @association.owner.hoardable_id)
+        if Thread.current[:hoardable_at]
+          (hoardable_id = @association.owner.hoardable_id)
           @association.scope.rewhere(@association.reflection.foreign_key => hoardable_id)
         else
           @association.scope
@@ -36,7 +36,7 @@ module Hoardable
         # {HasManyExtension} scope is always used when using {Hoardable.at}.
         class_eval <<-RUBY, __FILE__, __LINE__ + 1
           def #{args.first}
-            if Hoardable.instance_variable_get("@at")
+            if Thread.current[:hoardable_at]
               super.extending
             else
               super

data/lib/hoardable/scopes.rb

@@ -14,7 +14,7 @@ module Hoardable
       default_scope do
         scope =
           (
-            if (hoardable_at = Hoardable.instance_variable_get("@at"))
+            if (hoardable_at = Thread.current[:hoardable_at])
               at(hoardable_at)
             else
               exclude_versions

data/lib/hoardable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hoardable
-  VERSION = "0.18.1"
+  VERSION = "0.19.0"
 end

data/lib/hoardable.rb

@@ -4,6 +4,7 @@ require "active_record"
 require "fx"
 require_relative "hoardable/version"
 require_relative "hoardable/arel_visitors"
+require_relative "hoardable/arel_crud"
 require_relative "hoardable/schema_statements"
 require_relative "hoardable/schema_dumper"
 require_relative "hoardable/engine"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hoardable
 version: !ruby/object:Gem::Version
-  version: 0.18.1
+  version: 0.19.0
 platform: ruby
 authors:
 - justin talbott
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-01-15 00:00:00.000000000 Z
+date: 2025-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -17,6 +17,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -24,6 +27,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '9'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -31,6 +37,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -38,6 +47,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '9'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -45,6 +57,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -52,6 +67,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '9'
 - !ruby/object:Gem::Dependency
   name: fx
   requirement: !ruby/object:Gem::Requirement
@@ -116,6 +134,7 @@ files:
 - lib/generators/hoardable/triggers/set_hoardable_id.sql
 - lib/generators/hoardable/triggers/versions_prevent_update.sql
 - lib/hoardable.rb
+- lib/hoardable/arel_crud.rb
 - lib/hoardable/arel_visitors.rb
 - lib/hoardable/associations.rb
 - lib/hoardable/belongs_to.rb