hnruby 0.01.1 → 0.01.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6f1b2d89d4f5fc0c1382e12b0f61a013a44e82a8
-  data.tar.gz: dd86d0841ee82738e9a979d4ae1f087243c6efd7
+  metadata.gz: 4b6d68737114cfb703d4d7007b6719583bc99331
+  data.tar.gz: 4f93b627eb99063c28fc9a0e870e87d399663e7d
 SHA512:
-  metadata.gz: 80972f3f6816814943d8e1ac34a94a471a530ac5381b7df20bb1d17fa9facf26f4b2d895d1fe94b94a5f43e921e3cee6e666aa8b537540b2298e0836d35f2ec9
-  data.tar.gz: f5c38130b920c884734d4bbc7f1855d13aea976b32173b658e4acd9263569359fe0b4fda73a6feb5ffbb2ccc067930c4289b298d7e5f2f7e6f7a5b437645478f
+  metadata.gz: f2404fb955d07e5aa329766ba34d4561e5e04d20aa49930d759a787152e05dfb62401157bd7b15ea3438076fc04c78bf2999f6cf38453f4826b1c0be61ce40d5
+  data.tar.gz: 3ffe6c85c9e4df51dabf563a270a8c863f26b8238d0ec79179ba5b9e9bda930a032c4843dc912fd265c6da67d4226a4d1d5bf7c09e88f3ebbafab6d1910c81ad

data/lib/hnruby/comment.rb

@@ -57,44 +57,49 @@ class Comment
 
 	# Returns true if +comment+ is a child of +self+.
 	def parent_of?(comment)
-		comment.parent && comment.parent.id == @id
+		if comment.respond_to?(:parent)
+			comment.parent && comment.parent.id == @id
+		end
 	end
 
 	# Returns true if +self+ is a child of +comment+.
 	def child_of?(comment)
-		@parent && @parent.id == comment.id
+		@parent && comment.respond_to?(:id) && @parent.id == comment.id
 	end
 
-	# :nodoc:
-	def inspect
-		"<Comment> by #{@submitter} at #{@time}"
+	# Returns 1 if +self+ is older than +comment+, and -1 if +comment+ is older
+	# than +self+. Since comments can't be exactly the same age, never returns 0.
+	#
+	# If +comment+ isn't actually a Comment, returns +nil+.
+	def <=>(comment) #Since IDs are sequential, this sorts by time
+		comment.respond_to?(:id) && comment.id <=> @id
 	end
 
-	def <=>(comment)
-		left, right = [self, comment].map do |i|
-			i.time.split[0].to_i * {
-					"minute" => 60,    "minutes" => 60,
-					"hour"   => 3600,  "hours"   => 3600,
-					"day"    => 86400, "days"    => 86400
-			}[i.time.split[1]]
-		end
-
-		-(right <=> left)
+	# :nodoc:
+	def inspect
+		"<Comment> by #{@submitter}, #{@time}"
 	end
 end
 
 # Represents the list of comments pertaining to a particluar HN story.
 class CommentPage
 	include Enumerable
-	# Represents the title of
+	# Returns this comment page's title.
 	attr_reader :title
+	# Returns the URL for this comment page on Hacker News.
 	attr_reader :url
 
 	# Returns a new CommentPage corresponding to <tt>url</tt>.
 	#  cpage = HackerNews::CommentPage.new\
 	#  "https://news.ycombinator.com/item?id=6621679"	#=> "C--" <12 Comments>
+	#
+	# Alternately, if passed an integer, returns the CommentPage corresponding to
+	# the story whose ID is +url+.
+	#  cpage = HackerNews::CommentPage.new 6621679	#=> "C--" <12 Comments>
 	def initialize(url)
-		html = Nokogiri::HTML open(url)
+		url = "#{HN_URL}/item?id=#{url.to_i}" if url.is_a? Numeric
+
+		html = Nokogiri::HTML(open(url), nil, "UTF-8")
 		@title = html.title.chomp " | Hacker News"
 		@url = url
 

data/lib/hnruby/storylist.rb

@@ -20,7 +20,7 @@ module StoryList
 private
 	def self.update_page(index)
 		url = HN_URL + "#{"news#{index}" if index > 1}"
-		html = (Nokogiri::HTML(open(url)) / "tr").to_a[4..-6]
+		html = (Nokogiri::HTML(open(url), nil, "UTF-8") / "tr").to_a[4..-6]
 
 		(0...html.length).step(3) do |i|
 			item = NewsItem.new(html[i], html[i + 1])
@@ -32,7 +32,7 @@ public
 	#Clear story cache--- any actual NewsItem objects will still need to be
 	#updated, though.
 	def self.update
-		@@items = {}
+		@@items.clear
 	end
 
 	# If <tt>index</tt> is a number, returns a NewsItem representing the story
@@ -53,7 +53,7 @@ public
 		elsif i.is_a? Enumerable
 			self.stories i
 		else
-			raise TypeError
+			raise TypeError, "#{i.class} objects cannot be used to access stories"
 		end
 	end
 

data/test/test_hackernews.rb

@@ -45,6 +45,10 @@ class TestHackerNews < Test::Unit::TestCase
 	def test_comments
 		cpage = HackerNews::CommentPage.new File.dirname(__FILE__)+"/commentpage.html"
 
+		assert_equal 6640155, cpage.sort.first.id
+		assert_equal 6637431, cpage.sort.last.id
+		assert_equal 6638715, cpage.sort[20].id
+
 		first = cpage[0]
 
 		assert_equal 0, first.depth

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hnruby
 version: !ruby/object:Gem::Version
-  version: 0.01.1
+  version: 0.01.2
 platform: ruby
 authors:
 - Jem Orgun
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-01 00:00:00.000000000 Z
+date: 2013-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-terminfo
@@ -95,3 +95,4 @@ specification_version: 4
 summary: Hacker News scraper
 test_files:
 - test/test_hackernews.rb
+has_rdoc: