hnposts 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e82d7afe6c2a5c9fc820bb04b2b052a946f638b7
-  data.tar.gz: 298908d01dc037d5a236d310edb4ae60d34822ec
+  metadata.gz: 6efac427f24d1a4408cb79efb8df017f806f636f
+  data.tar.gz: c8fcdd42c307d8beadb2d8279fb86b28a648318b
 SHA512:
-  metadata.gz: e30d29de112fcef550d19e4d3597719381b8dcb4c9213290ec87d15f01854c72454200598c5b0e1babb09bafb50a16521e2c56b4b5da5ceab627d1f092919983
-  data.tar.gz: 580dd518c0f95e2be4bc9e19517552f0e7cb2c8c7fa0af24d0db63530961679a154ef1f5794a0788d38d507d453b70777e2062ebbff5d17cee86a27c3ad00b48
+  metadata.gz: a19a144f7781967260b796493554dd3264dcbd5259cf6051e910527402d78b7a4463c8e65f0e0ab3d95944ea5a0a422294c4c51c9830d49fa291fd2c049b2d00
+  data.tar.gz: c3776341b87d9bdd3455a7708880ac55be6287cf1ed710d146dab3cc28c1a900cb871ff2620d241074557f0ea9e4faaac447dc2a1e4ead489a86e039cb4d79ed

data/lib/hnposts/fetcher.rb

@@ -4,59 +4,63 @@ module HNPosts
 
     HN_URL = "https://news.ycombinator.com/"
 
-    def initialize
-      @hn_doc = Nokogiri::HTML(_contents)
-    end
-
     def fetch_posts
-      return @posts if @posts
-      
-      post_ids, titles, urls, points, comments = _post_ids, _titles, _urls, _points, _comments
-      post_count = post_ids.size
-      @posts = (0...post_count).collect do | indx |
-        Post.new post_id: post_ids[indx],
-                 title: titles[indx],
-                 url: urls[indx],
-                 points: points[indx],
-                 comments: comments[indx],
-                 position: (indx + 1)
+      posts = []
+      post_nodes = Nokogiri::HTML(contents).css('td[class=title]:nth-of-type(3)').map {|n| n.parent}
+
+      post_nodes.each_with_index do | node, indx |
+        posts << Post.new({
+                           post_id: (post_id node),
+                           title: (title node),
+                           url: (url node),
+                           points: (points node),
+                           comments: (comments node),
+                           position: (indx + 1)
+                         })
       end
+
+      posts
     end
       
     private
 
-    attr_reader :hn_doc
-
-    def _post_ids
-      hn_doc.css('td > center > a').collect { |tag| /up_(\d+)/.match(tag.attributes['id'].value)[1] }
+    def post_id tr
+      vote_node = tr.css('td > center > a')[0]
+      title_node = tr.css('td[class=title] > a')[0]
+      if vote_node
+        /^up_(\d+)$/.match(vote_node.attributes['id'])[1]
+      else
+        /^item\?id=(\d+)$/.match(title_node.attributes['href'])[1]
+      end
     end
     
-    def _titles
-      hn_doc.css('td[class=title] a').collect { |tag| tag.text.strip }
+    def title tr
+      tr.css('td[class=title] > a')[0].text.strip
     end
 
-    def _urls
-      hn_doc.css('td[class=title] a').collect { |tag| tag.attributes['href'].value }
+    def url tr
+      href = tr.css('td[class=title] > a')[0].attributes['href'].value
+      /^item\?id=\d+$/ =~ href ? HN_URL + href : href
     end
 
-    def _points
-      hn_doc.css('td[class=subtext] span').collect { |tag| tag.text[/\d+/].to_i }
+    def points tr
+      result = tr.next_sibling.css('span')[0]
+      result &&= /^(\d+) points$/.match(result.text)
+      result &&= result[1]
+      result.to_i
     end
 
-    def _comments
-      cntr = 0
-      hn_doc.css('td[class=subtext] a').reduce([]) do | acc, tag |
-        acc.tap do |acc|
-          acc << tag.text[/\d+/].to_i if cntr.odd?
-          cntr = cntr.next
-        end
-      end
+    def comments tr
+      result = tr.next_sibling.css('a')[1]
+      result &&= /^(\d+) comments$/.match(result.text)
+      result &&= result[1]
+      result.to_i
     end
     
-    def _contents
+    def contents
       open(HN_URL)
     end
-    
+
   end
 
 end

data/lib/hnposts/version.rb

@@ -1,3 +1,3 @@
 module HNPosts
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hnposts
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Sankaranarayanan Viswanathan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-15 00:00:00.000000000 Z
+date: 2014-01-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler