hn 0.0.6 → 0.0.7

data/README.md

@@ -16,6 +16,13 @@ And then execute:
 
     $ bundle
 
+## Issues
+
+Recently, Hacker News has started enforcing HTTPS connections. If you're having
+problems accessing Hacker News via this gem, read [these
+instructions](http://railsapps.github.com/openssl-certificate-verify-failed.html)
+for specific fixes.
+
 ## Usage
 
     require 'hn'
@@ -41,4 +48,5 @@ And then execute:
 
 Thanks following wonderful people for contributing to this project:
 
-[@bencevans](https://github.com/bencevans)
+[@bencevans](https://github.com/bencevans)
+[@imkmf](https://github.com/imkmf)

data/lib/hn/parsers/comment_parser.rb

@@ -5,7 +5,7 @@ require "chronic"
 module HackerNews
   class CommentParser
     def parse(entry_id)
-      doc = Nokogiri::HTML(open("http://news.ycombinator.com/item?id=#{entry_id}"))
+      doc = Nokogiri::HTML(open("https://news.ycombinator.com/item?id=#{entry_id}"))
       comment_data = doc.css('td.default').map { |td| extract_comment_from_td(td) }
       comments = []
 

data/lib/hn/parsers/entry_parser.rb

@@ -19,7 +19,7 @@ module HackerNews
     private
 
     def site_name
-      'http://news.ycombinator.com/'
+      'https://news.ycombinator.com/'
     end
 
     def parse_entries(url)
@@ -38,7 +38,7 @@ module HackerNews
     def parse_entry(trs, i)
       Entry.new do |entry|
         entry.link = trs[i*3].at_css('td.title a')['href']
-        entry.link = site_name + entry.link unless entry.link =~ /^http/
+        entry.link = site_name + entry.link unless entry.link =~ /^https/
 
         entry.title = trs[i*3].at_css('td.title a').text
 
@@ -52,7 +52,7 @@ module HackerNews
         begin
           entry.id = trs[i*3+1].css('td.subtext a')[1]['href'].match(/\d+/)[0].to_i
         rescue
-          entry.id = entry.link.match(/^http:\/\/news\.ycombinator\.com\/item\?id=(\d+)$/)[1].to_i
+          entry.id = entry.link.match(/^https:\/\/news\.ycombinator\.com\/item\?id=(\d+)$/)[1].to_i
         end
       end
     rescue

data/lib/hn/version.rb

@@ -1,3 +1,3 @@
 module HackerNews
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/spec/hn/parsers/comment_parser_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-FakeWeb.register_uri :get, 'http://news.ycombinator.com/item?id=4084603', :body => fixture('comments.html')
+FakeWeb.register_uri :get, 'https://news.ycombinator.com/item?id=4084603', :body => fixture('comments.html')
 
 module HackerNews
   describe CommentParser do

data/spec/hn/parsers/entry_parser_spec.rb

@@ -1,8 +1,8 @@
 require "spec_helper"
 
-FakeWeb.register_uri :get, 'http://news.ycombinator.com/', :body => fixture('home.html')
-FakeWeb.register_uri :get, 'http://news.ycombinator.com/newest', :body => fixture('newest.html')
-FakeWeb.register_uri :get, 'http://news.ycombinator.com/best', :body => fixture('best.html')
+FakeWeb.register_uri :get, 'https://news.ycombinator.com/', :body => fixture('home.html')
+FakeWeb.register_uri :get, 'https://news.ycombinator.com/newest', :body => fixture('newest.html')
+FakeWeb.register_uri :get, 'https://news.ycombinator.com/best', :body => fixture('best.html')
 
 module HackerNews
   describe EntryParser do
@@ -18,10 +18,10 @@ module HackerNews
         entries.each do |entry|
           entry.id.should > 4000000
           entry.username.should =~ /\w+/
-          entry.link.should =~ /^http/
+          entry.link.should =~ /^https/
           entry.title.should_not be_empty
           entry.num_comments.should >= 0
-          entry.site.should_not =~ /^http/
+          entry.site.should_not =~ /^https/
           entry.points.should_not == 0
 
           entry.submitted_at.should < Time.now
@@ -37,15 +37,15 @@ module HackerNews
         entries.each do |entry|
           entry.id.should > 4000000
           entry.username.should =~ /\w+/
-          entry.link.should =~ /^http/
+          entry.link.should =~ /^https/
 
           if entry.site.nil? # ASK HN
-            entry.id.should == entry.link.match(/^http:\/\/news\.ycombinator\.com\/item\?id=(\d+)$/)[1].to_i
+            entry.id.should == entry.link.match(/^https:\/\/news\.ycombinator\.com\/item\?id=(\d+)$/)[1].to_i
           end
 
           entry.title.should_not be_empty
           entry.num_comments.should >= 0
-          entry.site.should_not =~ /^http/
+          entry.site.should_not =~ /^https/
           entry.points.should >= 0
           entry.submitted_at.should < Time.now
         end
@@ -60,15 +60,15 @@ module HackerNews
         entries.each do |entry|
           entry.id.should > 4000000
           entry.username.should =~ /\w+/
-          entry.link.should =~ /^http/
+          entry.link.should =~ /^https/
 
           if entry.site.nil? # ASK HN
-            entry.id.should == entry.link.match(/^http:\/\/news\.ycombinator\.com\/item\?id=(\d+)$/)[1].to_i
+            entry.id.should == entry.link.match(/^https:\/\/news\.ycombinator\.com\/item\?id=(\d+)$/)[1].to_i
           end
 
           entry.title.should_not be_empty
           entry.num_comments.should >= 0
-          entry.site.should_not =~ /^http/
+          entry.site.should_not =~ /^https/
           entry.points.should >= 0
           entry.submitted_at.should < Time.now
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hn
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-19 00:00:00.000000000 Z
+date: 2013-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70300323557400 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70300323557400
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70300323556980 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70300323556980
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70300323556560 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +53,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70300323556560
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &70300323556140 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +69,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70300323556140
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70300323555720 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +85,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70300323555720
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: chronic
-  requirement: &70300323555300 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +101,12 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70300323555300
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A tiny gem to fetch Hacker News entries
 email:
 - afu@forresty.com
@@ -120,21 +150,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 556332051837383682
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 556332051837383682
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: A tiny gem to fetch Hacker News entries