hn 0.0.1 → 0.0.2

data/Rakefile

@@ -7,4 +7,4 @@ RSpec::Core::RakeTask.new(:spec) do |spec|
   spec.pattern = 'spec/**/*_spec.rb'
 end
 
-task :default => :spec
+task :default => :spec

data/hn.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'simplecov'
   gem.add_development_dependency 'chronic'
+  gem.add_development_dependency 'fakeweb'
 
   gem.add_runtime_dependency 'nokogiri'
 end

data/lib/hn/models/entry.rb

@@ -1,6 +1,6 @@
 module HackerNews
   class Entry
-    attr_accessor :id, :title, :link, :site, :points, :num_comments, :time_string, :user
+    attr_accessor :id, :title, :link, :site, :points, :num_comments, :time_string, :username
 
     def initialize
       yield self if block_given?

data/lib/hn/parsers/entry_parser.rb

@@ -4,15 +4,19 @@ require "open-uri"
 module HackerNews
   class EntryParser
     def homepage
-      parse_entries 'http://news.ycombinator.com/'
+      parse_entries site_name
     end
 
     def newest
-      parse_entries 'http://news.ycombinator.com/newest'
+      parse_entries "#{site_name}newest"
     end
 
     private
 
+    def site_name
+      'http://news.ycombinator.com/'
+    end
+
     def parse_entries(url)
       # doc = Nokogiri::HTML(open('spec/fixtures/home.html'))
       doc = Nokogiri::HTML(open(url))
@@ -23,9 +27,10 @@ module HackerNews
         Entry.new do |entry|
           entry.title = trs[i*3].at_css('td.title a').text
           entry.link = trs[i*3].at_css('td.title a')['href']
+          entry.link = site_name + entry.link unless entry.link =~ /^http/
           entry.site = trs[i*3].at_css('td.title span.comhead').text.match(/\((.+)\)/)[1] rescue nil
           entry.points = trs[i*3+1].at_css('td.subtext span').text.to_i rescue 0
-          entry.user = trs[i*3+1].at_css('td.subtext a').text
+          entry.username = trs[i*3+1].at_css('td.subtext a').text
           entry.time_string = trs[i*3+1].at_css('td.subtext a').next.text.sub('|', '').strip
           entry.num_comments = trs[i*3+1].css('td.subtext a')[1].text.to_i
           entry.id = trs[i*3+1].css('td.subtext a')[1]['href'].match(/\d+/)[0].to_i

data/lib/hn/version.rb

@@ -1,3 +1,3 @@
 module HackerNews
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/hn/parsers/entry_parser_spec.rb

@@ -1,6 +1,9 @@
 require "spec_helper"
 require "chronic"
 
+FakeWeb.register_uri :get, 'http://news.ycombinator.com/', :body => fixture('home.html')
+FakeWeb.register_uri :get, 'http://news.ycombinator.com/newest', :body => fixture('newest.html')
+
 module HackerNews
   describe EntryParser do
     subject { EntryParser.new }
@@ -9,13 +12,12 @@ module HackerNews
 
     context "homepage" do
       it "should parse them right" do
-        parser.stub(:open).and_return(open('spec/fixtures/home.html'))
         entries = parser.homepage
         entries.count.should == 30
         entries.first.should be_an Entry
         entries.each do |entry|
           entry.id.should > 4000000
-          entry.user.should =~ /\w+/
+          entry.username.should =~ /\w+/
           entry.link.should =~ /^http/ unless entry.site.nil?
           entry.title.should_not be_empty
           entry.num_comments.should > 0
@@ -28,14 +30,18 @@ module HackerNews
 
     context "newest" do
       it "should parse them right" do
-        parser.stub(:open).and_return(open('spec/fixtures/newest.html'))
         entries = parser.newest
         entries.count.should == 30
         entries.first.should be_an Entry
         entries.each do |entry|
           entry.id.should > 4000000
-          entry.user.should =~ /\w+/
-          entry.link.should =~ /^http/ unless entry.site.nil?
+          entry.username.should =~ /\w+/
+          entry.link.should =~ /^http/
+
+          if entry.site.nil? # ASK HN
+            entry.id.should == entry.link.match(/^http:\/\/news\.ycombinator\.com\/item\?id=(\d+)$/)[1].to_i
+          end
+
           entry.title.should_not be_empty
           entry.num_comments.should >= 0
           entry.site.should_not =~ /^http/

data/spec/spec_helper.rb

@@ -3,9 +3,12 @@ SimpleCov.start do
   add_filter 'spec'
 end
 
-require "open-uri"
 require 'hn'
 
-def fixture(filename)
-  open("spec/fixtures/#{filename}") { |file| file.read }
-end
+require "fakeweb"
+FakeWeb.allow_net_connect = false
+
+require "open-uri"
+def fixture(fixture_name)
+  open("spec/fixtures/#{fixture_name}") { |p| p.read }
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hn
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-28 00:00:00.000000000 Z
+date: 2012-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70199363409420 !ruby/object:Gem::Requirement
+  requirement: &70126472762360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70199363409420
+  version_requirements: *70126472762360
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70199363409000 !ruby/object:Gem::Requirement
+  requirement: &70126472761940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70199363409000
+  version_requirements: *70126472761940
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70199363408580 !ruby/object:Gem::Requirement
+  requirement: &70126472761520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70199363408580
+  version_requirements: *70126472761520
 - !ruby/object:Gem::Dependency
   name: chronic
-  requirement: &70199363408160 !ruby/object:Gem::Requirement
+  requirement: &70126472761100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,21 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70199363408160
+  version_requirements: *70126472761100
+- !ruby/object:Gem::Dependency
+  name: fakeweb
+  requirement: &70126472760680 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70126472760680
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70199363407740 !ruby/object:Gem::Requirement
+  requirement: &70126472760260 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +76,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70199363407740
+  version_requirements: *70126472760260
 description: A tiny gem to fetch Hacker News entries
 email:
 - afu@forresty.com
@@ -105,7 +116,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3803145340244818705
+      hash: 4450533506662142412
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -114,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3803145340244818705
+      hash: 4450533506662142412
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.11