historiographer 4.4.3 → 4.4.5

data/spec/examples.txt

@@ -0,0 +1,72 @@
+example_id                                                         | status | run_time        |
+------------------------------------------------------------------ | ------ | --------------- |
+./spec/historiographer_spec.rb[1:1:1]                              | passed | 0.07846 seconds |
+./spec/historiographer_spec.rb[1:1:2]                              | passed | 0.05421 seconds |
+./spec/historiographer_spec.rb[1:1:3]                              | passed | 0.05161 seconds |
+./spec/historiographer_spec.rb[1:2:1]                              | passed | 0.05923 seconds |
+./spec/historiographer_spec.rb[1:2:2]                              | passed | 0.0649 seconds  |
+./spec/historiographer_spec.rb[1:2:3:1:1]                          | passed | 0.10678 seconds |
+./spec/historiographer_spec.rb[1:2:3:1:2]                          | passed | 0.07362 seconds |
+./spec/historiographer_spec.rb[1:2:3:2:1]                          | passed | 0.0583 seconds  |
+./spec/historiographer_spec.rb[1:2:3:2:2]                          | passed | 0.06499 seconds |
+./spec/historiographer_spec.rb[1:2:3:2:3]                          | passed | 0.07272 seconds |
+./spec/historiographer_spec.rb[1:2:3:3:1]                          | passed | 0.07946 seconds |
+./spec/historiographer_spec.rb[1:2:3:3:2]                          | passed | 0.0671 seconds  |
+./spec/historiographer_spec.rb[1:2:4:1]                            | passed | 0.06979 seconds |
+./spec/historiographer_spec.rb[1:2:4:2]                            | passed | 0.06026 seconds |
+./spec/historiographer_spec.rb[1:2:4:3]                            | passed | 0.05019 seconds |
+./spec/historiographer_spec.rb[1:2:5:1]                            | passed | 0.0693 seconds  |
+./spec/historiographer_spec.rb[1:2:5:2]                            | passed | 0.06955 seconds |
+./spec/historiographer_spec.rb[1:2:5:3]                            | passed | 0.05246 seconds |
+./spec/historiographer_spec.rb[1:2:6]                              | passed | 0.04995 seconds |
+./spec/historiographer_spec.rb[1:2:7]                              | passed | 0.05019 seconds |
+./spec/historiographer_spec.rb[1:2:8]                              | passed | 0.05534 seconds |
+./spec/historiographer_spec.rb[1:3:1]                              | passed | 0.05769 seconds |
+./spec/historiographer_spec.rb[1:4:1]                              | passed | 0.07179 seconds |
+./spec/historiographer_spec.rb[1:5:1]                              | passed | 0.05631 seconds |
+./spec/historiographer_spec.rb[1:5:2]                              | passed | 0.0544 seconds  |
+./spec/historiographer_spec.rb[1:6:1]                              | passed | 0.05814 seconds |
+./spec/historiographer_spec.rb[1:6:2]                              | passed | 0.08519 seconds |
+./spec/historiographer_spec.rb[1:7:1]                              | passed | 0.0567 seconds  |
+./spec/historiographer_spec.rb[1:7:2]                              | passed | 0.0759 seconds  |
+./spec/historiographer_spec.rb[1:7:3]                              | passed | 0.05536 seconds |
+./spec/historiographer_spec.rb[1:7:4]                              | passed | 0.05564 seconds |
+./spec/historiographer_spec.rb[1:7:5]                              | passed | 0.07313 seconds |
+./spec/historiographer_spec.rb[1:8:1]                              | passed | 0.05466 seconds |
+./spec/historiographer_spec.rb[1:9:1]                              | passed | 0.07755 seconds |
+./spec/historiographer_spec.rb[1:10:1]                             | passed | 0.05444 seconds |
+./spec/historiographer_spec.rb[1:11:1]                             | passed | 0.05663 seconds |
+./spec/historiographer_spec.rb[1:11:2]                             | passed | 0.07322 seconds |
+./spec/historiographer_spec.rb[1:11:3]                             | passed | 0.07853 seconds |
+./spec/historiographer_spec.rb[1:11:4]                             | passed | 0.05709 seconds |
+./spec/historiographer_spec.rb[1:12:1]                             | passed | 0.07377 seconds |
+./spec/historiographer_spec.rb[1:12:2]                             | passed | 0.05676 seconds |
+./spec/historiographer_spec.rb[1:12:3]                             | passed | 0.07933 seconds |
+./spec/historiographer_spec.rb[1:12:4]                             | passed | 0.07886 seconds |
+./spec/historiographer_spec.rb[1:12:5]                             | passed | 0.07857 seconds |
+./spec/historiographer_spec.rb[1:12:6]                             | passed | 0.06854 seconds |
+./spec/historiographer_spec.rb[1:12:7]                             | passed | 0.08045 seconds |
+./spec/historiographer_spec.rb[1:13:1]                             | passed | 0.07652 seconds |
+./spec/historiographer_spec.rb[1:14:1]                             | passed | 0.05116 seconds |
+./spec/historiographer_spec.rb[1:14:2]                             | passed | 0.06274 seconds |
+./spec/historiographer_spec.rb[1:14:3]                             | passed | 0.0698 seconds  |
+./spec/historiographer_spec.rb[1:14:4]                             | passed | 0.05648 seconds |
+./spec/historiographer_spec.rb[1:15:1]                             | passed | 0.05722 seconds |
+./spec/historiographer_spec.rb[1:15:2]                             | passed | 0.08476 seconds |
+./spec/historiographer_spec.rb[1:16:1]                             | passed | 0.04781 seconds |
+./spec/historiographer_spec.rb[1:16:2]                             | passed | 0.04802 seconds |
+./spec/historiographer_spec.rb[1:16:3]                             | passed | 0.06019 seconds |
+./spec/historiographer_spec.rb[1:16:4]                             | passed | 0.07289 seconds |
+./spec/historiographer_spec.rb[1:17:1:1]                           | passed | 0.07235 seconds |
+./spec/historiographer_spec.rb[1:17:1:2]                           | passed | 0.06784 seconds |
+./spec/historiographer_spec.rb[1:17:2:1]                           | passed | 0.05847 seconds |
+./spec/integration/historiographer_safe_integration_spec.rb[1:1:1] | passed | 0.06664 seconds |
+./spec/integration/historiographer_safe_integration_spec.rb[1:1:2] | passed | 0.07357 seconds |
+./spec/integration/historiographer_safe_integration_spec.rb[1:1:3] | passed | 0.05953 seconds |
+./spec/view_backed_model_spec.rb[1:1:1]                            | passed | 0.06878 seconds |
+./spec/view_backed_model_spec.rb[1:1:2]                            | passed | 0.08949 seconds |
+./spec/view_backed_model_spec.rb[1:1:3:1]                          | passed | 0.11878 seconds |
+./spec/view_backed_model_spec.rb[1:1:3:2]                          | passed | 0.1122 seconds  |
+./spec/view_backed_model_spec.rb[1:1:3:3]                          | passed | 0.10204 seconds |
+./spec/view_backed_model_spec.rb[1:1:3:4]                          | passed | 0.11072 seconds |
+./spec/view_backed_model_spec.rb[1:2:1]                            | passed | 0.07444 seconds |

data/spec/historiographer_spec.rb

@@ -823,6 +823,36 @@ describe Historiographer do
       expect(post.latest_snapshot.comment_count).to eq 1
     end
 
+    it "snapshots all children when one has a null_snapshot history record" do
+      # This tests a bug where if one child record already has a history with snapshot_id: nil,
+      # the snapshot would silently fail to update it due to belongs_to :user validation
+      Historiographer::Configuration.mode = :snapshot_only
+
+      # Create records without triggering histories (snapshot_only mode)
+      author1 = Author.create(full_name: 'Author One', history_user_id: user.id)
+      author2 = Author.create(full_name: 'Author Two', history_user_id: user.id)
+
+      # Manually create a null_snapshot history for author1 (simulating previous state)
+      # This mimics what happens when a record has a history created outside of snapshot
+      AuthorHistory.create!(
+        author_id: author1.id,
+        full_name: author1.full_name,
+        history_user_id: nil,  # No user - this will trigger the bug
+        snapshot_id: nil,      # Null snapshot
+        history_started_at: Time.current
+      )
+
+      expect(AuthorHistory.count).to eq 1
+      expect(AuthorHistory.where(snapshot_id: nil).count).to eq 1
+
+      # Now snapshot author1 - this should work even though there's a null_snapshot
+      # The bug: without_history_user_id doesn't prevent belongs_to :user validation
+      author1.snapshot
+
+      expect(AuthorHistory.where.not(snapshot_id: nil).count).to eq 1
+      expect(AuthorHistory.first.snapshot_id).to be_present
+    end
+
     it "doesn't explode" do
       project = Project.create(name: "test_project")
       project_file = ProjectFile.create(project: project, name: "test_file", content: "Hello world")