historiographer 4.1.10 → 4.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e211bf451d7041d58702ebc28a4485eb3a073978aca72ef1933e9b5dcebc49fe
-  data.tar.gz: 20ab524186b29a4c3dd44553a62b8853cf46a82aae4f139d18d3178b045cb35a
+  metadata.gz: 8bf0d68cafc68171d60d3ca3c98895fe7493e5dee98f61d98dc3f6c7af25107f
+  data.tar.gz: 921c92bdb41a6a4fb2676576675487cfb6b1a69db7db6b57455b33be1c222a78
 SHA512:
-  metadata.gz: 055c01abfa33ab141ef48644ea38fa2a4052a9471d68519f89a659bbf45f83e37f66bb1aa847ba7014de9a46435af3cdced42d45ea122d25b70c409fdc312777
-  data.tar.gz: d7df91b900b2ea61b4e366b67972242d2882feadf8cfebbd8cd0d67875782535d267e084ec9cf044c835b4da757a0602b1ca8e75f6f27310faf4fe7b7bf69931
+  metadata.gz: 8a426ce99a92d73ec05809e35c66b4c76cd6a8fab0e588f4733e94a6d18d159717b60f80b32e435957c0e5aec4b1e5c1a05cceead4ce88be209f9877f2253c35
+  data.tar.gz: 5f0c40ab48ca22082530598a91876f757b2b5b263ca6e39ac0657834194168baeb9924ba341316af63af3a85713d1bf8fdfdf3a8e026ee62858f6096d68cfa84

data/lib/historiographer/history.rb

@@ -133,7 +133,7 @@ module Historiographer
         end
       end
 
-      foreign_class.columns.map(&:name).each do |method_name|
+      (foreign_class.columns.map(&:name) - ["id"]).each do |method_name|
         define_method(method_name) do |*args, &block|
           forward_method(method_name, *args, &block)
         end
@@ -336,12 +336,12 @@ module Historiographer
       return @dummy_instance if @dummy_instance
 
       # Only exclude history-specific columns
-      cannot_keep_cols = %w(history_started_at history_ended_at history_user_id snapshot_id)
+      cannot_keep_cols = %w(history_started_at history_ended_at history_user_id snapshot_id id)
       cannot_keep_cols += [self.class.history_foreign_key] 
       cannot_keep_cols.map!(&:to_s)
 
       attrs = attributes.clone
-      attrs[original_class.primary_key] = attrs[self.class.history_foreign_key]
+      # attrs[original_class.primary_key] = attrs[self.class.history_foreign_key]
 
       if original_class.sti_enabled?
         # Remove History suffix from type if present
@@ -368,6 +368,7 @@ module Historiographer
       history_methods.select! do |method| 
         self.class.instance_method(method).source_location.first == history_class_location
       end
+      history_methods += [:is_history_class?]
 
       history_methods.each do |method_name|
         instance.singleton_class.class_eval do 
@@ -400,11 +401,7 @@ module Historiographer
     end
 
     def forward_method(method_name, *args, &block)
-      if method_name == :class || method_name == 'class'
-        self.class
-      else
-        dummy_instance.send(method_name, *args, &block)
-      end
+      dummy_instance.send(method_name, *args, &block)
     end
   end
 end

data/lib/historiographer/version.rb

@@ -1,3 +1,3 @@
 module Historiographer
-  VERSION = "4.1.10"
+  VERSION = "4.1.12"
 end

data/lib/historiographer.rb

@@ -105,7 +105,7 @@ module Historiographer
       history_user_absent_action if history_user_id.nil?
 
       current_history = histories.where(history_ended_at: nil).order('id desc').limit(1).last
-      current_history.update!(history_ended_at: UTC.now) if current_history.present?
+      current_history.update_columns(history_ended_at: UTC.now) if current_history.present?
 
       if respond_to?(:paranoia_destroy)
         self.history_user_id = history_user_id
@@ -115,6 +115,7 @@ module Historiographer
         destroy_without_history
         @no_history = false
       end
+      true
     end
 
     alias_method :destroy, :destroy_with_history
@@ -366,23 +367,6 @@ module Historiographer
       raise HistoryUserIdMissingError, 'history_user_id must be passed in order to save record with histories! If you are in a context with no history_user_id, explicitly call #save_without_user'
     end
 
-    def list_callbacks(klass)
-      callbacks = {}
-
-      [:create, :update, :save, :destroy, :validation].each do |callback_type|
-        chain = klass.send("_#{callback_type}_callbacks")
-        callbacks[callback_type] = chain.map do |callback|
-          {
-            name: callback.filter,
-            kind: callback.kind,
-            options: callback.options
-          }
-        end
-      end
-
-      callbacks
-    end
-
     #
     # Save a record of the most recent changes, with the current
     # time as history_started_at, and the provided user as history_user_id.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: historiographer
 version: !ruby/object:Gem::Version
-  version: 4.1.10
+  version: 4.1.12
 platform: ruby
 authors:
 - brettshollenberger