historiographer 3.1.1 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d006e4c71b92e795f4f59b5acc12b9485a456ad145f420e270ec72e0d708971f
-  data.tar.gz: 93fdc339e3a603b8d9c51aa22a51b911b2eb45f30e1b498b1c72854e4f99b6cd
+  metadata.gz: f16398b9f6b0a3d58501a2115eabca0e0f93a938d04eeb4c21d3713f9b70079a
+  data.tar.gz: a460ef65372e236b001225b1028837eb7ba107e8d45d958c39d003be0cd64db4
 SHA512:
-  metadata.gz: 772f6e593fe7efd820cd26fb65a1e22142e1b968d74cb571989d4134723f0e6484f6fc46d2fd283e662e87377f9dc51204d697ca97212f751c0c073b51057f87
-  data.tar.gz: d79129aaf645d28b53989a3576b9989ec93c8839a4b265e99dac5fa6ae199607b00eef4c4f9eb42c0851a52a07120df0eeb3bbf17fad83996910ff35d235503f
+  metadata.gz: 3b545edcfe0076f0e83f5478347a9298fce77118d7274ad39ce8304844637b7ee15980e66c02dff36321eda4e36b0defdb10b6c33cc7486fba47e780043e5f42
+  data.tar.gz: f828cf26cc357fb0b3e2750bfcc1f62dc628c1579f1fa3356062f34314545783bb6ecb80366e4ac9d6988eae8374168afeb0d29c166daa9dbd7c860074494de4

data/.ruby-version

@@ -1 +1 @@
-2.6.3
+3.0.2

data/Gemfile

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 source 'https://rubygems.org'
-ruby '2.6.3'
+ruby '3.0.2'
 
 gem 'activerecord', '>= 6'
 gem 'activerecord-import'

data/Gemfile.lock

@@ -283,7 +283,7 @@ DEPENDENCIES
   timecop
 
 RUBY VERSION
-   ruby 2.6.3p62
+   ruby 3.0.2p107
 
 BUNDLED WITH
    1.17.3

data/VERSION

@@ -1 +1 @@
-3.1.1
+4.0.0

data/historiographer.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: historiographer 3.1.1 ruby lib
+# stub: historiographer 4.0.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "historiographer".freeze
-  s.version = "3.1.1"
+  s.version = "4.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["brettshollenberger".freeze]
-  s.date = "2022-10-19"
+  s.date = "2023-08-22"
   s.description = "Creates separate tables for each history table".freeze
   s.email = "brett.shollenberger@gmail.com".freeze
   s.extra_rdoc_files = [
@@ -62,7 +62,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/brettshollenberger/historiographer".freeze
   s.licenses = ["MIT".freeze]
-  s.rubygems_version = "3.2.23".freeze
+  s.rubygems_version = "3.2.22".freeze
   s.summary = "Create histories of your ActiveRecord tables".freeze
 
   if s.respond_to? :specification_version then

data/lib/historiographer/history_migration.rb

@@ -34,7 +34,12 @@ module Historiographer
         opts = {}
         opts.merge!(column.as_json.clone)
 
-        send(column.type, column.name, opts.symbolize_keys!)
+        if RUBY_VERSION.to_i >= 3
+          puts "Hello"
+          send(column.type, column.name, **opts.symbolize_keys!)
+        else
+          send(column.type, column.name, opts.symbolize_keys!)
+        end
       end
 
       datetime :history_started_at, null: false
@@ -86,4 +91,4 @@ module Historiographer
 
     end
   end
-end
+end

data/lib/historiographer.rb

@@ -1,8 +1,11 @@
-require "active_support/all"
-require_relative "./historiographer/history"
-require_relative "./historiographer/postgres_migration"
-require_relative "./historiographer/safe"
-require_relative "./historiographer/relation"
+# frozen_string_literal: true
+
+require 'active_support/all'
+require_relative './historiographer/history'
+require_relative './historiographer/postgres_migration'
+require_relative './historiographer/safe'
+require_relative './historiographer/relation'
+require_relative './historiographer/silent'
 
 # Historiographer takes "histories" (think audits or snapshots) of your model whenever you make changes.
 #
@@ -74,7 +77,7 @@ module Historiographer
 
   class HistoryUserIdMissingError < StandardError; end
 
-  UTC = Time.now.in_time_zone("UTC").time_zone
+  UTC = Time.now.in_time_zone('UTC').time_zone
 
   included do |base|
     after_save :record_history, if: :should_record_history?
@@ -86,7 +89,7 @@ module Historiographer
 
     def validate_history_user_id_present
       if @no_history.nil? && (!history_user_id.present? || !history_user_id.is_a?(Integer))
-        errors.add(:history_user_id, "must be an integer")
+        errors.add(:history_user_id, 'must be an integer')
       end
     end
 
@@ -95,7 +98,7 @@ module Historiographer
     def destroy_with_history(history_user_id: nil)
       history_user_absent_action if history_user_id.nil?
 
-      current_history = histories.where(history_ended_at: nil).order("id desc").limit(1).last
+      current_history = histories.where(history_ended_at: nil).order('id desc').limit(1).last
       current_history.update!(history_ended_at: UTC.now) if current_history.present?
 
       if respond_to?(:paranoia_destroy)
@@ -138,7 +141,7 @@ module Historiographer
       when 0..5 then changed? && valid?
       when 5.1..7 then saved_changes?
       else
-        raise "Unsupported Rails version"
+        raise 'Unsupported Rails version'
       end
     end
 
@@ -157,7 +160,7 @@ module Historiographer
 
     begin
       class_name.constantize
-    rescue
+    rescue StandardError
       history_class_initializer = Class.new(ActiveRecord::Base) do
       end
 
@@ -170,9 +173,14 @@ module Historiographer
       raise "#{base} already has histories. Talk to Brett if this is a legit use case."
     else
       opts = { class_name: class_name }
-      opts.merge!(foreign_key: klass.history_foreign_key) if klass.respond_to?(:history_foreign_key)
-      has_many :histories, opts
-      has_one :current_history, -> { current }, opts
+      opts[:foreign_key] = klass.history_foreign_key if klass.respond_to?(:history_foreign_key)
+      if RUBY_VERSION.to_i >= 3
+        has_many :histories, **opts
+        has_one :current_history, -> { current }, **opts
+      else
+        has_many :histories, opts
+        has_one :current_history, -> { current }, opts
+      end
     end
 
     klass.send(:include, Historiographer::History) unless klass.ancestors.include?(Historiographer::History)
@@ -187,14 +195,12 @@ module Historiographer
     module UpdateColumnsWithHistory
       def update_columns(*args)
         opts = args.extract_options!
-        any_changes = opts.keys.reject { |k| k == "id" }.any?
+        any_changes = opts.keys.reject { |k| k == 'id' }.any?
 
         transaction do
           persisted = super(opts)
 
-          if any_changes && persisted
-            record_history
-          end
+          record_history if any_changes && persisted
         end
       end
     end
@@ -216,7 +222,7 @@ module Historiographer
     private
 
     def history_user_absent_action
-      raise HistoryUserIdMissingError.new("history_user_id must be passed in order to save record with histories! If you are in a context with no history_user_id, explicitly call #save_without_user")
+      raise HistoryUserIdMissingError, 'history_user_id must be passed in order to save record with histories! If you are in a context with no history_user_id, explicitly call #save_without_user'
     end
 
     #
@@ -233,23 +239,22 @@ module Historiographer
       foreign_key = history_class.history_foreign_key
 
       now = UTC.now
-      attrs.merge!(foreign_key => attrs["id"], history_started_at: now, history_user_id: history_user_id)
+      attrs.merge!(foreign_key => attrs['id'], history_started_at: now, history_user_id: history_user_id)
 
-      attrs = attrs.except("id")
+      attrs = attrs.except('id')
 
-      current_history = histories.where(history_ended_at: nil).order("id desc").limit(1).last
+      current_history = histories.where(history_ended_at: nil).order('id desc').limit(1).last
 
-      unless foreign_key.present? && history_class.present?
-        raise "Need foreign key and history class to save history!"
-      else
+      if foreign_key.present? && history_class.present?
         history_class.create!(attrs)
         current_history.update!(history_ended_at: now) if current_history.present?
+      else
+        raise 'Need foreign key and history class to save history!'
       end
     end
   end
 
   class_methods do
-
     #
     # E.g. SponsoredProductCampaign => SponsoredProductCampaignHistory
     #

data/spec/examples.txt

@@ -1,29 +1,32 @@
 example_id                                | status | run_time        |
 ----------------------------------------- | ------ | --------------- |
-./spec/historiographer_spec.rb[1:1:1]     | passed | 0.00973 seconds |
-./spec/historiographer_spec.rb[1:1:2]     | passed | 0.01848 seconds |
-./spec/historiographer_spec.rb[1:1:3]     | passed | 0.0092 seconds  |
-./spec/historiographer_spec.rb[1:2:1]     | passed | 0.02492 seconds |
-./spec/historiographer_spec.rb[1:2:2]     | passed | 0.00099 seconds |
-./spec/historiographer_spec.rb[1:2:3:1:1] | passed | 0.13892 seconds |
-./spec/historiographer_spec.rb[1:2:3:1:2] | passed | 0.1202 seconds  |
-./spec/historiographer_spec.rb[1:2:3:2:1] | passed | 0.02734 seconds |
-./spec/historiographer_spec.rb[1:2:3:2:2] | passed | 0.04699 seconds |
-./spec/historiographer_spec.rb[1:2:3:2:3] | passed | 0.02185 seconds |
-./spec/historiographer_spec.rb[1:2:3:3:1] | passed | 0.08042 seconds |
-./spec/historiographer_spec.rb[1:2:3:3:2] | passed | 0.02825 seconds |
-./spec/historiographer_spec.rb[1:2:4:1]   | passed | 0.02411 seconds |
-./spec/historiographer_spec.rb[1:2:4:2]   | passed | 0.01286 seconds |
-./spec/historiographer_spec.rb[1:2:4:3]   | passed | 0.00469 seconds |
-./spec/historiographer_spec.rb[1:2:5]     | passed | 0.00478 seconds |
-./spec/historiographer_spec.rb[1:2:6]     | passed | 0.0035 seconds  |
-./spec/historiographer_spec.rb[1:2:7]     | passed | 0.01157 seconds |
-./spec/historiographer_spec.rb[1:3:1]     | passed | 0.09042 seconds |
-./spec/historiographer_spec.rb[1:4:1]     | passed | 0.05553 seconds |
-./spec/historiographer_spec.rb[1:5:1]     | passed | 0.0104 seconds  |
-./spec/historiographer_spec.rb[1:5:2]     | passed | 0.00905 seconds |
-./spec/historiographer_spec.rb[1:6:1]     | passed | 0.02652 seconds |
-./spec/historiographer_spec.rb[1:6:2]     | passed | 0.04419 seconds |
-./spec/historiographer_spec.rb[1:7:1]     | passed | 0.02102 seconds |
-./spec/historiographer_spec.rb[1:8:1]     | passed | 0.02556 seconds |
-./spec/historiographer_spec.rb[1:9:1]     | passed | 0.01444 seconds |
+./spec/historiographer_spec.rb[1:1:1]     | passed | 0.05541 seconds |
+./spec/historiographer_spec.rb[1:1:2]     | passed | 0.04942 seconds |
+./spec/historiographer_spec.rb[1:1:3]     | passed | 0.02648 seconds |
+./spec/historiographer_spec.rb[1:2:1]     | passed | 0.03832 seconds |
+./spec/historiographer_spec.rb[1:2:2]     | passed | 0.00076 seconds |
+./spec/historiographer_spec.rb[1:2:3:1:1] | passed | 0.04672 seconds |
+./spec/historiographer_spec.rb[1:2:3:1:2] | passed | 0.01971 seconds |
+./spec/historiographer_spec.rb[1:2:3:2:1] | passed | 0.12226 seconds |
+./spec/historiographer_spec.rb[1:2:3:2:2] | passed | 0.09424 seconds |
+./spec/historiographer_spec.rb[1:2:3:2:3] | passed | 0.05644 seconds |
+./spec/historiographer_spec.rb[1:2:3:3:1] | passed | 0.16536 seconds |
+./spec/historiographer_spec.rb[1:2:3:3:2] | passed | 0.01638 seconds |
+./spec/historiographer_spec.rb[1:2:4:1]   | passed | 0.00552 seconds |
+./spec/historiographer_spec.rb[1:2:4:2]   | passed | 0.01095 seconds |
+./spec/historiographer_spec.rb[1:2:4:3]   | passed | 0.0022 seconds  |
+./spec/historiographer_spec.rb[1:2:5:1]   | passed | 0.08367 seconds |
+./spec/historiographer_spec.rb[1:2:5:2]   | passed | 0.10781 seconds |
+./spec/historiographer_spec.rb[1:2:5:3]   | passed | 0.00516 seconds |
+./spec/historiographer_spec.rb[1:2:6]     | passed | 0.00482 seconds |
+./spec/historiographer_spec.rb[1:2:7]     | passed | 0.00642 seconds |
+./spec/historiographer_spec.rb[1:2:8]     | passed | 0.00926 seconds |
+./spec/historiographer_spec.rb[1:3:1]     | passed | 0.01607 seconds |
+./spec/historiographer_spec.rb[1:4:1]     | passed | 0.03777 seconds |
+./spec/historiographer_spec.rb[1:5:1]     | passed | 0.04254 seconds |
+./spec/historiographer_spec.rb[1:5:2]     | passed | 0.02652 seconds |
+./spec/historiographer_spec.rb[1:6:1]     | passed | 0.23851 seconds |
+./spec/historiographer_spec.rb[1:6:2]     | passed | 0.16412 seconds |
+./spec/historiographer_spec.rb[1:7:1]     | passed | 0.07495 seconds |
+./spec/historiographer_spec.rb[1:8:1]     | passed | 0.02917 seconds |
+./spec/historiographer_spec.rb[1:9:1]     | passed | 0.0228 seconds  |

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: historiographer
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 4.0.0
 platform: ruby
 authors:
 - brettshollenberger
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-19 00:00:00.000000000 Z
+date: 2023-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -287,7 +287,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.23
+rubygems_version: 3.2.22
 signing_key:
 specification_version: 4
 summary: Create histories of your ActiveRecord tables