historical-bank 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c5fcd5e46f402afbf0763d24571c0693def95ceec4deccbd729cec64aafa3efe
-  data.tar.gz: 0f783433317e6ec2dd7e66e7fbef898da8d0c14eca2fd9e7978cd0bf53057504
+  metadata.gz: e568c08d9edc80b5179c9f5213e673cb6903970cff5c0a4fa39b129216828c2a
+  data.tar.gz: 50c5a20b8e49885b1e236ce396c2338b485fb9f8bf97bf3ca306866003b9923c
 SHA512:
-  metadata.gz: d3d495434687b598670eb5bcbd3a5945becd67937993f62288cf55fb91e9bd2fc1a72b43db56bdacd3998debbf9d63d0058c58301b513442442e770e14c64118
-  data.tar.gz: eb517bdcb3e1c9210ffabacd375448b2279b032060d8aea55d5a662f51264a55096f31ddc402a1fd54c3297c3f2fe5909de370224483104129c1f74fc83f6eb7
+  metadata.gz: cbaa94ddb35713b5d9493c1093227b130d76122d6888d8a48fb2c6157998bfb244bc4ed286d86d63e7b501263928d818f8e1b7db4a6b5f4d63074ec1a1c62f59
+  data.tar.gz: 261784912fbac3b807e24a480b3d7ca93c34aa286a8b5c839993cdeccd8e2f4fc835768807c0e2a8dab72208711dee81ca23c65d11b76fe2b401c84b58687406

data/AUTHORS

@@ -2,3 +2,4 @@ Kostis Dadamis
 Emili Parreno
 Loris Mazloum
 Carlos Lopes
+Marek Stańczyk

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 0.1.7
+- Fix bug with Ruby memory cache not used. Thank you @stanley90!!
+
 ## 0.1.6
 - Update how Redis pipeline command is made. The old way will be removed in Redis 5.0.0
 

data/historical-bank.gemspec

@@ -16,7 +16,7 @@
 
 Gem::Specification.new do |s|
   s.name        = 'historical-bank'
-  s.version     = '0.1.6'
+  s.version     = '0.1.7'
   s.summary     = 'Historical Bank'
   s.description = 'A `Money::Bank::Base` with historical exchange rates'
   s.authors     = ['Kostis Dadamis', 'Emili Parreno']

data/lib/money/bank/historical.rb

@@ -318,7 +318,7 @@ class Money
       def get_base_rate(currency, date)
         @mutex.synchronize do
           rates = @rates[currency.iso_code]
-          rates[date] if rates
+          rates[date.iso8601] if rates
         end
       end
 

data/spec/bank/historical_spec.rb

@@ -357,6 +357,38 @@ class Money
 
             it { is_expected.to eq expected_result }
           end
+
+          context 'when rates do not exist anywhere' do
+            let(:from_currency_base_rates_store) { nil }
+            let(:to_currency_base_rates_store) { nil }
+            let(:rates_provider) { nil }
+
+            it 'raises an error' do
+              expect { subject }.to raise_error(NoMethodError)
+            end
+          end
+
+          context 'when rates exist in Redis but then disappear from Redis' do
+            let(:from_currency_base_rates_store) { from_currency_base_rates }
+            let(:to_currency_base_rates_store) { to_currency_base_rates }
+            let(:rates_provider) { nil }
+
+            it 'uses the value cached in memory' do
+              # first get it from Redis
+              expect_any_instance_of(RatesStore::HistoricalRedis).to receive(:get_rates)
+                .with(from_currency)
+              expect_any_instance_of(RatesStore::HistoricalRedis).to receive(:get_rates)
+                .with(to_currency)
+              expect(bank.exchange_with_historical(from_money, to_currency, datetime)).to eq expected_result
+
+              # then get it from memory
+              expect_any_instance_of(RatesStore::HistoricalRedis).not_to receive(:get_rates)
+                .with(from_currency)
+              expect_any_instance_of(RatesStore::HistoricalRedis).not_to receive(:get_rates)
+                .with(to_currency)
+              expect(bank.exchange_with_historical(from_money, to_currency, datetime)).to eq expected_result
+            end
+          end
         end
 
         # taken from real rates from XE.com

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: historical-bank
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Kostis Dadamis
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-26 00:00:00.000000000 Z
+date: 2024-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money