histogram 0.2.3.0 → 0.2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 87b16b66fb1ed20c22d818250d368d39fc3445fc
-  data.tar.gz: f6bf7bd712834fc3028a6e8c2ade8a20274ce004
+  metadata.gz: 1c90147f3e7e173081d8ac028ef4e5e1068518d5
+  data.tar.gz: e1abfe94cfdf162c8308c7d2a3582427b42a4a01
 SHA512:
-  metadata.gz: d19f5747ea74d6a9b70d9b9c22a0d0321f2be8b82679fbd1cbd4226bc9fae828775ded31c7c033bd3153c3528d5b238c1a8ff37bd6e77dcf2759137700fb690a
-  data.tar.gz: 6dadf8f32857060dc8b70bf30493f21b9a63e8caaf99f612a4db42877bc6a00350775cd24d6e9c38b24042cb7b1c6c9bc6be6aeac43d3f040dabd0e13e751d5a
+  metadata.gz: cc1f1267f0b6225201c9fafdc493b0a1efd8fca53e44bd87f1193b46c0639e062f80dd0bfca996789221b734e95ad35d119cc50813f08009333292d7c17db7a3
+  data.tar.gz: 50e6c5896bf2e0755ba2dbe81dfe0f73dbebe46ec4531483ffeb83562ed3a158a37019cf092a2375b00f882655733de8cd2939f41967a7c566172548af57932a

data/lib/histogram.rb

@@ -72,7 +72,7 @@ module Histogram
           hi_idx += 1 unless sz.even?
           median(srted[hi_idx..-1]) - median(srted[0..lo_idx])
         else
-          raise ArgumentError, "method must be :tukey"
+          raise ArgumentError, "method must be :tukey or :moore_mccabe"
         end
       answer.to_f
     end
@@ -88,11 +88,15 @@ module Histogram
   #
   # middle is the median between the other three values
   #
+  # Note: always returns 1 if all values are the same.
+  #
   # inspired by {Richard Cotton's matlab
   # implementation}[http://www.mathworks.com/matlabcentral/fileexchange/21033-calculate-number-of-bins-for-histogram]
   # and the {histogram page on
   # wikipedia}[http://en.wikipedia.org/wiki/Histogram]
   def number_of_bins(methd=DEFAULT_BIN_METHOD, quartile_method=DEFAULT_QUARTILE_METHOD)
+    return 1 if self.to_a.uniq.size == 1
+
     if methd == :middle
       [:scott, :sturges, :fd].map {|v| number_of_bins(v) }.sort[1]
     else
@@ -171,6 +175,8 @@ module Histogram
   #   (so, values lower than first bin are not included, but all values
   #   higher, than last bin are included.  Current implementation of custom
   #   bins is slow.
+  # * If the number of bins must be determined and all values are the same,
+  #   will use 1 bin.
   # * if other_sets are supplied, the same bins will be used for all the sets.
   #   It is useful if you just want a certain number of bins and for the sets
   #   to share the exact same bins. In this case returns [bins, freqs(caller),
@@ -312,9 +318,9 @@ module Histogram
       # NUMBER OF BINS:
       ########################################################
       # Create the scaling factor
-
       dmin = _min.to_f
-      conv = _max == _min ? 0 : bins.to_f/(_max - _min)
+      min_equals_max = _max == _min
+      conv = min_equals_max ? 0 : bins.to_f/(_max - _min)
 
       _bins =
         if self.is_a?(Array)
@@ -346,20 +352,18 @@ module Histogram
       iconv = 1.0/conv
       case bin_boundary
       when :avg
-        if bins == 1
-          _bins[0] = self.to_a.inject(0.0) {|sum, val| sum + val } / self.size
-        else
-          (0...bins).each do |i|
-            _bins[i] = ((i+0.5) * iconv) + dmin
-          end
+        if min_equals_max
+          set_bin_value = self.to_a.inject(0.0) {|sum, val| sum + val } / self.size
+        end
+        (0...bins).each do |i|
+          _bins[i] = min_equals_max ? set_bin_value : ((i+0.5) * iconv) + dmin
         end
       when :min
-        if bins == 1
-          _bins[0] = self.min
-        else
-          (0...bins).each do |i|
-            _bins[i] = (i * iconv) + dmin
-          end
+        if min_equals_max
+          set_bin_value = self.min
+        end
+        (0...bins).each do |i|
+          _bins[i] = min_equals_max ? set_bin_value : (i * iconv) + dmin
         end
       end
     end

data/lib/histogram/version.rb

@@ -1,3 +1,3 @@
 module Histogram
-  VERSION = "0.2.3.0"
+  VERSION = "0.2.4.1"
 end

data/spec/histogram_spec.rb

@@ -110,6 +110,18 @@ shared_examples 'something that can histogram' do
     bins, freq = obj8.histogram
   end
 
+  it 'uses 1 bin if all values are the same' do
+    bins, freq = obj6.histogram(:sturges)
+    bins.to_a.should == [0]
+    freq.to_a.should == [5]
+  end
+
+  it 'sets all bin values to the same if min equals max' do
+    bins, freq = obj6.histogram(2)
+    bins.to_a.should == [0.0, 0.0]
+    freq.to_a.should == [5.0, 0.0]
+  end
+
 end
 
 describe Histogram do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: histogram
 version: !ruby/object:Gem::Version
-  version: 0.2.3.0
+  version: 0.2.4.1
 platform: ruby
 authors:
 - John T. Prince
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-08 00:00:00.000000000 Z
+date: 2015-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler