his_emr_api_lab 2.3.6 → 2.3.8.streaming

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a4ea1a6183fe75cd7d56a11e934391903cab098f8892b91380d6f6e67b3b752
-  data.tar.gz: 4b9f2c6e7f8beabf94c5c474cd11a2cbafe833a4111d975786b9b65b85a093fd
+  metadata.gz: 3a671973ef081d74e78629725cd927893b24e306ca80ab86d7481c38e1831575
+  data.tar.gz: b552a83c8d3ed00094143d17fc736b79b55b22ba0902c255793a19b3f6068be9
 SHA512:
-  metadata.gz: b5562e97cd505fed7dc56e3529e7b5b38510cf3ec5d0a94dbd2fbff91a8286e7715a96bb77c6ff339cf7edf60d0eda539e57ec758109c32de26cd11892e387e7
-  data.tar.gz: '097f26ec972cd4f79e57f5719142c6224a975dad0b4c31de4e6063df96470f01885c000544b743f4d0470b09c2d63ab1180f97dad6eb585ab0d7ff6d01350e1b'
+  metadata.gz: 5802072a5d4a7107474a43f4a07dda845e27303f055d333e84da591e831c96cc18c0fdebb985ae02481332798da86793ff60c587cf792f5600d60dcef505d9ce
+  data.tar.gz: 2ba985b8824051e51d45c302b08c6b820d7a2735ececb8500c5a08f43588ca885e5691f156519b717065f023ecf15d8b483e6fdc43ac3cc98369cf7464e48e75

data/app/controllers/lab/orders_controller.rb

@@ -58,6 +58,10 @@ module Lab
     def verify_tracking_number
       tracking_number = params.require(:accession_number)
       render json: { exists: OrdersService.check_tracking_number(tracking_number) }, status: :ok
+    rescue Lab::Lims::ValidationUnavailable => e
+      # Return 502 Bad Gateway to indicate the external service is unavailable
+      # This allows the frontend to prompt user for confirmation
+      render json: { errors: [e.message] }, status: :bad_gateway
     end
 
     def destroy
@@ -74,7 +78,7 @@ module Lab
 
     def order_status
       order_params = params.permit(:tracking_number, :status, :status_time, :comments, :status_id,
-                                    updated_by: [:first_name, :last_name, :id, :phone_number])
+                                   updated_by: %i[first_name last_name id phone_number])
       OrdersService.update_order_status(order_params)
       render json: { message: "Status for order #{order_params['tracking_number']} successfully updated" }, status: :ok
     end

data/app/serializers/lab/lab_order_serializer.rb

@@ -71,7 +71,8 @@ module Lab
     def self.concept_name(concept_id)
       return concept_id unless concept_id
 
-      ::ConceptAttribute.find_by(concept_id:, attribute_type: ConceptAttributeType.test_catalogue_name)&.value_reference
+      ::ConceptAttribute.find_by(concept_id:, attribute_type: ConceptAttributeType.test_catalogue_name)&.value_reference ||
+        ::ConceptName.find_by_concept_id(concept_id)&.name
     end
 
     def self.voided_tests(order)

data/app/services/lab/lims/exceptions.rb

@@ -8,17 +8,18 @@ module Lab
       class MissingAccessionNumber < LimsException; end
       class UnknownSpecimenType < LimsException; end
       class UnknownTestType < LimsException; end
+      class ValidationUnavailable < LimsException; end
     end
   end
 end
 
-
 module Lab
   module Lims
-      class LimsException < StandardError; end
-      class DuplicateNHID < LimsException; end
-      class MissingAccessionNumber < LimsException; end
-      class UnknownSpecimenType < LimsException; end
-      class UnknownTestType < LimsException; end
+    class LimsException < StandardError; end
+    class DuplicateNHID < LimsException; end
+    class MissingAccessionNumber < LimsException; end
+    class UnknownSpecimenType < LimsException; end
+    class UnknownTestType < LimsException; end
+    class ValidationUnavailable < LimsException; end
   end
 end

data/app/services/lab/orders_service.rb

@@ -56,8 +56,14 @@ module Lab
 
         Order.transaction do
           encounter = find_encounter(order_params)
-          if order_params[:accession_number].present? && check_tracking_number(order_params[:accession_number])
-            raise 'Accession number already exists'
+          if order_params[:accession_number].present?
+            begin
+              raise 'Accession number already exists' if check_tracking_number(order_params[:accession_number])
+            rescue Lab::Lims::ValidationUnavailable => e
+              # Log warning but allow order creation to proceed
+              # User should have been prompted to confirm on the frontend
+              Rails.logger.warn("Creating order with unvalidated accession number: #{e.message}")
+            end
           end
 
           order = create_order(encounter, order_params)
@@ -364,6 +370,15 @@ module Lab
         # fetch from the rest api and check if it exists
         lims_api = Lab::Lims::ApiFactory.create_api
         lims_api.verify_tracking_number(accession_number).present?
+      rescue StandardError => e
+        # Log the error for debugging
+        Rails.logger.error("Failed to verify accession number with NLIMS: #{e.message}")
+        Rails.logger.error(e.backtrace.join("\n"))
+
+        # Raise a specific exception indicating validation is unavailable
+        # This allows the controller to handle it differently than "accession exists"
+        raise Lab::Lims::ValidationUnavailable,
+              "Failed to communicate with external service: #{e.message}"
       end
 
       ##

data/lib/lab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Lab
-  VERSION = '2.3.6'
+  VERSION = '2.3.8.streaming'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: his_emr_api_lab
 version: !ruby/object:Gem::Version
-  version: 2.3.6
+  version: 2.3.8.streaming
 platform: ruby
 authors:
 - Elizabeth Glaser Pediatric Foundation Malawi
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-06-15 00:00:00.000000000 Z
+date: 2026-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: couchrest
@@ -42,16 +42,16 @@ dependencies:
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.6
+        version: 8.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.0.6
+        version: 8.0.0
 - !ruby/object:Gem::Dependency
   name: socket.io-client-simple
   requirement: !ruby/object:Gem::Requirement
@@ -341,9 +341,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.4.1
 signing_key: