his_emr_api_lab 2.1.4.pre.alpha → 2.1.4.pre.beta

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 306b46064eb5c58668eb1f4598d99258f1e76b69db42b90abe33d35ddd2434b0
-  data.tar.gz: f367e1fdf5101dd25a2e64f83f61ac6eeffe4fee2007846da5037c18083d1b96
+  metadata.gz: 2cb84913a3c09866a51aa40a98812803bfee6f66a36c3e5c7ea4bdcb9a530724
+  data.tar.gz: 833074b20f473b97b515a11392fc768dabc0b3289b1717474e08b903120c6216
 SHA512:
-  metadata.gz: a8e09ab538d005a20b43f41b0c47357c0440a8cb8508f223b4d3f9639c1b3df2dc87a3c6f33d3c6cecd5604c77a1b4cb36f14e335e0df52732280ca1256c41b6
-  data.tar.gz: 47fdae979daa748c4dbc6fd1c291594b857a40b45e4f3adea3ecaae8fcb54275c2c77485e8bf2f2c222eddea66a1518f3c396236dbd56f4b4afcd9b16bfd4e76
+  metadata.gz: fa6487f57604f5ee24b2fc15e730dfc765cea9eff12051d1875560aa49832e36dc7ffab4320517eeb1f6ffe0ccb706b0e40e4bffc0bcb56d3055b77c9f72c650
+  data.tar.gz: 02a6a0b02074c8fcec8c3d9dbeaeee0a29ea6f96a62f30459f96ee904720c72a854d8251bfb111c5e6e80ae6552a658dabb409547b92119062ada27723d2d0bf

data/app/jobs/lab/process_lab_result_job.rb

@@ -6,7 +6,6 @@ module Lab
   class ProcessLabResultJob < ApplicationJob
     queue_as :default
     def perform(results_obs_id, serializer, result_enter_by)
-      Rails.logger.info("Lab::ProcessLabResultJob: Processing result completion for #{serializer}")
       results_obs = Lab::LabResult.find(results_obs_id)
       Lab::ResultsService.process_result_completion(results_obs, serializer, result_enter_by)
     end

data/app/serializers/lab/result_serializer.rb

@@ -7,11 +7,11 @@ module Lab
     def self.serialize(result)
       result.children.map do |measure|
         value, value_type = read_value(measure)
-        # Get the test catalog name instead of any random concept name
-        concept_name = get_test_catalog_concept_name(measure.concept_id)
-        program_id = ''
+        concept_name = ConceptName.find_by_concept_id(measure.concept_id)
+        
+        program_id = ""
         if measure.obs_id.present?
-          obs = Observation.unscope(where: :obs_group_id).find(measure.obs_id)
+          obs = Observation.find(measure.obs_id)
           encounter = Encounter.find(obs.encounter_id)
           program_id = encounter.program_id
         end
@@ -19,8 +19,8 @@ module Lab
         {
           id: measure.obs_id,
           indicator: {
-            concept_id: measure.concept_id,
-            name: concept_name
+            concept_id: concept_name&.concept_id,
+            name: concept_name&.name
           },
           date: measure.obs_datetime,
           value:,
@@ -31,12 +31,6 @@ module Lab
       end
     end
 
-    def self.get_test_catalog_concept_name(concept_id)
-      return nil unless concept_id
-
-      ::ConceptAttribute.find_by(concept_id:, attribute_type: ConceptAttributeType.test_catalogue_name)&.value_reference
-    end
-
     def self.read_value(measure)
       %w[value_numeric value_coded value_boolean value_text].each do |field|
         value = measure.send(field) if measure.respond_to?(field)

data/app/services/lab/concepts_service.rb

@@ -61,7 +61,7 @@ module Lab
         INNER JOIN concept_attribute ca2 ON ca.concept_id = ca2.concept_id
           AND ca2.attribute_type_id = #{ConceptAttributeType.nlims_code.concept_attribute_type_id}
         WHERE ca.attribute_type_id = #{ConceptAttributeType.test_catalogue_name.concept_attribute_type_id}
-        AND ca.concept_id IN (#{concept_set.select(:concept_set).to_sql})
+        AND ca.concept_id IN (#{concept_set.select(:concept_id).to_sql})
         GROUP BY ca.concept_id
       SQL
     end

data/app/services/lab/lims/api/rest_api.rb

@@ -341,7 +341,7 @@ module Lab
         def nlims_order_exists?(tracking_number)
           response = in_authenticated_session do |headers|
             Rails.logger.info("Verifying order ##{tracking_number}")
-            RestClient.get(expand_uri("orders/#{tracking_number}/exists", api_version: 'v2'), headers)
+            RestClient.get(expand_uri("orders/#{tracking_number}", api_version: 'v2'), headers)
           end
 
           Rails.logger.info("Order ##{tracking_number} verified... Parsing...")

data/app/services/lab/lims/pull_worker.rb

@@ -216,7 +216,7 @@ module Lab
           end
 
           next if test.result || test_results['results'].blank?
-
+          
           result_date = Time.now
           measures = test_results['results'].map do |indicator, value|
             measure = find_measure(order, indicator, value)

data/app/services/lab/lims/utils.rb

@@ -78,12 +78,8 @@ module Lab
       end
 
       def self.find_concept_by_name(name)
-        unescaped_name = CGI.unescapeHTML(name)
-        attribute_type_id = ConceptAttributeType.test_catalogue_name.concept_attribute_type_id
-
-        ConceptName.joins('INNER JOIN concept_attribute ON concept_attribute.concept_id = concept_name.concept_id')
-                   .where('concept_attribute.attribute_type_id = ? AND concept_attribute.value_reference = ? AND concept_name.name = ?',
-                          attribute_type_id, unescaped_name, unescaped_name)
+        ConceptName.joins("INNER JOIN concept_attribute ON concept_attribute.concept_id = concept_name.concept_id")
+                   .where("concept_attribute.value_reference = ?", CGI.unescapeHTML(name))
                    .first
       end
     end

data/app/services/lab/results_service.rb

@@ -20,11 +20,7 @@ module Lab
         serializer = {}
         results_obs = {}
         ActiveRecord::Base.transaction do
-          test = begin
-            Lab::LabTest.find(test_id)
-          rescue StandardError
-            nil
-          end
+          test = Lab::LabTest.find(test_id) rescue nil
           test = Lab::LabTest.find_by_uuid(test_id) if test.blank?
           encounter = find_encounter(test, encounter_id: params[:encounter_id],
                                            encounter_uuid: params[:encounter],
@@ -41,9 +37,9 @@ module Lab
 
         # force commit all transactions
         ActiveRecord::Base.connection.commit_db_transaction
-
-        # Execute job synchronously
-        ProcessLabResultJob.perform_now(results_obs.id, serializer, result_enter_by)
+        
+        # delay job by a second
+        ProcessLabResultJob.set(wait: 1.second).perform_later(results_obs.id, serializer, result_enter_by)
 
         Rails.logger.info("Lab::ResultsService: Result created for test #{test_id} #{serializer}")
         serializer
@@ -59,10 +55,10 @@ module Lab
       def precess_notification_message(result, values, result_enter_by)
         order = Order.find(result.order_id)
         data = { Type: result_enter_by,
-                 Specimen: get_test_catalog_name(order.concept_id) || ConceptName.find_by(concept_id: order.concept_id)&.name,
-                 'Test type': get_test_catalog_name(result.test.value_coded) || ConceptName.find_by(concept_id: result.test.value_coded)&.name,
+                 Specimen: ConceptName.find_by(concept_id: order.concept_id)&.name,
+                 'Test type': ConceptName.find_by(concept_id: result.test.value_coded)&.name,
                  'Accession number': order&.accession_number,
-                 order_date: Order.columns.include?('start_date') ? order.start_date : order.date_created,
+                 'Orde date': Order.columns.include?('start_date') ? order.start_date : order.date_created,
                  'ARV-Number': find_arv_number(result.person_id),
                  PatientID: result.person_id,
                  'Ordered By': Order.columns.include?('provider_id') ? order&.provider&.person&.name : Person.find(order.creator)&.name,
@@ -86,21 +82,19 @@ module Lab
       def find_encounter(test, encounter_id: nil, encounter_uuid: nil, date: nil, provider_id: nil)
         return Encounter.find(encounter_id) if encounter_id
         return Encounter.find_by_uuid(encounter_uuid) if encounter_uuid
-
-        lab_encounter_type = EncounterType.find_by_name!(Lab::Metadata::ENCOUNTER_TYPE_NAME)
+        encounter_type = EncounterType.find_by_name!(Lab::Metadata::ENCOUNTER_TYPE_NAME)
 
         encounter = Encounter.new
         encounter.patient_id = test.person_id
         encounter.program_id = test.encounter.program_id if Encounter.column_names.include?('program_id')
         encounter.visit_id = test.encounter.visit_id if Encounter.column_names.include?('visit_id')
-        # Use bracket notation to set the encounter_type column directly (bypasses association)
-        # This handles both Integer and EncounterType object
-        encounter_type_value = lab_encounter_type.is_a?(Integer) ? lab_encounter_type : lab_encounter_type.encounter_type_id
-        encounter[:encounter_type] = encounter_type_value
+        encounter.type = encounter_type
+        encounter.encounter_type = encounter_type if (encounter&.encounter_type.nil? || encounter&.type.nil?)
         encounter.encounter_datetime = date || Date.today
         encounter.provider_id = provider_id || User.current.user_id if Encounter.column_names.include?('provider_id')
+
         encounter.save!
-        encounter.reload
+
         encounter
       end
 
@@ -136,8 +130,7 @@ module Lab
       def add_measure_to_results(results_obs, params, date)
         validate_measure_params(params)
 
-        concept_id = params[:indicator][:concept_id] || Concept.find_concept_by_uuid(params.dig(:indicator,
-                                                                                                :concept))&.id
+        concept_id = params[:indicator][:concept_id] || Concept.find_concept_by_uuid(params.dig(:indicator, :concept))&.id
 
         Observation.create!(
           person_id: results_obs.person_id,
@@ -181,13 +174,6 @@ module Lab
         else raise InvalidParameterError, "Invalid boolean value: #{string}"
         end
       end
-
-      def get_test_catalog_name(concept_id)
-        return nil unless concept_id
-
-        ::ConceptAttribute.find_by(concept_id:,
-                                   attribute_type: ConceptAttributeType.test_catalogue_name)&.value_reference
-      end
     end
   end
 end

data/lib/lab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Lab
-  VERSION = '2.1.4-alpha'
+  VERSION = '2.1.4-beta'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: his_emr_api_lab
 version: !ruby/object:Gem::Version
-  version: 2.1.4.pre.alpha
+  version: 2.1.4.pre.beta
 platform: ruby
 authors:
 - Elizabeth Glaser Pediatric Foundation Malawi
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-01-30 00:00:00.000000000 Z
+date: 2026-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: couchrest