hippie_csv 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0c3685fbff376b677274444f9b9211a80165cabd
-  data.tar.gz: 36322262f11c8ff9e28e90fa17ebd9be07cc9bad
+  metadata.gz: d09ec409677ca747265cd3542b2ca799d7d6cb78
+  data.tar.gz: 3f6a81c389556408e7cae8dd73f5e6da70bc5593
 SHA512:
-  metadata.gz: 8d050fb4b1d7836f1167bacae1884126c92797026e1ac9177b1df316dcf146ffb34d46fc062e1a0bf5440cc9c6863fb750bc14ea76a08969a9969a90b70840b9
-  data.tar.gz: 24bcf0eb9c671a7116a311b74e3b381ae7557067f1e5d9174c835ac58344b5f4b0e8eaa263443d2ffd0f7b73ba7474fcb21e7c3be2b948a7d4add2507da4b14b
+  metadata.gz: 46c7ceaf2d3125fe02b3ba8feb8aedb4078db0eb685f109a8cb4e6f0006b008c14a4d4d74828269662023fc34a75d4e8d3a1732cac76539c848c906955a7b073
+  data.tar.gz: 22ac0bfd0871c7c7b6c010667da643307e7bc5d4d5a12da0d9ead4134b0ec79fb8126883023a8c4b69d6dd476ffc144ff9cd65c88c06aab4caa1482e0b7360cd

data/lib/hippie_csv/version.rb

@@ -1,3 +1,3 @@
 module HippieCSV
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 end

data/spec/fixtures/{trailing_leading_lines.csv → trailing_leading_blank_lines.csv}

@@ -1,20 +1,30 @@
 
 
+
+
+
+,,,,,,
 id,email,name,country,city,created_at,admin
 102,patrick@intercom.io,Patrick O'Doherty,United States,San Francisco,2014-04-28 23:57:08 UTC,true
 103,ben@intercom.io,Ben McRedmond,United States,San Francisco,2014-04-27 23:57:08 UTC,false
 104,ciaran@intercom.io,Ciaran Lee,Ireland,Dublin,2014-04-26 23:57:08 UTC,true
 105,eoghan@intercom.io,Eoghan McCabe,United States,San Francisco,2014-04-25 23:57:08 UTC,true
 106,des@intercom.io,Des Traynor,Ireland,Dublin,2014-04-24 23:57:08 UTC,true
+,,,,,,
+,,,,,,
+,,,,,,
 107,darragh@intercom.io,Darragh Curran,Ireland,Dublin,2014-04-23 23:57:08 UTC,true
 108,jeff@intercom.io,Jeff Gardner,Italy,Prata Camportaccio,2014-04-22 23:57:08 UTC,true
 109,macey@intercom.io,Macey Baker,United States,San Francisco,2014-04-21 23:57:08 UTC,true
 110,adam@intercom.io,Adam McCarthy,Dublin,Ireland,2014-04-20 23:57:08 UTC,true
+,,,,,,
 111,declan@intercom.io,Declan McGrath,Dublin,Ireland,2014-04-19 23:57:08 UTC,false
 112,peter@intercom.io,Peter McKenna,Dublin,Ireland,2014-04-18 23:57:08 UTC,false
 113,david@intercom.io,David Barett,Dublin,Ireland,2014-04-17 23:57:08 UTC,true
 114,eoin@intercom.io,Eoin Hennessy,Dublin,Ireland,2014-04-16 23:57:08 UTC,false
+,,,,,,
+
+
 
 
 
- 

data/spec/hippie_csv/version_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe HippieCSV do
 
   it "defines a version" do
-    expect(HippieCSV::VERSION).to eq("0.0.7")
+    expect(HippieCSV::VERSION).to eq("0.0.8")
   end
 
 end

data/spec/hippie_csv_spec.rb

@@ -124,7 +124,7 @@ describe HippieCSV do
     it "works when many invalid quote types contained" do
       path = fixture_path(:bad_quoting)
 
-      expect { CSV.read(path) }.to raise_error
+      expect { CSV.read(path) }.to raise_error(CSV::MalformedCSVError)
       expect {
         import = subject.read(path)
         expect(import.map(&:count).uniq).to eq([11])
@@ -133,11 +133,18 @@ describe HippieCSV do
     end
 
     it "strips leading/trailing blank lines" do
-      path = fixture_path(:trailing_leading_lines)
+      path = fixture_path(:trailing_leading_blank_lines)
 
       import = subject.read(path)
       expect(import.first).not_to be_empty
       expect(import.last).not_to be_empty
     end
+
+    it "maintains coherent column count when stripping blank lines" do
+      path = fixture_path(:trailing_leading_blank_lines)
+
+      import = subject.read(path)
+      expect(import.map(&:length).uniq.size).to eq(1)
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hippie_csv
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Stephen O'Brien
@@ -109,7 +109,7 @@ files:
 - spec/fixtures/malformed.csv
 - spec/fixtures/never_ordered.csv
 - spec/fixtures/normal.csv
-- spec/fixtures/trailing_leading_lines.csv
+- spec/fixtures/trailing_leading_blank_lines.csv
 - spec/fixtures/with_byte_order_mark.csv
 - spec/hippie_csv/constants_spec.rb
 - spec/hippie_csv/support_spec.rb
@@ -151,7 +151,7 @@ test_files:
 - spec/fixtures/malformed.csv
 - spec/fixtures/never_ordered.csv
 - spec/fixtures/normal.csv
-- spec/fixtures/trailing_leading_lines.csv
+- spec/fixtures/trailing_leading_blank_lines.csv
 - spec/fixtures/with_byte_order_mark.csv
 - spec/hippie_csv/constants_spec.rb
 - spec/hippie_csv/support_spec.rb