hipbot 1.0.0.rc2 → 1.0.0

data/spec/unit/message_spec.rb

@@ -4,9 +4,9 @@ describe Hipbot::Message do
   subject { Hipbot::Message }
   let(:sender) { stub }
   let(:room) { stub }
-  before(:all) do
-    Hipbot.bot = Hipbot::Bot.instance
-  end
+  before(:all) {
+    Hipbot::Bot.instance.setup
+  }
 
   it "should have a body" do
     message = subject.new('this is a message', room, sender)
@@ -34,25 +34,32 @@ describe Hipbot::Message do
     message.recipients.should include('dave')
   end
 
-  it "should strip primary recipient from message" do
+  it "should strip bot mention from message" do
+    Hipbot.configuration.user = stub(mention: 'dave')
     message = subject.new('@dave this is a message for @tom', room, sender)
     message.body.should == 'this is a message for @tom'
   end
 
-  it "should strip primary recipient from message with commma" do
+  it "should strip bot mention from message with commma" do
+    Hipbot.configuration.user = stub(mention: 'dave')
     message = subject.new('@dave, this is a message for @tom', room, sender)
     message.body.should == 'this is a message for @tom'
   end
 
   it "should be for bot" do
-    user = stub(:mention => 'robot')
+    user = stub(mention: 'robot')
     message = subject.new('hello @robot!', room, sender)
     message.for?(user).should be_true
   end
 
   it "should not be for bot" do
-    user = stub(:mention => 'robot')
+    user = stub(mention: 'robot')
     message = subject.new('hello @tom!', room, sender)
     message.for?(user).should be_false
   end
+
+  it 'knows its recipients' do
+    message = subject.new('@tom, @dave: @mike')
+    message.recipients.should == ['tom', 'dave', 'mike']
+  end
 end

data/spec/unit/reaction_factory_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe Hipbot::ReactionFactory do
+  subject { described_class.new(stub) }
+
+  let(:params) { [] }
+  let(:block) { stub }
+
+  let(:options_stack) { [subject.get_reaction_options(params)] }
+  let(:reaction) { subject.build(options_stack, block) }
+
+  describe "taking a regexp" do
+    let(:params) { [/.*/] }
+
+    it "builds a reaction with regexp" do
+      expect(reaction.regexps).to eq([/.*/i])
+    end
+
+    describe "with additional options" do
+      let(:params) { [/.*/, { from: 'wat' }] }
+
+      it "builds a reaction with proper options" do
+        expect(reaction.options).to eq(from: 'wat', regexps: [/.*/], desc: nil)
+      end
+    end
+  end
+
+  describe "taking multiple regexps and options" do
+    let(:params) { [/.*/, /wat/, { from: 'wat' }] }
+
+    it "builds a reaction with proper options" do
+      expect(reaction.options).to eq(from: 'wat', regexps: [/.*/, /wat/], desc: nil)
+    end
+  end
+
+  describe "setting description" do
+    before do
+      subject.description('woot')
+    end
+
+    it "builds reaction with proper description" do
+      expect(reaction.desc).to eq('woot')
+    end
+
+    it "resets description after first built reaction" do
+      subject.build(params, block)
+      expect(reaction.desc).to be_nil
+    end
+  end
+
+  it "applies optional scope params as default" do
+    expect(subject.build([{ from: 'dave' }], block).options[:from]).to eq('dave')
+  end
+end

data/spec/unit/reaction_spec.rb

@@ -0,0 +1,99 @@
+require 'spec_helper'
+
+describe Hipbot::Reaction do
+  subject { Hipbot::Reaction }
+
+  context 'instance' do
+    let(:options){ {} }
+    let(:reaction){ subject.new(@plugin, options, @block) }
+
+    it '#in_any_room?' do
+      reaction.in_any_room?.should be_false
+      options[:room] = true
+      reaction.in_any_room?.should be_true
+    end
+
+    it '#to_anything?' do
+      reaction.to_anything?.should be_true
+      reaction.options[:regexps] = nil
+      reaction.to_anything?.should be_true
+    end
+
+    it '#from_anywhere?' do
+      reaction.from_anywhere?.should be_true
+      reaction.options[:room] = nil
+      reaction.from_anywhere?.should be_true
+    end
+
+    it '#condition' do
+      reaction.condition.call.should be_true
+      reaction.options[:if] = proc{ false }
+      reaction.condition.call.should be_false
+    end
+
+    it '#delete' do
+      @plugin = stub(reactions: [reaction])
+      reaction.plugin = @plugin
+      reaction.delete
+      @plugin.reactions.should be_empty
+    end
+
+    it '#desc' do
+      reaction.desc.should be_nil
+      reaction.options[:desc] = 'description'
+      reaction.desc.should == 'description'
+    end
+
+    it '#from_all?' do
+      reaction.from_all?.should be_true
+      reaction.options[:room] = nil
+      reaction.from_all?.should be_true
+    end
+
+    it '#global?' do
+      reaction.global?.should be_false
+      reaction.options = { global: true }
+      reaction.global?.should be_true
+    end
+
+    it '#plugin_name' do
+      @plugin = (MyPlugins = Class.new)
+      reaction.plugin_name.should == 'MyPlugins'
+    end
+
+    it '#match_with' do
+      message = stub
+      reaction.match_with(message).should == Hipbot::Match.new(reaction, message)
+    end
+
+    it '#to_private_message?' do
+      reaction.to_private_message?.should be_false
+      reaction.options[:room] = false
+      reaction.to_private_message?.should be_true
+    end
+
+    it '#regexps' do
+      options[:regexps] = [/^sample regexp$/i, /^another one$/]
+      reaction.regexps.should == [/^sample regexp$/i, /^another one$/i]
+    end
+
+    it '#readable_command' do
+      options[:regexps] = [/^sample regexp$/i, /^another one$/]
+      reaction.readable_command.should == 'sample regexp or another one'
+    end
+
+    it '#rooms' do
+      rooms = ['Room 1', 'Room 2']
+      Hipbot.bot = stub(rooms: { special_rooms: rooms })
+      options[:room] = [:special_rooms, 'Room 3']
+      reaction.rooms.should == [*rooms, 'Room 3']
+    end
+
+    it '#users' do
+      users = ['User 1', 'User 2']
+      Hipbot.bot = stub(teams: { special_users: users })
+      options[:from] = [:special_users, 'User 3']
+      reaction.users.should == [*users, 'User 3']
+    end
+  end
+end

data/spec/unit/storages/hash_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+describe Hipbot::Storages::Hash do
+  let(:collection) { Class.new{ include Hipbot::Storages::Hash } }
+  let(:item) { collection.find(1) }
+  before do
+    @item = collection.create(id: 1, name: 'item', something: 'value')
+  end
+
+  context 'collection' do
+    context '#create' do
+      it 'creates new item' do
+        collection.all.count.should == 1
+      end
+
+      it 'saves the id' do
+        @item.id.should == 1
+      end
+
+      it 'saves the attributes' do
+        @item.attributes[:something].should == 'value'
+      end
+    end
+
+    context 'lookups' do
+      it 'finds by id' do
+        item.should == @item
+      end
+
+      it 'finds by params' do
+        collection.find_by(name: 'item') == @item
+        collection.find_by(name: 'item', id: 1) == @item
+        collection.find_by(name: 'item', id: 1, something: 'value') == @item
+      end
+
+      it 'finds all by params' do
+        @item2 = collection.create(id: 2, name: 'item 2', something: 'value')
+        collection.where(something: 'value').should == [@item, @item2]
+      end
+    end
+  end
+
+  context 'item' do
+    it 'aliases :name as :to_s' do
+      item.to_s.should == item.name
+    end
+
+    context 'updating attributes on lookup result' do
+      before do
+        item.update_attributes(name: 'item 2', something: 'value 2')
+      end
+
+      it 'changes the attributes' do
+        @item.name.should == 'item 2'
+        @item.attributes[:something].should == 'value 2'
+      end
+    end
+
+    context 'updating attributes on created object' do
+      before do
+        @item.update_attributes(name: 'item 3', something: 'value 3')
+      end
+
+      it 'changes the attributes' do
+        item.name.should == 'item 3'
+        item.attributes[:something].should == 'value 3'
+      end
+    end
+
+    it 'destroys itself' do
+      item.destroy
+      collection.all.should be_empty
+    end
+  end
+end

data/spec/unit/user_spec.rb

@@ -2,7 +2,6 @@ require 'spec_helper'
 
 describe Hipbot::User do
   subject { described_class.new(id: '1234', name: 'test bot', mention: 'testbotmention') }
-  before { described_class.send(:include, Hipbot::Collection) }
 
   its(:first_name) { should == 'test' }
   its(:mention) { should == 'testbotmention' }
@@ -11,5 +10,4 @@ describe Hipbot::User do
     subject { described_class.new(id: '1234', name: 'test bot name') }
     its(:mention) { should == 'testbotname' }
   end
-
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hipbot
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc2
+  version: 1.0.0
 platform: ruby
 authors:
 - Bartosz Kopiński
@@ -9,92 +9,78 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-03 00:00:00.000000000 Z
+date: 2013-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: daemons
+  name: xmpp4r-hipchat
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.1.8
+        version: 0.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.1.8
+        version: 0.0.3
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: daemons
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 3.2.12
+        version: 1.1.8
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 3.2.12
+        version: 1.1.8
 - !ruby/object:Gem::Dependency
-  name: i18n
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 3.2.12
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 3.2.12
 - !ruby/object:Gem::Dependency
   name: eventmachine
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.3
 - !ruby/object:Gem::Dependency
   name: em-http-request
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.3
-- !ruby/object:Gem::Dependency
-  name: xmpp4r
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.5'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -137,7 +123,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 0.13.3
-description: Hipbot is a bot for HipChat, written in ruby & eventmachine.
+description: Hipbot is a XMPP bot for HipChat, written in Ruby with EventMachine.
 email:
 - bartosz.kopinski@netguru.pl
 - pewniak747@gmail.com
@@ -150,44 +136,62 @@ files:
 - .rspec
 - .travis.yml
 - Gemfile
-- Gemfile.lock
 - Guardfile
 - LICENSE
 - README.md
 - Rakefile
 - bin/hipbot
-- examples/cleverbot.rb
-- examples/google_images.rb
 - hipbot.gemspec
 - lib/hipbot.rb
-- lib/hipbot/adapters/hipchat/connection.rb
-- lib/hipbot/adapters/hipchat/hipchat.rb
-- lib/hipbot/adapters/telnet/connection.rb
-- lib/hipbot/adapters/telnet/telnet.rb
+- lib/hipbot/adapter.rb
+- lib/hipbot/adapters/hipchat.rb
+- lib/hipbot/adapters/hipchat/initializer.rb
+- lib/hipbot/adapters/shell.rb
+- lib/hipbot/adapters/telnet.rb
 - lib/hipbot/bot.rb
-- lib/hipbot/collection.rb
+- lib/hipbot/cache.rb
+- lib/hipbot/callbacks/base.rb
+- lib/hipbot/callbacks/invite.rb
+- lib/hipbot/callbacks/lobby_presence.rb
+- lib/hipbot/callbacks/message.rb
+- lib/hipbot/callbacks/presence.rb
+- lib/hipbot/callbacks/private_message.rb
+- lib/hipbot/callbacks/room_message.rb
+- lib/hipbot/callbacks/room_presence.rb
+- lib/hipbot/configurable.rb
 - lib/hipbot/configuration.rb
 - lib/hipbot/helpers.rb
+- lib/hipbot/http.rb
 - lib/hipbot/logger.rb
 - lib/hipbot/match.rb
+- lib/hipbot/matchable.rb
 - lib/hipbot/message.rb
 - lib/hipbot/patches/encoding.rb
-- lib/hipbot/patches/hipchat_client.rb
 - lib/hipbot/plugin.rb
 - lib/hipbot/reactable.rb
 - lib/hipbot/reaction.rb
+- lib/hipbot/reaction_factory.rb
 - lib/hipbot/response.rb
 - lib/hipbot/room.rb
+- lib/hipbot/storages/base.rb
+- lib/hipbot/storages/hash.rb
+- lib/hipbot/storages/mongoid.rb
 - lib/hipbot/user.rb
 - lib/hipbot/version.rb
-- spec/integration/hipbot_spec.rb
 - spec/integration/my_hipbot.rb
+- spec/integration/my_hipbot_spec.rb
 - spec/spec_helper.rb
-- spec/unit/hipbot_spec.rb
+- spec/unit/adapters/hipchat_spec.rb
+- spec/unit/bot_spec.rb
+- spec/unit/match_spec.rb
 - spec/unit/message_spec.rb
+- spec/unit/reaction_factory_spec.rb
+- spec/unit/reaction_spec.rb
+- spec/unit/storages/hash_spec.rb
 - spec/unit/user_spec.rb
 homepage: http://github.com/pewniak747/hipbot
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -200,19 +204,25 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>'
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
-summary: Hipbot is a bot for HipChat, written in ruby & eventmachine.
+summary: Hipbot is a XMPP bot for HipChat, written in Ruby with EventMachine.
 test_files:
-- spec/integration/hipbot_spec.rb
 - spec/integration/my_hipbot.rb
+- spec/integration/my_hipbot_spec.rb
 - spec/spec_helper.rb
-- spec/unit/hipbot_spec.rb
+- spec/unit/adapters/hipchat_spec.rb
+- spec/unit/bot_spec.rb
+- spec/unit/match_spec.rb
 - spec/unit/message_spec.rb
+- spec/unit/reaction_factory_spec.rb
+- spec/unit/reaction_spec.rb
+- spec/unit/storages/hash_spec.rb
 - spec/unit/user_spec.rb
+has_rdoc: