hinderinputjs-rails 0.0.1 → 0.0.2

data/lib/hinderinputjs-rails/version.rb

@@ -1,5 +1,5 @@
 module Hinderinputjs
   module Rails
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

data/vendor/assets/javascripts/jquery.caret.js

@@ -5,26 +5,33 @@
 (function( $ ) {
 
   /**
-   *  Set a selection range with the given start and end indicies
+   *  Set a selection range with the given start and end indicies.
+   *
+   * @param {number} start The position at which to start the selection.
+   * @param {number} end The position at which to end the selection.
    **/
   $.fn.setSelection = function( start, end ) {
     return this.each(function( index, element ){
+      var range;
+
       if ( typeof element.setSelectionRange === 'function' ) {
         element.focus();
         element.setSelectionRange( start, end );
       }
       else if( typeof element.createTextRange === 'function' ) {
-        var range = element.createTextRange();
-          range.collapse( true );
-          range.moveEnd( 'character', start );
-          range.moveStart( 'character', end );
-          range.select();
+        range = element.createTextRange();
+        range.collapse( true );
+        range.moveEnd( 'character', start );
+        range.moveStart( 'character', end );
+        range.select();
       }
     });
   };
 
   /**
-   * Set the position of the cursor to the given index
+   * Set the position of the cursor to the given index.
+   *
+   * @param {number} pos The position at which to set the caret.
    **/
   $.fn.setCaretPosition = function( pos ) {
     return this.each(function( index, element ) {

data/vendor/assets/javascripts/jquery.hinderinput.js

@@ -17,28 +17,14 @@
     return this.each(function( index, element ) {
       var $target = $(this);
 
-      $target.keypress(function( event ) {
-        hinderInput.addChar.call( hinderInput, event, options );
-      }).keydown(function( event ) {
-        hinderInput.addSpecial.call( hinderInput, event, options );
-      }).click(function( event ) {
-        $target.setCaretAtEnd();
-      });
+      $target.keypress( $.proxy( hinderInput.addChar, hinderInput, options ) )
+        .keydown( $.proxy( hinderInput.addSpecial, hinderInput, options ) )
+        .click(function( event ) {
+          $target.setCaretAtEnd();
+        });
     });
   };
 
-  /**
-   * The default options for hinderInput.
-   **/
-  hinderInput.defaults = {
-    onAdd: function( value ) {
-      return;
-    },
-    onDelete: function() {
-      return;
-    }
-  };
-
   /**
    * Add a character to the input if it's valid.  Execute the onAdd
    * callback.
@@ -46,7 +32,7 @@
    * @param {object} event The event that triggered the input.
    * @param {object} options The options provided to hinderInput.
    **/
-  hinderInput.addChar = function( event, options ){
+  hinderInput.addChar = function( options, event ){
     var $target = $(event.target),
       keyCode = event.which;
 
@@ -63,22 +49,17 @@
    * @param {object} event The event that triggered the input.
    * @param {object} options The options provided to hinderInput.
    **/
-  hinderInput.addSpecial = function( event, options ) {
+  hinderInput.addSpecial = function( options, event ) {
     var $target = $( event.target ),
       keyCode = event.which;
 
     $target.setCaretAtEnd();
 
-    if ( this.isModifierPresent( event ) || this.isArrowKey( keyCode ) ) {
-      event.preventDefault();
-      return;
-    }
-
     if( keyCode === 8 ) {
       options.onDelete();
     }
-    // TODO refactor
-    else if( !this.isValidChar(keyCode) ) {
+    //TODO more TLC
+    else if( !this.isValidChar(keyCode) || this.isModifierPresent( event ) ) {
       event.preventDefault();
     }
   };
@@ -90,16 +71,9 @@
    * @param {number} keyCode The char code of the character to check.
    **/
   hinderInput.isValidChar = function( keyCode ) {
-    return (keyCode >= 32) && (keyCode <= 126) || (keyCode >= 186) && (keyCode <= 222);
-  };
-
-  /**
-   * Determine if the given key code is an arrow key.
-   *
-   * @param {number} keyCode The char code of the character to check.
-   **/
-  hinderInput.isArrowKey = function( keyCode ) {
-    return [37, 38, 39, 40].indexOf( keyCode ) !== -1;
+    return (keyCode > 31 && keyCode < 37)
+      || (keyCode > 40 && keyCode < 127)
+      || (keyCode > 185 && keyCode < 223);
   };
 
   /**
@@ -112,4 +86,16 @@
     return event.altKey || event.ctrlKey || event.metaKey;
   };
 
+  /**
+   * The default options for hinderInput.
+   **/
+  hinderInput.defaults = {
+    onAdd: function( value ) {
+      return;
+    },
+    onDelete: function() {
+      return;
+    }
+  };
+
 })( jQuery );

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hinderinputjs-rails
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-04 00:00:00.000000000 Z
+date: 2012-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -60,7 +60,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -806024439033560381
+      hash: 3659832406573053636
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -69,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -806024439033560381
+      hash: 3659832406573053636
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24