hightop 0.3.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee918ba56e73e37d1c623e99f4bf2971f1f99a82a369582eaf78144951dab192
-  data.tar.gz: c626b6953aae5d3e43e00291b5fba24d8326d133f5aba945ab58f59f4defcb65
+  metadata.gz: 1e2aa6433ef6bce3eeb12610eaa528a9ecd9b41d5efdcfb6483b7ea024937c81
+  data.tar.gz: dda7fd42d30a5eb6e02a4dc30cf92cf9a2a5893003805aceba07ead334800280
 SHA512:
-  metadata.gz: e82a5854442ce691bc664cf6bb32aa1db21ec5e527fbc4c2ff9ddca49c8b278b8edc454cb0178ddc147ab47db324b091a65840783c9912a3051c16185bf45be3
-  data.tar.gz: '0978f96d0c782e7e6cb9221c11ea01f1ec55ebc1e287fec595416b587f64d30dbe8dcda0859a18d81445ea5900b21c3acf1838cb9c29592bfa76a192f7bd76d2'
+  metadata.gz: 262218e9bb2753e7519459d6b63882ae948b599b14d28f9042af9bf379d9ca516e47cd1202c001df92806cc29fa2817313099a46cf452ba5a5b6207a131a4102
+  data.tar.gz: d7015662042f38e090b4dc0c330acacc6050ce68243c13d0967451296c2fe04698029d97258face412e691f9c244986b645797131f00cd3284d0fc641e07145e

data/CHANGELOG.md

@@ -1,7 +1,17 @@
+## 0.5.0 (2024-10-07)
+
+- Fixed connection leasing for Active Record 7.2+
+- Dropped support for Active Record < 7 and Ruby < 3.1
+
+## 0.4.0 (2023-07-02)
+
+- Dropped support for Active Record < 6.1 and Ruby < 3
+- Dropped support for Mongoid < 7
+
 ## 0.3.0 (2021-08-12)
 
 - Raise `ActiveRecord::UnknownAttributeReference` for non-attribute arguments
-- Raise `ArgumentError` for too many arguments with enumerable
+- Raise `ArgumentError` for too many arguments with arrays and hashes
 - Removed `uniq` option (use `distinct` instead)
 - Dropped support for Active Record < 5.2 and Ruby < 2.6
 

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2014-2021 Andrew Kane
+Copyright (c) 2014-2024 Andrew Kane
 
 MIT License
 

data/README.md

@@ -13,14 +13,14 @@ Visit.top(:browser)
 
 Works with Active Record, Mongoid, arrays and hashes
 
-[![Build Status](https://github.com/ankane/hightop/workflows/build/badge.svg?branch=master)](https://github.com/ankane/hightop/actions)
+[![Build Status](https://github.com/ankane/hightop/actions/workflows/build.yml/badge.svg)](https://github.com/ankane/hightop/actions)
 
 ## Installation
 
 Add this line to your application’s Gemfile:
 
 ```ruby
-gem 'hightop'
+gem "hightop"
 ```
 
 ## Options
@@ -93,18 +93,6 @@ Min count
 ["up", "up", "down"].top(min: 2)
 ```
 
-## Upgrading
-
-### 0.3.0
-
-Hightop 0.3.0 protects against unsafe input by default. For non-attribute arguments, use:
-
-```ruby
-Visit.top(Arel.sql(known_safe_value))
-```
-
-Also, the `uniq` option has been removed. Use `distinct` instead.
-
 ## History
 
 View the [changelog](https://github.com/ankane/hightop/blob/master/CHANGELOG.md)

data/lib/hightop/enumerable.rb

@@ -1,7 +1,7 @@
 module Enumerable
   def top(*args, **options, &block)
     if block || !(respond_to?(:scoping) || respond_to?(:with_scope))
-      raise ArgumentError, "wrong number of arguments (given 2, expected 0..1)" if args.size > 1
+      raise ArgumentError, "wrong number of arguments (given #{args.size}, expected 0..1)" if args.size > 1
 
       limit = args[0]
       min = options[:min]
@@ -17,7 +17,7 @@ module Enumerable
       arr = arr[0...limit] if limit
       Hash[arr]
     elsif respond_to?(:scoping)
-      scoping { @klass.send(:top, *args, **options, &block) }
+      scoping { klass.send(:top, *args, **options, &block) }
     else
       with_scope(self) { klass.send(:top, *args, **options, &block) }
     end

data/lib/hightop/utils.rb

@@ -7,7 +7,7 @@ module Hightop
       def validate_column(column)
         unless column.is_a?(Symbol) || column.is_a?(Arel::Nodes::SqlLiteral)
           column = column.to_s
-          unless /\A\w+(\.\w+)?\z/i.match(column)
+          unless /\A\w+(\.\w+)?\z/i.match?(column)
             raise ActiveRecord::UnknownAttributeReference, "Query method called with non-attribute argument(s): #{column.inspect}. Use Arel.sql() for known-safe values."
           end
         end
@@ -18,7 +18,7 @@ module Hightop
       def resolve_column(relation, column)
         node = relation.send(:relation).send(:arel_columns, [column]).first
         node = Arel::Nodes::SqlLiteral.new(node) if node.is_a?(String)
-        relation.connection.visitor.accept(node, Arel::Collectors::SQLString.new).value
+        relation.connection_pool.with_connection { |c| c.visitor.accept(node, Arel::Collectors::SQLString.new).value }
       end
     end
   end

data/lib/hightop/version.rb

@@ -1,3 +1,3 @@
 module Hightop
-  VERSION = "0.3.0"
+  VERSION = "0.5.0"
 end

data/lib/hightop.rb

@@ -2,16 +2,16 @@
 require "active_support"
 
 # modules
-require "hightop/enumerable"
-require "hightop/version"
+require_relative "hightop/enumerable"
+require_relative "hightop/version"
 
 ActiveSupport.on_load(:active_record) do
-  require "hightop/utils"
-  require "hightop/kicks"
+  require_relative "hightop/utils"
+  require_relative "hightop/kicks"
   extend Hightop::Kicks
 end
 
 ActiveSupport.on_load(:mongoid) do
-  require "hightop/mongoid"
+  require_relative "hightop/mongoid"
   Mongoid::Document::ClassMethods.include(Hightop::Mongoid)
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hightop
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Andrew Kane
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-13 00:00:00.000000000 Z
+date: 2024-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '7'
 description:
 email: andrew@ankane.org
 executables: []
@@ -51,14 +51,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.6'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.5.16
 signing_key:
 specification_version: 4
 summary: A nice shortcut for group count queries