highrise 2.0.1 → 3.0.0

data/spec/highrise/group_spec.rb

@@ -1,14 +1,5 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe Highrise::Group do
-
-  before(:each) do
-    @group = Highrise::Group.new
-  end
-  
-  it "should be instance of Highrise::Base" do
-    @group.kind_of?(Highrise::Base).should be_true
-  end
-
-
+  it { should be_a_kind_of Highrise::Base }
 end

data/spec/highrise/kase_spec.rb

@@ -1,25 +1,17 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe Highrise::Kase do
-
-  before(:each) do
-    @kase = Highrise::Kase.new
-  end
+  it { should be_a_kind_of Highrise::Subject }
   
-  it "should be instance of Highrise::Subject" do
-    @kase.kind_of?(Highrise::Subject).should be_true
+  it "#close!" do
+    mocked_now = Time.parse("Wed Jan 14 15:43:11 -0200 2009")
+    Time.should_receive(:now).and_return(mocked_now)
+    subject.should_receive(:update_attribute).with(:closed_at, mocked_now.utc)
+    subject.close!
   end
-  
-  describe ".close!" do
-
-    it "should set close date and save" do
-      time = Time.parse("Wed Jan 14 15:43:11 -0200 2009")
-      Time.should_receive(:now).and_return(time)
-      @kase.should_receive(:closed_at=).with(time.utc)
-      @kase.should_receive(:save)
-      @kase.close!
-    end
 
+  it "#open!" do
+    subject.should_receive(:update_attribute).with(:closed_at, nil)
+    subject.open!
   end
-
 end

data/spec/highrise/membership_spec.rb

@@ -1,14 +1,5 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe Highrise::Membership do
-
-  before(:each) do
-    @member = Highrise::Membership.new
-  end
-  
-  it "should be instance of Highrise::Base" do
-    @member.kind_of?(Highrise::Base).should be_true
-  end
-
-
+  it { should be_a_kind_of Highrise::Base }
 end

data/spec/highrise/note_spec.rb

@@ -1,23 +1,14 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe Highrise::Note do
-
-  before(:each) do
-    Highrise::Base.site = 'http://example.com.i:3000'
-    @note = Highrise::Note.new(:id => 1)
-  end
-  
-  it "should be instance of Highrise::Base" do
-    @note.kind_of?(Highrise::Base).should be_true
-  end
+  subject { Highrise::Note.new(:id => 1) }
   
-  describe "comments" do
+  it { should be_a_kind_of Highrise::Base }
 
-    it "should delegate to Highrise::Comment.find with correct params" do
-      Highrise::Comment.should_receive(:find).with(:all, {:from=>"/notes/1/comments.xml"}).and_return("comments")
-      @note.comments.should == "comments"
-    end
-
-  end
+  it_should_behave_like "a paginated class"
   
+  it "#comments" do
+    Highrise::Comment.should_receive(:find).with(:all, {:from=>"/notes/1/comments.xml"}).and_return("comments")
+    subject.comments.should == "comments"
+  end
 end

data/spec/highrise/pagination_behavior.rb

@@ -0,0 +1,20 @@
+shared_examples_for "a paginated class" do
+  it { subject.class.included_modules.should include(Highrise::Pagination) }
+
+  it ".find_all_across_pages" do
+    subject.class.should_receive(:find).with(:all,{:params=>{:n=>0}}).and_return(["things"])
+    subject.class.should_receive(:find).with(:all,{:params=>{:n=>1}}).and_return([])
+    subject.class.find_all_across_pages.should == ["things"]
+  end
+  
+  it ".find_all_across_pages with zero results" do
+    subject.class.should_receive(:find).with(:all,{:params=>{:n=>0}}).and_return(nil)
+    subject.class.find_all_across_pages.should == []
+  end
+
+  it ".find_all_across_pages_since" do
+    time = Time.parse("Wed Jan 14 15:43:11 -0200 2009")
+    subject.class.should_receive(:find_all_across_pages).with({:params=>{:since=>"20090114174311"}}).and_return("result")
+    subject.class.find_all_across_pages_since(time).should == "result"
+  end
+end

data/spec/highrise/pagination_spec.rb

@@ -1,10 +1,8 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe Highrise::Pagination do
+  class TestClass < Highrise::Base; include Highrise::Pagination; end
+  subject { TestClass.new }
   
-  it "should be tested" do
-    Highrise::Person.should_receive(:find).with(:all,{:params=>{:n=>0}}).and_return(["people"])
-    Highrise::Person.should_receive(:find).with(:all,{:params=>{:n=>1}}).and_return([])
-    Highrise::Person.find_all_across_pages.should == ["people"]
-  end
+  it_should_behave_like "a paginated class"
 end

data/spec/highrise/party_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe Highrise::Party do
+  it { should be_a_kind_of Highrise::Base }
+
+  it ".recently_viewed" do
+    Highrise::Party.should_receive(:find).with(:all, {:from => '/parties/recently_viewed.xml'})
+    Highrise::Party.recently_viewed
+  end
+  
+  it ".deletions_since" do
+    time = Time.parse("Wed Jan 14 15:43:11 -0200 2009")
+    Highrise::Party.should_receive(:find).with(:all, {:from => '/parties/deletions.xml', :params=>{:since=>"20090114174311"}}).and_return("result")
+    Highrise::Party.deletions_since(time).should == "result"
+  end
+end

data/spec/highrise/person_spec.rb

@@ -1,96 +1,39 @@
 # encoding: utf-8
-
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe Highrise::Person do
-
-  before(:each) do
-    Highrise::Base.site = 'http://example.com.i:3000'
-    @person = Highrise::Person.new(:id => 1)
-    returning @tags = [] do 
-      @tags << {'id' => "414578", 'name' => "cliente"}
-      @tags << {'id' => "414587", 'name' => "walk"}
-    end
-  end
+  subject { Highrise::Person.new(:id => 1) }
   
-  it "should be instance of Highrise::Subject" do
-    @person.kind_of?(Highrise::Subject).should be_true
-  end
-  
-  describe ".find_all_across_pages_since" do
-    
-    it "should delegate to find_all_across_pages with correct params" do
-      time = Time.parse("Wed Jan 14 15:43:11 -0200 2009")
-      Highrise::Person.should_receive(:find_all_across_pages).with({:params=>{:since=>"20090114174311"}}).and_return("result")
-      Highrise::Person.find_all_across_pages_since(time).should == "result"
-    end
+  it { should be_a_kind_of Highrise::Subject }
 
-  end
-  
-  describe ".company" do
-
-    it "should return nil when doesn't have company_id" do
-      @person.should_receive(:company_id).and_return(nil)
-      @person.company.should be_nil
-    end
-
-    it "should delegate to Highrise::Company when have company_id" do
-      @person.should_receive(:company_id).at_least(2).times.and_return(1)
-      Highrise::Company.should_receive(:find).with(1).and_return("company")
-      @person.company.should == "company"
-    end
+  it_should_behave_like "a paginated class"
+  it_should_behave_like "a taggable class"
+  it_should_behave_like "a searchable class"
 
+  it ".find_all_across_pages_since" do
+    mocked_now = Time.parse("Wed Jan 14 15:43:11 -0200 2009")
+    Highrise::Person.should_receive(:find_all_across_pages).with({:params=>{:since=>"20090114174311"}}).and_return("result")
+    Highrise::Person.find_all_across_pages_since(mocked_now).should == "result"
   end
   
-  describe ".name" do
-
-    it "should concat fist_name with last_name and strip" do
-      @person.should_receive(:first_name).and_return("Marcos")
-      @person.should_receive(:last_name).and_return("Tapajós     ")
-      @person.name.should == "Marcos Tapajós"
+  describe "#company" do
+    it "returns nil when it doesn't have a company" do
+      subject.should_receive(:company_id).and_return(nil)
+      subject.company.should be_nil
     end
 
-  end
-  
-  describe ".tags" do
-    
-    it "should return an array of all tags for that user." do
-      @person.should_receive(:get).with(:tags).and_return(@tags)
-      @person.tags.should == @tags
-    end
-    
-  end
-  
-  describe "tag!(tag_name)" do
-  
-    it "should create a tag for this user." do
-      @person.should_receive(:post).with(:tags, :name => "Forum_User" ).and_return(true)
-      @person.tag!("Forum_User").should be_true
-    end
-    
-  end
-  
-  describe "untag!(tag_name)" do
-  
-    it "should delete a tag for this user." do
-      @person.should_receive(:get).with(:tags).and_return(@tags)
-      @person.should_receive(:delete).with("tags/414578").and_return(true)
-      @person.untag!("cliente").should be_true
-    end
-    
-  end
-  
-  describe ".label" do
-    it "should return 'Party' for label" do
-      @person.label.should == 'Party'
+    it "delegate to Highrise::Company when have company_id" do
+      subject.should_receive(:company_id).at_least(2).times.and_return(1)
+      Highrise::Company.should_receive(:find).with(1).and_return("company")
+      subject.company.should == "company"
     end
   end
   
-  describe ".add_note" do
-    it "should delegate to Highrise::Note.create with correct params" do
-      Highrise::Note.should_receive(:create).with({:body=>"body", :subject_id=>1, :subject_type=>'Party'}).and_return(mock('note'))
-      @person.add_note :body=>'body'
-    end
+  it "#name" do
+    subject.should_receive(:first_name).and_return("Marcos")
+    subject.should_receive(:last_name).and_return("Tapajós     ")
+    subject.name.should == "Marcos Tapajós"
   end
   
+  it { subject.label.should == 'Party' }
 end

data/spec/highrise/recording_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe Highrise::Recording do
+  it { should be_a_kind_of Highrise::Base }
+
+  it_should_behave_like "a paginated class"
+  
+  it ".find_all_across_pages_since" do
+    time = Time.parse("Wed Jan 14 15:43:11 -0200 2009")
+    Highrise::Recording.should_receive(:find_all_across_pages).with({:params=>{:since=>"20090114174311"}}).and_return("result")
+    Highrise::Recording.find_all_across_pages_since(time).should == "result"
+  end
+end

data/spec/highrise/searchable_behavior.rb

@@ -0,0 +1,13 @@
+shared_examples_for "a searchable class" do
+  it { subject.class.included_modules.should include(Highrise::Searchable) }
+
+  it ".search" do
+    find_args = {:from => "/#{subject.class.collection_name}/search.xml", :params => {"criteria[email]" => "john.doe@example.com", "criteria[zip]" => "90210"}}
+    if subject.class.respond_to?(:find_all_across_pages)
+      subject.class.should_receive(:find_all_across_pages).with(find_args)
+    else
+      subject.class.should_receive(:find).with(:all, find_args)
+    end
+    subject.class.search(:email => "john.doe@example.com", :zip => "90210")
+  end
+end

data/spec/highrise/searchable_spec.rb

@@ -0,0 +1,8 @@
+require 'spec_helper'
+
+describe Highrise::Searchable do
+  class TestClass < Highrise::Base; include Highrise::Searchable; end
+  subject { TestClass.new }
+  
+  it_should_behave_like "a searchable class"
+end

data/spec/highrise/subject_spec.rb

@@ -1,49 +1,34 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe Highrise::Subject do
+  subject { Highrise::Subject.new(:id => 1) }
 
-  before(:each) do
-    @subject = Highrise::Subject.new(:id => 1)
-  end
+  it { should be_a_kind_of Highrise::Base }
 
-  it "should be instance of Highrise::Base" do
-    @subject.kind_of?(Highrise::Base).should be_true
+  it "#notes" do
+    Highrise::Note.should_receive(:find_all_across_pages).with({:from=>"/subjects/1/notes.xml"}).and_return("notes")
+    subject.notes.should == "notes"
   end
 
-  describe ".notes" do
-    it "should delegate to Highrise::Note with correct params" do      Highrise::Note.should_receive(:find_all_across_pages).with({:from=>"/subjects/1/notes.xml"}).and_return("notes")
-      @subject.notes.should == "notes"
-    end
+  it "#add_note" do
+    Highrise::Note.should_receive(:create).with({:body=>"body", :subject_id=>1, :subject_type=>'Subject'}).and_return(mock('note'))
+    subject.add_note :body=>'body'
   end
-
-  describe ".add_note" do
-    it "should delegate to Highrise::Note.create with correct params" do
-      Highrise::Note.should_receive(:create).with({:body=>"body", :subject_id=>1, :subject_type=>'Subject'}).and_return(mock('note'))
-      @subject.add_note :body=>'body'
-    end
+  
+  it "#add_task" do
+    Highrise::Task.should_receive(:create).with({:body=>"body", :subject_id=>1, :subject_type=>'Subject'}).and_return(mock('task'))
+    subject.add_task :body=>'body'
   end
 
-  describe ".emails" do
-    it "should delegate to Highrise::Email with correct params" do
-      Highrise::Email.should_receive(:find_all_across_pages).with({:from=>"/subjects/1/emails.xml"}).and_return("emails")
-      @subject.emails.should == "emails"
-    end
+  it "#emails" do
+    Highrise::Email.should_receive(:find_all_across_pages).with({:from=>"/subjects/1/emails.xml"}).and_return("emails")
+    subject.emails.should == "emails"
   end
 
-
-  describe ".upcoming_tasks" do
-
-    it "should delegate to Highrise::Task with correct params" do
-      Highrise::Task.should_receive(:find).with(:all, {:from=>"/subjects/1/tasks.xml"}).and_return("tasks")
-      @subject.upcoming_tasks.should == "tasks"
-    end
-
+  it "#upcoming_tasks" do
+    Highrise::Task.should_receive(:find).with(:all, {:from=>"/subjects/1/tasks.xml"}).and_return("tasks")
+    subject.upcoming_tasks.should == "tasks"
   end
   
-  describe ".label" do
-    it "should return the class name as a string" do
-      @subject.label.should == "Subject"
-    end
-  end
-
+  it { subject.label.should == "Subject" }
 end

data/spec/highrise/tag_spec.rb

@@ -1,23 +1,18 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 
 describe Highrise::Tag do
-  before(:each) do
-    Highrise::Base.site = 'http://example.com.i/'
-    @tag = Highrise::Tag.new(:id => 1, :name => "Name")
-  end
+  subject { Highrise::Tag.new(:id => 1, :name => "Name") }
   
-  it "should be instance of Highrise::Base" do
-    @tag.kind_of?(Highrise::Base).should be_true
-  end
+  it { should be_a_kind_of Highrise::Base }
 
-  it "should support equality" do
+  it "supports equality" do
     tag = Highrise::Tag.new(:id => 1, :name => "Name")
-    @tag.should == tag
+    subject.should == tag
   end
   
-  it "it should find_by_name" do
+  it ".find_by_name" do
     tag = Highrise::Tag.new(:id => 2, :name => "Next")
-    Highrise::Tag.should_receive(:find).with(:all).and_return([tag, @tag])
-    Highrise::Tag.find_by_name("Name").should == @tag
+    Highrise::Tag.should_receive(:find).with(:all).and_return([tag, subject])
+    Highrise::Tag.find_by_name("Name").should == subject
   end
 end

data/spec/highrise/taggable_behavior.rb

@@ -0,0 +1,27 @@
+shared_examples_for "a taggable class" do
+  before(:each) do
+    (@tags = []).tap do 
+      @tags << {'id' => "414578", 'name' => "cliente"}
+      @tags << {'id' => "414580", 'name' => "ged"}
+      @tags << {'id' => "414579", 'name' => "iepc"}
+    end
+  end
+
+  it { subject.class.included_modules.should include(Highrise::Taggable) }
+
+  it "#tags" do
+    subject.should_receive(:get).with(:tags).and_return(@tags)
+    subject.tags.should == @tags
+  end
+  
+  it "#tag!(tag_name)" do
+    subject.should_receive(:post).with(:tags, :name => "client" ).and_return(true)
+    subject.tag!("client").should be_true
+  end
+  
+  it "#untag!(tag_name)" do
+    subject.should_receive(:get).with(:tags).and_return(@tags)
+    subject.should_receive(:delete).with("tags/414578").and_return(true)
+    subject.untag!("cliente").should be_true
+  end
+end