highline_wrapper 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f360fc32885250acb479282caea2a5594cd40ad0f7ed101bf87bf4c229212d2f
-  data.tar.gz: 71dcb19db17ce249d0fb08307b88dcd4fa22686d951065e5d0cc5e479866a53a
+  metadata.gz: 911a5de9b3a7c5315a0dd7983a3a3da86fc7ac39309718a93601400cdfd3e5d1
+  data.tar.gz: 00c7153fd5d0f2d9bbc354aaa4c04113abfd507d7a42560865c472c218e4197e
 SHA512:
-  metadata.gz: 2a3e21cc1744f27746016e1744f16640504cdaad8f1b80e1bdf3a9f4b16ac3afa5aed6787f1128e2b02867ba9edd02d83d17fa25f834d27c6334c93063daac9f
-  data.tar.gz: 2560f9a19bcd5fdb633084109aac6a82769d49f54b065ca780c1f0e32503aa9ee66952a731753e0bc5d18a83585e5fb74c57a06f124ca0739f7d201cd8dbf571
+  metadata.gz: 8ec66bb92ec4b4e24d68b772774b04f9c5aff7efba95feea1f8d315098f88a0a7836a3ca37609fb638f43b1fadf6fe0b9fb1fa935c8a4accc279f6b8c94810fd
+  data.tar.gz: b4582ee3283bd032c9a611bed8850e92922877fde6b378594a31bfc7088fb19a74e642d99787d0a451f08066a1e31591fec643d5ab6197e38f20fecb7690c954

data/Gemfile.lock

@@ -1,24 +1,21 @@
 PATH
   remote: .
   specs:
-    highline_wrapper (1.1.0)
+    highline_wrapper (1.2.0)
       highline (~> 2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.2)
-    binding_of_caller (1.0.0)
-      debug_inspector (>= 0.0.1)
     coderay (1.1.3)
     concurrent-ruby (1.1.8)
-    debug_inspector (1.0.0)
     diff-lcs (1.4.4)
-    faker (2.16.0)
+    faker (2.18.0)
       i18n (>= 1.6, < 2)
-    ffi (1.15.0)
+    ffi (1.15.1)
     formatador (0.2.5)
-    guard (2.16.2)
+    guard (2.17.0)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
       lumberjack (>= 1.0.12, < 2.0)
@@ -33,10 +30,9 @@ GEM
       guard-compat (~> 1.1)
       rspec (>= 2.99.0, < 4.0)
     highline (2.0.3)
-    i18n (1.8.9)
+    i18n (1.8.10)
       concurrent-ruby (~> 1.0)
-    interception (0.5)
-    listen (3.4.1)
+    listen (3.5.1)
       rb-fsevent (~> 0.10, >= 0.10.3)
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.2.8)
@@ -46,27 +42,18 @@ GEM
       nenv (~> 0.1)
       shellany (~> 0.0)
     parallel (1.20.1)
-    parser (3.0.0.0)
+    parser (3.0.1.1)
       ast (~> 2.4.1)
-    pry (0.14.0)
+    pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    pry-doc (1.1.0)
-      pry (~> 0.11)
-      yard (~> 0.9.11)
-    pry-rescue (1.5.2)
-      interception (>= 0.5)
-      pry (>= 0.12.0)
-    pry-stack_explorer (0.6.1)
-      binding_of_caller (~> 1.0)
-      pry (~> 0.13)
     rainbow (3.0.0)
     rake (13.0.3)
-    rb-fsevent (0.10.4)
+    rb-fsevent (0.11.0)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
     regexp_parser (2.1.1)
-    rexml (3.2.4)
+    rexml (3.2.5)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
@@ -80,22 +67,21 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
-    rubocop (1.11.0)
+    rubocop (1.16.0)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.2.0, < 2.0)
+      rubocop-ast (>= 1.7.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.4.1)
-      parser (>= 2.7.1.5)
+    rubocop-ast (1.7.0)
+      parser (>= 3.0.1.1)
     ruby-progressbar (1.11.0)
     shellany (0.0.1)
     thor (1.1.0)
     unicode-display_width (2.0.0)
-    yard (0.9.26)
 
 PLATFORMS
   x86_64-darwin-20
@@ -106,12 +92,9 @@ DEPENDENCIES
   guard-rspec (~> 4.3)
   highline_wrapper!
   pry (~> 0.13)
-  pry-doc
-  pry-rescue
-  pry-stack_explorer
   rake (~> 13.0)
   rspec (~> 3.9)
   rubocop (~> 1.10)
 
 BUNDLED WITH
-   2.2.14
+   2.2.19

data/README.md

@@ -143,6 +143,7 @@ Notes:
 * If `required` is `true`, the question will repeat until the user answers the question
 * If `required` is `true`, then the `default` value will be ignored (defaults to `true`, but could be set to whatever and the code won't care... the question is required)
 * If `default` is `true` and `required` is `false`, and the user skips the question, the answer will be `true`
+* The response to the question MUST be given either as `y`/`n`/`yes`/`no` or with any capitalization... anything else given as a response will be unparseable
 
 <details><summary>Examples</summary>
 
@@ -174,7 +175,7 @@ Do you like Ruby?
 Do you like Ruby?
 --- This question is required ---
 Do you like Ruby?
-no
+N
 => false
 
 > HighlineWrapper.new.ask_yes_no('Do you like Ruby?')
@@ -182,7 +183,15 @@ Do you like Ruby?
 uh-huh
 --- This question is required ---
 Do you like Ruby?
+YES
+=> true
+
+> HighlineWrapper.new.ask_yes_no('Do you like Ruby?')
+Do you like Ruby?
 yep
+--- This question is required ---
+Do you like Ruby?
+yes
 => true
 ```
 

data/lib/highline_wrapper/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class HighlineWrapper
-  VERSION = '1.1.0'
+  VERSION = '1.2.0'
 end

data/lib/highline_wrapper/yes_no_question.rb

@@ -16,10 +16,14 @@ class HighlineWrapper
       end
 
       private def parse(answer, prompt, options)
-        return true if answer.include?('y')
-        return false if answer.include?('n')
-
-        recurse(prompt, nil, options)
+        case answer
+        when 'yes', 'y'
+          true
+        when 'no', 'n'
+          false
+        else
+          recurse(prompt, nil, options)
+        end
       end
 
       private def print_default_message(options)

data/spec/highline_wrapper/yes_no_question_spec.rb

@@ -28,7 +28,7 @@ describe HighlineWrapper::YesNoQuestion do
     end
 
     it 'should ask the highline client ask' do
-      expect(highline).to receive(:ask)
+      expect(highline).to receive(:ask).and_return('Y')
       subject.ask(Faker::Lorem.sentence, options)
     end
 
@@ -49,6 +49,12 @@ describe HighlineWrapper::YesNoQuestion do
       expect(subject).to receive(:print_default_message)
       subject.ask(Faker::Lorem.sentence, options)
     end
+
+    it 'should recurse if the answer given is unparseable' do
+      allow(highline).to receive(:ask).and_return('yep', 'yessss', 'yes')
+      expect(subject).to receive(:recurse).exactly(2).times.and_call_original
+      subject.ask(Faker::Lorem.sentence, options)
+    end
   end
 
   context 'with required set to true' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: highline_wrapper
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Emma Sax
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-09 00:00:00.000000000 Z
+date: 2021-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
@@ -167,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.15
 signing_key:
 specification_version: 4
 summary: A little wrapper for HighLine