highline 2.0.0.pre.develop.13 → 2.0.0.pre.develop.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 15f4a2a4093aa40f67585d304e451b7015ef098d
-  data.tar.gz: 3a192714c98631c7ec8263993fa3effa8f1c36b9
+  metadata.gz: 5ab46fe65f6eb631cce1fe0cc62caf13925bd40b
+  data.tar.gz: 4ac57c74c9460edca617bb6a829c1ec50bce410e
 SHA512:
-  metadata.gz: 6544dfa49255c98a453fcde92a5da742bc22bf3f02553f648f8c7568e04a67a524fbfe6cf325ed009f3a00fbcbb30777707db243f87bc3cfe2a946ddb71b04a1
-  data.tar.gz: d5d06ecbb06d9d062a5b344cac7de0e547b0ef3122e895131d5f56ab7beb4f3a637e58b5af3755c6ad7f836c1e10ec97e9019f73011d26237158eb50f9877627
+  metadata.gz: 24f92f0180bb9cdfa88f76d73f5e3ab0794276120b41741e9083b5325aa7be9411be8226b8d62591692693fe1b3f4302dc2fbb0704d79c9b227f76ee319e57b9
+  data.tar.gz: 2ed1a02b7bfd2d06bdd87b0e91fa6d1505d9d8d877461787ea431f0931acc2ae83eec795dbde832afa0cbb674113ae83442c47486d36e747a9333bf2cecf9282

data/Changelog.md

@@ -2,6 +2,9 @@
 
 Below is a complete listing of changes for each revision of HighLine.
 
+### 2.0.0-develop.14 / 2017-11-21
+* PR #222 / I #221 - Fix inconsistent behaviour when using agree with readline (@abinoam, @ailisp)
+
 ### 2.0.0-develop.13 / 2017-11-05
 * PR #219 - Make possible to use a callable as response (@abinoam)
 

data/lib/highline.rb

@@ -196,6 +196,7 @@ class HighLine
       q.responses[:not_valid]    = 'Please enter "yes" or "no".'
       q.responses[:ask_on_error] = :question
       q.character                = character
+      q.completion               = %w[yes no]
 
       yield q if block_given?
     end

data/lib/highline/question.rb

@@ -575,7 +575,7 @@ class HighLine
     # @param highline [HighLine] context
     # @return [void]
     def show_question(highline)
-      highline.say(self) unless readline && (echo == true && !limit)
+      highline.say(self)
     end
 
     # Returns an echo string that is adequate for this Question settings.

data/lib/highline/terminal.rb

@@ -98,9 +98,7 @@ class HighLine
     def get_line_with_readline(question, highline)
       require "readline" # load only if needed
 
-      question_string = highline.render_statement(question)
-
-      raw_answer = readline_read(question_string, question)
+      raw_answer = readline_read(question)
 
       if !raw_answer && highline.track_eof?
         raise EOFError, "The input stream is exhausted."
@@ -113,7 +111,7 @@ class HighLine
     # @param prompt [String] Readline prompt
     # @param question [HighLine::Question] question from where to get
     #   autocomplete candidate strings
-    def readline_read(prompt, question)
+    def readline_read(question)
       # prep auto-completion
       unless question.selection.empty?
         Readline.completion_proc = lambda do |str|
@@ -126,7 +124,7 @@ class HighLine
       $VERBOSE    = nil
 
       raw_answer  = run_preserving_stty do
-        Readline.readline(prompt, true)
+        Readline.readline("", true)
       end
 
       $VERBOSE = old_verbose

data/lib/highline/version.rb

@@ -2,5 +2,5 @@
 
 class HighLine
   # The version of the installed library.
-  VERSION = "2.0.0-develop.13".freeze
+  VERSION = "2.0.0-develop.14".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: highline
 version: !ruby/object:Gem::Version
-  version: 2.0.0.pre.develop.13
+  version: 2.0.0.pre.develop.14
 platform: ruby
 authors:
 - James Edward Gray II
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-05 00:00:00.000000000 Z
+date: 2017-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler