high_voltage 3.1.1 → 4.0.0.rc1

data/spec/high_voltage/page_finder_spec.rb

@@ -1,98 +0,0 @@
-# encoding: utf-8
-
-require "spec_helper"
-
-describe HighVoltage::PageFinder do
-  it "produces the name of an existing template" do
-    expect(find("existing")).to eq "pages/existing"
-  end
-
-  it "produces the name of a nested template" do
-    expect(find("dir/nested")).to eq "pages/dir/nested"
-  end
-
-  it "produces the name of a dotfile" do
-    expect(find(".file")).to eq "pages/.file"
-  end
-
-  it "supports non-ASCII characters" do
-    expect(find("résumé")).to eq "pages/résumé"
-  end
-
-  it "uses a custom content path" do
-    with_content_path("other_pages/") do
-      expect(find("also_exists")).to eq "other_pages/also_exists"
-    end
-  end
-
-  it "allows the trailing slash to be omitted from the content path" do
-    with_content_path("forgot_slash") do
-      expect(find("thing")).to eq "forgot_slash/thing"
-    end
-  end
-
-  it "exposes the content path" do
-    with_content_path("another_thing/") do
-      expect(page_finder.content_path).to eq "another_thing/"
-    end
-  end
-
-  it "provides the page_id" do
-    subclass = Class.new(HighVoltage::PageFinder) do
-      def page_name
-        "the page is #{page_id}"
-      end
-    end
-
-    expect(subclass.new("sweet page").page_name).to eq "the page is sweet page"
-  end
-
-  context "bad page_id" do
-    it "throws an exception if page_id resolves to empty" do
-      expect { find("") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("/") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find(".") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("\\.") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("/\\.") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("dummy/..") }.to raise_error HighVoltage::InvalidPageIdError
-    end
-
-    it "throws an exception if page_id resolves to outside the content path" do
-      expect { find("..") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("\\..") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("/\\..") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("../secret") }.
-        to raise_error HighVoltage::InvalidPageIdError
-      expect { find("\\../secret") }.
-        to raise_error HighVoltage::InvalidPageIdError
-      expect { find("/\\../secret") }.
-        to raise_error HighVoltage::InvalidPageIdError
-      expect { find("dummy/../../secret") }.
-        to raise_error HighVoltage::InvalidPageIdError
-    end
-
-    it "throws an exception if invalid byte sequence in page_id" do
-      expect { find("\xD0½\xA8\xCEļ\xFE\xBC\xD0.zip") }.
-        to raise_error HighVoltage::InvalidPageIdError
-    end
-  end
-
-  private
-
-  def find(page_id)
-    page_finder(page_id).find
-  end
-
-  def page_finder(page_id = "whatever")
-    HighVoltage::PageFinder.new(page_id)
-  end
-
-  def with_content_path(path)
-    original_content_path = HighVoltage.content_path
-    HighVoltage.content_path = path
-
-    yield
-
-    HighVoltage.content_path = original_content_path
-  end
-end

data/spec/high_voltage/page_spec.rb

@@ -1,65 +0,0 @@
-require "spec_helper"
-
-describe HighVoltage::Page do
-  it "produces the id for a page" do
-    page = page(full_file_path("exists.html.erb"))
-
-    expect(page.id).to eq "exists"
-  end
-
-  it "produces the id for a page in a subdirectory" do
-    page = page(full_file_path("dir/nested.html.erb"))
-
-    expect(page.id).to eq "dir/nested"
-  end
-
-  it "is valid for a page" do
-    page = page(full_file_path("exists.html.erb"))
-
-    expect(page).to be_valid
-  end
-
-  it "is valid for a page in a subdirectory" do
-    page = page(full_file_path("dir/nested.html.erb"))
-
-    expect(page).to be_valid
-  end
-
-  it "is invalid for a directory" do
-    page = page(full_file_path("dir"))
-
-    expect(page).to_not be_valid
-  end
-
-  it "is invalid for a partial" do
-    page = page(full_file_path("_partial.html.erb"))
-
-    expect(page).to_not be_valid
-  end
-
-  it "is invalid for a non-existent page" do
-    page = page(full_file_path("nonexistent.html.erb"))
-
-    expect(page).to_not be_valid
-  end
-
-  it "is valid for files without a format present" do
-    page = page(full_file_path("exists_without_html_extension.erb"))
-
-    expect(page).to be_valid
-  end
-
-  private
-
-  def full_content_path
-    HighVoltage.full_path.to_s
-  end
-
-  def page(file_path)
-    HighVoltage::Page.new(full_content_path, file_path)
-  end
-
-  def full_file_path(file_path)
-    "#{full_content_path}#{file_path}"
-  end
-end

data/spec/high_voltage_spec.rb

@@ -1,11 +0,0 @@
-require 'minimal_spec_helper'
-
-describe HighVoltage do
-  it 'is valid' do
-    expect(HighVoltage).to be_a(Module)
-  end
-
-  it 'is loadable without preloading rails' do
-    expect { require 'high_voltage' }.not_to raise_error
-  end
-end

data/spec/integration/navigation_spec.rb

@@ -1,7 +0,0 @@
-require 'spec_helper'
-
-describe 'Navigation' do
-  it 'is a valid app' do
-    expect(::Rails.application).to be_a(Dummy::Application)
-  end
-end

data/spec/minimal_spec_helper.rb

@@ -1,5 +0,0 @@
-RSpec.configure do |config|
-  require 'rspec/expectations'
-  config.include RSpec::Matchers
-  config.mock_with :rspec
-end

data/spec/requests/home_page_spec.rb

@@ -1,13 +0,0 @@
-require 'spec_helper'
-
-describe 'Home page route' do
-  before(:each) do
-    HighVoltage.home_page = 'home'
-    Rails.application.reload_routes!
-  end
-
-  it 'redirects the duplicate content to root' do
-    get '/home'
-    expect(response.headers['Location']).to eq 'http://www.example.com/'
-  end
-end

data/spec/routing/routes_spec.rb

@@ -1,140 +0,0 @@
-require 'spec_helper'
-
-describe 'routes' do
-  context 'default configuration' do
-    it 'generates a route' do
-      expect(page_path('one')).to eq '/pages/one'
-    end
-
-    it 'generates a nested route' do
-      expect(page_path('one/two')).to eq '/pages/one/two'
-    end
-
-    it 'recognizes a route' do
-      assert_recognizes(
-        {
-          :controller => 'high_voltage/pages',
-          :action => 'show',
-          :id => 'one'
-        },
-        '/pages/one'
-      )
-    end
-
-    it 'recognizes a nested route' do
-      assert_recognizes(
-        {
-          :controller => 'high_voltage/pages',
-          :action => 'show',
-          :id => 'one/two'
-        },
-        '/pages/one/two'
-      )
-    end
-
-    it 'recognizes a route with dots' do
-      assert_recognizes(
-        {
-          :controller => 'high_voltage/pages',
-          :action => 'show',
-          :id => 'one.two.three'
-        },
-        '/pages/one.two.three'
-      )
-    end
-  end
-
-  context 'using top-level routing configuration' do
-    before(:each) do
-      HighVoltage.route_drawer = HighVoltage::RouteDrawers::Root
-      Rails.application.reload_routes!
-    end
-
-    it 'generates a route' do
-      expect(page_path('one')).to eq '/one'
-    end
-
-    it 'generates  a nested route' do
-      expect(page_path('one/two')).to eq '/one/two'
-    end
-  end
-
-  context 'custom content path' do
-    before(:each) do
-      HighVoltage.content_path = 'other_pages/'
-      Rails.application.reload_routes!
-    end
-
-    it 'generates a route' do
-      expect(page_path('one')).to eq '/other_pages/one'
-    end
-
-    it 'generates a nested route' do
-      expect(page_path('one/two')).to eq '/other_pages/one/two'
-    end
-
-    it 'recognizes a route' do
-      assert_recognizes(
-        {
-          :controller => 'high_voltage/pages',
-          :action => 'show',
-          :id => 'one'
-        },
-        '/other_pages/one'
-      )
-    end
-
-    it 'recognizes a nested route' do
-      assert_recognizes(
-        {
-          :controller => 'high_voltage/pages',
-          :action => 'show',
-          :id => 'one/two'
-        },
-        '/other_pages/one/two'
-      )
-    end
-
-    it 'recognizes a route with dots' do
-      assert_recognizes(
-        {
-          :controller => 'high_voltage/pages',
-          :action => 'show',
-          :id => 'one.two.three'
-        },
-        '/other_pages/one.two.three'
-      )
-    end
-  end
-
-  context 'home page route' do
-    it 'recognizes the root route' do
-      HighVoltage.home_page = 'home'
-      Rails.application.reload_routes!
-
-      assert_recognizes(
-        {
-          :controller => 'high_voltage/pages',
-          :action => 'show',
-          :id => 'home'
-        },
-        '/'
-      )
-    end
-  end
-
-  context 'no home page route' do
-    it 'does generate a home page route' do
-      expect(get: '/').not_to be_routable
-    end
-  end
-
-  context 'disabled routes' do
-    it 'does not recognize routes' do
-      HighVoltage.routes = false
-      Rails.application.reload_routes!
-
-      expect(get: '/pages/one/two').not_to be_routable
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,39 +0,0 @@
-ENV["RAILS_ENV"] = "test"
-
-require "pry"
-require "active_model/railtie"
-require "action_controller/railtie"
-require "action_view/railtie"
-require "high_voltage"
-require "fake_app"
-require "rspec/rails"
-
-Rails.backtrace_cleaner.remove_silencers!
-
-Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each { |file| require file }
-
-RSpec.configure do |config|
-  config.infer_spec_type_from_file_location!
-
-  config.after(:each) do
-    HighVoltage.set_default_configuration
-    Rails.application.reload_routes!
-  end
-
-  config.expect_with :rspec do |c|
-    c.syntax = :expect
-  end
-
-  config.include RSpec::Matchers
-  config.mock_with :rspec
-  config.order = "random"
-
-  if Rails::VERSION::MAJOR >= 5
-    require "rails-controller-testing"
-
-    config.include(
-      Rails::Controller::Testing::TemplateAssertions,
-      type: :controller,
-    )
-  end
-end

data/spec/support/app/controllers/alternative_finder_controller.rb

@@ -1,14 +0,0 @@
-class AlternativeFinderController < HighVoltage::PagesController
-  private
-
-  def page_finder_factory
-    Rot13PageFinder
-  end
-
-  class Rot13PageFinder < HighVoltage::PageFinder
-    def find
-      paths = super.split('/')
-      "#{paths[0..-2].join('/')}/#{paths[-1].tr('a-z','n-za-m')}"
-    end
-  end
-end

data/spec/support/app/controllers/subclassed_pages_controller.rb

@@ -1,3 +0,0 @@
-class SubclassedPagesController < HighVoltage::PagesController
-  layout 'alternate'
-end

data/spec/support/http_method_shim.rb

@@ -1,19 +0,0 @@
-# Rails 5 deprecates calling HTTP action methods with positional arguments
-# in favor of keyword arguments. However, the keyword argument form is only
-# supported in Rails 5+. Since we support back to 4, we need some sort of shim
-# to avoid super noisy deprecations when running tests.
-module HTTPMethodShim
-  def get(path, params = nil, *args)
-    if args.any?
-      raise ArgumentError, "Unexpected arguments passed to shim: #{args.inspect}"
-    else
-      super(path, params: params)
-    end
-  end
-end
-
-if Rails::VERSION::MAJOR >= 5
-  RSpec.configure do |config|
-    config.include HTTPMethodShim, type: :controller
-  end
-end