high_voltage 3.1.1 → 3.1.2

data/spec/constraints/root_route_spec.rb

@@ -1,29 +0,0 @@
-require "spec_helper"
-
-describe HighVoltage::Constraints::RootRoute do
-  describe "#matches?" do
-    it "returns true when the view file exists" do
-      request = double(path: "exists")
-
-      result = described_class.new.matches?(request)
-
-      expect(result).to be true
-    end
-
-    it "returns true when the view file exists and url ends with .html" do
-      request = double(path: "exists.html")
-
-      result = described_class.new.matches?(request)
-
-      expect(result).to be true
-    end
-
-    it "returns false when the view files does not exist" do
-      request = double(path: "index")
-
-      result = described_class.new.matches?(request)
-
-      expect(result).to be false
-    end
-  end
-end

data/spec/controllers/alternative_finder_controller_spec.rb

@@ -1,12 +0,0 @@
-require 'spec_helper'
-
-describe AlternativeFinderController do
-  render_views
-
-  it 'renders the file from the alternative directory' do
-    get :show, :id => 'ebg13'
-
-    expect(response).to be_successful
-    expect(response).to render_template('rot13')
-  end
-end

data/spec/controllers/pages_controller_spec.rb

@@ -1,113 +0,0 @@
-# encoding: utf-8
-
-require "spec_helper"
-
-describe HighVoltage::PagesController do
-  render_views
-
-  context "using default configuration" do
-    describe "on GET to /pages/exists" do
-      before { get :show, id: "exists" }
-
-      it "responds with success and render template" do
-        expect(response).to be_successful
-        expect(response).to render_template("exists")
-      end
-
-      it "uses the default layout used by ApplicationController" do
-        expect(response).to render_template("layouts/application")
-      end
-    end
-
-    describe "on GET to /pages/dir/nested" do
-      before { get :show, id: "dir/nested" }
-
-      it "responds with success and render template" do
-        expect(response).to be_successful
-        expect(response).to render_template("pages/dir/nested")
-      end
-    end
-
-    it "raises a routing error for an invalid page" do
-      expect { get :show, id: "invalid" }.
-        to raise_error(ActionController::RoutingError)
-    end
-
-    it "raises a routing error for a page in another directory" do
-      expect { get :show, id: "../other/wrong" }.
-        to raise_error(ActionController::RoutingError)
-    end
-
-    it "raises a missing template error for valid page with invalid partial" do
-      expect { get :show, id: "exists_but_references_nonexistent_partial" }.
-        to raise_error(ActionView::MissingTemplate)
-    end
-  end
-
-  context "using custom layout" do
-    before(:each) do
-      HighVoltage.layout = "alternate"
-    end
-
-    describe "on GET to /pages/exists" do
-      before { get :show, id: "exists" }
-
-      it "uses the custom configured layout" do
-        expect(response).not_to render_template("layouts/application")
-        expect(response).to render_template("layouts/alternate")
-      end
-    end
-  end
-
-  context "using custom content path" do
-    before(:each) do
-      HighVoltage.content_path = "other_pages/"
-      Rails.application.reload_routes!
-    end
-
-    describe "on GET to /other_pages/also_exists" do
-      before { get :show, id: "also_exists" }
-
-      it "responds with success and render template" do
-        expect(response).to be_successful
-        expect(response).to render_template("other_pages/also_exists")
-      end
-    end
-
-    describe "on GET to /other_pages/also_dir/nested" do
-      before { get :show, id: "also_dir/also_nested" }
-
-      it "responds with success and render template" do
-        expect(response).to be_successful
-        expect(response).to render_template("other_pages/also_dir/also_nested")
-      end
-    end
-
-    it "raises a routing error for an invalid page" do
-      expect { get :show, id: "also_invalid" }.
-        to raise_error(ActionController::RoutingError)
-
-      expect { get :show, id: "√®ø" }.
-        to raise_error(ActionController::RoutingError)
-    end
-
-    context "page in another directory" do
-      it "raises a routing error" do
-        expect { get :show, id: "../other_wrong" }.
-          to raise_error(ActionController::RoutingError)
-      end
-
-      it "raises a routing error when using a Unicode exploit" do
-        expect { get :show, id: "/\\../other/wrong" }.
-          to raise_error(ActionController::RoutingError)
-      end
-    end
-
-    it "raises a missing template error for valid page with invalid partial" do
-      id = "also_exists_but_references_nonexistent_partial"
-
-      expect { get :show, id: id }.
-        to raise_error(ActionView::MissingTemplate)
-    end
-  end
-end

data/spec/controllers/subclassed_pages_controller_spec.rb

@@ -1,34 +0,0 @@
-require "spec_helper"
-
-describe SubclassedPagesController do
-  render_views
-
-  describe "on GET to /subclassed_pages/also_exists" do
-    before { get :show, id: "also_exists" }
-
-    it "responds with success and render template" do
-      expect(response).to be_successful
-      expect(response).to render_template("also_exists")
-    end
-
-    it "uses the custom configured layout" do
-      expect(response).not_to render_template("layouts/application")
-      expect(response).to render_template("layouts/alternate")
-    end
-  end
-
-  it 'raises a routing error for an invalid page' do
-    expect { get :show, id: "invalid" }.
-      to raise_error(ActionController::RoutingError)
-  end
-
-  it 'raises a routing error for a page in another directory' do
-    expect { get :show, id: "../other/wrong" }.
-      to raise_error(ActionController::RoutingError)
-  end
-
-  it 'raises a missing template error for valid page with invalid partial' do
-    expect { get :show, id: "also_exists_but_references_nonexistent_partial" }.
-      to raise_error(ActionView::MissingTemplate)
-  end
-end

data/spec/fake_app.rb

@@ -1,16 +0,0 @@
-class ApplicationController < ActionController::Base
-  protect_from_forgery
-end
-
-# Create a rails app
-module Dummy
-  class Application < Rails::Application
-    config.secret_key_base = "test"
-    config.eager_load = false
-    config.action_controller.perform_caching = true
-    config.action_controller.cache_store = :memory_store
-    config.root = "spec/fixtures"
-    config.paths["app/views"] << "spec/fixtures/app/views"
-  end
-end
-Dummy::Application.initialize!

data/spec/features/current_page_helper_spec.rb

@@ -1,9 +0,0 @@
-require "spec_helper"
-
-feature "current page helper" do
-  scenario "is available in view" do
-    visit page_path(id: "current_page_helper")
-
-    expect(page).to have_content "Current Page: pages/current_page_helper"
-  end
-end

data/spec/features/view_page_spec.rb

@@ -1,9 +0,0 @@
-require "spec_helper"
-
-feature "view page" do
-  scenario "successfully" do
-    visit page_path(id: "about")
-
-    expect(page).to have_content "About Us"
-  end
-end

data/spec/fixtures/app/views/layouts/alternate.html.erb

@@ -1,14 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-  <title>Dummy - Alternate Layout</title>
-  <%= stylesheet_link_tag :all %>
-  <%= javascript_include_tag :defaults %>
-  <%= csrf_meta_tag %>
-</head>
-<body>
-
-<%= yield %>
-
-</body>
-</html>

data/spec/fixtures/app/views/layouts/application.html.erb

@@ -1,14 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-  <title>Dummy</title>
-  <%= stylesheet_link_tag :all %>
-  <%= javascript_include_tag :defaults %>
-  <%= csrf_meta_tag %>
-</head>
-<body>
-
-<%= yield %>
-
-</body>
-</html>

data/spec/fixtures/app/views/other/wrong.html.erb

@@ -1 +0,0 @@
-cant get here from pages

data/spec/fixtures/app/views/other_pages/also_dir/also_nested.html.erb

@@ -1 +0,0 @@
-hello <%= 'world' %> from a nested dir

data/spec/fixtures/app/views/other_pages/also_exists.html.erb

@@ -1 +0,0 @@
-hello <%= 'world' %>

data/spec/fixtures/app/views/other_pages/also_exists_but_references_nonexistent_partial.html.erb

@@ -1,2 +0,0 @@
-hello <%= 'world' %>
-<%= render 'nonexistent' %>

data/spec/fixtures/app/views/pages/_partial.html.erb

@@ -1 +0,0 @@
-partial

data/spec/fixtures/app/views/pages/about.html.erb

@@ -1 +0,0 @@
-<h1>About Us</h1>

data/spec/fixtures/app/views/pages/also_dir/also_nested.html.erb

@@ -1 +0,0 @@
-hello <%= 'world' %> from a nested dir

data/spec/fixtures/app/views/pages/also_exists.html.erb

@@ -1 +0,0 @@
-hello <%= 'world' %>

data/spec/fixtures/app/views/pages/also_exists_but_references_nonexistent_partial.html.erb

@@ -1,2 +0,0 @@
-hello <%= 'world' %>
-<%= render 'nonexistent' %>

data/spec/fixtures/app/views/pages/current_page_helper.html.erb

@@ -1 +0,0 @@
-<h1>Current Page: <%= current_page %></h1>

data/spec/fixtures/app/views/pages/dir/nested.html.erb

@@ -1 +0,0 @@
-hello <%= 'world' %> from a nested dir

data/spec/fixtures/app/views/pages/exists.html.erb

@@ -1 +0,0 @@
-hello <%= 'world' %>

data/spec/fixtures/app/views/pages/exists_but_references_nonexistent_partial.html.erb

@@ -1,2 +0,0 @@
-hello <%= 'world' %>
-<%= render 'nonexistent' %>

data/spec/fixtures/app/views/pages/exists_without_html_extension.erb

@@ -1 +0,0 @@
-<h1>Exists without html extension</h1>

data/spec/fixtures/app/views/pages/rot13.html.erb

@@ -1 +0,0 @@
-alternative

data/spec/fixtures/app/views/pages/text.txt.erb

@@ -1 +0,0 @@
-text page

data/spec/fixtures/config/database.yml

@@ -1,3 +0,0 @@
-test:
-  adapter: sqlite3
-  database: ":memory:"

data/spec/fixtures/config/routes.rb

@@ -1,4 +0,0 @@
-Dummy::Application.routes.draw do
-  get "/subclassed_pages/*id" => 'subclassed_pages#show', :format => false
-  get "/alternative_finder/*id" => 'alternative_finder#show', :format => false
-end

data/spec/high_voltage/configuration_spec.rb

@@ -1,31 +0,0 @@
-require 'minimal_spec_helper'
-
-describe HighVoltage::Configuration do
-  describe 'basic config assignment' do
-    let(:config_value) { 'fake_config_value' }
-
-    before(:each) do
-      HighVoltage.configure do |config|
-        ActiveSupport::Deprecation.silence do
-          config.content_path = config_value
-          config.layout = config_value
-          config.parent_engine = config_value
-          config.route_drawer = config_value
-          config.routes = config_value
-        end
-      end
-    end
-
-    after(:each) do
-      HighVoltage.configure do |config|
-        config.parent_engine = Rails.application
-      end
-    end
-
-    it { expect(HighVoltage.content_path).to eq config_value }
-    it { expect(HighVoltage.layout).to eq config_value }
-    it { expect(HighVoltage.parent_engine).to eq config_value }
-    it { expect(HighVoltage.route_drawer).to eq config_value }
-    it { expect(HighVoltage.routes).to eq config_value }
-  end
-end

data/spec/high_voltage/page_collector_spec.rb

@@ -1,40 +0,0 @@
-require "spec_helper"
-
-describe HighVoltage::PageCollector do
-  it "produces an array of all page_ids under pages/" do
-    expect(HighVoltage.page_ids).to match_array [
-      "about",
-      "also_dir/also_nested",
-      "also_exists",
-      "also_exists_but_references_nonexistent_partial",
-      "current_page_helper",
-      "dir/nested",
-      "exists",
-      "exists_but_references_nonexistent_partial",
-      "rot13",
-      "exists_without_html_extension",
-      "text",
-    ]
-  end
-
-  it "produces an array of all page_ids under other_pages/" do
-    with_content_path("other_pages/") do
-      expect(HighVoltage.page_ids).to eq [
-        "also_dir/also_nested",
-        "also_exists",
-        "also_exists_but_references_nonexistent_partial",
-      ]
-    end
-  end
-
-  private
-
-  def with_content_path(path)
-    original_content_path = HighVoltage.content_path
-    HighVoltage.content_path = path
-
-    yield
-
-    HighVoltage.content_path = original_content_path
-  end
-end

data/spec/high_voltage/page_finder_spec.rb

@@ -1,98 +0,0 @@
-# encoding: utf-8
-
-require "spec_helper"
-
-describe HighVoltage::PageFinder do
-  it "produces the name of an existing template" do
-    expect(find("existing")).to eq "pages/existing"
-  end
-
-  it "produces the name of a nested template" do
-    expect(find("dir/nested")).to eq "pages/dir/nested"
-  end
-
-  it "produces the name of a dotfile" do
-    expect(find(".file")).to eq "pages/.file"
-  end
-
-  it "supports non-ASCII characters" do
-    expect(find("résumé")).to eq "pages/résumé"
-  end
-
-  it "uses a custom content path" do
-    with_content_path("other_pages/") do
-      expect(find("also_exists")).to eq "other_pages/also_exists"
-    end
-  end
-
-  it "allows the trailing slash to be omitted from the content path" do
-    with_content_path("forgot_slash") do
-      expect(find("thing")).to eq "forgot_slash/thing"
-    end
-  end
-
-  it "exposes the content path" do
-    with_content_path("another_thing/") do
-      expect(page_finder.content_path).to eq "another_thing/"
-    end
-  end
-
-  it "provides the page_id" do
-    subclass = Class.new(HighVoltage::PageFinder) do
-      def page_name
-        "the page is #{page_id}"
-      end
-    end
-
-    expect(subclass.new("sweet page").page_name).to eq "the page is sweet page"
-  end
-
-  context "bad page_id" do
-    it "throws an exception if page_id resolves to empty" do
-      expect { find("") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("/") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find(".") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("\\.") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("/\\.") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("dummy/..") }.to raise_error HighVoltage::InvalidPageIdError
-    end
-
-    it "throws an exception if page_id resolves to outside the content path" do
-      expect { find("..") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("\\..") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("/\\..") }.to raise_error HighVoltage::InvalidPageIdError
-      expect { find("../secret") }.
-        to raise_error HighVoltage::InvalidPageIdError
-      expect { find("\\../secret") }.
-        to raise_error HighVoltage::InvalidPageIdError
-      expect { find("/\\../secret") }.
-        to raise_error HighVoltage::InvalidPageIdError
-      expect { find("dummy/../../secret") }.
-        to raise_error HighVoltage::InvalidPageIdError
-    end
-
-    it "throws an exception if invalid byte sequence in page_id" do
-      expect { find("\xD0½\xA8\xCEļ\xFE\xBC\xD0.zip") }.
-        to raise_error HighVoltage::InvalidPageIdError
-    end
-  end
-
-  private
-
-  def find(page_id)
-    page_finder(page_id).find
-  end
-
-  def page_finder(page_id = "whatever")
-    HighVoltage::PageFinder.new(page_id)
-  end
-
-  def with_content_path(path)
-    original_content_path = HighVoltage.content_path
-    HighVoltage.content_path = path
-
-    yield
-
-    HighVoltage.content_path = original_content_path
-  end
-end