high_voltage 1.2.0 → 2.0.0

data/spec/high_voltage/page_finder_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+describe HighVoltage::PageFinder do
+  it 'produces the name of an existing template' do
+    find('existing').should eq 'pages/existing'
+  end
+
+  it 'produces the name of a nested template' do
+    find('dir/nested').should eq 'pages/dir/nested'
+  end
+
+  it 'uses a custom content path' do
+    with_content_path('other_pages/') do
+      find('also_exists').should eq 'other_pages/also_exists'
+    end
+  end
+
+  it 'exposes the content path' do
+    with_content_path('another_thing/') do
+      page_finder.content_path.should eq 'another_thing/'
+    end
+  end
+
+  it 'provides the page_id' do
+    subclass = Class.new(HighVoltage::PageFinder) do
+      def page_name
+        "the page is #{page_id}"
+      end
+    end
+
+    subclass.new('sweet page').page_name.should eq 'the page is sweet page'
+  end
+
+  private
+
+  def find(page_id)
+    page_finder(page_id).find
+  end
+
+  def page_finder(page_id = 'whatever')
+    HighVoltage::PageFinder.new(page_id)
+  end
+
+  def with_content_path(path)
+    original_content_path = HighVoltage.content_path
+    HighVoltage.content_path = path
+
+    yield
+
+    HighVoltage.content_path = original_content_path
+  end
+end

data/spec/high_voltage_spec.rb

@@ -1,7 +1,11 @@
-require 'spec_helper'
+require 'minimal_spec_helper'
 
 describe HighVoltage do
-  it "should be valid" do
+  it 'should be valid' do
     HighVoltage.should be_a(Module)
   end
-end
+
+  it 'should be loadable without preloading rails' do
+    expect { require 'high_voltage' }.not_to raise_error
+  end
+end

data/spec/integration/navigation_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
-describe "Navigation" do
+describe 'Navigation' do
   include Capybara::DSL
-  
-  it "should be a valid app" do
+
+  it 'should be a valid app' do
     ::Rails.application.should be_a(Dummy::Application)
   end
 end

data/spec/minimal_spec_helper.rb

@@ -0,0 +1,5 @@
+RSpec.configure do |config|
+  require 'rspec/expectations'
+  config.include RSpec::Matchers
+  config.mock_with :rspec
+end

data/spec/routing/routes_spec.rb

@@ -1,68 +1,142 @@
 require 'spec_helper'
-describe 'routes' do
-  context "using default configuration" do
 
-    it "should generate normal resource route with id" do
-      page_path(:id => "one").should == "/pages/one"
+describe 'routes' do
+  context 'using default configuration' do
+    it 'should generate normal resource route with id' do
+      page_path('one').should eq '/pages/one'
     end
 
-    it "should generate normal resource route with string" do
-      page_path("one").should == "/pages/one"
+    it 'should generate normal resource route with string' do
+      page_path('one').should eq '/pages/one'
     end
 
-    it "should generate nested route with string" do
-      page_path("one/two").should == "/pages/one/two"
+    it 'should generate nested route with string' do
+      page_path('one/two').should eq '/pages/one/two'
     end
 
-    it "should recognize nested route" do
-      assert_recognizes({ :controller => "high_voltage/pages", :action => "show", :id => "one/two" }, "/pages/one/two")
+    it 'should recognize nested route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one/two'
+        },
+        '/pages/one/two'
+      )
     end
 
-    it "should recognize normal route" do
-      assert_recognizes({ :controller => "high_voltage/pages", :action => "show", :id => "one" }, "/pages/one")
+    it 'should recognize normal route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one'
+        },
+        '/pages/one'
+      )
     end
 
-    it "should recognize normal route with dots" do
-      assert_recognizes({ :controller => "high_voltage/pages", :action => "show", :id => "one.two.three" }, "/pages/one.two.three")
+    it 'should recognize normal route with dots' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one.two.three'
+        },
+        '/pages/one.two.three'
+      )
     end
   end
 
-  context "using a custom content_path" do
+  context 'using top-level routing configuration' do
+    around do |example|
+      cached_high_voltage_route_drawer = HighVoltage.route_drawer
+      HighVoltage.route_drawer = HighVoltage::RouteDrawers::Root
+      Rails.application.reload_routes!
 
-    before(:all) do
-      @original_content_path = HighVoltage.content_path
-      HighVoltage.content_path = "other_pages/"
+      example.run
+
+      HighVoltage.route_drawer = cached_high_voltage_route_drawer
       Rails.application.reload_routes!
     end
 
-    after(:all) do
-      HighVoltage.content_path = @original_content_path
-      Rails.application.reload_routes!
+    it 'should generate normal resource route with string' do
+      page_path('one').should eq '/one'
     end
 
-    it "should generate normal resource route with id" do
-      page_path(:id => "one").should == "/other_pages/one"
+    it 'should generate nested route with string' do
+      page_path('one/two').should eq '/one/two'
+    end
+  end
+
+  context 'using a custom content_path' do
+    around do |example|
+      cached_high_voltage_content_path = HighVoltage.content_path
+      HighVoltage.content_path = 'other_pages/'
+      Rails.application.reload_routes!
+
+      example.run
+
+      HighVoltage.content_path = cached_high_voltage_content_path
+      Rails.application.reload_routes!
     end
 
-    it "should generate normal resource route with string" do
-      page_path("one").should == "/other_pages/one"
+    it 'should generate normal resource route with string' do
+      page_path('one').should eq '/other_pages/one'
     end
 
-    it "should generate nested route with string" do
-      page_path("one/two").should == "/other_pages/one/two"
+    it 'should generate nested route with string' do
+      page_path('one/two').should eq '/other_pages/one/two'
     end
 
-    it "should recognize nested route" do
-      assert_recognizes({:controller => "high_voltage/pages", :action => "show", :id => "one/two"}, "/other_pages/one/two")
+    it 'should recognize nested route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one/two'
+        },
+        '/other_pages/one/two'
+      )
     end
 
-    it "should recognize normal route" do
-      assert_recognizes({:controller => "high_voltage/pages", :action => "show", :id => "one"}, "/other_pages/one")
+    it 'should recognize normal route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one'
+        },
+        '/other_pages/one'
+      )
     end
 
-    it "should recognize normal route with dots" do
-      assert_recognizes({:controller => "high_voltage/pages", :action => "show", :id => "one.two.three"}, "/other_pages/one.two.three")
+    it 'should recognize normal route with dots' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one.two.three'
+        },
+        '/other_pages/one.two.three'
+      )
     end
   end
 
+  context 'with default configuration disabled' do
+    around do |example|
+      cached_high_voltage_routes = HighVoltage.routes
+      HighVoltage.routes = false
+      Rails.application.reload_routes!
+
+      example.run
+
+      HighVoltage.routes = cached_high_voltage_routes
+      Rails.application.reload_routes!
+    end
+
+    it 'should not recognize routes' do
+      { :get => '/pages/one/two' }.should_not be_routable
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,30 +1,19 @@
-# Configure Rails Envinronment
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'
 
 require File.expand_path("../dummy/config/environment.rb",  __FILE__)
-require "rails/test_help"
-require "rspec/rails"
-
-ActionMailer::Base.delivery_method = :test
-ActionMailer::Base.perform_deliveries = true
-ActionMailer::Base.default_url_options[:host] = "test.com"
+require 'pry'
+require 'rails/test_help'
+require 'rspec/rails'
+require 'capybara/rails'
 
 Rails.backtrace_cleaner.remove_silencers!
-
-# Configure capybara for integration testing
-require "capybara/rails"
-Capybara.default_driver   = :rack_test
+Capybara.default_driver = :rack_test
 Capybara.default_selector = :css
 
-# Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+Dir[File.dirname(__FILE__) + '/support/**/*.rb'].each {|f| require f}
 
 RSpec.configure do |config|
-  # Remove this line if you don't want RSpec's should and should_not
-  # methods or matchers
   require 'rspec/expectations'
   config.include RSpec::Matchers
-
-  # == Mock Framework
   config.mock_with :rspec
 end

data/spec/support/caching.rb

@@ -0,0 +1,12 @@
+RSpec.configure do |config|
+  config.around(:each, enable_caching: true) do |example|
+    ActionController::Base.perform_caching = true
+    old_cache_store = ActionController::Base.cache_store
+    ActionController::Base.cache_store = :memory_store
+
+    example.run
+
+    ActionController::Base.cache_store = old_cache_store
+    ActionController::Base.perform_caching = false
+  end
+end

data/spec/support/concern_reload.rb

@@ -0,0 +1,11 @@
+def concern_reload
+  HighVoltage::PagesController.class_eval do
+    if respond_to?(:caches_action)
+      caches_action :show, if: -> { HighVoltage.action_caching }
+    end
+
+    if respond_to?(:caches_page)
+      caches_page :show, if: -> { HighVoltage.page_caching }
+    end
+  end
+end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: high_voltage
 version: !ruby/object:Gem::Version
-  version: 1.2.0
-  prerelease: 
+  version: 2.0.0
 platform: ruby
 authors:
 - Matt Jankowski
@@ -17,73 +16,79 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-27 00:00:00.000000000 Z
+date: 2013-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '='
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 2.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '='
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 2.0.3
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: pry-debugger
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: Fire in the disco.  Fire in the ... taco bell.
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Fire in the disco. Fire in the ... taco bell.
 email:
 - support@thoughtbot.com
 executables: []
@@ -97,20 +102,28 @@ files:
 - Gemfile
 - Gemfile.lock
 - MIT-LICENSE
+- NEWS.md
 - README.md
 - Rakefile
+- app/controllers/concerns/high_voltage/static_page.rb
 - app/controllers/high_voltage/pages_controller.rb
 - config/routes.rb
-- gemfiles/rails-3.0.15.gemfile
-- gemfiles/rails-3.1.6.gemfile
-- gemfiles/rails-3.2.6.gemfile
 - high_voltage.gemspec
 - lib/high_voltage.rb
+- lib/high_voltage/constraints/root_route.rb
 - lib/high_voltage/engine.rb
+- lib/high_voltage/page_finder.rb
+- lib/high_voltage/route_drawers/default.rb
+- lib/high_voltage/route_drawers/root.rb
 - lib/high_voltage/version.rb
+- spec/constraints/root_route_spec.rb
+- spec/controllers/action_caching_controller_spec.rb
+- spec/controllers/alternative_finder_controller_spec.rb
+- spec/controllers/page_caching_controller_spec.rb
 - spec/controllers/pages_controller_spec.rb
 - spec/controllers/subclassed_pages_controller_spec.rb
 - spec/dummy/Rakefile
+- spec/dummy/app/controllers/alternative_finder_controller.rb
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/controllers/subclassed_pages_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
@@ -120,9 +133,13 @@ files:
 - spec/dummy/app/views/other_pages/also_dir/also_nested.html.erb
 - spec/dummy/app/views/other_pages/also_exists.html.erb
 - spec/dummy/app/views/other_pages/also_exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/also_dir/also_nested.html.erb
+- spec/dummy/app/views/pages/also_exists.html.erb
+- spec/dummy/app/views/pages/also_exists_but_references_nonexistent_partial.html.erb
 - spec/dummy/app/views/pages/dir/nested.html.erb
 - spec/dummy/app/views/pages/exists.html.erb
 - spec/dummy/app/views/pages/exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/rot13.html.erb
 - spec/dummy/config.ru
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
@@ -133,6 +150,7 @@ files:
 - spec/dummy/config/initializers/backtrace_silencers.rb
 - spec/dummy/config/initializers/inflections.rb
 - spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_key_base.rb
 - spec/dummy/config/initializers/secret_token.rb
 - spec/dummy/config/initializers/session_store.rb
 - spec/dummy/config/locales/en.yml
@@ -149,38 +167,95 @@ files:
 - spec/dummy/public/javascripts/rails.js
 - spec/dummy/public/stylesheets/.gitkeep
 - spec/dummy/script/rails
+- spec/high_voltage/page_finder_spec.rb
 - spec/high_voltage_spec.rb
 - spec/integration/navigation_spec.rb
+- spec/minimal_spec_helper.rb
 - spec/routing/routes_spec.rb
 - spec/spec_helper.rb
+- spec/support/caching.rb
+- spec/support/concern_reload.rb
 homepage: http://github.com/thoughtbot/high_voltage
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2706060558663144713
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2706060558663144713
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Simple static page rendering controller
-test_files: []
+test_files:
+- spec/constraints/root_route_spec.rb
+- spec/controllers/action_caching_controller_spec.rb
+- spec/controllers/alternative_finder_controller_spec.rb
+- spec/controllers/page_caching_controller_spec.rb
+- spec/controllers/pages_controller_spec.rb
+- spec/controllers/subclassed_pages_controller_spec.rb
+- spec/dummy/Rakefile
+- spec/dummy/app/controllers/alternative_finder_controller.rb
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/controllers/subclassed_pages_controller.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/app/views/layouts/alternate.html.erb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/app/views/other/wrong.html.erb
+- spec/dummy/app/views/other_pages/also_dir/also_nested.html.erb
+- spec/dummy/app/views/other_pages/also_exists.html.erb
+- spec/dummy/app/views/other_pages/also_exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/also_dir/also_nested.html.erb
+- spec/dummy/app/views/pages/also_exists.html.erb
+- spec/dummy/app/views/pages/also_exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/dir/nested.html.erb
+- spec/dummy/app/views/pages/exists.html.erb
+- spec/dummy/app/views/pages/exists_but_references_nonexistent_partial.html.erb
+- spec/dummy/app/views/pages/rot13.html.erb
+- spec/dummy/config.ru
+- spec/dummy/config/application.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
+- spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
+- spec/dummy/config/initializers/secret_key_base.rb
+- spec/dummy/config/initializers/secret_token.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/locales/en.yml
+- spec/dummy/config/routes.rb
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
+- spec/dummy/public/javascripts/application.js
+- spec/dummy/public/javascripts/controls.js
+- spec/dummy/public/javascripts/dragdrop.js
+- spec/dummy/public/javascripts/effects.js
+- spec/dummy/public/javascripts/prototype.js
+- spec/dummy/public/javascripts/rails.js
+- spec/dummy/public/stylesheets/.gitkeep
+- spec/dummy/script/rails
+- spec/high_voltage/page_finder_spec.rb
+- spec/high_voltage_spec.rb
+- spec/integration/navigation_spec.rb
+- spec/minimal_spec_helper.rb
+- spec/routing/routes_spec.rb
+- spec/spec_helper.rb
+- spec/support/caching.rb
+- spec/support/concern_reload.rb

data/gemfiles/rails-3.0.15.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rails", "3.0.15"
-
-gemspec :path=>"../"

data/gemfiles/rails-3.1.6.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rails", "3.1.6"
-
-gemspec :path=>"../"

data/gemfiles/rails-3.2.6.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "http://rubygems.org"
-
-gem "rails", "3.2.6"
-
-gemspec :path=>"../"