high_voltage 1.1.0 → 1.2.2

data/spec/controllers/pages_controller_spec.rb

@@ -1,106 +1,128 @@
+# encoding: UTF-8
 require 'spec_helper'
 
 describe HighVoltage::PagesController do
-
   render_views
 
-  context "using default configuration" do
-
-    describe "on GET to /pages/exists" do
+  context 'using default configuration' do
+    describe 'on GET to /pages/exists' do
       before { get :show, :id => 'exists' }
 
-      it "should respond with success and render template" do
+      it 'should respond with success and render template' do
         response.should be_success
         response.should render_template('exists')
       end
 
-      it "should use the default layout used by ApplicationController" do
-        response.should render_template("layouts/application")
+      it 'should use the default layout used by ApplicationController' do
+        response.should render_template('layouts/application')
       end
     end
 
-    describe "on GET to /pages/dir/nested" do
+    describe 'on GET to /pages/dir/nested' do
       before { get :show, :id => 'dir/nested' }
 
-      it "should respond with success and render template" do
+      it 'should respond with success and render template' do
         response.should be_success
         response.should render_template('pages/dir/nested')
       end
     end
 
-    it "should raise a routing error for an invalid page" do
-      lambda { get :show, :id => "invalid" }.should raise_error(ActionController::RoutingError)
+    it 'should raise a routing error for an invalid page' do
+      lambda {
+        get :show,
+        :id => 'invalid'
+      }.should raise_error(ActionController::RoutingError)
     end
 
-    it "should raise a routing error for a page in another directory" do
-      lambda { get :show, :id => "../other/wrong" }.should raise_error(ActionController::RoutingError)
+    it 'should raise a routing error for a page in another directory' do
+      lambda {
+        get :show,
+        :id => '../other/wrong'
+      }.should raise_error(ActionController::RoutingError)
     end
 
-    it "should raise missing template error for valid page with invalid partial" do
-      lambda { get :show, :id => "exists_but_references_nonexistent_partial" }.should raise_error(ActionView::MissingTemplate)
+    it 'should raise missing template error for valid page with invalid partial' do
+      lambda {
+        get :show,
+        :id => 'exists_but_references_nonexistent_partial'
+      }.should raise_error(ActionView::MissingTemplate)
     end
   end
 
-  context "using custom layout" do
+  context 'using custom layout' do
     before(:all) do
-      @original_layout = HighVoltage::layout
-      HighVoltage::layout = "alternate"
+      @original_layout = HighVoltage.layout
+      HighVoltage.layout = 'alternate'
     end
 
     after(:all) do
-      HighVoltage::layout = @original_layout
+      HighVoltage.layout = @original_layout
     end
 
-    describe "on GET to /pages/exists" do
-      before { get :show, :id => "exists" }
-      
-      it "should use the custom configured layout" do
-        response.should_not render_template("layouts/application")
-        response.should render_template("layouts/alternate")
+    describe 'on GET to /pages/exists' do
+      before { get :show, :id => 'exists' }
+
+      it 'should use the custom configured layout' do
+        response.should_not render_template('layouts/application')
+        response.should render_template('layouts/alternate')
       end
     end
   end
 
-  context "using custom content path" do
+  context 'using custom content path' do
     before(:all) do
-      @original_content_path = HighVoltage::content_path
-      HighVoltage::content_path = "other_pages/"
+      @original_content_path = HighVoltage.content_path
+      HighVoltage.content_path = 'other_pages/'
     end
 
     after(:all) do
-      HighVoltage::content_path = @original_content_path
+      HighVoltage.content_path = @original_content_path
     end
 
-    describe "on GET to /other_pages/also_exists" do
+    describe 'on GET to /other_pages/also_exists' do
       before { get :show, :id => 'also_exists' }
 
-      it "should respond with success and render template" do
+      it 'should respond with success and render template' do
         response.should be_success
         response.should render_template('other_pages/also_exists')
       end
     end
 
-    describe "on GET to /other_pages/also_dir/nested" do
+    describe 'on GET to /other_pages/also_dir/nested' do
       before { get :show, :id => 'also_dir/also_nested' }
 
-      it "should respond with success and render template" do
+      it 'should respond with success and render template' do
         response.should be_success
         response.should render_template('other_pages/also_dir/also_nested')
       end
     end
 
-    it "should raise a routing error for an invalid page" do
-      lambda { get :show, :id => "also_invalid" }.should raise_error(ActionController::RoutingError)
+    it 'should raise a routing error for an invalid page' do
+      lambda { 
+        get :show, 
+        :id => 'also_invalid' 
+      }.should raise_error(ActionController::RoutingError)
     end
 
-    it "should raise a routing error for a page in another directory" do
-      lambda { get :show, :id => "../other/wrong" }.should raise_error(ActionController::RoutingError)
+    it 'should raise a routing error for a page in another directory' do
+      lambda {
+        get :show,
+        :id => '../other/wrong' 
+      }.should raise_error(ActionController::RoutingError)
     end
 
-    it "should raise missing template error for valid page with invalid partial" do
-      lambda { get :show, :id => "also_exists_but_references_nonexistent_partial" }.should raise_error(ActionView::MissingTemplate)
+    it 'should raise a routing error for a page in another directory when using a Unicode exploit' do
+      lambda { 
+        get :show,
+        :id => '/\\../other/wrong'
+      }.should raise_error(ActionController::RoutingError)
     end
-  end
-
 
+    it 'should raise missing template error for valid page with invalid partial' do
+      lambda {
+        get :show,
+        :id => 'also_exists_but_references_nonexistent_partial'
+      }.should raise_error(ActionView::MissingTemplate)
+    end
+  end
 end

data/spec/controllers/subclassed_pages_controller_spec.rb

@@ -1,41 +1,40 @@
 require 'spec_helper'
 
 describe SubclassedPagesController do
-
   render_views
 
-  describe "on GET to /subclassed_pages/also_exists" do
+  describe 'on GET to /subclassed_pages/also_exists' do
     before { get :show, :id => 'also_exists' }
 
-    it "should respond with success and render template" do
+    it 'should respond with success and render template' do
       response.should be_success
       response.should render_template('also_exists')
     end
 
-    it "should use the custom configured layout" do
-      response.should_not render_template("layouts/application")
+    it 'should use the custom configured layout' do
+      response.should_not render_template('layouts/application')
       response.should render_template('layouts/alternate')
     end
   end
 
-  describe "on GET to /subclassed_pages/also_dir/nested" do
-    before { get :show, :id => 'also_dir/also_nested' }
-
-    it "should respond with success and render template" do
-      response.should be_success
-      response.should render_template('other_pages/also_dir/also_nested')
-    end
-  end
-
-  it "should raise a routing error for an invalid page" do
-    lambda { get :show, :id => "invalid" }.should raise_error(ActionController::RoutingError)
+  it 'should raise a routing error for an invalid page' do
+    lambda {
+      get :show,
+      :id => 'invalid'
+    }.should raise_error(ActionController::RoutingError)
   end
 
-  it "should raise a routing error for a page in another directory" do
-    lambda { get :show, :id => "../other/wrong" }.should raise_error(ActionController::RoutingError)
+  it 'should raise a routing error for a page in another directory' do
+    lambda {
+      get :show,
+      :id => '../other/wrong'
+    }.should raise_error(ActionController::RoutingError)
   end
 
-  it "should raise missing template error for valid page with invalid partial" do
-    lambda { get :show, :id => "also_exists_but_references_nonexistent_partial" }.should raise_error(ActionView::MissingTemplate)
+  it 'should raise missing template error for valid page with invalid partial' do
+    lambda {
+      get :show,
+      :id => 'also_exists_but_references_nonexistent_partial'
+    }.should raise_error(ActionView::MissingTemplate)
   end
 end

data/spec/dummy/app/controllers/alternative_finder_controller.rb

@@ -0,0 +1,14 @@
+class AlternativeFinderController < HighVoltage::PagesController
+  private
+
+  def page_finder_factory
+    Rot13PageFinder
+  end
+
+  class Rot13PageFinder < HighVoltage::PageFinder
+    def find
+      paths = super.split('/')
+      "#{paths[0..-2].join('/')}/#{paths[-1].tr('a-z','n-za-m')}"
+    end
+  end
+end

data/spec/dummy/app/controllers/subclassed_pages_controller.rb

@@ -1,7 +1,3 @@
 class SubclassedPagesController < HighVoltage::PagesController
   layout 'alternate'
-
-  def content_path
-    'other_pages/'
-  end
 end

data/spec/dummy/app/views/pages/also_dir/also_nested.html.erb

@@ -0,0 +1 @@
+hello <%= 'world' %> from a nested dir

data/spec/dummy/app/views/pages/also_exists.html.erb

@@ -0,0 +1 @@
+hello <%= 'world' %>

data/spec/dummy/app/views/pages/also_exists_but_references_nonexistent_partial.html.erb

@@ -0,0 +1,2 @@
+hello <%= 'world' %>
+<%= render 'nonexistent' %>

data/spec/dummy/app/views/pages/rot13.html.erb

@@ -0,0 +1 @@
+alternative

data/spec/dummy/config/application.rb

@@ -3,7 +3,6 @@ require File.expand_path('../boot', __FILE__)
 require "active_model/railtie"
 require "action_controller/railtie"
 require "action_view/railtie"
-require "action_mailer/railtie"
 
 Bundler.require
 require "high_voltage"

data/spec/dummy/config/environments/test.rb

@@ -20,11 +20,6 @@ Dummy::Application.configure do
   # Disable request forgery protection in test environment
   config.action_controller.allow_forgery_protection    = false
 
-  # Tell Action Mailer not to deliver emails to the real world.
-  # The :test delivery method accumulates sent emails in the
-  # ActionMailer::Base.deliveries array.
-  config.action_mailer.delivery_method = :test
-
   # Use SQL instead of Active Record's schema dumper when creating the test database.
   # This is necessary if your schema can't be completely dumped by the schema dumper,
   # like if you have constraints or database-specific column types

data/spec/dummy/config/routes.rb

@@ -1,3 +1,4 @@
 Dummy::Application.routes.draw do
   match "/subclassed_pages/*id" => 'subclassed_pages#show', :format => false
+  match "/alternative_finder/*id" => 'alternative_finder#show', :format => false
 end

data/spec/high_voltage/page_finder_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+describe HighVoltage::PageFinder do
+  it 'produces the name of an existing template' do
+    find('existing').should eq 'pages/existing'
+  end
+
+  it 'produces the name of a nested template' do
+    find('dir/nested').should eq 'pages/dir/nested'
+  end
+
+  it 'uses a custom content path' do
+    with_content_path('other_pages/') do
+      find('also_exists').should eq 'other_pages/also_exists'
+    end
+  end
+
+  it 'exposes the content path' do
+    with_content_path('another_thing/') do
+      page_finder.content_path.should eq 'another_thing/'
+    end
+  end
+
+  it 'provides the page_id' do
+    subclass = Class.new(HighVoltage::PageFinder) do
+      def page_name
+        "the page is #{page_id}"
+      end
+    end
+
+    subclass.new('sweet page').page_name.should eq 'the page is sweet page'
+  end
+
+  private
+
+  def find(page_id)
+    page_finder(page_id).find
+  end
+
+  def page_finder(page_id = 'whatever')
+    HighVoltage::PageFinder.new(page_id)
+  end
+
+  def with_content_path(path)
+    original_content_path = HighVoltage.content_path
+    HighVoltage.content_path = path
+
+    yield
+
+    HighVoltage.content_path = original_content_path
+  end
+end

data/spec/high_voltage_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 describe HighVoltage do
-  it "should be valid" do
+  it 'should be valid' do
     HighVoltage.should be_a(Module)
   end
-end
+end

data/spec/integration/navigation_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
-describe "Navigation" do
+describe 'Navigation' do
   include Capybara::DSL
-  
-  it "should be a valid app" do
+
+  it 'should be a valid app' do
     ::Rails.application.should be_a(Dummy::Application)
   end
 end

data/spec/routing/routes_spec.rb

@@ -1,68 +1,150 @@
 require 'spec_helper'
-describe 'routes' do
-  context "using default configuration" do
 
-    it "should generate normal resource route with id" do
-      page_path(:id => "one").should == "/pages/one"
+describe 'routes' do
+  context 'using default configuration' do
+    it 'should generate normal resource route with id' do
+      page_path(:id => 'one').should eq '/pages/one'
     end
 
-    it "should generate normal resource route with string" do
-      page_path("one").should == "/pages/one"
+    it 'should generate normal resource route with string' do
+      page_path('one').should eq '/pages/one'
     end
 
-    it "should generate nested route with string" do
-      page_path("one/two").should == "/pages/one/two"
+    it 'should generate nested route with string' do
+      page_path('one/two').should eq '/pages/one/two'
     end
 
-    it "should recognize nested route" do
-      assert_recognizes({ :controller => "high_voltage/pages", :action => "show", :id => "one/two" }, "/pages/one/two")
+    it 'should recognize nested route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one/two'
+        },
+        '/pages/one/two'
+      )
     end
 
-    it "should recognize normal route" do
-      assert_recognizes({ :controller => "high_voltage/pages", :action => "show", :id => "one" }, "/pages/one")
+    it 'should recognize normal route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one'
+        },
+        '/pages/one'
+      )
     end
 
-    it "should recognize normal route with dots" do
-      assert_recognizes({ :controller => "high_voltage/pages", :action => "show", :id => "one.two.three" }, "/pages/one.two.three")
+    it 'should recognize normal route with dots' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one.two.three'
+        },
+        '/pages/one.two.three'
+      )
     end
   end
 
-  context "using a custom content_path" do
+  context 'using root routing configuration' do
+    around do |example|
+      cached_high_voltage_route_drawer = HighVoltage.route_drawer
+      HighVoltage.route_drawer = HighVoltage::RouteDrawers::Root
+      Rails.application.reload_routes!
+
+      example.run
 
-    before(:all) do
-      @original_content_path = HighVoltage::content_path
-      HighVoltage::content_path = "other_pages/"
+      HighVoltage.route_drawer = cached_high_voltage_route_drawer
       Rails.application.reload_routes!
     end
 
-    after(:all) do
-      HighVoltage::content_path = @original_content_path
+    it 'should generate normal resource route with id' do
+      page_path(:id => 'one').should eq '/one'
+    end
+
+    it 'should generate normal resource route with string' do
+      page_path('one').should eq '/one'
+    end
+
+    it 'should generate nested route with string' do
+      page_path('one/two').should eq '/one/two'
+    end
+  end
+
+  context 'using a custom content_path' do
+    around do |example|
+      cached_high_voltage_content_path = HighVoltage.content_path
+      HighVoltage.content_path = 'other_pages/'
+      Rails.application.reload_routes!
+
+      example.run
+
+      HighVoltage.content_path = cached_high_voltage_content_path
       Rails.application.reload_routes!
     end
 
-    it "should generate normal resource route with id" do
-      page_path(:id => "one").should == "/other_pages/one"
+    it 'should generate normal resource route with id' do
+      page_path(:id => 'one').should eq '/other_pages/one'
     end
 
-    it "should generate normal resource route with string" do
-      page_path("one").should == "/other_pages/one"
+    it 'should generate normal resource route with string' do
+      page_path('one').should eq '/other_pages/one'
     end
 
-    it "should generate nested route with string" do
-      page_path("one/two").should == "/other_pages/one/two"
+    it 'should generate nested route with string' do
+      page_path('one/two').should eq '/other_pages/one/two'
     end
 
-    it "should recognize nested route" do
-      assert_recognizes({:controller => "high_voltage/pages", :action => "show", :id => "one/two"}, "/other_pages/one/two")
+    it 'should recognize nested route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one/two'
+        },
+        '/other_pages/one/two'
+      )
     end
 
-    it "should recognize normal route" do
-      assert_recognizes({:controller => "high_voltage/pages", :action => "show", :id => "one"}, "/other_pages/one")
+    it 'should recognize normal route' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one'
+        },
+        '/other_pages/one'
+      )
     end
 
-    it "should recognize normal route with dots" do
-      assert_recognizes({:controller => "high_voltage/pages", :action => "show", :id => "one.two.three"}, "/other_pages/one.two.three")
+    it 'should recognize normal route with dots' do
+      assert_recognizes(
+        {
+          :controller => 'high_voltage/pages',
+          :action => 'show',
+          :id => 'one.two.three'
+        },
+        '/other_pages/one.two.three'
+      )
     end
   end
 
+  context 'with default configuration disabled' do
+    around do |example|
+      cached_high_voltage_routes = HighVoltage.routes
+      HighVoltage.routes = false
+      Rails.application.reload_routes!
+
+      example.run
+
+      HighVoltage.routes = cached_high_voltage_routes
+      Rails.application.reload_routes!
+    end
+
+    it 'should not recognize routes' do
+      { :get => '/pages/one/two' }.should_not be_routable
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,30 +1,18 @@
-# Configure Rails Envinronment
-ENV["RAILS_ENV"] = "test"
+ENV['RAILS_ENV'] = 'test'
 
 require File.expand_path("../dummy/config/environment.rb",  __FILE__)
-require "rails/test_help"
-require "rspec/rails"
-
-ActionMailer::Base.delivery_method = :test
-ActionMailer::Base.perform_deliveries = true
-ActionMailer::Base.default_url_options[:host] = "test.com"
+require 'rails/test_help'
+require 'rspec/rails'
+require 'capybara/rails'
 
 Rails.backtrace_cleaner.remove_silencers!
-
-# Configure capybara for integration testing
-require "capybara/rails"
 Capybara.default_driver   = :rack_test
 Capybara.default_selector = :css
 
-# Load support files
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
-  # Remove this line if you don't want RSpec's should and should_not
-  # methods or matchers
   require 'rspec/expectations'
   config.include RSpec::Matchers
-
-  # == Mock Framework
   config.mock_with :rspec
 end