higcm 0.0.2 → 0.0.3

data/higcm.gemspec

@@ -4,7 +4,7 @@ $:.unshift File.expand_path('../lib', __FILE__)
 
 Gem::Specification.new do |s|
   s.name         = "higcm"
-  s.version      = "0.0.2"
+  s.version      = "0.0.3"
   s.authors      = ["hifrank"]
   s.email        = "frank_chen@htc.com"
   s.homepage     = "https://github.com/hifrank/higcm"

data/lib/higcm/sender.rb

@@ -20,6 +20,7 @@ module HiGCM
       end
 
       def send(registration_ids, opts={}, handler=nil)
+        handler = HiGCM::Handler.new if handler.nil?
         request = send_async(registration_ids, opts, handler)
         send_async_run
         request.handled_response

data/spec/lib/higcm/handler_spec.rb

@@ -13,7 +13,7 @@ describe HiGCM::Handler do
   end
 
   describe "#handle" do
-    it "#handle should handle various response in when response code is 500" do
+    pending "#handle should handle various response in when response code is 500" do
     end
 
     it "#handle should handle various response when response code is 200" do
@@ -65,20 +65,20 @@ describe HiGCM::Handler do
       sender.send_async_run
 
       @fail_ids.should == { 2 => "Unavailable, retry after #{@retry_after}", 3 => "InvalidRegistration", 6 => "NotRegistered" }
-      @fail_response.is_a?(Typhoeus::Response).should == true
+      @fail_response.should be_a(Typhoeus::Response)
 
       @retry_ids.should  == { 2 => 10 }
       @retry_opts.should == {}
-      @retry_response.is_a?(Typhoeus::Response).should == true
+      @retry_response.should be_a(Typhoeus::Response)
 
       @renew_ids.should == { 5 => "32" }
-      @renew_response.is_a?(Typhoeus::Response).should == true
+      @renew_response.should be_a(Typhoeus::Response)
 
       @success_ids.should == { 1 => "1:0408", 4 => "1:1516", 5 => "1:2342" }
-      @success_response.is_a?(Typhoeus::Response).should == true
+      @success_response.should be_a(Typhoeus::Response)
 
       @unreg_ids.should == { 3 => "InvalidRegistration", 6 => "NotRegistered" }
-      @unreg_response.is_a?(Typhoeus::Response).should == true
+      @unreg_response.should be_a(Typhoeus::Response)
 
     end
   end

data/spec/lib/higcm/sender_spec.rb

@@ -28,17 +28,17 @@ describe HiGCM::Sender do
       expect { sender = HiGCM::Sender.new nil}.to raise_error
     end
 
-    it "should raise exception when given api_key is nil or empty" do
+    it "should accept correct API key" do
       sender  = HiGCM::Sender.new(@api_key)
-      sender.is_a?(HiGCM::Sender).should == true
-      sender.api_key.should            == @api_key
+      sender.should be_a(HiGCM::Sender)
+      sender.api_key.should == @api_key
     end
   end
 
   describe "#send" do
-    it "should return Typhoeus::Request" do
-      response = @sender.send_async(@registration_ids, {})
-      response.class.should == Typhoeus::Request
+    it "should return Typhoeus::Response" do
+      response = @sender.send(@registration_ids, {})
+      response.should be_a(Typhoeus::Response)
     end
 
     it "should call handler.handle after request is completed" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: higcm
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-24 00:00:00.000000000Z
+date: 2012-07-31 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
-  requirement: &2185503900 !ruby/object:Gem::Requirement
+  requirement: &2160619160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 0.3.3
   type: :runtime
   prerelease: false
-  version_requirements: *2185503900
+  version_requirements: *2160619160
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2185503040 !ruby/object:Gem::Requirement
+  requirement: &2160618400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *2185503040
+  version_requirements: *2160618400
 - !ruby/object:Gem::Dependency
   name: json
-  requirement: &2185502040 !ruby/object:Gem::Requirement
+  requirement: &2160617000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2185502040
+  version_requirements: *2160617000
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2185501180 !ruby/object:Gem::Requirement
+  requirement: &2160616060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2185501180
+  version_requirements: *2160616060
 description: ruby wrapper for GCM google cloud messaging.
 email: frank_chen@htc.com
 executables: []