hieraviz 0.1.2 → 0.2.0

data/spec/app/apiv1_spec.rb

@@ -1,20 +1,19 @@
 require 'sinatra_helper'
 
 describe HieravizApp::ApiV1 do
-
-  context "page not found" do
-    describe "GET /v1/blahblah" do
-      let(:expected) { { 'error' => "endpoint not found" }  }
+  context 'page not found' do
+    describe 'GET /v1/blahblah' do
+      let(:expected) { { 'error' => 'Endpoint not found' } }
       before do
         get '/blahblah'
       end
       it { expect(last_response).not_to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
     end
   end
 
-  context "when no creds" do
-    describe "GET /v1/nodes" do
+  context 'when no creds' do
+    describe 'GET /v1/nodes' do
       let(:expected) { 'http://example.org/v1/not_logged' }
       before do
         get '/nodes'
@@ -23,57 +22,58 @@ describe HieravizApp::ApiV1 do
       it { expect(last_response.header['Location']).to eq expected }
     end
     describe 'GET /v1/not_logged' do
-      let(:expected) { { 'error' => "Not connected." }  }
+      let(:expected) { { 'error' => 'Not connected.' } }
       before do
         get '/not_logged'
       end
       it { expect(last_response).to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
     end
   end
 
-  context "with creds but no perms" do
-    describe "GET /v1/nodes" do
+  context 'with creds but no perms' do
+    describe 'GET /v1/nodes' do
       let(:expected) { 'http://example.org/v1/unauthorized' }
       before do
         current_session.rack_session[:access_token] = 'sada'
-        allow(Hieraviz::Store).
-          to receive(:get).
-          with('sada', 3600).
-          and_return(false)
+        allow(Hieraviz::Store)
+          .to receive(:get)
+          .with('sada', 3600)
+          .and_return(false)
         get '/nodes'
       end
       it { expect(last_response).not_to be_ok }
       it { expect(last_response.header['Location']).to eq expected }
     end
     describe 'GET /v1/unauthorized' do
-      let(:expected) { { 'error' => "Unauthorized" }  }
+      let(:expected) { { 'error' => 'Unauthorized' } }
       before do
         get '/unauthorized'
       end
       it { expect(last_response).to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
     end
   end
 
-  context "with proper creds" do
+  context 'with proper creds' do
     before do
       current_session.rack_session[:access_token] = 'sada'
-      allow(Hieraviz::Store).
-        to receive(:get).
-        with('sada', 3600).
-        and_return({})
+      allow(app.settings.store)
+        .to receive(:get)
+        .with('sada', 3600)
+        .and_return({'username' => 'toto'})
     end
-    describe "GET /v1/nodes" do
+    describe 'GET /v1/nodes' do
       let(:expected) { ['node1.example.com'] }
       before do
         get '/nodes'
       end
       it { expect(last_response).to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
     end
-    describe "GET /v1/node/node1.example.com/info" do
-      let(:expected) {
+
+    describe 'GET /v1/node/node1.example.com/info' do
+      let(:expected) do
         {
           'classes' => ['farm1'],
           'country' => 'fr',
@@ -81,110 +81,219 @@ describe HieravizApp::ApiV1 do
           'farm' => 'dev',
           'fqdn' => 'node1.example.com'
         }
-      }
+      end
       before do
         get '/node/node1.example.com/info'
       end
       it { expect(last_response).to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
     end
-    describe "GET /v1/node/node1.example.com/params" do
-      let(:expected) {
+
+    describe 'GET /v1/node/node1.example.com/params' do
+      let(:expected) do
         {
-          "param1.subparam1" => {
-            "value" => "value1", 
-            "file" => "params/nodes/node1.example.com.yaml", 
-            "overriden" => false, 
-            "found_in" => [
+          'param1.subparam1' => {
+            'value' => 'value1',
+            'file' => 'params/nodes/node1.example.com.yaml',
+            'overriden' => false,
+            'found_in' => [
               {
-                "value"=>"value1", 
-                "file"=>"params/nodes/node1.example.com.yaml"
+                'value' => 'value1',
+                'file' => 'params/nodes/node1.example.com.yaml'
               }
             ]
           }
         }
-      }
+      end
       before do
         get '/node/node1.example.com/params'
       end
       it { expect(last_response).to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
     end
-    describe "GET /v1/node/node1.example.com" do
-      let(:expected) {
+
+    describe 'GET /v1/node/node1.example.com' do
+      let(:expected) do
         {
-          "param1.subparam1" => {
-            "value" => "value1", 
-            "file" => "params/nodes/node1.example.com.yaml", 
-            "overriden" => false, 
-            "found_in" => [
+          'param1.subparam1' => {
+            'value' => 'value1',
+            'file' => 'params/nodes/node1.example.com.yaml',
+            'overriden' => false,
+            'found_in' => [
               {
-                "value"=>"value1", 
-                "file"=>"params/nodes/node1.example.com.yaml"
+                'value' => 'value1',
+                'file' => 'params/nodes/node1.example.com.yaml'
               }
             ]
           }
         }
-      }
+      end
       before do
         get '/node/node1.example.com'
       end
       it { expect(last_response).to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
-    end
-    describe "GET /v1/node/node1.example.com/allparams" do
-      let(:expected) {
-         {
-          "param1.subparam1" => {
-            "value" => "value1", 
-            "file" => "-", 
-            "overriden" => true, 
-            "found_in" => [
+      it { expect(JSON.parse(last_response.body)).to eq expected }
+    end
+
+    describe 'GET /v1/node/node1.example.com/allparams' do
+      let(:expected) do
+        {
+          'param1.subparam1' => {
+            'value' => 'value1',
+            'file' => '-',
+            'overriden' => true,
+            'found_in' => [
               {
-                "value" => "value1", 
-                "file" => "params/nodes/node1.example.com.yaml"
+                'value' => 'value1',
+                'file' => 'params/nodes/node1.example.com.yaml'
               },
               {
-                "value" => "value common", 
-                "file"=>"params/common/common.yaml"
+                'value' => 'value common',
+                'file' => 'params/common/common.yaml'
               }
             ]
           },
-          "param2.subparam2" => {
-            "value" => "another value", 
-            "file"=>"params/common/common.yaml", 
-            "overriden" => false, 
-            "found_in" => [
+          'param2.subparam2' => {
+            'value' => 'another value',
+            'file' => 'params/common/common.yaml',
+            'overriden' => false,
+            'found_in' => [
               {
-                "value" => "another value", 
-                "file"=>"params/common/common.yaml"
+                'value' => 'another value',
+                'file' => 'params/common/common.yaml'
               }
             ]
           }
         }
-      }
+      end
       before do
         get '/node/node1.example.com/allparams'
       end
       it { expect(last_response).to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
+    end
+
+    describe 'GET /v1/node/node1.example.com/facts' do
+      context 'when no facts are recorded' do
+        let(:expected) { Hash.new }
+        before do
+          get '/node/node1.example.com/facts'
+        end
+        it { expect(last_response).to be_ok }
+        it { expect(JSON.parse(last_response.body)).to eq expected }
+      end
+      context 'when some facts are recorded' do
+        let(:tmpdir) { 'spec/files/tmp' }
+        let(:base) { '' }
+        let(:node) { 'node1.example.com' }
+        let(:user) { 'toto' }
+        let(:facts) { Hieraviz::Facts.new tmpdir, base, node, user }
+        let(:data) { { 'a' => 'b' } }
+        let(:factsfile) { 'spec/files/tmp/__node1.example.com__toto' }
+        after  { File.unlink factsfile }
+        before do
+          facts.write(data)
+          get '/node/node1.example.com/facts'
+        end
+        it { expect(last_response).to be_ok }
+        it { expect(JSON.parse(last_response.body)).to eq data }
+      end
+    end
+
+    describe 'POST /v1/node/node1.example.com/facts' do
+      let(:data) { { 'a' => 'b' } }
+      let(:factsfile) { 'spec/files/tmp/__node1.example.com__toto' }
+      after  { File.unlink factsfile }
+      before do
+        post '/node/node1.example.com/facts', data.to_json
+      end
+      it { expect(last_response).to be_ok }
+      it { expect(File).to exist(factsfile) }
     end
-    describe "GET /v1/farms" do
-      let(:expected) { { "farm1" => 0 } }
+
+    describe 'DELETE /v1/node/node1.example.com/facts' do
+      let(:tmpdir) { 'spec/files/tmp' }
+      let(:base) { '' }
+      let(:node) { 'node1.example.com' }
+      let(:user) { 'toto' }
+      let(:facts) { Hieraviz::Facts.new tmpdir, base, node, user }
+      let(:data) { { 'a' => 'b' } }
+      let(:factsfile) { 'spec/files/tmp/__node1.example.com__toto' }
+      before do
+        facts.write(data)
+        delete '/node/node1.example.com/facts'
+      end
+      it { expect(last_response).to be_ok }
+      it { expect(File).not_to exist(factsfile) }
+    end
+
+    describe 'GET /v1/farms' do
+      let(:expected) { { 'farm1' => 0 } }
       before do
         get '/farms'
       end
       it { expect(last_response).to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
     end
-    describe "GET /v1/vars" do
-      let(:expected) { ['fqdn', 'farm'] }
+
+    describe 'GET /v1/vars' do
+      let(:expected) { %w(fqdn farm) }
       before do
         get '/vars'
       end
       it { expect(last_response).to be_ok }
-      it { expect(JSON.parse last_response.body).to eq expected }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
     end
-  end
 
+    describe 'GET /v1/node/node1.example.com/hierarchy' do
+      let(:expected) do
+        {
+          'hiera' => [
+            'nodes/%{fqdn}',
+            'farm/%{farm}',
+            'common/common'
+          ],
+          'vars' => %w(
+            fqdn
+            farm),
+          'info' => {
+            'fqdn' => 'node1.example.com',
+            'country' => 'fr',
+            'datacenter' => 'equinix',
+            'farm' => 'dev',
+            'classes' => [
+              'farm1'
+            ]
+          },
+          'files' => [
+            'params/nodes/node1.example.com.yaml'
+          ],
+          'facts' => {},
+          'defaults' => nil
+        }
+      end
+      before do
+        get '/node/node1.example.com/hierarchy'
+      end
+      it { expect(last_response).to be_ok }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
+    end
+
+    describe 'GET /v1/farm/dev' do
+      let(:expected) do
+        {
+          'node1.example.com' => {
+            'country' => 'fr',
+            'datacenter' => 'equinix',
+            'farm' => 'dev'
+          }
+        }
+      end
+      before do
+        get '/farm/dev'
+      end
+      it { expect(last_response).to be_ok }
+      it { expect(JSON.parse(last_response.body)).to eq expected }
+    end
+  end
 end

data/spec/app/web_dummy_auth_spec.rb

@@ -0,0 +1,11 @@
+require 'sinatra_helper'
+
+describe HieravizApp::Web do
+  before do
+    ENV['HIERAVIZ_CONFIG_FILE'] = File.expand_path '../../files/config_dummy.yml', __FILE__
+    app.set :configdata, Hieraviz::Config.load
+    app.set :basepaths, Hieraviz::Config.basepaths
+    app.set :store, Hieraviz::Store.new(app.settings.configdata['tmpdir'])
+  end
+  
+end

data/spec/app/web_spec.rb

@@ -1,52 +1,50 @@
 require 'sinatra_helper'
 
 describe HieravizApp::Web do
-
-  context "without creds" do
-    describe "GET /" do
+  context 'without creds' do
+    describe 'GET /' do
       before { get '/' }
       it { expect(last_response.status).to eq 401 }
     end
   end
 
-  context "with proper creds" do
+  context 'with proper creds' do
     before do
       basic_authorize 'toto', 'toto'
     end
-    describe "GET /" do
+    describe 'GET /' do
       before { get '/' }
       it { expect(last_response.status).to eq 200 }
       it { expect(last_response.body).to include 'Welcome to hieraviz' }
     end
-    describe "GET /logout" do
+    describe 'GET /logout' do
       before { get '/logout' }
       it { expect(last_response.body).to include 'Please login again' }
     end
-    describe "GET /nodes" do
+    describe 'GET /nodes' do
       before { get '/nodes' }
       it { expect(last_response.body).to include 'node1.example.com' }
     end
-    describe "GET /farms" do
+    describe 'GET /farms' do
       before { get '/farms' }
       it { expect(last_response.body).to include 'farm1' }
     end
-    describe "GET /modules" do
+    describe 'GET /modules' do
       before { get '/modules' }
       it { expect(last_response.body).to include 'Work In Progress' }
     end
-    describe "GET /resources" do
+    describe 'GET /resources' do
       before { get '/resources' }
       it { expect(last_response.body).to include 'Work In Progress' }
     end
-    describe "GET /tata/toto" do
+    describe 'GET /tata/toto' do
       before { get '/tata/toto' }
       it { expect(last_response.status).to eq 404 }
       it { expect(last_response.body).to include 'Page not found' }
     end
-    describe "GET /user" do
+    describe 'GET /user' do
       before { get '/user' }
       it { expect(last_response.body).to include 'toto' }
     end
   end
-
 end

data/spec/files/config_dummy.yml

@@ -12,7 +12,6 @@ puppetdb:
   usessl: false
   host: puppetdb.example.com
   port: 8080
-
 auth_method: dummy
 http_auth:
   username: 'toto'

data/spec/lib/auth_gitlab_spec.rb

@@ -2,12 +2,21 @@ require 'spec_helper'
 require 'oauth2_helper'
 
 describe Hieraviz::AuthGitlab do
-
-  let(:oauth2) { Hieraviz::AuthGitlab.new({}) }
+  let(:settings) do
+    {
+      'application_id' => '',
+      'secret' => '',
+      'host' => '',
+      'resource_required' => false,
+      'required_response_key' => '',
+      'required_response_value' => ''
+    }
+  end
+  let(:oauth2) { Hieraviz::AuthGitlab.new(settings) }
   before do
-    allow(OAuth2::Client).
-      to receive(:new).
-      and_return(Oauth2Mock.new)
+    allow(OAuth2::Client)
+      .to receive(:new)
+      .and_return(Oauth2Mock.new)
   end
 
   describe '.new' do
@@ -22,25 +31,25 @@ describe Hieraviz::AuthGitlab do
     let(:url) { 'http://example.com/something' }
     let(:token) { '123456' }
     let(:urlfail) { 'fail' }
-    let(:expected) {
+    let(:expected) do
       {
-        "somekey" => "somevalue"
+        'somekey' => 'somevalue'
       }
-    }
-    let(:expectedfail) {
+    end
+    let(:expectedfail) do
       {
-        "error" => "message"
+        'error' => 'message'
       }
-    }
+    end
     before do
-      allow(OAuth2::AccessToken).
-        to receive(:new).
-        and_return(AccessTokenMock.new)
+      allow(OAuth2::AccessToken)
+        .to receive(:new)
+        .and_return(AccessTokenMock.new)
     end
-    context "when there is an error" do
+    context 'when there is an error' do
       it { expect(oauth2.get_response(urlfail, token)).to eq expectedfail }
     end
-    context "when everything is fine" do
+    context 'when everything is fine' do
       it { expect(oauth2.get_response(url, token)).to eq expected }
     end
   end
@@ -56,17 +65,60 @@ describe Hieraviz::AuthGitlab do
   end
 
   describe '.authorized?' do
+    context 'when authorization is required' do
+      let(:settings) do
+        {
+          'application_id' => '',
+          'secret' => '',
+          'host' => '',
+          'resource_required' => 'http://example.com/something',
+          'required_response_key' => 'somekey',
+          'required_response_value' => 'somevalue'
+        }
+      end
+      context 'with a valid authorization' do
+        let(:token) { '123456' }
+        before do
+          allow(OAuth2::AccessToken)
+            .to receive(:new)
+            .and_return(AccessTokenMock.new)
+        end
+        it { expect(oauth2.authorized?(token)).to eq true }
+      end
+      context 'without a valid authorization' do
+        let(:settings) do
+          {
+            'application_id' => '',
+            'secret' => '',
+            'host' => '',
+            'resource_required' => 'fail',
+            'required_response_key' => 'id',
+            'required_response_value' => '42'
+          }
+        end
+        let(:token) { '123456' }
+        before do
+          allow(OAuth2::AccessToken)
+            .to receive(:new)
+            .and_return(AccessTokenMock.new)
+        end
+        it { expect(oauth2.authorized?(token)).to eq false }
+      end
+    end
+    context 'when no authorization is required' do
+      let(:token) { '123456' }
+      it { expect(oauth2.authorized?(token)).to be_truthy }
+    end
   end
 
   describe '.user_info' do
     let(:token) { '123456' }
-    let(:expected) { { "somekey" => "somevalue" } }
+    let(:expected) { { 'somekey' => 'somevalue' } }
     before do
-      allow(OAuth2::AccessToken).
-        to receive(:new).
-        and_return(AccessTokenMock.new)
+      allow(OAuth2::AccessToken)
+        .to receive(:new)
+        .and_return(AccessTokenMock.new)
     end
     it { expect(oauth2.user_info(token)).to eq expected }
   end
-
 end

data/spec/lib/config_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Hieraviz::Config do
-
   context 'with a single puppet dir' do
     before do
       ENV['HIERAVIZ_CONFIG_FILE'] = File.expand_path '../../files/config.yml', __FILE__
@@ -9,7 +8,7 @@ describe Hieraviz::Config do
     end
 
     describe '.load' do
-      let(:expected) { "spec/files/puppet" }
+      let(:expected) { 'spec/files/puppet' }
       it { expect(Hieraviz::Config.load['basepath']).to eq expected }
     end
 
@@ -32,12 +31,12 @@ describe Hieraviz::Config do
       context 'when path starts with a slash' do
         let(:path) { '/some/path' }
         let(:expected) { path }
-        it { expect(Hieraviz::Config.root_path path).to eq expected }
+        it { expect(Hieraviz::Config.root_path(path)).to eq expected }
       end
       context 'when path don\'t start with a slash' do
         let(:path) { 'relative/path' }
         let(:expected) { File.expand_path(File.join('../../../', path), __FILE__) }
-        it { expect(Hieraviz::Config.root_path path).to eq expected }
+        it { expect(Hieraviz::Config.root_path(path)).to eq expected }
       end
     end
   end
@@ -49,15 +48,13 @@ describe Hieraviz::Config do
     end
 
     describe '.basepaths' do
-      let(:expected) { 
+      let(:expected) do
         [
           File.expand_path('../../../spec/files/puppet', __FILE__),
           File.expand_path('../../../spec/files/puppet2', __FILE__)
         ]
-      }
+      end
       it { expect(Hieraviz::Config.basepaths).to match_array(expected) }
     end
-
   end
-
 end