hierarchable 0.3.0 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac67b8aa97065b5917fe0a13e8016d14047cac537bcbb74f8d2910614d86d0da
-  data.tar.gz: effb465602763db73be3f247daf54fe523eb3fad1ac489fe75df26f08fd4df0b
+  metadata.gz: c906048aba37ae782246aaceec861dde107dfc1a17aed8be531ed5100f3bb5c2
+  data.tar.gz: 6ab096cae6a3fd9d8da70bd222732f513a63b693d414751fa44e6ebe085210eb
 SHA512:
-  metadata.gz: f873a3c653dd0eff928657715c49e71eead1080a9798ef7fb97b6d9df296fa4eb686f1335b2e2ba8d1f44af16065246a2918dd864e2b60b29542dcb0772361cc
-  data.tar.gz: 0be6318e611e86efec91acb95fb4225c653d43b519dece0444c15eeddd3b58b3aff9815dfaebd013f1aec9d1da64befac6fc23fe30fdc00a85b37abd3fc9ddb2
+  metadata.gz: c31a773cafe33d14b83b63d25a7783ed4c75bb1385458de3e893b3c91530b42e2421c4d59c76d9590cddc6b2260aaef391c4f62b9af5f1ad91c6c0979b439827
+  data.tar.gz: 8ebef8dcc55ab798c7abad2f94cd895a6d3778e28c07aadbcc175bfbe1fc40c526d833590783e6c3c94793b6a9579c3ab3ee5c968660ea8e600cb410c6d81da9

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    hierarchable (0.3.0)
+    hierarchable (0.3.2)
       activerecord (> 4.2.0)
       activesupport (> 4.2.0)
 

data/README.md

@@ -1,6 +1,7 @@
 # Hierarchable
 
 [![CircleCI](https://dl.circleci.com/status-badge/img/gh/prschmid/hierarchable/tree/main.svg?style=shield)](https://dl.circleci.com/status-badge/redirect/gh/prschmid/hierarchable/tree/main)
+[![Gem Version](https://badge.fury.io/rb/hierarchable.svg)](https://badge.fury.io/rb/hierarchable)
 
 A simple way to define cross model hierarchical (parent, child, sibling) relationships between ActiveRecord models.
 
@@ -24,14 +25,14 @@ Or install it yourself as:
 
 Once the gem is installed, you will need to make sure that your models have the correct columns.
 
-* hierarchy_root: The root node in the hierarchy hierarchy (polymorphic)
-* hierarchy_parent: The parent of the current object (polymorphic)
-* hierarchy_ancestors_path: The string representation of all ancestors of
+* `hierarchy_root`: The root node in the hierarchy hierarchy (polymorphic)
+* `hierarchy_parent`: The parent of the current object (polymorphic)
+* `hierarchy_ancestors_path`: The string representation of all ancestors of
                             the current object (string).
 
 Assuming that you are using UUIDs for your IDs, this can be done by adding the following to the model(s) for which you wish to have hierarchy information:
 
-```
+```ruby
 t.references :hierarchy_root,
              polymorphic: true,
              null: true,
@@ -59,13 +60,13 @@ We will describe the usage using a simplistic Project and Task analogy where we
 class Project
   include Hierarchable
   hierarchable
-  # If desired, could explicitly setting the parent source to `nil`, but this is
-  # the same "under the hood"
+  # If desired, one could explicitly set the parent source to `nil` for clarity,
+  # but this is the same as omitting it.
   # hierarchable parent_source: nil
 end
 ```
 
-This will set up the `Project` as the root of the hierarchy. When a `Project` model is saved, it will not have any values for the hierarchy_root, hierarchy_parent, or hierarchy_ancestors_path. This is because for the root item as we are not guaranteed to have an ID for the object until after it is saved, and so there is no way for us to set these values in a consistent way across different use cases. This doesn't affect any of the usage of the library, it's just something to keep in mind.
+This will set up the `Project` as the root of the hierarchy. When a `Project` model is saved, it will not have any values for the hierarchy_root, hierarchy_parent, or hierarchy_ancestors_path (i.e. they are `nil`). This is because for the root item we are not guaranteed to have an ID for the object until after it is saved. Thus, there is no consistent way for us to set these values across different use cases. This doesn't affect any of the usage of the library, it's just something to keep in mind.
 
 ```ruby
 project = Project.create!
@@ -148,7 +149,7 @@ project.hierarchy_descendants
 
 The major distinction for what is returned is whether you are querying "up the hierarchy" or "down the hierarchy". As there is only 1 path up the hierchy to get to the root, the return values of `hierarchy_ancestors` is a list and `hierarchy_parent` is a single object. However, traversing down the list is a little more tricky as there are various models and potential paths to get all the way do to the leaves. As such, for all methods at the same level or going down the tree (`hierarchy_siblings`, `hierarchy_children`, and `hierarchy_descendants`), the return value is a hash that has the model class as the key, and either a `ActiveRecord::Relation` or a list as the value. For example, for a Project model that has tasks and milestones as descendants, the return value might be something like
 
-```
+```ruby
 {
   'Task': [all descendant tasks starting at the project]
   'Milestone': [all descendant milestones starting at the project]
@@ -166,7 +167,7 @@ All of the methods (except `hierarchy_parent`) take a `models` paramter that can
 
 There are times when we only need to get the siblings/children/descendants of one type and having a hash returned is a little cumbersome. To deal with this case, you can pass `compact: true` as a parameter and it will return just single result not as a hash. For example:
 
-```
+```ruby
 # Returns as a hash of the form `{Task: [..all descendants..]}`
 project.hierarch_descendants(models: ['Task'])
 
@@ -238,7 +239,7 @@ However there are times when we need to manually add a child relation to be insp
 
 ```ruby
 class SomeObject
-  include Hierarched
+  include Hierarchable
   hierarched parent_source: :parent,
              additional_descendant_associations: [:some_association]
 end
@@ -248,14 +249,12 @@ There may also be a case when we want exact control over what associations that
 
 ```ruby
 class SomeObject
-  include Hierarched
+  include Hierarchable
   hierarched parent_source: :parent,
              descendant_associations: [:some_association]
 end
 ```
 
-Note: For the use case that this library was designed (e.g. creating breadcrumbs) this was a limitation that was perfectly acceptible. In the future we may plan to letusers create an optional "ancestry" table to make this more efficient. Once this table exists, inserts and updates will be slower as an extra object will need to be managed, but queries descenants will be improved.
-
 ### Configuring the separators
 
 By default the separators to use for the path and records are `/` and `|` respectively. This means that a hierarchy path will look something like

data/lib/hierarchable/hierarchable.rb

@@ -396,6 +396,7 @@ module Hierarchable
       until models_to_analyze.empty?
 
         klass = models_to_analyze.pop
+        next unless klass
         next if models.include?(klass)
 
         obj = klass.new
@@ -514,7 +515,7 @@ module Hierarchable
     # also add in the one provided.
     #
     #   class A
-    #     include Hierarched
+    #     include Hierarchable
     #     hierarched parent_source: :parent,
     #                additional_descendant_associations: [:some_association]
     #   end
@@ -523,7 +524,7 @@ module Hierarchable
     # that should be used. In that case, we can specify it like this:
     #
     #   class A
-    #     include Hierarched
+    #     include Hierarchable
     #     hierarched parent_source: :parent,
     #                descendant_associations: [:some_association]
     #   end
@@ -682,11 +683,15 @@ module Hierarchable
     def hierarchy_parent_changed?
       # FIXME: We need to figure out how to deal with updating the
       # object_hierarchy_ancestry_path, object_hierarchy_full_path, etc.,
-      if hierarchy_parent_source.present?
-        public_send("#{hierarchy_parent_source}_id_changed?")
-      else
-        false
-      end
+      return true unless persisted?
+
+      source = hierarchy_parent_source
+      return false if source.blank?
+
+      changed_method = "#{source}_id_changed?"
+      return public_send(changed_method) if respond_to?(changed_method)
+
+      send(source)&.id == hierarchy_parent_id
     end
 
     # Update the hierarchy_ancestors_path if the hierarchy has changed.
@@ -699,7 +704,6 @@ module Hierarchable
   def class_for_association(association)
     self.association(association)
         .reflection
-        .class_name
-        .safe_constantize
+        .klass
   end
 end

data/lib/hierarchable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hierarchable
-  VERSION = '0.3.0'
+  VERSION = '0.3.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hierarchable
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.2
 platform: ruby
 authors:
 - Patrick R. Schmid
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-24 00:00:00.000000000 Z
+date: 2023-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler