hierarchable 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac67b8aa97065b5917fe0a13e8016d14047cac537bcbb74f8d2910614d86d0da
-  data.tar.gz: effb465602763db73be3f247daf54fe523eb3fad1ac489fe75df26f08fd4df0b
+  metadata.gz: 77318268a18001072d590f7ad65524e5f608923cea6c6e757946ad164862518b
+  data.tar.gz: 7740d0be435b42dd701fc626eaa706b58c50688c0bb7639da9caf8b5864d3f3b
 SHA512:
-  metadata.gz: f873a3c653dd0eff928657715c49e71eead1080a9798ef7fb97b6d9df296fa4eb686f1335b2e2ba8d1f44af16065246a2918dd864e2b60b29542dcb0772361cc
-  data.tar.gz: 0be6318e611e86efec91acb95fb4225c653d43b519dece0444c15eeddd3b58b3aff9815dfaebd013f1aec9d1da64befac6fc23fe30fdc00a85b37abd3fc9ddb2
+  metadata.gz: '078378d734ddc00ccfcecf685fdd142e581560af7444a34985172c354eae1aeedb91ea98a2b08fd47a20728ce8d594c5d965a49409e7957236549b34352a852f'
+  data.tar.gz: 4b9192aec201abb47df5be7589a207c46131fb3544bb2b7cb439dd5c4d6a5df4fe09bc98e32aba14b72b2f3aa789295933226793cb282741a90f1dcd442f38ca

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    hierarchable (0.3.0)
+    hierarchable (0.3.1)
       activerecord (> 4.2.0)
       activesupport (> 4.2.0)
 

data/README.md

@@ -238,7 +238,7 @@ However there are times when we need to manually add a child relation to be insp
 
 ```ruby
 class SomeObject
-  include Hierarched
+  include Hierarchable
   hierarched parent_source: :parent,
              additional_descendant_associations: [:some_association]
 end
@@ -248,7 +248,7 @@ There may also be a case when we want exact control over what associations that
 
 ```ruby
 class SomeObject
-  include Hierarched
+  include Hierarchable
   hierarched parent_source: :parent,
              descendant_associations: [:some_association]
 end

data/lib/hierarchable/hierarchable.rb

@@ -396,6 +396,7 @@ module Hierarchable
       until models_to_analyze.empty?
 
         klass = models_to_analyze.pop
+        next unless klass
         next if models.include?(klass)
 
         obj = klass.new
@@ -514,7 +515,7 @@ module Hierarchable
     # also add in the one provided.
     #
     #   class A
-    #     include Hierarched
+    #     include Hierarchable
     #     hierarched parent_source: :parent,
     #                additional_descendant_associations: [:some_association]
     #   end
@@ -523,7 +524,7 @@ module Hierarchable
     # that should be used. In that case, we can specify it like this:
     #
     #   class A
-    #     include Hierarched
+    #     include Hierarchable
     #     hierarched parent_source: :parent,
     #                descendant_associations: [:some_association]
     #   end
@@ -682,11 +683,15 @@ module Hierarchable
     def hierarchy_parent_changed?
       # FIXME: We need to figure out how to deal with updating the
       # object_hierarchy_ancestry_path, object_hierarchy_full_path, etc.,
-      if hierarchy_parent_source.present?
-        public_send("#{hierarchy_parent_source}_id_changed?")
-      else
-        false
-      end
+      return true unless persisted?
+
+      source = hierarchy_parent_source
+      return false if source.blank?
+
+      changed_method = "#{source}_id_changed?"
+      public_send(changed_method) if respond_to?(changed_method)
+
+      send(source).id == hierarchy_parent_id
     end
 
     # Update the hierarchy_ancestors_path if the hierarchy has changed.
@@ -699,7 +704,6 @@ module Hierarchable
   def class_for_association(association)
     self.association(association)
         .reflection
-        .class_name
-        .safe_constantize
+        .klass
   end
 end

data/lib/hierarchable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Hierarchable
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: hierarchable
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Patrick R. Schmid
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-24 00:00:00.000000000 Z
+date: 2023-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler