hidden_hooks 1.1.0 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e80baab48dbc8bc16a9dd82cbe6ba965d1b5076d0658404e7641e3c1e7818797
-  data.tar.gz: 13b66da95b3dad6192d4ccab88b9f19f2c0cbb980b6e721b24df06e1cbea32ca
+  metadata.gz: 88532a44bde6fdd20a6bcd02505060ec0abffd7fe55e815c3dd82a80d0be8819
+  data.tar.gz: 118bd2af55f7472686deaf3c93f9008b8d3fd820dab2082d6f032103f4f72583
 SHA512:
-  metadata.gz: 8b234e254887127321a42ff8ee96da7ba0f6a80179ca1bd1871a24d753143295746b1f99afcf57a01a4aa8f9fe987c3aefc791b655351e7f0aa6f69bdcbd0cd1
-  data.tar.gz: 26eb29ecc3824a2628fafc7d21b687e37e66da4a3d2c16c439fcc9351b5c3324cb4aaf2a78b116b756e1324c1411bd21d00ddd780f89add7c0df9cf3a2bbe151
+  metadata.gz: 6c7b53ac8c04c1b6d02dbd6af42d7c7d6e6d93a60faea4c23ffcbf615e6744d3626678b01a4d8d4c4b53846263e188aedfcfb39ea9e22d36c61ddbdb4c98fa9e
+  data.tar.gz: c81d8c1c686af906141279a02067a90a131445506a6c83c9fd967bd582b7868a6da54e780f08c1cba3d44da920ae8796e2be2a8c2b47611792647eb92da39434

data/CHANGELOG.md

@@ -8,6 +8,21 @@
 ### Bug fixes
 )-->
 
+## 1.1.2 2025-01-28
+
+### Bug fixes
+
+- Fixed Active Record integration not setting callbacks for derived classes.
+- Removed `after_*_commit` shortcut hooks.
+  - These aren't actually callbacks, but little more than wrappers for `after_commit` itself, so the method that gets called on the callback object is always `#after_commit`, causing some weird behaviors.
+
+## 1.1.1 2025-01-28
+
+### Bug fixes
+
+- Removed `around_*` callbacks.
+  - The problem with `around_*` callbacks is that the callback needs to yield to the passed block otherwise the callback chain stops, so if there aren't hooks for a certain callback no one's yielding and the chain always stops.
+
 ## 1.1.0 2025-01-28
 
 ### New features

data/lib/hidden_hooks/active_record.rb

@@ -4,34 +4,30 @@ module HiddenHooks
   module ActiveRecord
     extend ActiveSupport::Concern
 
-    included do
-      [
-        :after_commit,
-        :after_create,
-        :after_create_commit,
-        :after_destroy,
-        :after_destroy_commit,
-        :after_find,
-        :after_initialize,
-        :after_rollback,
-        :after_save,
-        :after_save_commit,
-        :after_touch,
-        :after_update,
-        :after_update_commit,
-        :after_validation,
-        :around_create,
-        :around_destroy,
-        :around_save,
-        :around_update,
-        :before_commit,
-        :before_create,
-        :before_destroy,
-        :before_save,
-        :before_update,
-        :before_validation
-      ].each do |callback|
-        send callback, HiddenHooks[self], prepend: true
+    class_methods do
+      def inherited subclass
+        super
+
+        [
+          :after_commit,
+          :after_create,
+          :after_destroy,
+          :after_find,
+          :after_initialize,
+          :after_rollback,
+          :after_save,
+          :after_touch,
+          :after_update,
+          :after_validation,
+          :before_commit,
+          :before_create,
+          :before_destroy,
+          :before_save,
+          :before_update,
+          :before_validation
+        ].each do |callback|
+          subclass.send callback, HiddenHooks[subclass], prepend: true
+        end
       end
     end
   end

data/lib/hidden_hooks/version.rb

@@ -1,3 +1,3 @@
 module HiddenHooks
-  VERSION = '1.1.0'
+  VERSION = '1.1.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hidden_hooks
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.2
 platform: ruby
 authors:
 - Moku S.r.l.