hibiki_rails 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b661448cbe2b84a20e26f5cd0bffaf2cf7be8c755f0f1b9c692f77e9f5798430
-  data.tar.gz: b09c3b35032a6990ab08c17e424a147e9e667905a4f9e9378062d52583e213d6
+  metadata.gz: a8ac38db2808ab9f20f6fccf7cf50c202454fc222cba122f6466e25cf5fe2eb3
+  data.tar.gz: 89b5a3ab98b4bf10ba10466de9f352d9e9e3c3a814abb35175df798aa4fafc89
 SHA512:
-  metadata.gz: dc4013a0867b606341dd9af0135a82ab9e5a8c6b5f5cabd788eea48e0f3b604a708d31aa21c044f8639a5f2951242986b710d893b968246d03703359d562235b
-  data.tar.gz: d407a4c966366e5b11d9db6eaf7e789dcd4e086ca028dad0b2bc9b69bc4ec8f6b110339e338894b51851aa8ace18f08ef2339ce9198cf7a9226dc48d11b8c592
+  metadata.gz: 1d970c278b67be036e36a4703e3a38f6581b27bb890a4a7b599000755085a74f311646ae1519752e6457633590326bb9e6ca0fcf1b7fb1925e784d5f3a2c70b3
+  data.tar.gz: 468b0706478f48ee97019baf35b4da08912647b7a649575b8f970d05a21186cb85cf9c6c5dc89d9d0e6c75c6b0ad5c936c0b5cb6d8b223b5924edbb094ea2304

data/CHANGELOG.md

@@ -4,6 +4,25 @@ The gem and the npm package are released in lockstep and share these version
 numbers — `app/assets/javascripts/hibiki.js` is a single copy served both ways,
 so importmap and bundler apps always resolve identical client code.
 
+## 0.9.1 — 2026-08-18
+
+### Added
+
+**`hibiki:rails:nested` creates a missing child model from the field list.**
+`bin/rails g hibiki:rails:nested Song Credit role:string position:integer`
+no longer refuses when `Credit` doesn't exist: the generator invokes
+`active_record:model` with `song:references` prepended (kept where you put it
+if you typed it yourself), then wires the edge off the argument list exactly
+as if the field list had narrowed an existing schema. Run
+`bin/rails db:migrate` before using the fieldset. A created child is never
+ordered silently — put `position` in the field list, or pass
+`--position=COLUMN` and the column joins the create-table migration. With an
+existing child model nothing changes, and a missing model with no field list
+still refuses, now suggesting the inline syntax.
+
+The runtime and the packaged client did not change; the npm 0.9.1 exists only
+to keep the lockstep rule.
+
 ## 0.9.0 — 2026-08-17
 
 ### Added

data/lib/generators/hibiki/rails/nested/USAGE

@@ -8,9 +8,11 @@ Description:
     fallback in the full-page form, and the controller's params.expect
     double-array group.
 
-    Parent and Child models must exist and be migrated, and Child must
-    declare belongs_to :<parent>. An optional field list narrows or orders
-    the child's form fields; the facts stay the schema's.
+    When the Child model exists (migrated, with belongs_to :<parent>), an
+    optional field list narrows or orders its form fields; the facts stay
+    the schema's. When it doesn't, the field list creates it — model and
+    migration via active_record:model, <parent>:references prepended for
+    you. Run bin/rails db:migrate before using the fieldset.
 
     Depth is composition: run once per edge. A run whose Parent is itself a
     nested child (its _<parent>_fields partial exists) nests into that
@@ -20,7 +22,8 @@ Description:
     the fieldset ordered — the has_many gains an order scope, the parent
     form stamps positions from array order, and rows get ↑/↓ buttons. The
     named column is added by migration when missing; --skip-position opts
-    out entirely.
+    out entirely. A created child is never ordered silently: put position
+    in the field list, or pass --position.
 
 Examples:
     bin/rails g hibiki:rails:nested Song Credit
@@ -28,3 +31,5 @@ Examples:
     bin/rails g hibiki:rails:nested Credit Contribution
 
     bin/rails g hibiki:rails:nested Song Credit artist:references role:string --position=rank
+
+    bin/rails g hibiki:rails:nested Song Credit role:string position:integer

data/lib/generators/hibiki/rails/nested/nested_generator.rb

@@ -22,6 +22,8 @@ module Hibiki
       # generic Hibiki::Rails::NestedActions), reactive_nested on the parent
       # form, the model wiring, the classic fields_for fallback in the
       # full-page form, and the controller's params.expect double-array group.
+      # A missing child model is created from the field list (model +
+      # migration via active_record:model, the parent reference prepended).
       #
       # Depth is composition — run once per edge. A run whose parent is
       # itself a nested child injects into the parent's own fields partial
@@ -62,6 +64,14 @@ module Hibiki
           warn_without_phlex_rails
         end
 
+        def create_child_model
+          return unless create_child?
+
+          # to_argv, never GeneratedAttribute#to_s: `title:string!` round-trips
+          # through to_s as "title:string{null}", which .parse then rejects.
+          invoke "active_record:model", child_model_argv
+        end
+
         def create_child_form
           template "child_form.rb.tt", child_form_path
         end
@@ -111,10 +121,7 @@ module Hibiki
         end
 
         def post_install
-          if @position_migration
-            say_status :migrate, "#{child_table_name}.#{position_column} was added — " \
-                                 "run bin/rails db:migrate before using the fieldset.", :yellow
-          end
+          migrate_notice
           schema.belongs_tos.each do |column|
             say_status :assoc, "using #{column.association_class_name}##{column.label_column} as " \
                                "the #{column.human_name.downcase} option label — edit " \
@@ -124,6 +131,18 @@ module Hibiki
 
         private
 
+        # Never both: a created child's ordering column rides its
+        # create-table migration.
+        def migrate_notice
+          if create_child?
+            say_status :migrate, "#{child_class_name} was generated — " \
+                                 "run bin/rails db:migrate before using the fieldset.", :yellow
+          elsif @position_migration
+            say_status :migrate, "#{child_table_name}.#{position_column} was added — " \
+                                 "run bin/rails db:migrate before using the fieldset.", :yellow
+          end
+        end
+
         # The scaffold's own view layer, read from what it left on disk; an
         # explicit --phlex wins. Deep mode reads it off the parent's fields
         # partial instead of the row form.

data/lib/generators/hibiki/rails/nested_helpers.rb

@@ -36,8 +36,19 @@ module Hibiki
 
         def child_form_class_name = "#{child_class_name}Form"
         def child_form_path = File.join("app/forms", "#{child_class_name.underscore}_form.rb")
+        def child_model_path = File.join("app/models", "#{child_class_name.underscore}.rb")
         def child_table_name = child_class_name.tableize.tr("/", "_")
 
+        # Create mode: no constant, no model file, and a field list to build
+        # from. Memoized before the invoke writes the file — later calls must
+        # keep the preflight answer.
+        def create_child?
+          return @create_child if defined?(@create_child)
+
+          @create_child = attributes.any? && child_class_name.safe_constantize.nil? &&
+                          !exists?(child_model_path)
+        end
+
         def child_class
           @child_class ||= begin
             klass = child_class_name.safe_constantize
@@ -53,9 +64,13 @@ module Hibiki
         end
 
         def missing_child_message
-          "No model #{child_class_name}. hibiki:rails:nested needs the child model " \
-            "to exist:\n    bin/rails g model #{child_class_name} #{singular_name}:references " \
-            "role:string\nMigrate, then re-run."
+          if exists?(child_model_path)
+            "#{child_class_name} has no table yet. Run bin/rails db:migrate first."
+          else
+            "No model #{child_class_name}. Pass its fields and the generator creates it " \
+              "(#{singular_name}:references is added for you):\n    " \
+              "bin/rails g hibiki:rails:nested #{name} #{child} role:string"
+          end
         end
 
         # The child's belongs_to back to the parent. Required: the has_many's
@@ -92,9 +107,14 @@ module Hibiki
 
         # Everything that can refuse, before anything is written.
         def check_wireable!
-          child_class
-          parent_reflection
-          check_parent_wireable!
+          if create_child?
+            check_parent_wireable!
+            check_creatable!
+          else
+            child_class
+            parent_reflection
+            check_parent_wireable!
+          end
           check_editable_columns!
         end
 
@@ -119,10 +139,21 @@ module Hibiki
 
           raise ::Rails::Generators::Error,
                 "#{child_class_name} has no editable columns beyond " \
-                "#{parent_reflection.foreign_key}#{" and #{position_column}" if ordered?} — " \
+                "#{child_foreign_key}#{" and #{position_column}" if ordered?} — " \
                 "nothing to build a fieldset from."
         end
 
+        # A bare <parent>_id column generates no belongs_to, and the has_many's
+        # inverse_of and accepts_nested_attributes_for both stand on it.
+        def check_creatable!
+          fk = "#{singular_name}_id"
+          return if attributes.none? { !it.reference? && it.name == fk }
+
+          raise ::Rails::Generators::Error,
+                "Spell the parent column #{singular_name}:references — a bare #{fk} " \
+                "generates no belongs_to, and the nested wiring needs one."
+        end
+
         # ---- the owning resource ---------------------------------------------
         #
         # Root mode: the parent itself. Deep mode: derived from where the
@@ -182,15 +213,36 @@ module Hibiki
 
         # ---- the child schema ------------------------------------------------
         #
-        # Always the introspection path — the child model is required — with
-        # the scaffold's 3.6 merge when a field list narrows or orders it. The
-        # parent's foreign key and the ordering column never become form
-        # fields: the association assigns one, the parent form stamps the
-        # other.
+        # Introspection when the child model exists (the scaffold's 3.6 merge
+        # when a field list narrows or orders it); the argument-only path when
+        # this run is creating the model — the fresh constant is not loadable
+        # in-process, so nothing may read it. The parent's foreign key and the
+        # ordering column never become form fields: the association assigns
+        # one, the parent form stamps the other.
+
+        def introspectable_child = create_child? ? nil : child_class
+
+        # Argument-derived in create mode: there is no reflection to ask yet.
+        def child_foreign_key
+          @child_foreign_key ||= create_child? ? "#{singular_name}_id" : parent_reflection.foreign_key.to_s
+        end
+
+        # What create_child_model hands to active_record:model: the parent
+        # reference prepended unless the field list already spells it, the
+        # --position column appended when ordering asked for one the list
+        # doesn't carry.
+        def child_model_argv
+          parent_ref = ("#{singular_name}:references" unless parent_ref_argument?)
+          position_arg = ("#{position_column}:integer" if ordered? && options[:position].present? &&
+                                                          attributes.none? { it.name == position_column })
+          [child_class_name, *parent_ref, *attributes.map { to_argv(it) }, *position_arg]
+        end
+
+        def parent_ref_argument? = attributes.any? { it.reference? && it.name == singular_name }
 
         def full_schema
           @full_schema ||= if attributes.any?
-                             ScaffoldSchema.from_attributes(attributes, model: child_class)
+                             ScaffoldSchema.from_attributes(attributes, model: introspectable_child)
                            else
                              ScaffoldSchema.from_model(child_class)
                            end
@@ -206,7 +258,7 @@ module Hibiki
 
         def form_excluded?(column)
           return true if column.belongs_to? && column.association_name == singular_name.to_sym
-          return true if column.name.to_s == parent_reflection.foreign_key.to_s
+          return true if column.name.to_s == child_foreign_key
 
           ordered? && column.name.to_s == position_column
         end
@@ -218,6 +270,7 @@ module Hibiki
 
           @ordered = if options[:skip_position] then false
                      elsif options[:position].present? then true
+                     elsif create_child? then attributes.any? { it.name == "position" }
                      else child_class.column_names.include?("position")
                      end
         end
@@ -225,7 +278,7 @@ module Hibiki
         def position_column = @position_column ||= options[:position].presence || "position"
 
         def position_migration_needed?
-          ordered? && !child_class.column_names.include?(position_column)
+          ordered? && !create_child? && !child_class.column_names.include?(position_column)
         end
 
         # ---- template refs ---------------------------------------------------

data/lib/hibiki/rails/version.rb

@@ -2,6 +2,6 @@
 
 module Hibiki
   module Rails
-    VERSION = "0.9.0"
+    VERSION = "0.9.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: hibiki_rails
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - planetaska